[linux-sunxi] Re: [PATCH v2] drm: sun4i: Add support for suspending the display driver

2019-11-04 Thread Daniel Vetter
= > { > .driver = { > .name = "sun4i-drm", > .of_match_table = sun4i_drv_of_table, > + .pm = _drv_drm_pm_ops, > }, > }; > module_platform_driver(sun4i_drv_platform_driver); > -- > 2.23.0 >

[linux-sunxi] Re: [PATCH v4 0/8] Allwinner H6 Mali GPU support

2019-05-13 Thread Daniel Vetter
-3.dts| 5 > .../dts/allwinner/sun50i-h6-orangepi.dtsi | 5 > .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 5 ++++ > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++ > 6 files changed, 61 insertions(+) > > -- > 2.17.1 > -- Daniel V

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Daniel Vetter
On Tue, Feb 05, 2019 at 11:24:19AM +0100, Thierry Reding wrote: > On Tue, Feb 05, 2019 at 09:57:37AM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 04:59:09PM +0100, Daniel Vetter wrote: > >

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Daniel Vetter
On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > On Mon, Feb 04, 2019 at 04:59:09PM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 12:22:18PM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > >

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Daniel Vetter
On Mon, Feb 04, 2019 at 12:22:18PM +0100, Thierry Reding wrote: > On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > >

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Daniel Vetter
instead of trying to auto-match against a DT compatible string and load a panel driver which is almost all fake. Or we teach dp_aux to register itself and somehow teach panel-edp how it can get hold of the dp_aux channel it needs. But fake mode in panel-simple sounds like the wrong approach. A

[linux-sunxi] Re: [PATCH] drm/sun4i: wait on implicit fence before display

2018-11-22 Thread Daniel Vetter
> + .prepare_fb = drm_gem_fb_prepare_fb, > .atomic_check = sun8i_vi_layer_atomic_check, > .atomic_disable = sun8i_vi_layer_atomic_disable, > .atomic_update = sun8i_vi_layer_atomic_update, > -- > 2.17.1 > >

[linux-sunxi] Re: [PATCH 9/9] [DO NOT MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check

2018-10-18 Thread Daniel Vetter
> > return MODE_CLOCK_LOW; > > > > - if (rounded_rate > rate) > > + if (rounded_rate > rate * 21 / 20) > > return MODE_CLOCK_HIGH; > > > > DRM_DEBUG_DRIVER("Clock rate OK\n"); > > -- > Regards, > > Laure

[linux-sunxi] Re: Planes enumeration with sun4i-drm driver

2018-10-15 Thread Daniel Vetter
re" at all. So yeah, Paul's idea doesn't seem entirely out of hand to me, and for the "bug regressions" we need a concrete example of what will break. Since we're fine-tuning the drm api all the time, within the limits of what userspace expects :-) Cheers, Daniel -- Daniel Vetter S

[linux-sunxi] Re: [PATCH] drm/sun4i: Avoid failing to init fbdev without any connector

2018-08-07 Thread Daniel Vetter
> + return ret; > + } > + > + return 0; > } > > void sun4i_framebuffer_free(struct drm_device *drm) > -- > 2.18.0 > > _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org

[linux-sunxi] Re: [PATCH v2 00/10] Allwinner H3/H5/A64(DE2) SimpleFB support

2017-11-06 Thread Daniel Vetter
ply the H3/5 > > part of this patchset? > > This came a bit late, we're too close from the merge window > now. Please resend them after -rc1 is out. Just dropping here that drm-misc is open all the time, making for a much better process for contributors :-) -Daniel -- Daniel Vetter S

[linux-sunxi] Re: [PATCH v3 09/14] regmap: add iopoll-like polling macro for regmap_field

2017-10-11 Thread Daniel Vetter
regmap: add iopoll-like polling macro for regmap_field > > include/linux/regmap.h | 39 +++ > 1 file changed, 39 insertions(+) > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > ht

[linux-sunxi] Re: [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

2017-07-10 Thread Daniel Vetter
hould have >> >> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support") >> >> Otherwise, >> >> Reviewed-by: Chen-Yu Tsai <w...@csie.org> > > And it should be sent to stable too. > > Can you resend it? Fyi but patchwork aut

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-25 Thread Daniel Vetter
On Tue, Oct 25, 2016 at 08:44:22AM +0200, Daniel Vetter wrote: > On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > > +static int de2_drm_bind(struct device *dev) > > +{ > > + struct drm_device *drm; > > + struct priv *priv; > &g

[linux-sunxi] Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2

2016-10-25 Thread Daniel Vetter
v, dev); > + if (ret) > + goto out2; > + > + /* start the subdevices */ > + ret = component_bind_all(dev, drm); > + if (ret < 0) > + goto out2; > + > + ret = drm_dev_register(drm, 0); This needs to be the very last step in y

[linux-sunxi] Re: [PATCH v2 13/26] drm/fb_cma_helper: Remove implicit call to disable_unused_functions

2016-01-24 Thread Daniel Vetter
On Mon, Jan 25, 2016 at 12:19:27AM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Friday 15 January 2016 11:17:30 Daniel Vetter wrote: > > On Fri, Jan 15, 2016 at 01:13:05AM +0200, Laurent Pinchart wrote: > > > On Thursday 14 January 2016 16:2

[linux-sunxi] Re: [PATCH v2 13/26] drm/fb_cma_helper: Remove implicit call to disable_unused_functions

2016-01-15 Thread Daniel Vetter
dev->mode_config.num_crtc, > >dev->mode_config.num_connector); > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 876cad58b1f9..24be31d69701 > > 100644 > > --- a/drivers/gpu/drm/ti

[linux-sunxi] Re: [PATCH 08/19] drm: Add Allwinner A10 Display Engine support

2015-11-16 Thread Daniel Vetter
On Wed, Nov 11, 2015 at 02:14:12PM -0800, Maxime Ripard wrote: > Hi Daniel, > > Thanks for your review! Back from vacation, sorry for the delay. > > On Fri, Oct 30, 2015 at 03:44:09PM +0100, Daniel Vetter wrote: > > > +static void sun4i_crtc_disab

[linux-sunxi] Re: [PATCH 00/19] drm: Add Allwinner A10 display engine support

2015-10-30 Thread Daniel Vetter
e mode 100644 drivers/gpu/drm/sun4i/sun4i_drv.h > create mode 100644 drivers/gpu/drm/sun4i/sun4i_framebuffer.c > create mode 100644 drivers/gpu/drm/sun4i/sun4i_framebuffer.h > create mode 100644 drivers/gpu/drm/sun4i/sun4i_layer.c > create mode 100644 drivers/gpu/drm/sun4i/sun4i_layer

[linux-sunxi] Re: [PATCH 08/19] drm: Add Allwinner A10 Display Engine support

2015-10-30 Thread Daniel Vetter
On Fri, Oct 30, 2015 at 03:20:54PM +0100, Maxime Ripard wrote: > The Allwinner A10 and subsequent SoCs share the same display pipeline, with > variations in the number of controllers (1 or 2), or the presence or not of > some output (HDMI, TV, VGA) or not. > > This hardware supports 4 layers and