Re: [linux-sunxi] [PATCH] pinctrl: sunxi: Honor GPIO output initial vaules

2014-01-15 Thread Chen-Yu Tsai
Hi, On Wed, Jan 15, 2014 at 6:02 PM, Maxime Ripard wrote: > Hi Chen-Yu, > > Nice catch :) > > On Wed, Jan 15, 2014 at 04:21:12PM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Wed, Jan 15, 2014 at 8:37 AM, Ma Haijun wrote: >> > Hi, >> > >> > I think it is better to set the output value first to avoi

Re: [linux-sunxi] [PATCH] pinctrl: sunxi: Honor GPIO output initial vaules

2014-01-15 Thread Maxime Ripard
Hi Chen-Yu, Nice catch :) On Wed, Jan 15, 2014 at 04:21:12PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Wed, Jan 15, 2014 at 8:37 AM, Ma Haijun wrote: > > Hi, > > > > I think it is better to set the output value first to avoid glitch. > > If I understand the user manual correctly, setting the out

Re: [linux-sunxi] [PATCH] pinctrl: sunxi: Honor GPIO output initial vaules

2014-01-15 Thread Chen-Yu Tsai
gt;> Sent: Tuesday, January 14, 2014 10:50 PM >> To: Maxime Ripard >> Cc: Chen-Yu Tsai; linux-arm-kernel; linux-sunxi; Linus Walleij >> Subject: [linux-sunxi] [PATCH] pinctrl: sunxi: Honor GPIO output initial > vaules >> >> Some GPIO users, such as fixed-regula

RE: [linux-sunxi] [PATCH] pinctrl: sunxi: Honor GPIO output initial vaules

2014-01-14 Thread Ma Haijun
d > Cc: Chen-Yu Tsai; linux-arm-kernel; linux-sunxi; Linus Walleij > Subject: [linux-sunxi] [PATCH] pinctrl: sunxi: Honor GPIO output initial vaules > > Some GPIO users, such as fixed-regulator, request GPIO output with initial > value of 1. This was ignored by sunxi driver. &g

[linux-sunxi] [PATCH] pinctrl: sunxi: Honor GPIO output initial vaules

2014-01-14 Thread Chen-Yu Tsai
Some GPIO users, such as fixed-regulator, request GPIO output with initial value of 1. This was ignored by sunxi driver. Signed-off-by: Chen-Yu Tsai --- drivers/pinctrl/pinctrl-sunxi.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-