Re: [linux-sunxi] [PATCH] sunxi: remove magic numbers from clock_get_pll{5,6}

2014-04-18 Thread Ian Campbell
On Fri, 2014-04-18 at 12:13 +0800, Chen-Yu Tsai wrote: You should remove the declaration for clock_get_pll5 from arch/arm/include/asm/arch-sunxi/clock.h Oops, yes, indeed. +#define CCM_PLL6_CTRL_N_SHIFT 8 +#define CCM_PLL6_CTRL_N_MASK (0x1fCCM_PLL6_CTRL_N_SHIFT) Maybe a space

Re: [linux-sunxi] [PATCH] sunxi: remove magic numbers from clock_get_pll{5,6}

2014-04-17 Thread Chen-Yu Tsai
Hi, On Tue, Apr 15, 2014 at 3:46 AM, Ian Campbell i...@hellion.org.uk wrote: For clock_get_pll5 just remove it since it is unused. For clock_get_pll6 introduce the necessary #defines. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/clock.c | 18

[linux-sunxi] [PATCH] sunxi: remove magic numbers from clock_get_pll{5,6}

2014-04-14 Thread Ian Campbell
For clock_get_pll5 just remove it since it is unused. For clock_get_pll6 introduce the necessary #defines. Signed-off-by: Ian Campbell i...@hellion.org.uk --- arch/arm/cpu/armv7/sunxi/clock.c | 18 ++ arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 5 +