[linux-sunxi] [PATCH 13/17] net: sun8i-emac: Determine pinmux based on SoC, not EMAC type

[Jernej Skrabec]

From: Andre Przywara <andre.przyw...@arm.com>

---
 drivers/net/sun8i_emac.c | 28 ++++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 4524604126c9..7e57f1d01c8c 100644
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -85,7 +85,9 @@
 
 /* IO mux settings */
 #define SUN8I_IOMUX_H3         2
-#define SUN8I_IOMUX_R40        5
+#define SUN8I_IOMUX_R40                5
+#define SUN8I_IOMUX_H6         5
+#define SUN8I_IOMUX_H616       2
 #define SUN8I_IOMUX            4
 
 /* H3/A64 EMAC Register's offset */
@@ -519,10 +521,10 @@ static int sun8i_emac_eth_start(struct udevice *dev)
 
 static int parse_phy_pins(struct udevice *dev)
 {
-       struct emac_eth_dev *priv = dev_get_priv(dev);
        int offset;
        const char *pin_name;
        int drive, pull = SUN4I_PINCTRL_NO_PULL, i;
+       u32 iomux;
 
        offset = fdtdec_lookup_phandle(gd->fdt_blob, dev_of_offset(dev),
                                       "pinctrl-0");
@@ -549,6 +551,21 @@ static int parse_phy_pins(struct udevice *dev)
        else if (fdt_get_property(gd->fdt_blob, offset, "bias-pull-down", NULL))
                pull = SUN4I_PINCTRL_PULL_DOWN;
 
+       /*
+        * The GPIO pinmux value is an integration choice, so depends on the
+        * SoC, not the EMAC variant.
+        */
+       if (IS_ENABLED(CONFIG_MACH_SUN8I_H3))
+               iomux = SUN8I_IOMUX_H3;
+       else if (IS_ENABLED(CONFIG_MACH_SUN8I_R40))
+               iomux = SUN8I_IOMUX_R40;
+       else if (IS_ENABLED(CONFIG_MACH_SUN50I_H6))
+               iomux = SUN8I_IOMUX_H6;
+       else if (IS_ENABLED(CONFIG_MACH_SUN50I_H616))
+               iomux = SUN8I_IOMUX_H616;
+       else
+               iomux = SUN8I_IOMUX;
+
        for (i = 0; ; i++) {
                int pin;
 
@@ -561,12 +578,7 @@ static int parse_phy_pins(struct udevice *dev)
                if (pin < 0)
                        continue;
 
-               if (priv->variant == H3_EMAC)
-                       sunxi_gpio_set_cfgpin(pin, SUN8I_IOMUX_H3);
-               else if (priv->variant == R40_GMAC || priv->variant == H6_EMAC)
-                       sunxi_gpio_set_cfgpin(pin, SUN8I_IOMUX_R40);
-               else
-                       sunxi_gpio_set_cfgpin(pin, SUN8I_IOMUX);
+               sunxi_gpio_set_cfgpin(pin, iomux);
 
                if (drive != ~0)
                        sunxi_gpio_set_drv(pin, drive);
-- 
2.30.0

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit 
https://groups.google.com/d/msgid/linux-sunxi/20210103092633.36226-14-jernej.skrabec%40siol.net.