Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-24 Thread Hans de Goede
Hi, On 03/24/2014 12:04 AM, Henrik Nordström wrote: fre 2014-03-21 klockan 16:33 + skrev Ian Campbell: Thanks, I was really hoping we could pull mainline up to this level too ASAP. I want to avoid the possibility of diverging into two forks with different featuresets. But I guess hno

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-24 Thread Ian Campbell
On Mon, 2014-03-24 at 12:55 +0800, Chen-Yu Tsai wrote: Hi, On Mon, Mar 24, 2014 at 4:21 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 03/23/2014 04:13 PM, Ian Campbell wrote: On Sat, 2014-03-22 at 20:22 +0100, Hans de Goede wrote: One thing that stands out when doing a diff

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-24 Thread Chen-Yu Tsai
On Mon, Mar 24, 2014 at 4:39 PM, Ian Campbell i...@hellion.org.uk wrote: On Mon, 2014-03-24 at 12:55 +0800, Chen-Yu Tsai wrote: Hi, On Mon, Mar 24, 2014 at 4:21 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 03/23/2014 04:13 PM, Ian Campbell wrote: On Sat, 2014-03-22 at 20:22

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-23 Thread Ian Campbell
On Sat, 2014-03-22 at 20:22 +0100, Hans de Goede wrote: One thing that stands out when doing a diff against sunxi-merge-v2014.04-rc2 is this: --- u-boot/drivers/net/designware.c 2014-03-21 16:26:42.229522420 +0100 +++ u-boot-sunxi/drivers/net/designware.c 2014-03-22

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-23 Thread Henrik Nordström
fre 2014-03-21 klockan 16:33 + skrev Ian Campbell: Thanks, I was really hoping we could pull mainline up to this level too ASAP. I want to avoid the possibility of diverging into two forks with different featuresets. But I guess hno isn't around so this will have to do. What is held back

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-23 Thread Chen-Yu Tsai
Hi, On Mon, Mar 24, 2014 at 4:21 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 03/23/2014 04:13 PM, Ian Campbell wrote: On Sat, 2014-03-22 at 20:22 +0100, Hans de Goede wrote: One thing that stands out when doing a diff against sunxi-merge-v2014.04-rc2 is this: ---

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Hans de Goede
Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: while(POKE THE HARDWARE); which obscures the potentially infinite loop, I've rewritten as: while(POKE THE HARDWARE) ; Signed-off-by: Ian Campbell

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: while(POKE THE HARDWARE); which obscures the potentially infinite loop, I've rewritten as: while(POKE THE

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Hans de Goede
Hi, On 03/21/2014 04:45 PM, Ian Campbell wrote: On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: while(POKE THE HARDWARE); which obscures the potentially infinite

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Hans de Goede
Hi, On 03/21/2014 05:11 PM, Hans de Goede wrote: Hi, On 03/21/2014 04:45 PM, Ian Campbell wrote: On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: while(POKE THE

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 16:48 +0100, Hans de Goede wrote: Hi, On 03/21/2014 04:45 PM, Ian Campbell wrote: On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is:

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 17:11 +0100, Hans de Goede wrote: Hi, On 03/21/2014 04:45 PM, Ian Campbell wrote: On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is:

Re: [linux-sunxi] [PATCH u-boot-sunxi.git] sunxi: dram: checkpatch.pl cleanups

2014-03-21 Thread Ian Campbell
On Fri, 2014-03-21 at 17:11 +0100, Hans de Goede wrote: Hi, On 03/21/2014 04:45 PM, Ian Campbell wrote: On Fri, 2014-03-21 at 16:14 +0100, Hans de Goede wrote: Hi, On 03/20/2014 10:37 PM, Ian Campbell wrote: Mainly whitespace. The main construct which it complains about is: