Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

2014-02-07 Thread Carlo Caione
On Fri, Feb 7, 2014 at 6:24 PM, Thomas Gleixner wrote: > Not sure, really, but I tend to a core patch. Though we really want to > know whether the issue is threaded only or not. If it's a general > issue then this wants to go into unmask_irq() itself and not into an > extra unmask_threaded_irq() f

Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

2014-02-07 Thread Thomas Gleixner
On Fri, 7 Feb 2014, Carlo Caione wrote: > Yeah, no really difference between threaded and non threaded. > For the record, from a mail exchange with Allwinner's engineers: "the > NMI module is a signal conversion module. It catches the NMI pin's > state and generates irq to GIC", so GIC does not rea

Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

2014-02-07 Thread Carlo Caione
On Fri, Feb 7, 2014 at 12:51 PM, Thomas Gleixner wrote: > I can't see why it would be specific for the threaded case. > > The explanation says that the NMI chip is ignoring the ack on mask, > which is basically the entry of the interrupt handler. Now it does not > matter whether you are threaded o

Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

2014-02-07 Thread Thomas Gleixner
On Fri, 7 Feb 2014, Carlo Caione wrote: > The context and the rationale is fully explained in this thread > http://www.spinics.net/lists/arm-kernel/msg299952.html and some > answers are already given along the thread especially by Hans here > http://www.spinics.net/lists/arm-kernel/msg303542.html >

Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

2014-02-07 Thread Carlo Caione
On Thu, Feb 6, 2014 at 10:54 PM, Thomas Gleixner wrote: > On Thu, 6 Feb 2014, Carlo Caione wrote: >> On Thu, Feb 6, 2014 at 10:14 PM, Thomas Gleixner wrote: >> > On Thu, 6 Feb 2014, Carlo Caione wrote: >> > >> >> Several irqchip drivers require the level-triggered interrupt to be >> >> acked befo

Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

2014-02-06 Thread Thomas Gleixner
On Thu, 6 Feb 2014, Carlo Caione wrote: > On Thu, Feb 6, 2014 at 10:14 PM, Thomas Gleixner wrote: > > On Thu, 6 Feb 2014, Carlo Caione wrote: > > > >> Several irqchip drivers require the level-triggered interrupt to be > >> acked before unmasking to avoid that a second interrupt is immediately > >

Re: [linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

2014-02-06 Thread Carlo Caione
On Thu, Feb 6, 2014 at 10:14 PM, Thomas Gleixner wrote: > On Thu, 6 Feb 2014, Carlo Caione wrote: > >> Several irqchip drivers require the level-triggered interrupt to be >> acked before unmasking to avoid that a second interrupt is immediately >> triggered. This small patch introduces a new irqch

[linux-sunxi] Re: [PATCH] irq: Add new flag to ack level-triggered interrupts before unmasking

2014-02-06 Thread Thomas Gleixner
On Thu, 6 Feb 2014, Carlo Caione wrote: > Several irqchip drivers require the level-triggered interrupt to be > acked before unmasking to avoid that a second interrupt is immediately > triggered. This small patch introduces a new irqchip flags that is used > to ack the IRQ line before it is unmask