Re: [linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

2014-03-06 Thread Carlo Caione
On Thu, Mar 6, 2014 at 11:07 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 03/05/2014 09:46 PM, Carlo Caione wrote: On Wed, Mar 5, 2014 at 9:02 PM, Hans de Goede hdego...@redhat.com wrote: So I've added your patches to my sunxi-devel tree and they work as advertised :) Thank you

Re: [linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

2014-03-06 Thread Hans de Goede
Hi, On 03/06/2014 11:10 AM, Carlo Caione wrote: On Thu, Mar 6, 2014 at 11:07 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 03/05/2014 09:46 PM, Carlo Caione wrote: On Wed, Mar 5, 2014 at 9:02 PM, Hans de Goede hdego...@redhat.com wrote: So I've added your patches to my sunxi-devel

Re: [linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

2014-03-06 Thread Carlo Caione
On Thu, Mar 6, 2014 at 12:05 PM, Hans de Goede hdego...@redhat.com wrote: Ah, yes but that is before you added all the regulators, which are a fixed part of the chip. Once you get long dts bits like that having a dtsi file makes a lot of sense IMHO. Note that the part of the dts this was

Re: [linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

2014-03-05 Thread Hans de Goede
Hi, On 03/01/2014 08:29 PM, Hans de Goede wrote: Hi, On 03/01/2014 06:17 PM, Carlo Caione wrote: On Sat, Mar 1, 2014 at 5:56 PM, Hans de Goede hdego...@redhat.com wrote: Hi Carlo, Great work, thanks for all the time you're putting into this! Hi Hans :) I've 2 questions: 1) What

Re: [linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

2014-03-05 Thread Carlo Caione
On Wed, Mar 5, 2014 at 9:02 PM, Hans de Goede hdego...@redhat.com wrote: So I've added your patches to my sunxi-devel tree and they work as advertised :) Thank you for keeping the tree updated :) I've also added dt support for the axp209 to the cubietruck dts file, to avoid things becoming

[linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

2014-03-01 Thread Hans de Goede
Hi Carlo, Great work, thanks for all the time you're putting into this! I've 2 questions: 1) What dependencies does this patch-set have? Obviously it needs the NMI irq patches for A20, anything else ? I no longer see any use of a special flag for ack on unmask, is that no longer needed ? 2)

[linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

2014-03-01 Thread Carlo Caione
On Sat, Mar 1, 2014 at 5:56 PM, Hans de Goede hdego...@redhat.com wrote: Hi Carlo, Great work, thanks for all the time you're putting into this! Hi Hans :) I've 2 questions: 1) What dependencies does this patch-set have? Obviously it needs the NMI irq patches for A20, anything else ? I

Re: [linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

2014-03-01 Thread Hans de Goede
Hi, On 03/01/2014 06:17 PM, Carlo Caione wrote: On Sat, Mar 1, 2014 at 5:56 PM, Hans de Goede hdego...@redhat.com wrote: Hi Carlo, Great work, thanks for all the time you're putting into this! Hi Hans :) I've 2 questions: 1) What dependencies does this patch-set have? Obviously it