[linux-sunxi] Re: [PATCH 08/19] drm: Add Allwinner A10 Display Engine support

2015-11-16 Thread Daniel Vetter
On Wed, Nov 11, 2015 at 02:14:12PM -0800, Maxime Ripard wrote: > Hi Daniel, > > Thanks for your review! Back from vacation, sorry for the delay. > > On Fri, Oct 30, 2015 at 03:44:09PM +0100, Daniel Vetter wrote: > > > +static void sun4i_crtc_disable(struct drm_crtc *crtc) > > > +{ > > > +

[linux-sunxi] Re: [PATCH 08/19] drm: Add Allwinner A10 Display Engine support

2015-11-11 Thread Maxime Ripard
Hi Daniel, Thanks for your review! On Fri, Oct 30, 2015 at 03:44:09PM +0100, Daniel Vetter wrote: > > +static void sun4i_crtc_disable(struct drm_crtc *crtc) > > +{ > > + struct sun4i_crtc *scrtc = drm_crtc_to_sun4i_crtc(crtc); > > + struct sun4i_drv *drv = scrtc->drv; > > + > > +

[linux-sunxi] Re: [PATCH 08/19] drm: Add Allwinner A10 Display Engine support

2015-10-30 Thread Daniel Vetter
On Fri, Oct 30, 2015 at 03:20:54PM +0100, Maxime Ripard wrote: > The Allwinner A10 and subsequent SoCs share the same display pipeline, with > variations in the number of controllers (1 or 2), or the presence or not of > some output (HDMI, TV, VGA) or not. > > This hardware supports 4 layers and