[linux-sunxi] Re: [PATCH 1/2] ARM: dts: sun9i: cubieboard4: Enable USB support

2015-05-12 Thread Maxime Ripard
On Mon, May 11, 2015 at 04:26:58PM +0800, Chen-Yu Tsai wrote: +usbphy1 { + phy-supply = reg_usb1_vbus; + status = okay; +}; + +/* + * Unfortunately reg_usb1_vbus also powers one of the ports from usb3's hub. + * One should always make sure both regulators are

[linux-sunxi] Re: [PATCH 1/2] ARM: dts: sun9i: cubieboard4: Enable USB support

2015-05-11 Thread Chen-Yu Tsai
On Fri, May 8, 2015 at 7:40 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Fri, May 08, 2015 at 04:01:14PM +0800, Chen-Yu Tsai wrote: +ehci0 { + status = okay; +}; + +ehci2 { + status = okay; +}; + +/* usb1 is connected to a GL850G USB hub chip, so no need

[linux-sunxi] Re: [PATCH 1/2] ARM: dts: sun9i: cubieboard4: Enable USB support

2015-05-08 Thread Chen-Yu Tsai
On Fri, May 8, 2015 at 3:46 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: Hi, On Fri, May 08, 2015 at 12:43:56AM +0800, Chen-Yu Tsai wrote: The Cubieboard4 has 4 USB ports. 3 of them are connected to a GL850G USB hub chip on usb1. The fourth one, the lower port of 2 ports next to

[linux-sunxi] Re: [PATCH 1/2] ARM: dts: sun9i: cubieboard4: Enable USB support

2015-05-08 Thread Maxime Ripard
Hi, On Fri, May 08, 2015 at 12:43:56AM +0800, Chen-Yu Tsai wrote: The Cubieboard4 has 4 USB ports. 3 of them are connected to a GL850G USB hub chip on usb1. The fourth one, the lower port of 2 ports next to the power barrel, is directly connected to usb3. 2 power enable GPIOs are used

[linux-sunxi] Re: [PATCH 1/2] ARM: dts: sun9i: cubieboard4: Enable USB support

2015-05-08 Thread Maxime Ripard
On Fri, May 08, 2015 at 04:01:14PM +0800, Chen-Yu Tsai wrote: +ehci0 { + status = okay; +}; + +ehci2 { + status = okay; +}; + +/* usb1 is connected to a GL850G USB hub chip, so no need to enable OHCI */ You're mentionning usb1, but I don't see it enabled anywhere,