[linux-sunxi] Re: [PATCH 1/4] ASoC: sun4i-codec: Add support for PA gpio pin

2015-11-20 Thread Maxime Ripard
On Sat, Nov 21, 2015 at 12:42:41AM +0800, Chen-Yu Tsai wrote: > >> static void sun4i_codec_stop_playback(struct sun4i_codec *scodec) > >> { > >> - /* > >> - * FIXME: according to the BSP, we might need to drive a PA > >> - *GPIO low here on some boards > >> - */ > >> -

[linux-sunxi] Re: [PATCH 1/4] ASoC: sun4i-codec: Add support for PA gpio pin

2015-11-20 Thread Chen-Yu Tsai
On Sat, Nov 21, 2015 at 12:30 AM, Maxime Ripard wrote: > On Fri, Nov 20, 2015 at 02:47:10PM +0100, Hans de Goede wrote: >> Add support for PA gpio pin for controlling an external amplifier as used >> on some Allwinner boards. >> >> Signed-off-by: Hans de Goede

[linux-sunxi] Re: [PATCH 1/4] ASoC: sun4i-codec: Add support for PA gpio pin

2015-11-20 Thread Maxime Ripard
On Fri, Nov 20, 2015 at 02:47:10PM +0100, Hans de Goede wrote: > Add support for PA gpio pin for controlling an external amplifier as used > on some Allwinner boards. > > Signed-off-by: Hans de Goede > --- > .../devicetree/bindings/sound/sun4i-codec.txt | 3 +++ >

[linux-sunxi] Re: [PATCH 1/4] ASoC: sun4i-codec: Add support for PA gpio pin

2015-11-20 Thread Rob Herring
On Fri, Nov 20, 2015 at 02:47:10PM +0100, Hans de Goede wrote: > Add support for PA gpio pin for controlling an external amplifier as used > on some Allwinner boards. > > Signed-off-by: Hans de Goede Acked-by: Rob Herring > --- >