[linux-sunxi] Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Julia, On Tue, 17 Nov 2015 10:05:03 +0100 (CET) Julia Lawall wrote: > > > (This isn't the worst one, but it just happens to be one of the first.) > > > There are many cases where the typical style would be to declare a new > > > variable at the top of the function,

[linux-sunxi] Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Brian, On Mon, 16 Nov 2015 19:00:19 -0800 Brian Norris wrote: > Hi Boris, > > On Mon, Nov 16, 2015 at 02:37:47PM +0100, Boris Brezillon wrote: > > struct nand_chip now embeds an mtd device. Patch all drivers to make use > > of this mtd instance instead of using

[linux-sunxi] Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

> > (This isn't the worst one, but it just happens to be one of the first.) > > There are many cases where the typical style would be to declare a new > > variable at the top of the function, where you perform the > > macro/function-call to convert from one abstraction to another. Like > > > >

[linux-sunxi] Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Boris, On Mon, Nov 16, 2015 at 02:37:47PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris