Re: [linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs

On Thu, Sep 17, 2015 at 9:31 PM, Maxime Ripard wrote: > Hi Mark, > > On Wed, Sep 16, 2015 at 08:16:12PM +0100, Mark Brown wrote: >> On Sat, Sep 12, 2015 at 03:26:24PM +0200, Maxime Ripard wrote: >> >> This looks pretty good, there's a few minor things below but

[linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs

Hi Mark, On Wed, Sep 16, 2015 at 08:16:12PM +0100, Mark Brown wrote: > On Sat, Sep 12, 2015 at 03:26:24PM +0200, Maxime Ripard wrote: > > This looks pretty good, there's a few minor things below but I'll apply > anyway - please send followup patches fixing these. Sure, I will. Thanks! > > > +

Re: [linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs

On Thu, Sep 17, 2015 at 11:10:41PM +0800, Chen-Yu Tsai wrote: > On Thu, Sep 17, 2015 at 9:31 PM, Maxime Ripard > >> > + .formats= SNDRV_PCM_FMTBIT_S16_LE | > >> > + SNDRV_PCM_FMTBIT_S32_LE, > >> > + .sig_bits = 24, > >> So presumably

[linux-sunxi] Re: [PATCH 2/2] ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs

On Sat, Sep 12, 2015 at 03:26:24PM +0200, Maxime Ripard wrote: This looks pretty good, there's a few minor things below but I'll apply anyway - please send followup patches fixing these. > + if (clk_set_rate(scodec->clk_module, clk_freq)) > + return -EINVAL; Better to pass back