[linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-12 Thread Maxime Ripard
Hi Jernej, The patch content looks fine, but there's a few things that would need to be addressed. On Wed, May 10, 2017 at 06:46:30PM +0200, Jernej Skrabec wrote: > This commit adds support for TV (composite) output. > > Signed-off-by: Jernej Skrabec > --- > > arch/arm/include/asm/arch-sunxi/

[linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-14 Thread Simon Glass
Hi, On 12 May 2017 at 10:06, Maxime Ripard wrote: > Hi Jernej, > > The patch content looks fine, but there's a few things that would need > to be addressed. > > On Wed, May 10, 2017 at 06:46:30PM +0200, Jernej Skrabec wrote: >> This commit adds support for TV (composite) output. >> >> Signed-off-

[linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-14 Thread Maxime Ripard
On Sun, May 14, 2017 at 09:03:19PM -0600, Simon Glass wrote: > Hi, > > On 12 May 2017 at 10:06, Maxime Ripard > wrote: > > Hi Jernej, > > > > The patch content looks fine, but there's a few things that would need > > to be addressed. > > > > On Wed, May 10, 2017 at 06:46:30PM +0200, Jernej Skrab

[linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-15 Thread Jernej Škrabec
Hi, Dne ponedeljek, 15. maj 2017 ob 08:11:55 CEST je Maxime Ripard napisal(a): > On Sun, May 14, 2017 at 09:03:19PM -0600, Simon Glass wrote: > > Hi, > > > > On 12 May 2017 at 10:06, Maxime Ripard wrote: > > > Hi Jernej, > > > > > > The patch content looks fine, but there's a few things that w

[linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-15 Thread Simon Glass
Hi Maxime, On 15 May 2017 at 00:11, Maxime Ripard wrote: > On Sun, May 14, 2017 at 09:03:19PM -0600, Simon Glass wrote: >> Hi, >> >> On 12 May 2017 at 10:06, Maxime Ripard >> wrote: >> > Hi Jernej, >> > >> > The patch content looks fine, but there's a few things that would need >> > to be addre

Re: [linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-13 Thread icenowy
在 2017-05-13 00:06,Maxime Ripard 写道: Hi Jernej, The patch content looks fine, but there's a few things that would need to be addressed. On Wed, May 10, 2017 at 06:46:30PM +0200, Jernej Skrabec wrote: This commit adds support for TV (composite) output. Signed-off-by: Jernej Skrabec --- arch

Re: [linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-13 Thread Chen-Yu Tsai
On Sat, May 13, 2017 at 11:02 PM, wrote: > 在 2017-05-13 00:06,Maxime Ripard 写道: >> >> Hi Jernej, >> >> The patch content looks fine, but there's a few things that would need >> to be addressed. >> >> On Wed, May 10, 2017 at 06:46:30PM +0200, Jernej Skrabec wrote: >>> >>> This commit adds support

Re: [linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-14 Thread Maxime Ripard
On Sat, May 13, 2017 at 11:14:00PM +0800, Chen-Yu Tsai wrote: > >>> +static int sunxi_tve_get_plug_in_status(void) > >>> +{ > >>> + struct sunxi_tve_reg * const tve = > >>> + (struct sunxi_tve_reg *)SUNXI_TVE0_BASE; > >>> + u32 status; > >>> + > >>> + status = readl(

Re: [linux-sunxi] Re: [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

2017-05-15 Thread Jernej Škrabec
Hi, Dne ponedeljek, 15. maj 2017 ob 08:31:22 CEST je Maxime Ripard napisal(a): > On Sat, May 13, 2017 at 11:14:00PM +0800, Chen-Yu Tsai wrote: > > >>> +static int sunxi_tve_get_plug_in_status(void) > > >>> +{ > > >>> + struct sunxi_tve_reg * const tve = > > >>> + (struct sunxi_