On 28-09-14 17:42, Hans de Goede wrote:
Hi,
On 09/28/2014 05:37 PM, Ian Campbell wrote:
On Sun, 2014-09-28 at 17:23 +0200, Hans de Goede wrote:
If you take a closer look at the code you will see not all 3 writes are the
same:
/* Set PLL ldo voltage without this PLL6 does not work pr
Hi,
On 09/28/2014 05:37 PM, Ian Campbell wrote:
> On Sun, 2014-09-28 at 17:23 +0200, Hans de Goede wrote:
>> If you take a closer look at the code you will see not all 3 writes are the
>> same:
>>
>> /* Set PLL ldo voltage without this PLL6 does not work properly */
>> writel(PRCM_
On Sun, 2014-09-28 at 17:23 +0200, Hans de Goede wrote:
> If you take a closer look at the code you will see not all 3 writes are the
> same:
>
> /* Set PLL ldo voltage without this PLL6 does not work properly */
> writel(PRCM_PLL_CTRL_LDO_DIGITAL_EN | PRCM_PLL_CTRL_LDO_ANALOG_EN |
Hi,
On 09/22/2014 02:47 PM, Chen-Yu Tsai wrote:
> On Mon, Sep 22, 2014 at 2:35 AM, Ian Campbell wrote:
>> On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote:
>>
>>> +#ifdef CONFIG_SPL_BUILD
>>
>> Since there is no SPL support this is dead code right now, correct?
>
> This was part of Hans' at
On Mon, Sep 22, 2014 at 9:15 PM, Ian Campbell wrote:
> On Mon, 2014-09-22 at 20:47 +0800, Chen-Yu Tsai wrote:
>> On Mon, Sep 22, 2014 at 2:35 AM, Ian Campbell wrote:
>> > On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote:
>> >> + /* Set PLL ldo voltage without this PLL6 does not work prop
On Mon, 2014-09-22 at 20:47 +0800, Chen-Yu Tsai wrote:
> On Mon, Sep 22, 2014 at 2:35 AM, Ian Campbell wrote:
> > On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote:
> >> + /* Set PLL ldo voltage without this PLL6 does not work properly */
> >
> > Is "this" here the doing it 3 times bit? If
On Mon, Sep 22, 2014 at 2:35 AM, Ian Campbell wrote:
> On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote:
>
>> +#ifdef CONFIG_SPL_BUILD
>
> Since there is no SPL support this is dead code right now, correct?
This was part of Hans' attempt to support SPL. It was not finished.
> I'm wondering
On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote:
> +#ifdef CONFIG_SPL_BUILD
Since there is no SPL support this is dead code right now, correct?
I'm wondering whether we should leave it out of mainline until the SPL
stuff is done, so SPL will be upstreamed all at once. What do others
think?
