[linux-sunxi] Re: [PATCH 5/7] ARM: sunxi-mmc: Add mmc support for sun6i / A31

2014-09-21 Thread Ian Campbell
On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote: > From: Hans de Goede > > Signed-off-by: Hans de Goede > [w...@csie.org: use setbits_le32 for reset control, drop obsolete changes, > squash "sunxi-mmc: sun6i has its fifo at a different address"] > Signed-off-by: Chen-Yu Tsai

[linux-sunxi] Re: [PATCH 5/7] ARM: sunxi-mmc: Add mmc support for sun6i / A31

2014-09-21 Thread Chen-Yu Tsai
On Mon, Sep 22, 2014 at 2:44 AM, Ian Campbell wrote: > On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote: >> From: Hans de Goede >> >> Signed-off-by: Hans de Goede >> [w...@csie.org: use setbits_le32 for reset control, drop obsolete changes, >> squash "sunxi-mmc: sun6i has its

[linux-sunxi] Re: [PATCH 5/7] ARM: sunxi-mmc: Add mmc support for sun6i / A31

2014-09-23 Thread Chen-Yu Tsai
On Mon, Sep 22, 2014 at 10:11 AM, Chen-Yu Tsai wrote: > On Mon, Sep 22, 2014 at 2:44 AM, Ian Campbell wrote: >> On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote: >>> From: Hans de Goede >>> >>> Signed-off-by: Hans de Goede >>> [w...@csie.org: use setbits_le32 for reset control, drop obsole

[linux-sunxi] Re: [PATCH 5/7] ARM: sunxi-mmc: Add mmc support for sun6i / A31

2014-09-23 Thread Ian Campbell
On Tue, 2014-09-23 at 19:50 +0800, Chen-Yu Tsai wrote: > Ian, include/configs/sun?i.h and sunxi-common.h only have config > related #defines. Are we sure this is the place for something > like register offsets? I guess not ;-) > For reference, drivers/i2c/mvtwsi.c has sunxi specific register > of

[linux-sunxi] Re: [PATCH 5/7] ARM: sunxi-mmc: Add mmc support for sun6i / A31

2014-09-23 Thread Chen-Yu Tsai
On Tue, Sep 23, 2014 at 7:54 PM, Ian Campbell wrote: > On Tue, 2014-09-23 at 19:50 +0800, Chen-Yu Tsai wrote: >> Ian, include/configs/sun?i.h and sunxi-common.h only have config >> related #defines. Are we sure this is the place for something >> like register offsets? > > I guess not ;-) > >> For

[linux-sunxi] Re: [PATCH 5/7] ARM: sunxi-mmc: Add mmc support for sun6i / A31

2014-09-23 Thread Ian Campbell
On Tue, 2014-09-23 at 20:07 +0800, Chen-Yu Tsai wrote: > On Tue, Sep 23, 2014 at 7:54 PM, Ian Campbell wrote: > > On Tue, 2014-09-23 at 19:50 +0800, Chen-Yu Tsai wrote: > >> Ian, include/configs/sun?i.h and sunxi-common.h only have config > >> related #defines. Are we sure this is the place for so