Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-24 Thread Lee Jones
+static struct mfd_cell axp20x_cells[] = { + { + .name = axp20x-pek, + .num_resources = ARRAY_SIZE(axp20x_pek_resources), + .resources = axp20x_pek_resources, + }, { + .name = axp20x-regulator, + }, +}; nit:

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Mark Brown
On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: + of_id = of_match_device(axp20x_of_match, i2c-dev); + if (!of_id) { + dev_err(i2c-dev, Unable to setup AXP20X data\n); + return -ENODEV; + }

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Dmitry Torokhov
On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote: On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown broo...@kernel.org wrote: On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: + of_id =

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Sat, Mar 22, 2014 at 11:42:01AM -0700, Dmitry Torokhov wrote: On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote: On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown broo...@kernel.org wrote: On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: On Tue, Mar 18, 2014 at

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-22 Thread Carlo Caione
On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown broo...@kernel.org wrote: On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: + of_id = of_match_device(axp20x_of_match, i2c-dev); + if (!of_id) { + dev_err(i2c-dev,

[linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

2014-03-18 Thread Lee Jones
This patch introduces the preliminary support for PMICs X-Powers AXP202 and AXP209. The AXP209 and AXP202 are the PMUs (Power Management Unit) used by A10, A13 and A20 SoCs and developed by X-Powers, a sister company of Allwinner. The core enables support for two subsystems: - PEK (Power