Re: [linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

2016-02-11 Thread Krzysztof Adamski
On Thu, Feb 11, 2016 at 02:17:41PM +0100, Linus Walleij wrote: On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski wrote: sunxi_pmx_set accepts pin number and then calculates offset by subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand, gets offset so we

Re: [linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

2016-02-11 Thread Linus Walleij
On Thu, Feb 11, 2016 at 2:20 PM, Krzysztof Adamski wrote: > On Thu, Feb 11, 2016 at 02:17:41PM +0100, Linus Walleij wrote: >> >> On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski wrote: >> >>> sunxi_pmx_set accepts pin number and then calculates offset by >>>

[linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

2016-02-11 Thread Chen-Yu Tsai
Hi, On Thu, Feb 11, 2016 at 9:17 PM, Linus Walleij wrote: > On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski wrote: > >> sunxi_pmx_set accepts pin number and then calculates offset by >> subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the

[linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

2016-02-11 Thread Linus Walleij
On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski wrote: > sunxi_pmx_set accepts pin number and then calculates offset by > subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand, > gets offset so we have to convert it to pin number so we won't get > negative

[linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

2016-02-02 Thread Chen-Yu Tsai
Hi, On Wed, Feb 3, 2016 at 5:21 AM, Krzysztof Adamski wrote: > sunxi_pmx_set accepts pin number and then calculates offset by > subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand, > gets offset so we have to convert it to pin number so we won't get > negative