[linux-sunxi] Re: [PATCH v3 05/10] arm: dts: sun8i: split Allwinner H3 .dtsi

2017-01-30 Thread Maxime Ripard
On Mon, Jan 30, 2017 at 01:42:40AM +, André Przywara wrote: > > + { > > + compatible = "allwinner,sun8i-h3-ccu"; > > +}; > > I believe this kind of sharing nodes is a bit frowned upon in connection > with sharing .dtsi's. If the compatible name differs, I think it > deserves to be a

[linux-sunxi] Re: [PATCH v3 05/10] arm: dts: sun8i: split Allwinner H3 .dtsi

2017-01-30 Thread Maxime Ripard
On Sun, Jan 29, 2017 at 10:33:26AM +0800, Icenowy Zheng wrote: > +#include > +#include > +#include > +#include You're also converting to the new headers you created. This should be part of a separate patch, or merged with your next one. Maxime -- Maxime Ripard, Free Electrons Embedded

[linux-sunxi] Re: [PATCH v3 05/10] arm: dts: sun8i: split Allwinner H3 .dtsi

2017-01-29 Thread André Przywara
On 29/01/17 02:33, Icenowy Zheng wrote: > From: Andre Przywara (Adding DT folks to CC:) see below ... > The new Allwinner H5 SoC is pin-compatible to the H3 SoC, but with the > Cortex-A7 cores replaced by Cortex-A53 cores and the MMC controller > updated. So we should