[linux-sunxi] Re: [PATCH v3 1/5] clk: Add a basic multiplier clock

2015-10-07 Thread Maxime Ripard
On Mon, Oct 05, 2015 at 11:09:29AM -0700, Stephen Boyd wrote: > On 10/05, Maxime Ripard wrote: > > Hi, > > > > On Fri, Oct 02, 2015 at 01:43:08PM -0700, Stephen Boyd wrote: > > > On 09/29, Maxime Ripard wrote: > > > > + > > > > + if (!val && mult->flags & CLK_MULTIPLIER_ZERO_BYPASS) > > > >

[linux-sunxi] Re: [PATCH v3 1/5] clk: Add a basic multiplier clock

2015-10-07 Thread Stephen Boyd
On 10/07, Maxime Ripard wrote: > On Mon, Oct 05, 2015 at 11:09:29AM -0700, Stephen Boyd wrote: > > On 10/05, Maxime Ripard wrote: > > > > > > Actually, the logic is also reversed. > > > > > > The divider driver will always try to find some rate that is higher > > > than the one we already have,

[linux-sunxi] Re: [PATCH v3 1/5] clk: Add a basic multiplier clock

2015-10-05 Thread Stephen Boyd
On 10/05, Maxime Ripard wrote: > Hi, > > On Fri, Oct 02, 2015 at 01:43:08PM -0700, Stephen Boyd wrote: > > On 09/29, Maxime Ripard wrote: > > > + > > > + if (!val && mult->flags & CLK_MULTIPLIER_ZERO_BYPASS) > > > + val = 1; > > > + > > > + return parent_rate * val; > > > +} > > > + > >

[linux-sunxi] Re: [PATCH v3 1/5] clk: Add a basic multiplier clock

2015-10-05 Thread Maxime Ripard
Hi, On Fri, Oct 02, 2015 at 01:43:08PM -0700, Stephen Boyd wrote: > On 09/29, Maxime Ripard wrote: > > diff --git a/drivers/clk/clk-multiplier.c b/drivers/clk/clk-multiplier.c > > new file mode 100644 > > index ..61097e365d55 > > --- /dev/null > > +++ b/drivers/clk/clk-multiplier.c >

[linux-sunxi] Re: [PATCH v3 1/5] clk: Add a basic multiplier clock

2015-10-02 Thread Stephen Boyd
On 09/29, Maxime Ripard wrote: > diff --git a/drivers/clk/clk-multiplier.c b/drivers/clk/clk-multiplier.c > new file mode 100644 > index ..61097e365d55 > --- /dev/null > +++ b/drivers/clk/clk-multiplier.c > @@ -0,0 +1,176 @@ > +/* > + * Copyright (C) 2015 Maxime Ripard