[linux-sunxi] Re: [PATCH v3 2/3] nvmem: sunxi-sid: add support for H3's SID controller

2017-02-10 Thread Maxime Ripard
On Tue, Feb 07, 2017 at 09:36:35PM +0800, Icenowy Zheng wrote: > >>  >>  @@ -51,7 +64,8 @@ static u8 sunxi_sid_read_byte(const struct > >> sunxi_sid *sid, > >>  >>   { > >>  >>   u32 sid_key; > >>  >> > >>  >>  - sid_key = ioread32be(sid->base + round_down(offset, 4)); > >>  >>  + sid_key

[linux-sunxi] Re: [PATCH v3 2/3] nvmem: sunxi-sid: add support for H3's SID controller

2017-02-07 Thread Maxime Ripard
On Mon, Feb 06, 2017 at 04:56:55PM +0800, Icenowy Zheng wrote: > 06.02.2017, 16:54, "Maxime Ripard" : > > On Thu, Feb 02, 2017 at 09:13:37PM +0800, Icenowy Zheng wrote: > >>  The H3 SoC have a bigger SID controller, which has its direct read > >>  address at 0x200 position in the SID block, not 0x0

[linux-sunxi] Re: [PATCH v3 2/3] nvmem: sunxi-sid: add support for H3's SID controller

2017-02-06 Thread Maxime Ripard
On Thu, Feb 02, 2017 at 09:13:37PM +0800, Icenowy Zheng wrote: > The H3 SoC have a bigger SID controller, which has its direct read > address at 0x200 position in the SID block, not 0x0. > > Also, H3 SID controller has some silicon bug that makes the direct read > value wrong at cold boot, add cod