[linux-sunxi] Re: [RFC PATCH v2 04/14] mtd: nand: define struct nand_timings

2014-03-10 Thread Boris BREZILLON
Hello, Le 29/01/2014 15:34, Boris BREZILLON a écrit : Define a struct containing the standard NAND timings as described in NAND datasheets. Signed-off-by: Boris BREZILLON --- include/linux/mtd/nand.h | 49 ++ 1 file changed, 49 insertions(+) di

[linux-sunxi] Re: [RFC PATCH v2 04/14] mtd: nand: define struct nand_timings

2014-03-11 Thread Jason Gunthorpe
On Mon, Mar 10, 2014 at 02:44:04PM +0100, Boris BREZILLON wrote: > Some timings are missing here (see Table 55 in the ONFI spec): Right.. The 'mode' covers only the raw electrical parameters needed to exchange commands, other timings cover the commands themselves. Notably the timing mode does no

[linux-sunxi] Re: [RFC PATCH v2 04/14] mtd: nand: define struct nand_timings

2014-03-12 Thread Boris BREZILLON
Le 11/03/2014 19:55, Jason Gunthorpe a écrit : On Mon, Mar 10, 2014 at 02:44:04PM +0100, Boris BREZILLON wrote: Some timings are missing here (see Table 55 in the ONFI spec): Right.. The 'mode' covers only the raw electrical parameters needed to exchange commands, other timings cover the comm

[linux-sunxi] Re: [RFC PATCH v2 04/14] mtd: nand: define struct nand_timings

2014-03-12 Thread Jason Gunthorpe
On Wed, Mar 12, 2014 at 05:46:53PM +0100, Boris BREZILLON wrote: > >>I see at least 3 of those timings that could be useful (for the moment) : > >>- tR: this one should be used to fill the chip_delay field > >>- tPROG and tBERS: could be used within nand_wait to choose the timeo > >> value appro

[linux-sunxi] Re: [RFC PATCH v2 04/14] mtd: nand: define struct nand_timings

2014-03-12 Thread Warner Losh
On Mar 12, 2014, at 1:07 PM, Jason Gunthorpe wrote: > On Wed, Mar 12, 2014 at 05:46:53PM +0100, Boris BREZILLON wrote: >> I'm not a big fan of this name. I think timing structs should not >> contain onfi in their names, because these timings are also >> available on non ONFI chips. > > Explici