Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi! Le jeudi 19 octobre 2023, 16:51:04 EEST Steven Rostedt a écrit : > On Thu, 19 Oct 2023 21:18:43 +0900 > > Masami Hiramatsu (Google) wrote: > > > So why is this adding stable? (and as Greg's form letter states, that's > > > not > > > how you do that) > > > > > > I don't see this as a fix but

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi! Le jeudi 19 octobre 2023, 18:07:08 EEST Masami Hiramatsu a écrit : > On Thu, 19 Oct 2023 09:51:04 -0400 > > Steven Rostedt wrote: > > On Thu, 19 Oct 2023 21:18:43 +0900 > > > > Masami Hiramatsu (Google) wrote: > > > > So why is this adding stable? (and as Greg's form letter states, > > > >

[PATCH v6 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi. In the kernel source code, it exists different functions which share the same name but which have, of course, different addresses as they can be defined in different modules: # Kernel was compiled with CONFIG_NTFS_FS and CONFIG_NTFS3_FS as built-in. root@vm-amd64:~# grep ntfs_file_write_iter

Re: [PATCH v6 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi, Thanks for update the series. The series looks good to me. Let me pick those in probes/fixes. Thank you! On Fri, 20 Oct 2023 13:42:48 +0300 Francis Laniel wrote: > Hi. > > > In the kernel source code, it exists different functions which share the same > name but which have, of course, di

[bug report] eventfs: Remove eventfs_file and just use eventfs_inode

Hello Steven Rostedt (Google), The patch 5790b1fb3d67: "eventfs: Remove eventfs_file and just use eventfs_inode" from Oct 4, 2023 (linux-next), leads to the following Smatch static checker warning: fs/tracefs/event_inode.c:782 eventfs_create_events_dir() error: potential null dere

[PATCH] tracing: Fix a NULL vs IS_ERR() bug in event_subsystem_dir()

The eventfs_create_dir() function returns error pointers, it never returns NULL. Update the check to reflect that. Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode") Signed-off-by: Dan Carpenter --- kernel/trace/trace_events.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v6 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi! Le vendredi 20 octobre 2023, 15:12:39 EEST Masami Hiramatsu a écrit : > Hi, > > Thanks for update the series. The series looks good to me. > Let me pick those in probes/fixes. Thank you for picking it and all the good advices during the development process! > Thank you! Best regards. > O