[PATCH net-next v3 3/3] tcp: add location into reset trace process

2024-03-28 Thread Jason Xing
From: Jason Xing In addition to knowing the 4-tuple of the flow which generates RST, the reason why it does so is very important because we have some cases where the RST should be sent and have no clue which one exactly. Adding location of reset process can help us more, like what trace_kfree_sk

[PATCH net-next v3 2/3] trace: tcp: fully support trace_tcp_send_reset

2024-03-28 Thread Jason Xing
From: Jason Xing Prior to this patch, what we can see by enabling trace_tcp_send is only happening under two circumstances: 1) active rst mode 2) non-active rst mode and based on the full socket That means the inconsistency occurs if we use tcpdump and trace simultaneously to see how rst happens

[PATCH net-next v3 1/3] trace: adjust TP_STORE_ADDR_PORTS_SKB() parameters

2024-03-28 Thread Jason Xing
From: Jason Xing Introducing entry_saddr and entry_daddr parameters in this macro for later use can help us record the reverse 4-tuple by analyzing the 4-tuple of the incoming skb when receiving. Signed-off-by: Jason Xing --- include/trace/events/tcp.h | 21 +++-- 1 file change

[PATCH net-next v3 0/3] tcp: make trace of reset logic complete

2024-03-28 Thread Jason Xing
From: Jason Xing Before this, we miss some cases where the TCP layer could send RST but we cannot trace it. So I decided to complete it :) v3 1. fix a format problem in patch [3/3] v2 1. fix spelling mistakes Jason Xing (3): trace: adjust TP_STORE_ADDR_PORTS_SKB() parameters trace: tcp: fu

Re: [PATCH net-next v2 3/3] tcp: add location into reset trace process

2024-03-28 Thread Jason Xing
On Fri, Mar 29, 2024 at 9:15 AM Jakub Kicinski wrote: > > On Tue, 26 Mar 2024 12:08:01 +0100 Paolo Abeni wrote: > > > - TP_PROTO(const struct sock *sk, const struct sk_buff *skb), > > > + TP_PROTO( > > > + const struct sock *sk, > > > + const struct sk_buff *skb, > > > +

Re: [PATCH net-next v2 3/3] tcp: add location into reset trace process

2024-03-28 Thread Jakub Kicinski
On Tue, 26 Mar 2024 12:08:01 +0100 Paolo Abeni wrote: > > - TP_PROTO(const struct sock *sk, const struct sk_buff *skb), > > + TP_PROTO( > > + const struct sock *sk, > > + const struct sk_buff *skb, > > + void *location), > > Very minor nit: the above lines shoul

Re: [PATCH v5 0/2] Update mce_record tracepoint

2024-03-28 Thread Naik, Avadhut
On 3/28/2024 13:14, Sohil Mehta wrote: > On 3/28/2024 11:04 AM, Avadhut Naik wrote: > >> - Since only caps of words which are not acronyms have been changed in >>this version and the word "REVISION" has been removed i.e. changes are >>very minor, have retained the the below tags receiv

Re: [PATCH v5 0/2] Update mce_record tracepoint

2024-03-28 Thread Sohil Mehta
On 3/28/2024 11:04 AM, Avadhut Naik wrote: > - Since only caps of words which are not acronyms have been changed in >this version and the word "REVISION" has been removed i.e. changes are >very minor, have retained the the below tags received for previous >versions: > Reviewed-by:

[PATCH v5 1/2] tracing: Include PPIN in mce_record tracepoint

2024-03-28 Thread Avadhut Naik
Machine Check Error information from struct mce is exported to userspace through the mce_record tracepoint. Currently, however, the PPIN (Protected Processor Inventory Number) field of struct mce is not exported through the tracepoint. Export PPIN through the tracepoint as it provides a unique id

[PATCH v5 2/2] tracing: Include Microcode Revision in mce_record tracepoint

2024-03-28 Thread Avadhut Naik
Currently, the microcode field (Microcode Revision) of struct mce is not exported to userspace through the mce_record tracepoint. Knowing the microcode version on which the MCE was received is critical information for debugging. If the version is not recorded, later attempts to acquire the version

[PATCH v5 0/2] Update mce_record tracepoint

2024-03-28 Thread Avadhut Naik
This patchset updates the mce_record tracepoint so that the recently added fields of struct mce are exported through it to userspace. The first patch adds PPIN (Protected Processor Inventory Number) field to the tracepoint. The second patch adds the microcode field (Microcode Revision) to the tra

[PATCH 00/11] address remaining stringop-truncation warnings

2024-03-28 Thread Arnd Bergmann
From: Arnd Bergmann We are close to being able to turn on -Wstringop-truncation unconditionally instead of only at the 'make W=1' level, these ten warnings are all that I saw in randconfig testing across compiler versions on arm, arm64 and x86. The final patch is only there for reference at the