Re: [PATCH v1 3/4] platform/x86/intel/ifs: Add SBAF test support

2024-07-06 Thread Kuppuswamy Sathyanarayanan
On 7/6/24 10:20 AM, Joseph, Jithu wrote: > Thanks very much for the review Ilpo, > > On 7/6/2024 6:19 PM, Ilpo Järvinen wrote: >> On Thu, 27 Jun 2024, Kuppuswamy Sathyanarayanan wrote: >> >>> From: Jithu Joseph >>> >>> In a core, the SBAF test engine is shared between sibling CPUs. >>> >>> An

Re: [PATCH v1 3/4] platform/x86/intel/ifs: Add SBAF test support

2024-07-06 Thread Joseph, Jithu
Thanks very much for the review Ilpo, On 7/6/2024 6:19 PM, Ilpo Järvinen wrote: > On Thu, 27 Jun 2024, Kuppuswamy Sathyanarayanan wrote: > >> From: Jithu Joseph >> >> In a core, the SBAF test engine is shared between sibling CPUs. >> >> An SBAF test image contains multiple bundles. Each bundle

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-06 Thread Jiri Olsa
On Sat, Jul 06, 2024 at 07:00:34PM +0200, Jiri Olsa wrote: > On Fri, Jul 05, 2024 at 05:37:05PM +0200, Oleg Nesterov wrote: > > Tried to read this patch, but I fail to understand it. It looks > > obvioulsy wrong to me, see below. > > > > I tend to agree with the comments from Peter, but lets

Re: [PATCH v2 04/12] uprobes: revamp uprobe refcounting and lifetime management

2024-07-06 Thread Jiri Olsa
On Fri, Jul 05, 2024 at 05:37:05PM +0200, Oleg Nesterov wrote: > Tried to read this patch, but I fail to understand it. It looks > obvioulsy wrong to me, see below. > > I tend to agree with the comments from Peter, but lets ignore them > for the moment. > > On 07/01, Andrii Nakryiko wrote: > > >

Re: [PATCH v1 3/4] platform/x86/intel/ifs: Add SBAF test support

2024-07-06 Thread Ilpo Järvinen
On Thu, 27 Jun 2024, Kuppuswamy Sathyanarayanan wrote: > From: Jithu Joseph > > In a core, the SBAF test engine is shared between sibling CPUs. > > An SBAF test image contains multiple bundles. Each bundle is further > composed of subunits called programs. When a SBAF test (for a particular >