Re: [PATCH v2 3/4] platform/x86/intel/ifs: Add SBAF test support

2024-07-11 Thread Joseph, Jithu
On 7/12/2024 2:51 AM, Ashok Raj wrote: > On Thu, Jul 11, 2024 at 12:44:23PM +0300, Ilpo Järvinen wrote: >>> +static bool sbaf_bundle_completed(union ifs_sbaf_status status) >>> +{ >>> + if (status.sbaf_status || status.error_code) >>> + return false; >>> + return true; >> >> This i

Re: [PATCH v2 3/4] platform/x86/intel/ifs: Add SBAF test support

2024-07-11 Thread Joseph, Jithu
On 7/11/2024 9:28 PM, Kuppuswamy Sathyanarayanan wrote: >>> + >>> +static const char * const sbaf_test_status[] = { >>> + [IFS_SBAF_NO_ERROR] = "SBAF no error", >>> + [IFS_SBAF_OTHER_THREAD_COULD_NOT_JOIN] = "Other thread could not join.", >>> + [IFS_SBAF_INTERRUPTED_BEFORE_RENDEZVOUS] =

Re: [PATCH v1 3/4] platform/x86/intel/ifs: Add SBAF test support

2024-07-06 Thread Joseph, Jithu
Thanks very much for the review Ilpo, On 7/6/2024 6:19 PM, Ilpo Järvinen wrote: > On Thu, 27 Jun 2024, Kuppuswamy Sathyanarayanan wrote: > >> From: Jithu Joseph >> >> In a core, the SBAF test engine is shared between sibling CPUs. >> >> An SBAF test image contains multiple bundles. Each bundle i