Re: [PATCH] arm64: uprobes: Optimize cache flushes for xol slot

2024-09-23 Thread Will Deacon
On Mon, Sep 23, 2024 at 09:57:14AM +0800, Liao, Chang wrote: > 在 2024/9/20 23:32, Catalin Marinas 写道: > > On Fri, Sep 20, 2024 at 04:58:31PM +0800, Liao, Chang wrote: > >> 在 2024/9/19 22:18, Oleg Nesterov 写道: > >>> On 09/19, Liao Chang wrote: > --- a/arch/arm64/kernel/probes/uprobes.c > +

Re: [PATCH] arm64: uprobes: Optimize cache flushes for xol slot

2024-09-22 Thread Will Deacon
On Fri, Sep 20, 2024 at 07:32:23PM +0200, Oleg Nesterov wrote: > On 09/20, Catalin Marinas wrote: > > > > On Fri, Sep 20, 2024 at 04:58:31PM +0800, Liao, Chang wrote: > > > > > > > > > 在 2024/9/19 22:18, Oleg Nesterov 写道: > > > > On 09/19, Liao Chang wrote: > > > >> > > > >> --- a/arch/arm64/kernel

Re: [PATCH v14 08/19] tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs

2024-09-17 Thread Will Deacon
gt; > > +static __always_inline struct pt_regs * > > +ftrace_partial_regs(const struct ftrace_regs *fregs, struct pt_regs *regs) > > +{ > > + memcpy(regs->regs, fregs->regs, sizeof(u64) * 9); > > + regs->sp = fregs->sp; > > + regs->pc = fregs->pc; > > + regs->regs[29] = fregs->fp; > > + regs->regs[30] = fregs->lr; > > + return regs; > > +} Ah, I guess this is where we pick up the lr that was set in patch 5. Acked-by: Will Deacon Will

Re: [PATCH v14 05/19] function_graph: Pass ftrace_regs to retfunc

2024-09-17 Thread Will Deacon
On Sun, Sep 15, 2024 at 04:49:20AM -0400, Steven Rostedt wrote: > On Fri, 13 Sep 2024 00:09:02 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Masami Hiramatsu (Google) > > > > Pass ftrace_regs to the fgraph_ops::retfunc(). If ftrace_regs is not > > available, it passes a NULL instead. U

Re: [PATCH v14 04/19] function_graph: Replace fgraph_ret_regs with ftrace_regs

2024-09-17 Thread Will Deacon
On Sun, Sep 15, 2024 at 05:11:44AM -0400, Steven Rostedt wrote: > On Fri, 13 Sep 2024 00:08:51 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Masami Hiramatsu (Google) > > > > Use ftrace_regs instead of fgraph_ret_regs for tracing return value > > on function_graph tracer because of sim

Re: [PATCH v14 03/19] function_graph: Pass ftrace_regs to entryfunc

2024-09-17 Thread Will Deacon
On Sun, Sep 15, 2024 at 04:46:14AM -0400, Steven Rostedt wrote: > Can I get an Acked-by from the AARCH64 maintainers for this patch? Sorry, I wasn't CC'd on the thread, so I missed this. > On Fri, 13 Sep 2024 00:08:40 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Masami Hiramatsu (Goog