Re: [PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-30 Thread Ingo Molnar
* Naik, Avadhut wrote: > On 3/29/2024 02:11, Ingo Molnar wrote: > > > > Please split out the other (capitalization) changes to the output into > > a separate patch. > > > Okay. Will put the capitalization changes into a separate patch. > > > - While at it, don't forget to: > > > >s/ADD

[PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-29 Thread Naik, Avadhut
On 3/29/2024 11:50, Luck, Tony wrote: >>> - While at it, don't forget to: >>> >>>s/ADDR/MISC/SYND >>> /addr/misc/synd >>> >> These are actually acronyms for Address, Miscellaneous and Syndrome >> registers. > > They look like abbreviations, not acronyms to me. > > -Tony Yes, they are

RE: [PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-29 Thread Luck, Tony
>> - While at it, don't forget to: >> >>s/ADDR/MISC/SYND >> /addr/misc/synd >> > These are actually acronyms for Address, Miscellaneous and Syndrome registers. They look like abbreviations, not acronyms to me. -Tony

[PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-29 Thread Naik, Avadhut
patch below? > > Thanks, > > Ingo > > ====> > From: Ingo Molnar > Date: Fri, 29 Mar 2024 08:09:23 +0100 > Subject: [PATCH] x86/mce: Clean up TP_printk() output line of the mce_record > tracepoint > > - Only capitalize entries where that make

[PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-29 Thread Ingo Molnar
s/ADDR/MISC/SYND /addr/misc/synd - Also, it's a bit weird that we have 'CPU' but also 'processor' fields, why isn't it 'vendor' and 'CPUID'? - Finally, why are some fields 'merged' as per ADDR/MISC/SYND, while others a