Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-06 Thread Xuan Zhuo
On Tue, 5 Dec 2023 20:39:28 +0100, Eric Dumazet wrote: > On Tue, Dec 5, 2023 at 3:11 AM Xuan Zhuo wrote: > > > > On Mon, 4 Dec 2023 13:28:21 +0100, Eric Dumazet wrote: > > > On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > > > > > > > Add 3 tracepoints, namely

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2023 20:39:28 +0100 Eric Dumazet wrote: > > So, we do not want to add some tracepoint to do some unknow debug. > > We have a clear goal. debugging is just an incidental capability. > > > > We have powerful mechanisms in the stack already that ordinary (no > privilege requested)

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-05 Thread Eric Dumazet
On Tue, Dec 5, 2023 at 3:11 AM Xuan Zhuo wrote: > > On Mon, 4 Dec 2023 13:28:21 +0100, Eric Dumazet wrote: > > On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > > > > > Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, > > > which will be called every time a tcp data

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-04 Thread Xuan Zhuo
On Mon, 4 Dec 2023 13:28:21 +0100, Eric Dumazet wrote: > On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > > > Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, > > which will be called every time a tcp data packet is sent, received, and > > acked. > > tcp_data_send: called

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-04 Thread Eric Dumazet
On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, > which will be called every time a tcp data packet is sent, received, and > acked. > tcp_data_send: called after a data packet is sent. > tcp_data_recv: called after a data

[PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-04 Thread Philo Lu
Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, which will be called every time a tcp data packet is sent, received, and acked. tcp_data_send: called after a data packet is sent. tcp_data_recv: called after a data packet is receviced. tcp_data_acked: called after a valid ack