Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-20 Thread Francis Laniel
Hi! Le jeudi 19 octobre 2023, 18:07:08 EEST Masami Hiramatsu a écrit : > On Thu, 19 Oct 2023 09:51:04 -0400 > > Steven Rostedt wrote: > > On Thu, 19 Oct 2023 21:18:43 +0900 > > > > Masami Hiramatsu (Google) wrote: > > > > So why is this adding stable? (and as Greg's form letter states, > > >

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-20 Thread Francis Laniel
Hi! Le jeudi 19 octobre 2023, 16:51:04 EEST Steven Rostedt a écrit : > On Thu, 19 Oct 2023 21:18:43 +0900 > > Masami Hiramatsu (Google) wrote: > > > So why is this adding stable? (and as Greg's form letter states, that's > > > not > > > how you do that) > > > > > > I don't see this as a fix

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-19 Thread Google
On Thu, 19 Oct 2023 09:51:04 -0400 Steven Rostedt wrote: > On Thu, 19 Oct 2023 21:18:43 +0900 > Masami Hiramatsu (Google) wrote: > > > > So why is this adding stable? (and as Greg's form letter states, that's > > > not > > > how you do that) > > > > > > I don't see this as a fix but a new

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-19 Thread Steven Rostedt
On Thu, 19 Oct 2023 21:18:43 +0900 Masami Hiramatsu (Google) wrote: > > So why is this adding stable? (and as Greg's form letter states, that's not > > how you do that) > > > > I don't see this as a fix but a new feature. > > I asked him to make this a fix since the current kprobe event'

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-19 Thread Google
On Wed, 18 Oct 2023 13:00:42 -0400 Steven Rostedt wrote: > On Wed, 18 Oct 2023 17:40:28 +0300 > Francis Laniel wrote: > > > Changes since: > > v1: > > * Use EADDRNOTAVAIL instead of adding a new error code. > > * Correct also this behavior for sysfs kprobe. > > v2: > > * Count the

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-19 Thread Francis Laniel
Hi! Le mercredi 18 octobre 2023, 20:00:42 EEST Steven Rostedt a écrit : > On Wed, 18 Oct 2023 17:40:28 +0300 > > Francis Laniel wrote: > > Changes since: > > v1: > > * Use EADDRNOTAVAIL instead of adding a new error code. > > * Correct also this behavior for sysfs kprobe. > > > > v2: >

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-18 Thread Steven Rostedt
On Wed, 18 Oct 2023 17:40:28 +0300 Francis Laniel wrote: > Changes since: > v1: > * Use EADDRNOTAVAIL instead of adding a new error code. > * Correct also this behavior for sysfs kprobe. > v2: > * Count the number of symbols corresponding to function name and return > EADDRNOTAVAIL if

[PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

2023-10-18 Thread Francis Laniel
Hi. In the kernel source code, it exists different functions which share the same name but which have, of course, different addresses as they can be defined in different modules: # Kernel was compiled with CONFIG_NTFS_FS and CONFIG_NTFS3_FS as built-in. root@vm-amd64:~# grep ntfs_file_write_iter