Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-04 Thread Xuan Zhuo
On Mon, 4 Dec 2023 13:28:21 +0100, Eric Dumazet wrote: > On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > > > Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, > > which will be called every time a tcp data packet is sent, received, and > > acked. > > tcp_data_send: called

[PATCH v2] 9p: prevent read overrun in protocol dump tracepoint

2023-12-04 Thread JP Kobryn
An out of bounds read can occur within the tracepoint 9p_protocol_dump. In the fast assign, there is a memcpy that uses a constant size of 32 (macro named P9_PROTO_DUMP_SZ). When the copy is invoked, the source buffer is not guaranteed match this size. It was found that in some cases the source

Re: [PATCH] 9p: prevent read overrun in protocol dump tracepoint

2023-12-04 Thread JP Kobryn
On Sun, Dec 03, 2023 at 02:32:15PM +0900, Dominique Martinet wrote: > Steven Rostedt wrote on Sat, Dec 02, 2023 at 11:15:24PM -0500: > > > Also, for custom tracepoints e.g. bpftrace the program needs to know how > > > many bytes can be read safely even if it's just for dumping -- unless > > >

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-04 Thread Eric Dumazet
On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, > which will be called every time a tcp data packet is sent, received, and > acked. > tcp_data_send: called after a data packet is sent. > tcp_data_recv: called after a data

[PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-04 Thread Philo Lu
Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, which will be called every time a tcp data packet is sent, received, and acked. tcp_data_send: called after a data packet is sent. tcp_data_recv: called after a data packet is receviced. tcp_data_acked: called after a valid ack