Re: [PATCH v2 3/4] mips: drop definition of pfn_valid() for DISCONTIGMEM

2023-02-03 Thread David Hildenbrand
On 29.01.23 13:42, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" There is stale definition of pfn_valid() for DISCONTINGMEM memory model guarded !FLATMEM && !SPARSEMEM && NUMA ifdefery. Remove everything but definition of pfn_valid() for FLATMEM. Signed-off-by: Mike Rapoport (IBM) Revie

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-02-03 Thread David Hildenbrand
On 29.01.23 13:42, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" Every architecture that supports FLATMEM memory model defines its own version of pfn_valid() that essentially compares a pfn to max_mapnr. Use mips/powerpc version implemented as static inline as a generic implementation of pf

Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU

2023-02-03 Thread David Hildenbrand
On 29.01.23 13:42, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" The MMU variant uses generic definitions of page_to_pfn() and pfn_to_page(), but !MMU defines them in include/asm/page_no.h for no good reason. Include asm-generic/memory_model.h in the common include/asm/page.h and drop redun

Re: [PATCH v2 1/4] arm: include asm-generic/memory_model.h from page.h rather than memory.h

2023-02-03 Thread David Hildenbrand
On 29.01.23 13:42, Mike Rapoport wrote: From: "Mike Rapoport (IBM)" Makes it consistent with other architectures and allows for generic definition of pfn_valid() in asm-generic/memory_model.h with clear override in arch/arm/include/asm/page.h Signed-off-by: Mike Rapoport (IBM) --- Reviewed-