"retval" has to be a signed integer for the error handling to work.
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 05ecf14..bd7cbaa 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -589,7 +589,8 @@ smsc95xx_ethto
Hi,
I have exactly the same webcam, lsusb says "Bus 002 Device 004: ID
046d:0826 Logitech, Inc."...
On 06.07.2012, Alan Stern wrote:
> On Thu, 5 Jul 2012, Frederik Himpe wrote:
> > I tried setting to on again, and then this appears in the logs:
> > Jul 5 21:21:59 piranha kernel: [ 9788.223118
On 07/11/2012 03:37 AM, Dr. Ing. Dieter Jurzitza wrote:
Dear listmembers,
dear Sarah, dear Andiry,
Andiry's suggestion (uncomment the return 0 - statement) fixed my issue, the
usb soundcard remains active after a login-logout; however, as I understood
Sarah's comment this is no more than a plaste
Phy may need to change settings when port connect change.
Signed-off-by: Richard Zhao
Tested-by: Subodh Nijsure
---
Changes since last version:
- remove unlikely
drivers/usb/core/hub.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub
On Tue, Jul 10, 2012 at 11:07:14AM -0400, Alan Stern wrote:
> On Tue, 10 Jul 2012, Richard Zhao wrote:
>
> > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote:
> > > Phy may need to change settings when port connect change.
> > >
> > > Signed-off-by: Richard Zhao
> > > Tested-by: Subo
On 07/11/2012 01:56 AM, Matt wrote:
Lee Harris writes:
Hi Sarah
Whenever I restart or coldboot, my external drive (3.5 sata in a USB3
enclosure) is not detected / initialised correctly. fdisk -l does not
show the drive at all.
I have found that I have to:
turn it off ( or disconnect the usb
> ehci_hcd :00:1d.0: port 1 reset error -110
It stands for software wants bus reset to complete, but hardware refuses
it after 1ms handshake. If Alan is correct that it is a internal hub
integrated in chipset,
you may can't do nothing except for asking chip vendor as you can't
measure the dp/d
Signed-off-by: Tomoya MORINAGA
---
drivers/usb/host/ehci-hub.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index fc9e7cc..d596d0f 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@
From: Gustavo Padovan
A lot of Broadcom Bluetooth devices provides vendor specific interface
class and we are getting flooded by patches adding new device support.
This change will help us enable support for any other Broadcom with vendor
specific device that arrives in the future.
Only the prod
Hi Gustavo,
> A lot of Broadcom Bluetooth devices provides vendor specific interface
> class and we are getting flooded by patches adding new device support.
> This change will help us enable support for any other Broadcom with vendor
> specific device that arrives in the future.
>
> Only the pro
On Tue, Jul 10, 2012 at 06:51:03PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> A lot of Broadcom Bluetooth devices provides vendor specific interface
> class and we are getting flooded by patches adding new device support.
> This change will help us enable support for any other Broa
From: Gustavo Padovan
A lot of Broadcom Bluetooth devices provides vendor specific interface
class and we are getting flooded by patches adding new device support.
This change will help us enable support for any other Broadcom with vendor
specific device that arrives in the future.
Only the prod
Hi Peter,
I tried to do some more debugging . I am getting a time out in
port reset . Here I am copying the dmesg . Here is the error I
am getting .
ehci_hcd :00:1d.0: port 1 reset error -110
hub 2-0:1.0: hub_port_status failed (err = -32)
-
Hi Yuri,
On Wed, Jul 11, 2012 at 12:33:22AM +0700, Yuri Khan wrote:
> * Add this device to usbhid ignore list
Please do not forget your "Signed-off-by: " so that I can apply the
patch.
Thanks.
> ---
> drivers/hid/hid-core.c|1 +
> drivers/hid/hid-ids.h |3 +++
> drivers
On Wed, 11 Jul 2012, Yuri Khan wrote:
> * Add this device to usbhid ignore list
> ---
> drivers/hid/hid-core.c|1 +
> drivers/hid/hid-ids.h |3 +++
Acked-by: Jiri Kosina
> drivers/input/joystick/xpad.c |1 +
> 3 files changed, 5 insertions(+)
>
> diff --git a/drive
Dear listmembers,
dear Sarah, dear Andiry,
Andiry's suggestion (uncomment the return 0 - statement) fixed my issue, the
usb soundcard remains active after a login-logout; however, as I understood
Sarah's comment this is no more than a plaster on the problem.
So, I am willing to do more testing -
Lee Harris writes:
>
>
> Hi Sarah
>
> Whenever I restart or coldboot, my external drive (3.5 sata in a USB3
> enclosure) is not detected / initialised correctly. fdisk -l does not
> show the drive at all.
> I have found that I have to:
> turn it off ( or disconnect the usb cable)
> modprobe
* Add this device to usbhid ignore list
---
drivers/hid/hid-core.c|1 +
drivers/hid/hid-ids.h |3 +++
drivers/input/joystick/xpad.c |1 +
3 files changed, 5 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 6ac0286..1540934 100644
--- a/d
On Tue, Jul 10, 2012 at 10:11 AM, Alan Stern wrote:
> On Tue, 10 Jul 2012, Greg KH wrote:
>
>> > I'm fine with this patch. I was going to add these:
>> >
>> > Based-on-patch-by: AceLan Kao
>> > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=37632
>> > Reference: https://bugzi
On Tue, Jul 10, 2012 at 10:17 AM, Greg KH wrote:
> On Tue, Jul 10, 2012 at 12:11:41PM -0400, Alan Stern wrote:
>> On Tue, 10 Jul 2012, Greg KH wrote:
>>
>> > > I'm fine with this patch. I was going to add these:
>> > >
>> > > Based-on-patch-by: AceLan Kao
>> > > Reference: https://bugzil
Hi Greg/Venu/Alan and others,
The defect discussed in this thread was found in 2006, and was marked in
Coverity Scan as false positive - intentional ( by linux developer or coverity
admin that we don't know)...
As a general rule,
1. what was discussed with some of the Linux folks, Focus on NEW
Hi,
I put a printk before the check and this is what I got
udc: at91_udc version 3 May 2006
g_ether gadget: using random host ethernet address
usb0: MAC a2:46:1a:43:ea:9f
usb0: HOST MAC de:bd:69:82:1d:68
g_ether gadget: Ethernet Gadget, version: Memorial Day 2008
g_ether gadget: g_ether ready
TCP
Reorder elements in the usb_host_interface structure to remove 8 bytes
of padding on 64 bit builds , and so shrink it's size to 40 bytes.
usb_interface_descriptor is a odd size which leaves a gap that is not
big enough to hold a pointer, so moving extralen into that gap removes
the need for mo
On Tue, Jul 10, 2012 at 12:11:41PM -0400, Alan Stern wrote:
> On Tue, 10 Jul 2012, Greg KH wrote:
>
> > > I'm fine with this patch. I was going to add these:
> > >
> > > Based-on-patch-by: AceLan Kao
> > > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=37632
> > > Reference:
On Tue, 10 Jul 2012, Greg KH wrote:
> > I'm fine with this patch. I was going to add these:
> >
> > Based-on-patch-by: AceLan Kao
> > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=37632
> > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=42728
> >
> > I don't have t
On Tue, Jul 10, 2012 at 09:32:59AM -0600, Bjorn Helgaas wrote:
> On Mon, Jul 9, 2012 at 10:47 AM, Greg KH wrote:
> > On Mon, Jul 09, 2012 at 06:50:24PM +0200, Rafael J. Wysocki wrote:
> >> On Monday, July 09, 2012, Alan Stern wrote:
> >> > Quite a few ASUS computers experience a nasty problem, rel
On Tue, Jul 10, 2012 at 03:54:06PM +0100, Mario Jorge Isidoro wrote:
> I've found that the following change also works, if someone doesn't want to
> simply eliminate the check
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index 7687ccd..33a6999 100644
> --- a/drive
On Mon, Jul 9, 2012 at 10:47 AM, Greg KH wrote:
> On Mon, Jul 09, 2012 at 06:50:24PM +0200, Rafael J. Wysocki wrote:
>> On Monday, July 09, 2012, Alan Stern wrote:
>> > Quite a few ASUS computers experience a nasty problem, related to the
>> > EHCI controllers, when going into system suspend. It
Yes, ignore my patch. It was applied to usb-next already and I forgot to check
there.
Jerry
On Tue Jul 10 12, Greg KH wrote:
> On Mon, Jul 09, 2012 at 11:32:20PM -0700, Gerard Snitselaar wrote:
> > commit ff9cce82 added back 2 lines that were removed by commit
> > c83a8542 causing build of twl60
On Tue, 10 Jul 2012, Venu Byravarasu wrote:
> Thanks Alan for your comments.
>
> On Monday 09 July 2012 08:04 PM, Alan Stern wrote:
> > On Mon, 9 Jul 2012, Venu Byravarasu wrote:
> >
> >> In functions itd_complete & sitd_complete, a pointer
> >> by name stream may get dereferenced after freeing
On Tue, 10 Jul 2012, Richard Zhao wrote:
> On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote:
> > Phy may need to change settings when port connect change.
> >
> > Signed-off-by: Richard Zhao
> > Tested-by: Subodh Nijsure
> > ---
> > drivers/usb/core/hub.c |8
> > 1 fil
Hi,
I can confirm that with the latest rc and the alterations you mentioned also
solve the problem for me
I've found that the following change also works, if someone doesn't want to
simply eliminate the check
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 7687c
On Tue, Jul 10, 2012 at 10:24:07AM -0400, Alan Stern wrote:
> On Tue, 10 Jul 2012, Richard Zhao wrote:
>
> > > > @@ -4037,6 +4038,13 @@ static void hub_port_connect_change(struct
> > > > usb_hub *hub, int port1,
> > > > }
> > > > }
> > > >
> > > > + if (unlikely(hc
On Tue, Jul 10, 2012 at 09:56:39AM +0530, Venu Byravarasu wrote:
> Thanks Alan for your comments.
>
> On Monday 09 July 2012 08:04 PM, Alan Stern wrote:
> >On Mon, 9 Jul 2012, Venu Byravarasu wrote:
> >
> >>In functions itd_complete & sitd_complete, a pointer
> >>by name stream may get dereferenc
On Mon, Jul 09, 2012 at 11:32:20PM -0700, Gerard Snitselaar wrote:
> commit ff9cce82 added back 2 lines that were removed by commit
> c83a8542 causing build of twl6030-usb to get an error due to otg being
> referenced, but not declared. This patch removes those 2 lines again
> to restore intent of
On Tue, Jul 10, 2012 at 07:50:30AM -0400, Sarah Sharp wrote:
> USB 3.0 devices can optionally support Latency Tolerance Messaging
> (LTM). Add a new sysfs file in the device directory to show whether a
> device is LTM capable. This file will be present for both USB 2.0 and
> USB 3.0 devices.
>
>
On Tue, 10 Jul 2012, Richard Zhao wrote:
> > > @@ -4037,6 +4038,13 @@ static void hub_port_connect_change(struct usb_hub
> > > *hub, int port1,
> > > }
> > > }
> > >
> > > + if (unlikely(hcd->phy && !hdev->parent)) {
> >
> > Why is this "unlikely"? And why mark it as such, is this
+wider auditory (linux-kernel)
-- Forwarded message --
From: Ruslan Bilovol
Date: Fri, Jul 6, 2012 at 7:53 PM
Subject: How to get drivers/usb/musb/omap2430.c built into the kernel, not
as module? (bug in kconfig?)
To: linux-usb@vger.kernel.org
Hi all,
It seems we have an issue
On 7/8/2012 4:20 AM, Paul Zimmerman wrote:
Commit "usb: dwc3: resume phy during gadget initialization on recent
cores" breaks phy suspend on cores newer than 1.94a. The core will
still operate, but the power savings provided by phy suspend are lost.
Pratyush, did you see an actual problem caused
We need to use CONFIG_FSL_SOC_BOOKE instead of CONFIG_PPC_85xx as
CONFIG_PPC_85xx isn't defined when we build support for 64-bit embedded
FSL PPC SoCs.
Signed-off-by: Kumar Gala
---
drivers/usb/host/ehci-fsl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/
USB 3.0 devices can optionally support Latency Tolerance Messaging
(LTM). Add a new sysfs file in the device directory to show whether a
device is LTM capable. This file will be present for both USB 2.0 and
USB 3.0 devices.
Signed-off-by: Sarah Sharp
---
v2: Add ABI documentation.
I think th
Dear Richard Zhao,
[...]
> > > --- a/drivers/usb/core/hub.c
> > > +++ b/drivers/usb/core/hub.c
> > > @@ -1924,6 +1924,11 @@ void usb_disconnect(struct usb_device **pdev)
> > >
> > >*/
> > >
> > > device_del(&udev->dev);
> > >
> > > + if (udev->parent && !udev->parent->parent) {
> > > +
On 7/6/2012 4:01 PM, Pratyush ANAND wrote:
In some rare cases, we have observed that core generates xfercomplete
event for last transfer even when "end transfer" was issued for that
endpoint.
Now since we have already called the giveback for the submitted request,
so we do not need to handle thi
On Tue, Jul 10, 2012 at 05:22:20AM +0200, Marek Vasut wrote:
> Dear Richard Zhao,
>
> > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote:
> > > Phy may need to change settings when port connect change.
> > >
> > > Signed-off-by: Richard Zhao
> > > Tested-by: Subodh Nijsure
> > > ---
Hi,
>
> Hi,
> > On Tue, Jul 10, 2012 at 11:35 AM, Gupta, Ajay Kumar
> > wrote:
> > > Hi,
> > >>
> > >> On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri
> > >> wrote:
> > >> > From: Ajay Kumar Gupta
> > >> >
> > >> > AM335x uses NOP transceiver driver and need to enable builtin PHY
> > >> > b
On Tue, Jul 10, 2012 at 02:59:27AM +0200, Peter Stuge wrote:
> Ian Osgood wrote:
> > dmesg errors:
> > xhci_hcd :00:14.0: xhci_run
> > xhci_hcd :00:14.0: Failed to enable MSI-X
> > xhci_hcd :00:14.0: failed to allocate MSI entry
> > xhci_hcd :00:14.0: No msi-x/msi found and no IRQ i
On Fri, Jul 6, 2012 at 8:06 PM, Mario Jorge Isidoro
wrote:
> Hi Fabio,
>
> I tried 3.4 and you were right, it still works fine.
>
> For the 'struct at91_ep' has no member named 'desc' error I tried commenting
> the offending declaration (|| ep->desc)
> and it builds without any error. During the
Dear Joel,
Thank you for your review.
@Sebastian, Alan, Felipe: Thank you, too.
On Monday, July 02, 2012 11:09 AM Joel Becker wrote:
>
> > As a prerequisite it adds an operation to configfs. The operation allows
> > checking if it is ok to remove a pseudo directory corresponding to a
> > con
On Tuesday 10 July 2012 01:46 PM, ABRAHAM, KISHON VIJAY wrote:
Hi,
On Tue, Jul 10, 2012 at 11:59 AM, Rajendra Nayak wrote:
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote:
All the unnessary functions in omap-phy-internal is removed.
These functionality are now handled by omap
On Tuesday 10 July 2012 01:43 PM, ABRAHAM, KISHON VIJAY wrote:
Hi,
On Tue, Jul 10, 2012 at 11:57 AM, Rajendra Nayak wrote:
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote:
Add usb otg data node in omap4/omap3 device tree file. Also update
the node with board specific setting
Thomas Schäfer writes:
> Am Montag, 9. Juli 2012, 10:25:27 schrieben Sie:
>> Thomas Schäfer writes:
>> > The modem works at /dev/USB2.
>
>> posted:
>> | diag 19d2:0326 MI00\6
>> | nema 19d2:0326 MI01\6
>> | at- 19d2:0326 MI02\6
>> | modem 19d2:0326 MI03\6
>> | ndis 19d2:0326 MI04\6
>>
>> I
Hi,
On Tue, Jul 10, 2012 at 12:14 PM, Rajendra Nayak wrote:
> On Tuesday 10 July 2012 11:58 AM, ABRAHAM, KISHON VIJAY wrote:
>>
>> Hi,
>>
>> On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak wrote:
>>>
>>> On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote:
Add device
Hi,
On Tue, Jul 10, 2012 at 11:59 AM, Rajendra Nayak wrote:
> On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote:
>>
>> All the unnessary functions in omap-phy-internal is removed.
>> These functionality are now handled by omap-usb2 phy driver.
>>
>> Cc: Felipe Balbi
>> Signed-off-by
Hi,
On Tue, Jul 10, 2012 at 11:57 AM, Rajendra Nayak wrote:
> On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote:
>>
>> Add usb otg data node in omap4/omap3 device tree file. Also update
>> the node with board specific setting in omapx-.dts file.
>>
>> Signed-off-by: Kishon Vijay Abr
Hi,
> Documentation/devicetree/bindings/usb/omap-usb.txt | 34
> -
> drivers/usb/musb/omap2430.c| 52
>
[...]
> + of_property_read_u32(np, "mode", (u32 *)&pdata->mode);
> + of_property_read_u32(np, "interface_type"
On Tuesday 10 July 2012 12:18 PM, ABRAHAM, KISHON VIJAY wrote:
Hi,
On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu
wrote:
+
+#ifdef CONFIG_PM
Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM?
Why? I think we should have CONFIG_PM_SLEEP only when we have
*suspend*, *resume* hoo
> Hi,
>
> On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu
> wrote:
> >> > +
> >> > +#ifdef CONFIG_PM
> >
> > Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM?
>
> Why? I think we should have CONFIG_PM_SLEEP only when we have
> *suspend*, *resume* hooks. But this driver has only *runt
On Tuesday 10 July 2012 12:22 PM, ABRAHAM, KISHON VIJAY wrote:
+TWL4030 USB PHY AND COMPARATOR
>> + - compatible : Should be "ti,twl4030-usb"
>> + - interrupts : The interrupt numbers to the cpu should be specified.
>> First
>> + interrupt number is the otg interrupt number that raises ID i
58 matches
Mail list logo
