[PATCH v2] musb: Fix bad call to kfree() in musb_free

2012-08-04 Thread Brian Downing
Commit 622859634a663c5e55d0e2a2cdbb55ac058d97b3 (usb: musb: drop a gigantic amount of ifdeferry) included this change: @@ -1901,11 +1844,7 @@ static void musb_free(struct musb *musb) dma_controller_destroy(c); } -#ifdef CONFIG_USB_MUSB_HDRC_HCD -

Re: USB UPS slows boot

2012-08-04 Thread James
On 08/04/12 13:21, Alan Stern wrote: > On Sat, 4 Aug 2012, James wrote: > >> Maybe the pause is not USB. >> [2.243856] usb 4-1: Manufacturer: Logitech >> [ 62.739097] cx25840 6-0044: unable to open firmware >> v4l-cx23885-avcore-01.fw > > Yeah, that looks like the problem. The firmware fo

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Alan Stern
On Sat, 4 Aug 2012, Rafael J. Wysocki wrote: > On Saturday, August 04, 2012, Alan Stern wrote: > > On Sat, 4 Aug 2012, Rafael J. Wysocki wrote: > > > > > > That wasn't what he meant. What if the code needs to run in the _same_ > > > > context as the caller? For example, with a spinlock held. >

Re: [PATCH] musb: Fix bad call to kfree() in musb_free

2012-08-04 Thread Sergei Shtylyov
Hello. On 04-08-2012 17:34, Brian Downing wrote: Commit 622859634a663c5e55d0e2a2cdbb55ac058d97b3 removed a bunch of Please also specify the summary of that commit in parens. #ifdefs from the musb code, including this change: @@ -1901,11 +1844,7 @@ static void musb_free(struct mus

Re: Does larger than 32 bits report size is supported at HID?

2012-08-04 Thread Marek Vasut
Dear Chen Peter-B29397, > > On Thu, Mar 10, 2011 at 01:34:38AM +, Chen Peter-B29397 wrote: > > > Hi all, > > > > > > I am sorry I can't find linux-hid and linux-input ML, so I try to get a > > > > help here. > > > > > I have a device which follows usb-hid protocol (can be communicated by >

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Rafael J. Wysocki
On Saturday, August 04, 2012, Alan Stern wrote: > On Sat, 4 Aug 2012, Rafael J. Wysocki wrote: > > > > That wasn't what he meant. What if the code needs to run in the _same_ > > > context as the caller? For example, with a spinlock held. > > > > I see. I think it wouldn't be unreasonable to re

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Rafael J. Wysocki
On Saturday, August 04, 2012, Alan Stern wrote: > On Sat, 4 Aug 2012, Rafael J. Wysocki wrote: > > > > What happens if a system sleep begins after > > > pm_runtime_async_resume_and_call() but before the runtime resume? When > > > the system wakes up, the device will be back at full power withou

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Alan Stern
On Sat, 4 Aug 2012, Rafael J. Wysocki wrote: > > That wasn't what he meant. What if the code needs to run in the _same_ > > context as the caller? For example, with a spinlock held. > > I see. I think it wouldn't be unreasonable to require that func should take > all of the necessary locks by

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Rafael J. Wysocki
On Saturday, August 04, 2012, Alan Stern wrote: > On Sat, 4 Aug 2012, Rafael J. Wysocki wrote: > > > On Friday, August 03, 2012, Ming Lei wrote: > > > On Fri, Aug 3, 2012 at 10:20 AM, Alan Stern > > > wrote: > > > > On Thu, 2 Aug 2012, Rafael J. Wysocki wrote: > > > > > > > Hmmm. You'd probabl

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Alan Stern
On Sat, 4 Aug 2012, Rafael J. Wysocki wrote: > > What happens if a system sleep begins after > > pm_runtime_async_resume_and_call() but before the runtime resume? When > > the system wakes up, the device will be back at full power without ever > > executing a runtime PM call. Then how will fu

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Alan Stern
On Sat, 4 Aug 2012, Rafael J. Wysocki wrote: > On Friday, August 03, 2012, Ming Lei wrote: > > On Fri, Aug 3, 2012 at 10:20 AM, Alan Stern > > wrote: > > > On Thu, 2 Aug 2012, Rafael J. Wysocki wrote: > > > > > Hmmm. You'd probably want a version that does a "get" at the same > > > time. I su

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Rafael J. Wysocki
On Friday, August 03, 2012, Alan Stern wrote: > On Thu, 2 Aug 2012, Alan Stern wrote: > > > On Thu, 2 Aug 2012, Rafael J. Wysocki wrote: > > > > > > I don't know about that -- the logic involved in doing the processing > > > > within the resume callback isn't terribly complicated. At least, not

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Rafael J. Wysocki
On Friday, August 03, 2012, Ming Lei wrote: > On Fri, Aug 3, 2012 at 10:20 AM, Alan Stern wrote: > > On Thu, 2 Aug 2012, Rafael J. Wysocki wrote: > > > Hmmm. You'd probably want a version that does a "get" at the same > > time. I suppose you would call func directly if the device was already >

Re: Do we need asynchronous pm_runtime_get()? (was: Re: bisected regression ...)

2012-08-04 Thread Rafael J. Wysocki
On Friday, August 03, 2012, Alan Stern wrote: > On Thu, 2 Aug 2012, Rafael J. Wysocki wrote: > > > > I don't know about that -- the logic involved in doing the processing > > > within the resume callback isn't terribly complicated. At least, not > > > much more complicated than the logic involv

Re: USB UPS slows boot

2012-08-04 Thread Alan Stern
On Sat, 4 Aug 2012, James wrote: > Maybe the pause is not USB. > [2.243856] usb 4-1: Manufacturer: Logitech > [ 62.739097] cx25840 6-0044: unable to open firmware > v4l-cx23885-avcore-01.fw Yeah, that looks like the problem. The firmware for the digital video board isn't available. Ther

Re: USB UPS slows boot

2012-08-04 Thread James
On 08/01/12 13:14, Alan Stern wrote: > On Wed, 1 Aug 2012 bjloc...@lockie.ca wrote: > >>> That's progress. Have you checked to see whether ehci-hcd is loaded >>> before or after ohci-hcd? >> >> Is there a way to tell besides watching the screen (which scrolls too >> fast) during boot? > > Run th

[PATCH] musb: Fix bad call to kfree() in musb_free

2012-08-04 Thread Brian Downing
Commit 622859634a663c5e55d0e2a2cdbb55ac058d97b3 removed a bunch of #ifdefs from the musb code, including this change: @@ -1901,11 +1844,7 @@ static void musb_free(struct musb *musb) dma_controller_destroy(c); } -#ifdef CONFIG_USB_MUSB_HDRC_HCD - u