Re: Kernel oops on usbhid_submit_report (updates)

2012-08-17 Thread Alan Stern
On Sat, 18 Aug 2012, Amit wrote: > Amit writes: > > > I am getting the following kernel oops (http://paste.debian.net/182812/) > > sporadically. Kernel version is 3.2.14. > > > > Code basically does the following: > > > > ioctl(fd,HIDIOCSUSAGES, &ref_multi_u); > > ioctl(fd,HIDIOCSREPORT, &re

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Ming Lei
On Fri, Aug 17, 2012 at 10:42 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 17, 2012 at 10:38:16AM -0400, Alan Stern wrote: >> On Fri, 17 Aug 2012, Ming Lei wrote: >> >> > But, if HOTPLUG is not enabled, should device_add() trigger driver probe >> > further after kernel init is completed? Or even

Re: Kernel oops on usbhid_submit_report (updates)

2012-08-17 Thread Amit
Amit writes: > I am getting the following kernel oops (http://paste.debian.net/182812/) > sporadically. Kernel version is 3.2.14. > > Code basically does the following: > > ioctl(fd,HIDIOCSUSAGES, &ref_multi_u); > ioctl(fd,HIDIOCSREPORT, &rep_info_u); > > Here are some notes: > > 1. Happen

Re: add ZTE EV_DO to a proper driver

2012-08-17 Thread Greg KH
On Thu, Jul 26, 2012 at 05:51:59PM +0300, nirinA raseliarison wrote: > hi Greg, > > Le Thu, 26 Jul 2012 01:04:08 +0300, Greg KH a > écrit: > > >On Wed, Jul 25, 2012 at 12:51:34PM -0700, nirinA raseliarison wrote: > >>hello there, > >>i have an usb modem zte ev-do that i used with kernel from > >

Re: [PATCH] CDC ACM: Fix NULL pointer dereference

2012-08-17 Thread Sven Schnelle
Greg KH writes: > On Fri, Aug 17, 2012 at 08:07:11PM +0200, Sven Schnelle wrote: >> If a device specifies zero endpoints in its interface descriptor, >> the kernel oops's with the following output: >> >> Aug 17 19:32:37 deprecated kernel: [ 103.785466] cdc_acm >> 1-5:1.0:usb_probe_interface >>

Re: [PATCH] CDC ACM: Fix NULL pointer dereference

2012-08-17 Thread Sven Schnelle
Greg KH writes: > On Fri, Aug 17, 2012 at 09:43:43PM +0200, Sven Schnelle wrote: >> Greg KH writes: >> >> > On Fri, Aug 17, 2012 at 08:07:11PM +0200, Sven Schnelle wrote: >> >> If a device specifies zero endpoints in its interface descriptor, >> >> the kernel oops's with the following output: >

Re: [PATCH] CDC ACM: Fix NULL pointer dereference

2012-08-17 Thread Greg KH
On Fri, Aug 17, 2012 at 09:43:43PM +0200, Sven Schnelle wrote: > Greg KH writes: > > > On Fri, Aug 17, 2012 at 08:07:11PM +0200, Sven Schnelle wrote: > >> If a device specifies zero endpoints in its interface descriptor, > >> the kernel oops's with the following output: > >> > >> Aug 17 19:32:37

Re: [PATCH] CDC ACM: Fix NULL pointer dereference

2012-08-17 Thread Greg KH
On Fri, Aug 17, 2012 at 08:07:11PM +0200, Sven Schnelle wrote: > If a device specifies zero endpoints in its interface descriptor, > the kernel oops's with the following output: > > Aug 17 19:32:37 deprecated kernel: [ 103.785466] cdc_acm > 1-5:1.0:usb_probe_interface > Aug 17 19:32:37 deprecate

[PATCH] CDC ACM: Fix NULL pointer dereference

2012-08-17 Thread Sven Schnelle
If a device specifies zero endpoints in its interface descriptor, the kernel oops's with the following output: Aug 17 19:32:37 deprecated kernel: [ 103.785466] cdc_acm 1-5:1.0:usb_probe_interface Aug 17 19:32:37 deprecated kernel: [ 103.785474] cdc_acm 1-5:1.0:usb_probe_interface - got id Aug

[GIT PATCH] USB fixes for 3.6-rc3

2012-08-17 Thread Greg KH
The following changes since commit 0d7614f09c1ebdbaa1599a5aba7593f147bf96ee: Linux 3.6-rc1 (2012-08-02 16:38:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.6-rc3 for you to fetch changes up to 731879f8e3d4c612204621

Re: [PATCH 2/9] scripts/modpost: add a exception for USB gadget drivers

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/15/2012 10:14 PM, Sam Ravnborg wrote: Could you use the __ref / __refdata annotation? This would be much cleaner than this hack in modpost. Hmmm. $ git grep " __init " drivers/usb/gadget/ | grep -vE '[_-]udc\.c|net22..\.c|udc-core\.c|dummy_hcd' | wc -l 71 That is the number of annotat

Re: [PATCH 2/3] usb: dwc3: gadget: implement ->reset notification

2012-08-17 Thread Alan Stern
On Thu, 16 Aug 2012, Felipe Balbi wrote: > After introducing the new ->reset method on > struct usb_gadget_driver, UDC drivers are > required to implement proper handling for it. > > This patch adds proper ->reset handling for > dwc3 driver. After working on the equivalent change for net2280, I

Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-17 Thread Roland Stigge
Hi! On 08/17/2012 03:14 PM, Sebastian Andrzej Siewior wrote: > On 08/16/2012 11:31 AM, Roland Stigge wrote: >> USB_ISP1301 already depends on I2C. >> >> Maybe we should rather let USB_LPC32XX "depends on USB_ISP1301" instead >> of "select USB_ISP1301"? > > And your OHCI select has the same proble

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Greg Kroah-Hartman
On Fri, Aug 17, 2012 at 10:38:16AM -0400, Alan Stern wrote: > On Fri, 17 Aug 2012, Ming Lei wrote: > > > But, if HOTPLUG is not enabled, should device_add() trigger driver probe > > further after kernel init is completed? Or even devices should be allowed > > to add into system? > > Indeed, doe

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Alan Stern
On Fri, 17 Aug 2012, Ming Lei wrote: > But, if HOTPLUG is not enabled, should device_add() trigger driver probe > further after kernel init is completed? Or even devices should be allowed > to add into system? Indeed, does it make any sense to have USB support at all if HOTPLUG isn't enabled?

Re: disconnect and uas_work_list

2012-08-17 Thread Sebastian Andrzej Siewior
On Fri, Aug 17, 2012 at 03:41:33PM +0200, Gerd Hoffmann wrote: > I'm testing uas in a virtual machine, qemu 1.2 (to be released soon) > features uas emulation support. Only usb 2.0 for now, qemu usb > emulation can't handle streams and other 3.0 stuff. Yet. Ah good to know. So there is an altern

Re: Question regarding ClearTTBuffer request on closing of USB serial device

2012-08-17 Thread Alan Stern
On Fri, 17 Aug 2012, Antti Pulakka wrote: > Hi, > > I have been analyzing USB traffic with USB 2.0 protocol analyzer. In > my test setup I have a Full-Speed USB serial device connected to > High-Speed hub which is connected to Linux host. The protocol analyzer > is connected between the Linux hos

Re: Potential fsg->state problem at file_storage.c

2012-08-17 Thread Alan Stern
On Fri, 17 Aug 2012, Peter Chen wrote: > Alan, will you submit a patch to add reset callback for file_storage? > If not, I can help send a patch. I will submit a patch, probably on Monday. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a messag

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Greg Kroah-Hartman
On Fri, Aug 17, 2012 at 08:16:15PM +0800, Ming Lei wrote: > On Fri, Aug 17, 2012 at 6:24 PM, Fengguang Wu wrote: > > On Fri, Aug 17, 2012 at 05:27:08PM +0800, Fengguang Wu wrote: > >> Hi Bjørn, > >> > >> > -static const struct usb_device_id id_table[] __devinitconst = { > >> > +static const struct

Re: disconnect and uas_work_list

2012-08-17 Thread Gerd Hoffmann
On 08/17/12 15:01, Sebastian Andrzej Siewior wrote: > On Fri, Aug 17, 2012 at 02:13:40PM +0200, Oliver Neukum wrote: >>> I just noticed some of my patches here got reverted. Do you have any >>> hardware >>> or did you just stumble over it? I have just my target UAS gadget… >> >> No hardware. Do

Re: disconnect and uas_work_list

2012-08-17 Thread Sebastian Andrzej Siewior
On Fri, Aug 17, 2012 at 03:05:15PM +0200, Oliver Neukum wrote: > On Friday 17 August 2012 15:01:16 Sebastian Andrzej Siewior wrote: > > > It is possible that you get -ENOMEM while a command is already being > > > executed. The worst case is probably that you got a command to the device > > > and y

Re: [PATCH 8/9] usb/gadget: Add I2C dependency for USB_LPC32XX

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/16/2012 11:31 AM, Roland Stigge wrote: USB_ISP1301 already depends on I2C. Maybe we should rather let USB_LPC32XX "depends on USB_ISP1301" instead of "select USB_ISP1301"? And your OHCI select has the same problem. So we make both things depend on the transceiver instead of selecting it

Re: disconnect and uas_work_list

2012-08-17 Thread Oliver Neukum
On Friday 17 August 2012 15:01:16 Sebastian Andrzej Siewior wrote: > > It is possible that you get -ENOMEM while a command is already being > > executed. The worst case is probably that you got a command to the device > > and you need to do autosense, but you get -ENOMEM. > > Looking at the code,

Re: disconnect and uas_work_list

2012-08-17 Thread Sebastian Andrzej Siewior
On Fri, Aug 17, 2012 at 02:13:40PM +0200, Oliver Neukum wrote: > > I just noticed some of my patches here got reverted. Do you have any > > hardware > > or did you just stumble over it? I have just my target UAS gadget… > > No hardware. Do you have suggestions where to get hardware? No. I've b

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Ming Lei
On Fri, Aug 17, 2012 at 6:24 PM, Fengguang Wu wrote: > On Fri, Aug 17, 2012 at 05:27:08PM +0800, Fengguang Wu wrote: >> Hi Bjørn, >> >> > -static const struct usb_device_id id_table[] __devinitconst = { >> > +static const struct usb_device_id id_table[] = { >> >> Good catch! It magically fixed the

Re: disconnect and uas_work_list

2012-08-17 Thread Oliver Neukum
On Friday 17 August 2012 13:11:30 Sebastian Andrzej Siewior wrote: > On Thu, Aug 16, 2012 at 04:23:15PM +0200, Oliver Neukum wrote: > > > > > No, you are right. If the command EP was closed and the URB submission > > > then it > > > will retry over and over again. > > > > Well, what remedy woul

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/17/2012 01:32 PM, Roland Stigge wrote: How about the following: Below, I show how the initialization of the current controller is done (statically). Removing this struct initialization completely would make the code much uglier, introducing many individual assignments. I said what I had t

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Roland Stigge
On 08/17/2012 01:02 PM, Felipe Balbi wrote: > On Fri, Aug 17, 2012 at 01:01:44PM +0200, Sebastian Andrzej Siewior wrote: >> On 08/17/2012 12:51 PM, Felipe Balbi wrote: Sounds reasonable? >>> >>> no it doesn't. Please remove that static global. Sorry but one of the >>> goals with udc_start/udc_

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/17/2012 01:02 PM, Felipe Balbi wrote: On Fri, Aug 17, 2012 at 01:01:44PM +0200, Sebastian Andrzej Siewior wrote: On 08/17/2012 12:51 PM, Felipe Balbi wrote: Sounds reasonable? no it doesn't. Please remove that static global. Sorry but one of the goals with udc_start/udc_stop was really

Re: disconnect and uas_work_list

2012-08-17 Thread Sebastian Andrzej Siewior
On Thu, Aug 16, 2012 at 04:23:15PM +0200, Oliver Neukum wrote: > > > No, you are right. If the command EP was closed and the URB submission then > > it > > will retry over and over again. > > Well, what remedy would you suggest? I just noticed some of my patches here got reverted. Do you have

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Felipe Balbi
On Fri, Aug 17, 2012 at 01:01:44PM +0200, Sebastian Andrzej Siewior wrote: > On 08/17/2012 12:51 PM, Felipe Balbi wrote: > >>Sounds reasonable? > > > >no it doesn't. Please remove that static global. Sorry but one of the > >goals with udc_start/udc_stop was really to get rid of all those > >nonsens

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/17/2012 12:51 PM, Felipe Balbi wrote: Sounds reasonable? no it doesn't. Please remove that static global. Sorry but one of the goals with udc_start/udc_stop was really to get rid of all those nonsensical static globals. I wouldn't insist on it. If you look at pxa25x, " static struct pxa

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Felipe Balbi
On Fri, Aug 17, 2012 at 11:42:15AM +0200, Sebastian Andrzej Siewior wrote: > On 08/17/2012 11:10 AM, Roland Stigge wrote: > >Also, since this device is a single controller in the LPC32xx SoC, I > >would keep it until some other silicon uses several of this IP core > >(which I doubt), at which point

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Felipe Balbi
On Fri, Aug 17, 2012 at 11:10:19AM +0200, Roland Stigge wrote: > Hi, > > On 08/16/2012 06:16 PM, Roland Stigge wrote: > > On 08/16/2012 06:05 PM, Sebastian Andrzej Siewior wrote: > >>> --- linux-2.6.orig/drivers/usb/gadget/lpc32xx_udc.c > >>> +++ linux-2.6/drivers/usb/gadget/lpc32xx_udc.c > >>> @@

Re: [RFC 0/2] USB gadget - configfs

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/17/2012 12:30 PM, Andrzej Pietrasiewicz wrote: There is a separation between "setting myself up" and "seeing that a host wants to talk to me". You are a woman. And if you not done yet done you ignore the host until you are ready. Can also be ready before the host wants to talk to you. I

RE: [RFC 0/2] USB gadget - configfs

2012-08-17 Thread Andrzej Pietrasiewicz
Hello Sebastian, Hello Joel, On Friday, August 17, 2012 11:22 AM Sebastian Andrzej Siewior wrote: > There is a separation between "setting myself up" and "seeing that a host > wants to talk to me". You are a woman. And if you not done yet done you ignore > the host until you are ready. Can also

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Fengguang Wu
On Fri, Aug 17, 2012 at 05:27:08PM +0800, Fengguang Wu wrote: > Hi Bjørn, > > > -static const struct usb_device_id id_table[] __devinitconst = { > > +static const struct usb_device_id id_table[] = { > > Good catch! It magically fixed the oops. So that id_table was > freed sometime with __devinitc

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/17/2012 11:10 AM, Roland Stigge wrote: Also, since this device is a single controller in the LPC32xx SoC, I would keep it until some other silicon uses several of this IP core (which I doubt), at which point we would probably still keep the (global static) controller and memcpy it to a dyna

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Fengguang Wu
Hi Bjørn, > -static const struct usb_device_id id_table[] __devinitconst = { > +static const struct usb_device_id id_table[] = { Good catch! It magically fixed the oops. So that id_table was freed sometime with __devinitconst? There are some more "usb_device_id .* __devinitconst" users in the sy

Re: [RFC 0/2] USB gadget - configfs

2012-08-17 Thread Sebastian Andrzej Siewior
On 08/17/2012 03:46 AM, Joel Becker wrote: The configuration has to remain unchanged until the "connect" attribute is changed (i.e. unconnected). That means the gadget can only be reconfigured once it is not active. Yes, that's my understanding of the driver code. What I'm trying to un

Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface

2012-08-17 Thread Roland Stigge
Hi, On 08/16/2012 06:16 PM, Roland Stigge wrote: > On 08/16/2012 06:05 PM, Sebastian Andrzej Siewior wrote: >>> --- linux-2.6.orig/drivers/usb/gadget/lpc32xx_udc.c >>> +++ linux-2.6/drivers/usb/gadget/lpc32xx_udc.c >>> @@ -2987,14 +2986,14 @@ static irqreturn_t lpc32xx_usb_vbus_irq( >>> retu

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Bjørn Mork
Bjørn Mork writes: > Fengguang Wu writes: > >> @@ -779,6 +780,7 @@ static int usb_device_match(struct devic >> intf = to_usb_interface(dev); >> usb_drv = to_usb_driver(drv); >> >> + pr_info("%s: device %s, driver %s \n", __func__, >> dev_name(dev), drv->

[PATCH 2/2] usb: convert USB_QUIRK_RESET_MORPHS to USB_QUIRK_RESET

2012-08-17 Thread Lan Tianyu
Since the attribute avoid_reset_quirk is work for all devices including those devices that can't morph, convert USB_QUIRK_RESET_MORPHS to USB_QUIRK_RESET. Signed-off-by: Lan Tianyu --- drivers/usb/core/quirks.c |2 +- drivers/usb/core/sysfs.c|6 +++--- drivers/usb/storage/t

[PATCH 1/2] usb/endpoint: Set release callback in the struct device_type instead of in the device itself directly

2012-08-17 Thread Lan Tianyu
For following the way the rest of the usb core does, this patch is to change the place of setting release callback. Signed-off-by: Lan Tianyu --- drivers/usb/core/endpoint.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/core/endpoint.c b/drivers/usb

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Bjørn Mork
Fengguang Wu writes: > @@ -779,6 +780,7 @@ static int usb_device_match(struct devic > intf = to_usb_interface(dev); > usb_drv = to_usb_driver(drv); > > + pr_info("%s: device %s, driver %s \n", __func__, > dev_name(dev), drv->name); > id =

Re: new device for qmi_wwan and option Vodafone/ZTE K5006Z

2012-08-17 Thread Thomas Schäfer
Am 17.08.2012 08:38, schrieb Marcel Holtmann: Hi Thomas, which German operator is giving you IPv6 over LTE? No one. I do test with the new qmi-wwan-driver: IPv4 at 2G/3G/4G (regular contract t-mobile) IPv6 at 2G/3G in a test environment by vodafone The option-driver(ppp) works for me only in

Re: disconnect and uas_work_list

2012-08-17 Thread Oliver Neukum
On Thursday 16 August 2012 16:03:36 Sebastian Andrzej Siewior wrote: > On Tue, Aug 14, 2012 at 05:48:56PM +0200, Oliver Neukum wrote: > > going through uas it looks to me like there is a race by which > > uas_do_work() can walk uas_work_list and do IO to a device > > after it has been removed. This

Question regarding ClearTTBuffer request on closing of USB serial device

2012-08-17 Thread Antti Pulakka
Hi, I have been analyzing USB traffic with USB 2.0 protocol analyzer. In my test setup I have a Full-Speed USB serial device connected to High-Speed hub which is connected to Linux host. The protocol analyzer is connected between the Linux host and the High-Speed hub. The test case which I have be