[PATCH] usb/gadget: remove usb_gadget_controller_number()

2012-09-10 Thread Sebastian Andrzej Siewior
The bcdDevice field is defined as |Device release number in binary-coded decimal in the USB 2.0 specification. We use this field to distinguish the UDCs from each other. In theory this could be used on the host side to apply certain quirks if the special UDC in combination with this gadget is

[PATCH] tools/usb: remove last USBFS user

2012-09-10 Thread Sebastian Andrzej Siewior
In commit fb28d58b (USB: remove CONFIG_USB_DEVICEFS) USBFS got removed. Since it is gone we can stop using it in testusb and try udev nodes right away. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- tools/usb/testusb.c | 25 + 1 file changed, 1

usb: dwc3: query: dma sg implementation for isoc

2012-09-10 Thread Pratyush Anand
Hi Felip, I am not sure what was the original intention to use sg. But I wanted to use this to resolve one of the issue with my application related to isoc endpoint. So, you can correct me , if I am not in-lined with uses philosophy. I have a scenario, where I have scattered data to be

Re: usbcore / Linux 2.6.+ / USB IO Board 04d8:000a

2012-09-10 Thread Bjørn Mork
Xiaofan Chen xiaof...@gmail.com writes: On Sun, Sep 9, 2012 at 6:04 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 8 Sep 2012, Florian Wöhrl wrote: I first thought it might be the change in the driver - because in the past 04d8:000a was handled by cdc_acm, now the modalias shows

Re: [RFC] How to handle delays in isochronous transfers?

2012-09-10 Thread Peter Chen
If the feedback is supported, the device will know host sends data slowly, it will give speed up feedback information after it receives packet 5 or other packets depends on its interval at descriptor. At this information, it can tell the host to increase the packet size, then the

Re: usbcore / Linux 2.6.+ / USB IO Board 04d8:000a

2012-09-10 Thread Oliver Neukum
On Monday 10 September 2012 10:11:15 Bjørn Mork wrote: And I do not think ftdi_sio should be loaded for this device since it is really not an FTDI device after all. 04d8:000a is a CDC-ACM demo device from Microchip's USB Firmware Framework. Yes, that is cleary an error which should be

Re: usbcore / Linux 2.6.+ / USB IO Board 04d8:000a

2012-09-10 Thread Oliver Neukum
On Monday 10 September 2012 10:51:32 Bjørn Mork wrote: Oliver Neukum oneu...@suse.de writes: On Monday 10 September 2012 10:11:15 Bjørn Mork wrote: And I do not think ftdi_sio should be loaded for this device since it is really not an FTDI device after all. 04d8:000a is a CDC-ACM

Re: [RFC] How to handle delays in isochronous transfers?

2012-09-10 Thread Clemens Ladisch
Peter Chen wrote: Essentially, the stream is restarted with known timing. So, if big delay occurs (like 10ms), you would like the controller layer tells you that, then, you drop 10ms packet? I want to be able to know when the next submitted packet will be transmitted. Regards, Clemens -- To

Re: [PATCH] usb/gadget: remove usb_gadget_controller_number()

2012-09-10 Thread Michal Nazarewicz
On Mon, Sep 10 2012, Sebastian Andrzej Siewior wrote: The bcdDevice field is defined as |Device release number in binary-coded decimal in the USB 2.0 specification. We use this field to distinguish the UDCs from each other. In theory this could be used on the host side to apply certain quirks

Re: Wrong SSD sector count with current F17 (right with live)

2012-09-10 Thread Michael J Gruber
On Fri, Sep 7, 2012 at 5:48 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 7 Sep 2012, Michael J Gruber wrote: On Fri, Sep 7, 2012 at 11:30 AM, Michael J Gruber michaeljgruber+fedora-li...@gmail.com wrote: [Originally posted to fedora general, where Alan Cox suspected a usb issue

[PATCH] USB: ftdi_sio: do not claim CDC ACM function

2012-09-10 Thread Bjørn Mork
The Microchip vid:pid 04d8:000a is used for their CDC ACM demo firmware application. This is a device with a single function conforming to the CDC ACM specification and with the intention of demonstrating CDC ACM class firmware and driver interaction. The demo is used on a number of development

Re: usbcore / Linux 2.6.+ / USB IO Board 04d8:000a

2012-09-10 Thread Florian Wöhrl
Am 10.09.2012 04:55, schrieb Oliver Neukum: On Monday 10 September 2012 10:51:32 Bjørn Mork wrote: Oliver Neukum oneu...@suse.de writes: On Monday 10 September 2012 10:11:15 Bjørn Mork wrote: And I do not think ftdi_sio should be loaded for this device since it is really not an FTDI device

Re: [PATCH 14/29] usb/gadget: move USB_BUFSIZ into global composite.h

2012-09-10 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 08:11:13PM +0200, Sebastian Andrzej Siewior wrote: This patch moves USB_BUFSIZ into global header file as USB_COMP_EP0_BUFSIZ. There is currently only one user (f_sourcesink) besides composite which need it. Ideally f_sourcesink would have its own ep0 buffer. Lets keep

Re: usbcore / Linux 2.6.+ / USB IO Board 04d8:000a

2012-09-10 Thread Oliver Neukum
On Monday 10 September 2012 08:37:55 Florian Wöhrl wrote: Am 10.09.2012 04:55, schrieb Oliver Neukum: On Monday 10 September 2012 10:51:32 Bjørn Mork wrote: Oliver Neukum oneu...@suse.de writes: On Monday 10 September 2012 10:11:15 Bjørn Mork wrote: And I do not think ftdi_sio should be

Re: usbcore / Linux 2.6.+ / USB IO Board 04d8:000a

2012-09-10 Thread Xiaofan Chen
On Mon, Sep 10, 2012 at 8:37 PM, Florian Wöhrl f...@woehrl.biz wrote: it seems like cdc_acm was altered, too - am I right? modinfo doesn't mention 04d8:000A. It just tells 04d8:000B. Did you make that patch? That is bad. 1634/* Support for Droids MuIn LCD */ 1635{

[PATCH 14/29 rebased] usb/gadget: move USB_BUFSIZ into global composite.h

2012-09-10 Thread Sebastian Andrzej Siewior
This patch moves USB_BUFSIZ into global header file as USB_COMP_EP0_BUFSIZ. There is currently only one user (f_sourcesink) besides composite which need it. Ideally f_sourcesink would have its own ep0 buffer. Lets keep it that way it was for now. Acked-by: Michal Nazarewicz min...@mina86.com

Re: usb: dwc3: query: dma sg implementation for isoc

2012-09-10 Thread Felipe Balbi
Hi, On Mon, Sep 10, 2012 at 12:50:47PM +0530, Pratyush Anand wrote: Hi Felip, I am not sure what was the original intention to use sg. But I wanted to use this to resolve one of the issue with my application related to isoc endpoint. So, you can correct me , if I am not in-lined with uses

[PATCH 15/29 rebased] usb/gadget: remove bufsiz from struct usb_composite_dev

2012-09-10 Thread Sebastian Andrzej Siewior
there is no read user of bufsiz, its content is available via USB_COMP_EP0_BUFSIZ. Remove it. Acked-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/composite.c |1 - include/linux/usb/composite.h |2 -- 2

[PATCH 23/29 rebased] usb/gadget: push iSerialNumber into gadgets

2012-09-10 Thread Sebastian Andrzej Siewior
This patch pushes the iSerialNumber module argument from composite into each gadget. Once the user uses the module paramter, the string is overwritten with the final value. Acked-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de ---

[PATCH 24/29 rebased] usb/gadget: push iManufacturer into gadgets

2012-09-10 Thread Sebastian Andrzej Siewior
This patch pushes the iManufacturer module argument from composite into each gadget. Once the user uses the module paramter, the string is overwritten with the final value. Acked-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de ---

[PATCH 25/29 rebased] usb/gadget: push iProduct into gadgets

2012-09-10 Thread Sebastian Andrzej Siewior
This patch pushes the iProduct module argument from composite into each gadget. Acked-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/composite.c | 21 +++-- include/linux/usb/composite.h |6

[PATCH 26/29 rebased] usb/gadget: remove string override from struct usb_composite_driver

2012-09-10 Thread Sebastian Andrzej Siewior
The struct usb_composite_driver members iProduct, iSerial and iManufacturer can be entered directly via the string array. There is no need for them to appear here. Acked-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de ---

[PATCH 27/29 rebased] usb/gadget: Provide a default implementation of default manufacturer string

2012-09-10 Thread Sebastian Andrzej Siewior
Some gadgets provide custom entry here. Some may override it with an etntry that is also created by composite if there was no value sumbitted at all. This patch removes all custom manufacturer strings which are the same as these which are created by composite. Then it moves the creation of the

Re: [PATCH v2 1/2] usb: otg: mxs-phy: Fix mx23 operation

2012-09-10 Thread Fabio Estevam
Hi Felipe, On Thu, Aug 30, 2012 at 6:26 PM, Fabio Estevam feste...@gmail.com wrote: From: Mike Thompson mpthomp...@gmail.com Currently mx23 fails to enumerate a USB device: [ 1.30] hub 1-0:1.0: unable to enumerate USB device on port 1 [ 1.52] hub 1-0:1.0: unable to enumerate USB

Re: [PATCH v3] usb: phy: add R-Car USB phy driver

2012-09-10 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 07:22:59PM -0700, Kuninori Morimoto wrote: This patch adds Renesas R-Car USB phy driver. It supports R8A7779 chip at this point. R-Car has some USB controllers, but has only one phy-initializer. So, this driver is counting users. Signed-off-by: Kuninori Morimoto

Re: usb: dwc3: query: dma sg implementation for isoc

2012-09-10 Thread Felipe Balbi
On Mon, Sep 10, 2012 at 06:45:06PM +0530, Pratyush Anand wrote: Hi Felip, Thanks for the clarifications. On 9/10/2012 6:29 PM, Felipe Balbi wrote: If my understanding is correct, then I might need to modify dwc3 driver a bit. only first TRB of the service interval should have TRBCTL as

Re: [PATCH] usb: gadget: Conform with checkpatch -3 warnings, 1 error

2012-09-10 Thread Felipe Balbi
On Sun, Sep 09, 2012 at 10:50:35AM +1000, Ben Minerds wrote: Removed 3 checkpatch.sh warnings and 1 error in drivers/usb/gadget/serial.c. -sizeof brackets x2 -remove initialise to 0 -pr_warning to pr_warn Signed-off-by: Ben Minerds puzzled...@gmail.com please rebase this on my gadget

[PATCH 1/2] usb: redefine DeviceRemovable and wHubDelay as _le16

2012-09-10 Thread Lan Tianyu
DeviceRemovalbe and wHubDelay for usb3.0 hub are little-endian and so define them as _le16. Signed-off-by: Lan Tianyu tianyu@intel.com --- include/linux/usb/ch11.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/usb/ch11.h b/include/linux/usb/ch11.h

[PATCH 2/2] usb: add little-endian transform for DeviceRemovable of usb3.0 hub

2012-09-10 Thread Lan Tianyu
Signed-by-off: Lan Tianyutianyu@intel.com Signed-off-by: Lan Tianyu tianyu@intel.com --- drivers/usb/core/hub.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 3def91e..aa45e43 100644 ---

Re: usb: dwc3: query: dma sg implementation for isoc

2012-09-10 Thread Pratyush Anand
On 9/10/2012 6:49 PM, Felipe Balbi wrote: aaa true:-) I had forgotten about that extra bit of information when using chained TRBs :-s My bad. Please send a patch. Sure, will send. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH] usb: renesas_usbhs: convert to devm_xxx()

2012-09-10 Thread Felipe Balbi
On Mon, Sep 10, 2012 at 02:11:32AM -0700, Kuninori Morimoto wrote: Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/usb/renesas_usbhs/common.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git

Re: [GIT PULL] USB fixes for v3.6-rc4

2012-09-10 Thread Felipe Balbi
On Fri, Sep 07, 2012 at 08:28:29AM -0700, Greg KH wrote: On Thu, Sep 06, 2012 at 08:05:01PM +0300, Felipe Balbi wrote: Hi Greg, Here's my previous pull request now rebased on top of v3.6-rc4. Sorry for the inconvenience my never rebase methodology :-) Note that I'm rebased on top of

Re: [balbi-usb:gadget 58/62] drivers/usb/gadget/ether.c:113:1: error: expected ')' before '.' token

2012-09-10 Thread Sebastian Andrzej Siewior
On 09/10/2012 03:54 PM, Fengguang Wu wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget head: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f commit: 721e2e91945bc2520d57d795dfe1b502ecec567c [58/62] usb: gadget: libcomposite: move composite.c into libcomposite config:

re: usb: gadget: dummy_hcd: add support for USB_DT_BOS on rh

2012-09-10 Thread Dan Carpenter
Hello Sebastian Andrzej Siewior, The patch 3b9c1c5ba7a95: usb: gadget: dummy_hcd: add support for USB_DT_BOS on rh from Oct 19, 2012, leads to the following warning: drivers/usb/gadget/dummy_hcd.c:2038 dummy_hub_control() error: memcpy() 'buf' too small (15 vs 16) 2031 case

Re: [balbi-usb:gadget 58/62] drivers/usb/gadget/ether.c:113:1: error: expected ')' before '.' token

2012-09-10 Thread Felipe Balbi
On Mon, Sep 10, 2012 at 04:06:48PM +0200, Sebastian Andrzej Siewior wrote: On 09/10/2012 03:54 PM, Fengguang Wu wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget head: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f commit: 721e2e91945bc2520d57d795dfe1b502ecec567c

Re: usb: gadget: dummy_hcd: add support for USB_DT_BOS on rh

2012-09-10 Thread Sebastian Andrzej Siewior
On Mon, Sep 10, 2012 at 05:21:39PM +0300, Dan Carpenter wrote: Hello Sebastian Andrzej Siewior, The patch 3b9c1c5ba7a95: usb: gadget: dummy_hcd: add support for USB_DT_BOS on rh from Oct 19, 2012, leads to the following warning: drivers/usb/gadget/dummy_hcd.c:2038 dummy_hub_control()

[PATCH] usb/core: Fix race condition when removing EHCI PCI devices

2012-09-10 Thread Don Zickus
A customer of ours noticed that after a bunch of hot removals of the EHCI PCI device, a panic occurs. This happened on a 2.6.32 RHEL-6 kernel, but I believe is still applicable upstream. The panic was further simplified to enabling SLUB debug poisoning and running the following command: while

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-10 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 12:56:07PM -0700, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [120906 10:23]: Hi, On Thu, Sep 06, 2012 at 08:13:03PM +0300, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote: On 9/6/2012 8:25

Re: [RFC 0/6] dwc3 isoc fixes : part 2

2012-09-10 Thread Felipe Balbi
HI, On Fri, Sep 07, 2012 at 10:03:44AM +0530, Pratyush Anand wrote: Part 1 of these fixes (http://www.spinics.net/lists/linux-usb/msg69842.html) resolves few issues around isoc transfer. It was able to handle specially those cases where application (gadget) was blocking, I mean during each

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-10 Thread Benoit Cousson
Hi Felipe, On 09/10/2012 05:58 PM, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 12:56:07PM -0700, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [120906 10:23]: Hi, On Thu, Sep 06, 2012 at 08:13:03PM +0300, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-10 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 05:27:42PM +0300, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 04:27:12PM +0200, Enrico Scholz wrote: Felipe Balbi ba...@ti.com writes: Because the fsl_udc_core driver shares one 'status_req' object for the complete ep0 control transfer, it is not

[PATCH] usb/serial gadget: shift bcd version left by 16

2012-09-10 Thread Sebastian Andrzej Siewior
Fengguang Wu reported: |drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from |constant value (2400 becomes 0) I obviously let the version number shift away. Since the version is a 16bit number it can be applied as it. Cc: fengguang...@intel.com Signed-off-by: Sebastian Andrzej

Re: [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)

2012-09-10 Thread Sebastian Andrzej Siewior
On 09/10/2012 06:40 PM, Fengguang Wu wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git master head: d9c88901337158c9f253a7de58a10b5125d61d26 commit: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f [33/36] usb: gadget: remove usb_gadget_controller_number() All sparse

[PATCH v2] usb/serial gadget: don't shift bcd version left by 16

2012-09-10 Thread Sebastian Andrzej Siewior
Fengguang Wu reported: |drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from |constant value (2400 becomes 0) I obviously let the version number shift away. Since the version is a 16bit number it can be applied as it. Cc: fengguang...@intel.com Signed-off-by: Sebastian Andrzej

RE: changing usbnet's API to better deal with cdc-ncm

2012-09-10 Thread Alexey ORISHKO
-Original Message- From: Oliver Neukum [mailto:oli...@neukum.org] Sent: Friday, September 07, 2012 8:23 PM There is a temptation to send full NTBs even with a single IP packet, But it will lead to wasted USB bandwidth and reduced ability to send real data for other functions in

Re: [PATCH v2] usb/serial gadget: don't shift bcd version left by 16

2012-09-10 Thread Sergei Shtylyov
Hello. On 09/10/2012 09:06 PM, Sebastian Andrzej Siewior wrote: Fengguang Wu reported: |drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from |constant value (2400 becomes 0) I obviously let the version number shift away. Since the version is a 16bit number it can be

Re: [BUG] - USB3 bluetooth device not working properly?

2012-09-10 Thread Sarah Sharp
On Sat, Sep 08, 2012 at 01:32:58PM +0200, Miroslav Sabljic wrote: On 09/07/2012 07:07 PM, Sarah Sharp wrote: Big improvment with the latest patches from for-usb-linus-plus-set-addr branch. My bluetooth device now works as expected, I can suspend and device isn't disconnected after a resume.

Re: [RFC PATCH V2 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-09-10 Thread Sarah Sharp
On Fri, Sep 07, 2012 at 05:33:29PM +0800, Lan Tianyu wrote: On 2012/9/5 22:39, Alan Stern wrote: On Wed, 5 Sep 2012, Lan Tianyu wrote: This is copied from xhci_usb3_hub_descriptor(). struct usb_hub_descriptor { __u8 bDescLength; __u8 bDescriptorType; __u8 bNbrPorts;

Re: [PATCH 2/4] xhci: Add Etron XHCI_TRUST_TX_LENGTH quirk.

2012-09-10 Thread Matthew Hall
Hi Sarah, I'm wondering what to try next on the issue with my card reader running over this controller? Should I try a fresher kernel or anything? Regards, Matthew. On Wed, Aug 08, 2012 at 02:37:36PM -0700, Matthew Hall wrote: I understand if it takes a while as it's a complex one off

Re: [PATCH 2/2] usb: add little-endian transform for DeviceRemovable of usb3.0 hub

2012-09-10 Thread Greg KH
On Mon, Sep 10, 2012 at 09:24:42PM +0800, Lan Tianyu wrote: Signed-by-off: Lan Tianyutianyu@intel.com Signed-off-by: Lan Tianyu tianyu@intel.com What? -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

[PATCH net] net: qmi_wwan: call subdriver with control intf only

2012-09-10 Thread Bjørn Mork
This fixes a hang on suspend due to calling wdm_suspend on the unregistered data interface. The hang should have been a NULL pointer reference had it not been for a logic error in the cdc_wdm code. commit 230718bd net: qmi_wwan: bind to both control and data interface changed qmi_wwan to use

[PATCH] USB: cdc-wdm: fix wdm_find_device* return value

2012-09-10 Thread Bjørn Mork
A logic error made the wdm_find_device* functions return a bogus pointer into static data instead of the intended NULL no matching device was found. Cc: sta...@vger.kernel.org # v3.4+ Cc: Oliver Neukum oli...@neukum.org Signed-off-by: Bjørn Mork bj...@mork.no --- drivers/usb/class/cdc-wdm.c |

Re: [PATCH v3] usb: phy: add R-Car USB phy driver

2012-09-10 Thread Kuninori Morimoto
Hi Felipe Thank you for checking this patch +/* USBH common register */ +#define USBPCTRL0 0x0800 +#define USBPCTRL1 0x0804 +#define USBST 0x0808 +#define USBEH0 0x080C +#define USBOH0 0x081C +#define USBCTL00x0858 +#define

[PATCH v2] usb: renesas_usbhs: convert to devm_xxx()

2012-09-10 Thread Kuninori Morimoto
Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v1 - v2 - used devm_request_and_ioremap() drivers/usb/renesas_usbhs/common.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/usb/renesas_usbhs/common.c

Re: [RFC 1/6] usb/dwc3: fix resource_index

2012-09-10 Thread Pratyush Anand
On 9/10/2012 9:33 PM, Felipe Balbi wrote: - if (!dep-resource_index) - return; the thing is that this will let us fall into a situation where we issue END_TRANSFER even when resource_index is zero, which isn't good at all. I will explain the situation: 1. isoc IN transfer has

[PATCH V2 0/5] dwc3 isoc fixes : part 2

2012-09-10 Thread Pratyush Anand
Changes since RFC: patch usb/dwc3: fix resource_index dropped. patch usb/dwc3: fix isoc END TRANSFER Condition amended so that fixing resource index is not needed. Now, it is insured that END TRANSFER is issued only when we have at least one request in request_list. RFC LOG:

[PATCH V2 2/5] usb/dwc3: Correct Return from ep_queue

2012-09-10 Thread Pratyush Anand
Its better to return from each if condition as they are mutually exclusive. Signed-off-by: Pratyush Anand pratyush.an...@st.com --- drivers/usb/dwc3/gadget.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index

[PATCH V2 3/5] usb/dwc3: Fix skip LINK-TRB on ISOC

2012-09-10 Thread Pratyush Anand
When we reach to link trb, we just need to increase free_slot and then calculate TRB. Return is not correct, as it will cause wrong TRB DMA address to fetch in case of update transfer. Signed-off-by: Pratyush Anand pratyush.an...@st.com --- drivers/usb/dwc3/gadget.c | 13 + 1 files

[PATCH V2 5/5] usb/dwc3: Remove return from start_isoc if request_list is empty

2012-09-10 Thread Pratyush Anand
Now do not return from start_isoc if request_list is empty. You are going to return from kick_transfer anyway in this case. Signed-off-by: Pratyush Anand pratyush.an...@st.com --- drivers/usb/dwc3/gadget.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git

[PATCH V2 1/5] usb/dwc3: fix isoc END TRANSFER Condition

2012-09-10 Thread Pratyush Anand
There were still some corner cases where isoc transfer was not able to restart, specially when missed isoc does not happen , and in fact gadget does not queue any new request during giveback. Cleanup function calls giveback first, which provides a way to queue another request to gadget. But

Re: [PATCH v3] usb: phy: add R-Car USB phy driver

2012-09-10 Thread Felipe Balbi
On Mon, Sep 10, 2012 at 06:46:50PM -0700, Kuninori Morimoto wrote: Hi Felipe Thank you for checking this patch +/* USBH common register */ +#define USBPCTRL00x0800 +#define USBPCTRL10x0804 +#define USBST0x0808 +#define USBEH0 0x080C

Re: usbcore / Linux 2.6.+ / USB IO Board 04d8:000a

2012-09-10 Thread Xiaofan Chen
On Mon, Sep 10, 2012 at 9:35 PM, Xiaofan Chen xiaof...@gmail.com wrote: On Mon, Sep 10, 2012 at 8:48 PM, Oliver Neukum oneu...@suse.de wrote: On Monday 10 September 2012 08:37:55 Florian Wöhrl wrote: it seems like cdc_acm was altered, too - am I right? modinfo doesn't mention 04d8:000A. It