[PATCH 00/12] usbnet: usb_control_msg cleanup

2012-10-02 Thread Ming Lei
Hi, This patch set introduces 3 helpers for handling usb read, write and write_async command, and replaces the low level's implemention with the generic ones. Firstly, it is a cleanup and about 300 lines code can be saved. Secondly, the patch fixes DMA on the buffer which is embedded inside one

[PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-02 Thread Ming Lei
This patch introduces the below 3 usb command helpers: usbnet_read_cmd / usbnet_write_cmd / usbnet_write_cmd_async so that each low level driver doesn't need to implement them by itself, and the dma buffer allocation for usb transfer and runtime PM things can be handled just in one

[PATCH 02/12] usbnet: asix: apply introduced usb command APIs

2012-10-02 Thread Ming Lei
Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/asix_common.c | 117 + 1 file changed, 13 insertions(+), 104 deletions(-) diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index 774d9ce..50d1673 100644 ---

[PATCH 03/12] usbnet: cdc-ncm: apply introduced usb command APIs

2012-10-02 Thread Ming Lei
Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/cdc_ncm.c | 73 ++--- 1 file changed, 23 insertions(+), 50 deletions(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 4cd582a..429a2ad 100644 ---

[PATCH 04/12] usbnet: dm9601: apply introduced usb command APIs

2012-10-02 Thread Ming Lei
Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/dm9601.c | 107 +++--- 1 file changed, 15 insertions(+), 92 deletions(-) diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index e0433ce..3f554c1 100644 ---

[PATCH 06/12] usbnet: mcs7830: apply introduced usb command APIs

2012-10-02 Thread Ming Lei
Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/mcs7830.c | 85 - 1 file changed, 6 insertions(+), 79 deletions(-) diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c index 03c2d8d..db46a68 100644 ---

[PATCH 07/12] usbnet: net1080: apply introduced usb command APIs

2012-10-02 Thread Ming Lei
Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/net1080.c | 110 + 1 file changed, 30 insertions(+), 80 deletions(-) diff --git a/drivers/net/usb/net1080.c b/drivers/net/usb/net1080.c index c062a3e..93e0716 100644 ---

[PATCH 09/12] usbnet: sierra_net: apply introduced usb command APIs

2012-10-02 Thread Ming Lei
Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/sierra_net.c | 45 -- 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c index c27d277..eb5c7a8 100644 ---

[PATCH 10/12] usbnet: smsc75xx: apply introduced usb command APIs

2012-10-02 Thread Ming Lei
Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/smsc75xx.c | 39 ++- 1 file changed, 14 insertions(+), 25 deletions(-) diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c index b77ae76..1baa53a 100644 ---

[PATCH 12/12] usbnet: make device out of suspend before calling usbnet_read/write_cmd

2012-10-02 Thread Ming Lei
This patche gets the runtime PM reference count before calling usb_control_msg, and puts it after completion of the usb_control_msg, so that the usb control message can always be sent to one active device. Signed-off-by: Ming Lei ming@canonical.com --- drivers/net/usb/usbnet.c |4 1

Re: [PATCH v4] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-10-02 Thread Olivier Sobrie
Hi Marc and Wolfgang, On Sat, Sep 22, 2012 at 06:02:14PM +0200, Wolfgang Grandegger wrote: On 09/21/2012 11:54 AM, Marc Kleine-Budde wrote: On 09/20/2012 07:06 AM, Olivier Sobrie wrote: This driver provides support for several Kvaser CAN/USB devices. Such kind of devices supports up to

[PATCH v5] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-10-02 Thread Olivier Sobrie
This driver provides support for several Kvaser CAN/USB devices. Such kind of devices supports up to three CAN network interfaces. It has been tested with a Kvaser USB Leaf Light (one network interface) connected to a pch_can interface. The firmware version of the Kvaser device was 2.5.205. List

[patch 1/2] target: remove duplicate initialization

2012-10-02 Thread Dan Carpenter
We set bAlternateSetting to zero twice. I kept the second one (.bAlternateSetting = USB_G_ALT_INT_BBB) because that's more descriptive. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c index

[patch] WUSB: remove an unnused variable

2012-10-02 Thread Dan Carpenter
The wusb_cap_descr_default is never used. GCC doesn't complain about it because we have that line .bLength = sizeof(wusb_cap_descr_default) inside the definition itself. Clang complains though. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- It could be instead that the intent was to

[patch] orinoco_usb: clean up some signedness issues

2012-10-02 Thread Dan Carpenter
In ezusb_read_ltv() we had a comparison (bufsize 0) which was never true because bufsize was unsigned. I looked at the implications of that. If we passed a negative number to ezusb_access_ltv() then it would be used as the size parameter of the memcpy() because that function uses min_t(int,

Re: [PATCH] usb: serial: ftdi_sio: option to hide selected interfaces of multiple interfaces convertes

2012-10-02 Thread Robert Ryszard Paciorek
Hi, Couldn't you instead do an unbind of that particular interface via sysfs? I can unbind only full usb device not single interfaces on devices. When I try unbind interface I get write error: No such device My mistake - unbinding single interface is posibbble only in

Re: [RFC 1/2] Convert ehci-hcd to a library

2012-10-02 Thread Felipe Balbi
Hi, On Mon, Oct 01, 2012 at 04:21:31PM -0400, Alan Stern wrote: Felipe: We've been talking about this for a long time. Here at last is an initial attempt at splitting ehci-hcd up into a library module and multiple platform driver modules. The first patch is just preparation. It moves a

FTDI USB-to-UART converters and tcdrain()

2012-10-02 Thread Jarkko Huijts
Hello knowledgeable people, I have a question regarding tcdrain() and kernel driver drivers/usb/serial/ftdi_sio.c (for a family of USB-to-UART converter chips from FTDI). I'm using an FT232RL and kernel 2.6.38-16. (The driver code does not seem to have changed much between that version and 3.6.)

[RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Sarah Sharp
Hi Don, The WD drive arrived today, but I can't reproduce your I/O errors on 3.6. I didn't try with 3.5 yet. However, I did notice that the device really doesn't want to enter U1, but it will enter U2. Can you test the following patch with your device and see if it helps? If that doesn't work,

Re: [RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Alan Stern
On Tue, 2 Oct 2012, Sarah Sharp wrote: --- a/include/linux/usb/ch9.h +++ b/include/linux/usb/ch9.h @@ -828,7 +828,9 @@ struct usb_ss_cap_descriptor {/* Link Power Management */ #define USB_HIGH_SPEED_OPERATION (1 2) /* High speed operation */ #define USB_5GBPS_OPERATION

Re: [RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Sarah Sharp
On Tue, Oct 02, 2012 at 03:50:45PM -0400, Alan Stern wrote: On Tue, 2 Oct 2012, Sarah Sharp wrote: --- a/include/linux/usb/ch9.h +++ b/include/linux/usb/ch9.h @@ -828,7 +828,9 @@ struct usb_ss_cap_descriptor { /* Link Power Management */ #define USB_HIGH_SPEED_OPERATION

Re: [patch 2/2] target: strlen() doesn't count the terminator

2012-10-02 Thread Nicholas A. Bellinger
On Tue, 2012-10-02 at 11:27 +0300, Dan Carpenter wrote: We need to take the terminator into consideration here or the last character gets silently truncated away later. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/usb/gadget/tcm_usb_gadget.c

Re: [RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Don Zickus
On Tue, Oct 02, 2012 at 12:15:46PM -0700, Sarah Sharp wrote: Hi Don, The WD drive arrived today, but I can't reproduce your I/O errors on 3.6. I didn't try with 3.5 yet. However, I did notice that the device really doesn't want to enter U1, but it will enter U2. I did update the firmware

Re: [RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Sarah Sharp
On Tue, Oct 02, 2012 at 05:26:48PM -0400, Don Zickus wrote: On Tue, Oct 02, 2012 at 12:15:46PM -0700, Sarah Sharp wrote: Hi Don, The WD drive arrived today, but I can't reproduce your I/O errors on 3.6. I didn't try with 3.5 yet. However, I did notice that the device really doesn't

[PATCH] usb: phy: tegra remove include of mach/iomap.h

2012-10-02 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com Almost nothing from this file is used, and the file will hopefully be deleted soon. Copy the tiny portions that are used directly into tegra_usb_phy.c. I believe that Venu Byravarasu is working on cleaning up our USB driver, and those cleanups will remove

[PATCH] usb: ehci-s5p: use clk_prepare_enable and clk_disable_unprepare

2012-10-02 Thread Thomas Abraham
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- drivers/usb/host/ehci-s5p.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH] usb: ohci-exynos: use clk_prepare_enable and clk_disable_unprepare

2012-10-02 Thread Thomas Abraham
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- drivers/usb/host/ohci-exynos.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: Linux xHCI driver problems (reset ep)

2012-10-02 Thread Yuliya T
Hi Sarah, 2. Clear Halt of EP Also note that the xHCI hardware will only allow the Reset Endpoint to complete if the endpoint was actually halted due to a stall, babble, transfer error, etc. It won't reset the endpoint toggles or sequence number at arbitrary points, so we can't reset the

RE: [PATCH] usb: host: tegra remove include of mach/iomap.h

2012-10-02 Thread Venu Byravarasu
-Original Message- From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Wednesday, October 03, 2012 4:19 AM To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org; linux-te...@vger.kernel.org; Stephen Warren; Venu Byravarasu Subject: [PATCH] usb: host: tegra remove include of

RE: [PATCH] usb: phy: tegra remove include of mach/iomap.h

2012-10-02 Thread Venu Byravarasu
-Original Message- From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Wednesday, October 03, 2012 4:20 AM To: Felipe Balbi Cc: Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux- te...@vger.kernel.org; Stephen Warren; Venu Byravarasu Subject: [PATCH] usb: phy: tegra remove