This patch sets hub device's default autosuspend delay as 0 to
speedup bus suspend, see comments in code for details.
Acked-by: Alan Stern
Signed-off-by: Ming Lei
---
drivers/usb/core/hub.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/usb/co
The hub status endpoint has a long 'bInterval', which is 255ms
for FS/LS device and 256ms for HS device according to USB 2.0 spec,
so the device connection change may be reported later more than 255ms
via status pipe.
The connection change in hub may have been happened already on the
downstream po
There are two patches on usb hub autosuspend.
Change log:
V5:
- convert a symbolic constant into macro as suggested by Alan
V4:
- rebase on 3.7-rc2-next-20121022
V3:
- don't stop suspend for !PMSG_IS_AUTO() case(1/2)
- remove one unnecessary check on device_may_wake
On Tue, Oct 23, 2012 at 10:17:22AM +0530, Anil Nair wrote:
> Hello Greg,
>
> > No, debugfs needs to be mounted at /sys/kernel/debug/ Is it not mounted
> > that way for you? Perhaps it is mounted with root-only access (default
> > for 3.7-rc1 and newer kernels)?
>
> Yes you are right i verified
On Tue, Oct 23, 2012 at 03:53:26PM -0700, Sarah Sharp wrote:
> The following changes since commit 3b6054da68f9b0d5ed6a7ed0f42a79e61904352c:
>
> usb hub: send clear_tt_buffer_complete events when canceling TT clear work
> (2012-10-22 11:34:41 -0700)
>
> are available in the git repository at:
>
On Tue, Oct 23, 2012 at 10:35:54AM +0300, Felipe Balbi wrote:
> Hi Greg,
>
> here's my second set of fixes for v3.7-rc cycle. Let me know if you
> want any changes.
>
> cheers
>
> The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556:
>
> Linux 3.7-rc2 (2012-10-20 12:11:
On Fri, Oct 19, 2012 at 10:55:16AM +0300, Felipe Balbi wrote:
> that check will have to be done by all users
> of xhci_suspend() so it sounds a lot better to
> move the check to xhci_suspend() in order to
> avoid code duplication.
Hi Felipe,
This looks fine. Do you want me to add it to my usb-ne
Remove the variable slot_ctx from xhci_dbg_ctx(), since it is assigned
but unused. Caught by Coverity.
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-dbg.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
i
The command cancellation code doesn't check whether find_trb_seg()
couldn't find the segment that contains the TRB to be canceled. This
could cause a NULL pointer deference later in the function when next_trb
is called. It's unlikely to happen unless something is wrong with the
command ring point
Remove the variable ep_ctx from xhci_add_endpoint(), since it is
assigned but unused. Caught by Coverity.
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index ffe2
Coverity complains that xhci_evaluate_context_result() is missing a
break statement after the COMP_EBADSLT switch case. It's not a big
deal, since we wanted to return the same error code as the case
statement below it does. The end result would be one that a Slot
Disabled error completion code wo
The following changes since commit 16b45fdf9c4e82f5d3bc53aa70737650e7c8d5ed:
xhci: fix integer overflow (2012-10-23 15:43:38 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
for-usb-linus-queue
for you to fetch changes up to 1dba7a
From: Lan Tianyu
Struct usb_hub_descriptor.ss.DeviceRemovable has been defined as __le16
and (__force__ __u16) doesn't need.
Signed-off-by: Lan Tianyu
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-hub.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/driver
From: Oliver Neukum
xhci_service_interval_to_ns() returns long long
to avoid an overflow. However, the type cast happens
too late. The fix is to force ULL from the beginning.
This patch should be backported to kernels as old as 3.5, that contain
the commit e3567d2c15a7a8e2f992a5f7c7683453ca406d8
From: Oliver Neukum
An le16 is accessed without conversion.
This patch should be backported to kernels as old as 3.5, that contain
the commit e3567d2c15a7a8e2f992a5f7c7683453ca406d82 "xhci: Add Intel
U1/U2 timeout policy."
Signed-off-by: Oliver Neukum
Signed-off-by: Sarah Sharp
CC: sta...@vge
From: Lan Tianyu
When setting usb port's acpi power resource, there will be some xhci hub
requests.
This will cause dead lock since xhci->lock has been held before setting acpi
power
resource in the xhci_hub_control(). The usb_acpi_power_manageable() function
might
fall into sleep so release x
The following changes since commit 3b6054da68f9b0d5ed6a7ed0f42a79e61904352c:
usb hub: send clear_tt_buffer_complete events when canceling TT clear work
(2012-10-22 11:34:41 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
for-usb-l
On 10/23/2012 02:33 PM, Alan Stern wrote:
> On Tue, 23 Oct 2012, Stephen Warren wrote:
>
>>> Nothing intrinsically distinguishes this class of hardware. The only
>>> thing these devices have in common is that they can be managed by
>>> Linux's ehci-platform driver.
>>
>> I don't agree. They're al
On Tue, 23 Oct 2012, Stephen Warren wrote:
> > Nothing intrinsically distinguishes this class of hardware. The only
> > thing these devices have in common is that they can be managed by
> > Linux's ehci-platform driver.
>
> I don't agree. They're all EHCI USB controllers (or all EHCI USB
> contr
On 10/23/2012 11:59 AM, Alan Stern wrote:
> On Tue, 23 Oct 2012, Stephen Warren wrote:
>
So, rather than:
compatible = "usb-ehci";
You should always have e.g.:
compatible = "nvidia,tegra20-ehci", "usb-ehci";
Given that, there is then always enough infor
On Tue, 23 Oct 2012, Ming Lei wrote:
> With the problem of non-SMP-safe bitfields access, the power.lock should
> be held, but that is not enough to prevent children from being probed or
> disconnected. Looks another lock is still needed. I think a global lock
> is OK in the infrequent path.
Agre
On Tue, 23 Oct 2012, Stephen Warren wrote:
> >> So, rather than:
> >>
> >> compatible = "usb-ehci";
> >>
> >> You should always have e.g.:
> >>
> >> compatible = "nvidia,tegra20-ehci", "usb-ehci";
> >>
> >> Given that, there is then always enough information in the device tree
> >> for the driver
Fix NULL-pointer dereference at release by moving port data allocation
and deallocation to port_probe and port_remove.
Fix NULL-pointer dereference at disconnect by stopping port urbs at
port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the por
From: Ming Lei
Date: Tue, 23 Oct 2012 17:19:29 +0800
> On Mon, Oct 15, 2012 at 2:30 PM, Oliver Neukum wrote:
>>>
>>> v1:
>>> - drop previous patch 12, and let net/core handle
>>> runtime PM in ioctl path
>>
>> Acked-by: Oliver Neukum
>
> David, could you queue the patchset on net-n
On 10/23/2012 08:10 AM, Alan Stern wrote:
> On Mon, 22 Oct 2012, Stephen Warren wrote:
>
>>> I see. But why would it be done this way instead having a separate
>>> property?
>>
>> Well, I did say normally:-)
>>
>> I can certainly see an argument for representing these differences using
>> custom
On Tuesday 23 October 2012 10:20:15 Alan Stern wrote:
> On Tue, 23 Oct 2012, Florian Fainelli wrote:
>
> > Hi Kelvin,
> >
> > On Tuesday 23 October 2012 16:13:01 Kelvin Cheung wrote:
> > > Thank Florian.
> > > It looks great.
> > > However, you forget to remove corresponding section in
> > > driv
On Tue, Oct 23, 2012 at 10:15 PM, Alan Stern wrote:
>
>> + .idVendor = 0x05e3,
>
> Can you make this a symbolic constant (USB_VENDOR_GENESYS_LOGIC)? Or
> at least put a comment there?
OK, will do it in v5.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe lin
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the write
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the call
Make sure generic close is called at close.
The driver relies on the generic write implementation but did not call
generic close.
Note that the call to kill the read urb is not redundant, as mct_u232
uses an interrupt urb from the second port as the read urb and that
generic close therefore fails
On Tue, Oct 23, 2012 at 10:46 PM, Alan Stern wrote:
> On Tue, 23 Oct 2012, Ming Lei wrote:
>
>> On Mon, Oct 22, 2012 at 10:33 PM, Alan Stern
>> wrote:
>> >
>> > Tail recursion should be implemented as a loop, not as an explicit
>> > recursion. That is, the function should be:
>> >
>> > void pm_
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that this patc
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that this also
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the oob p
Make sure no control urb is submitted during close after a disconnect by
checking the disconnected flag.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
ind
Fix memory leak in attach error path where the read urb was never freed.
Cc: Bill Pemberton
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 2cdfdcc..5adb742
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the fifth
Fix memory leak in write error path.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/opticon.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
index 459c288..6aba731 100644
--- a/drivers/usb/serial/opticon
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that this patc
Make sure to allocate the control-message buffer dynamically as some
platforms cannot do DMA from stack.
Note that only the first byte of the old buffer was used.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/opticon.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff
Make sure no control urb is submitted during close after a disconnect by
checking the disconnected flag.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/metro-usb.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/serial/metro-usb.c b/driver
Fix port-data memory leak by replacing attach and release with
port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Compile-only tested.
Cc:
Signed
Kill urbs unconditionally at close and disconnect.
Note that URB status is not valid outside of completion handler.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/quatech2.c b/driver
Here are some more fixes against v3.7-rc2. The first five
USB: metro-usb: fix port-data memory leak
USB: metro-usb: fix io after disconnect
USB: whiteheat: fix memory leak in error path
USB: whiteheat: fix port-data memory leak
USB: ch341: fix port-data memory leak
are simply resends to
Make sure command buffer is deallocated in case of errors during attach.
Cc:
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/whiteheat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index 346c7ef..cfd155e 100644
---
Fix port-data memory leak by moving port data allocation to port_probe
and actually implementing deallocation.
Note that this driver has never even bothered to try to deallocate it's
port data...
Compile-only tested.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 23
On Tue, 23 Oct 2012, Ankit Patel wrote:
> Hi,
>
> Whenever, software asserts, HC resets during xHCI initialization, host
> controller is setting PRC and CSC (one of the version of host controller sets
> WRC bit also). However, there is no handling of these bits in xHCI software.
What do you mean
δΊ 2012/10/23 2:37, Alan Stern ει:
On Mon, 22 Oct 2012, Sarah Sharp wrote:
On Mon, Oct 15, 2012 at 08:42:47AM +0200, Rafael J. Wysocki wrote:
Sorry for the delay, I have been distracted by a number of things.
Me too. :)
On Monday 24 of September 2012 15:10:36 Sarah Sharp wrote:
On Tue, Sep
On Tue, 23 Oct 2012, Ming Lei wrote:
> On Mon, Oct 22, 2012 at 10:33 PM, Alan Stern
> wrote:
> >
> > Tail recursion should be implemented as a loop, not as an explicit
> > recursion. That is, the function should be:
> >
> > void pm_runtime_set_memalloc_noio(struct device *dev, bool enable)
> >
From: "Justin P. Mattock"
Signed-off-by: Justin P. Mattock
---
The below patch fixes a typo in usb: ehci-w90x900.c as well as adding
whitespace to the comment.
NOTE: this is a resend due to a typo creating a new typo as well as revision to
the original.
drivers/usb/host/ehci-w90x900.c |
Hi Felipe,
On Tuesday 23 October 2012 16:52:31 Felipe Balbi wrote:
> On Tue, Oct 23, 2012 at 09:50:10PM +0800, Bhupesh SHARMA wrote:
> > On Tuesday, October 23, 2012 6:31 PM Laurent Pinchart wrote:
> > > On Wednesday 01 August 2012 14:57:09 Laurent Pinchart wrote:
> > > > Hi,
> > > >
> > > > Thes
Hi Bhupesh,
On Tuesday 23 October 2012 21:50:10 Bhupesh SHARMA wrote:
> On Tuesday, October 23, 2012 6:31 PM Laurent Pinchart wrote:
> > On Wednesday 01 August 2012 14:57:09 Laurent Pinchart wrote:
> > > Hi,
> > >
> > > These 6 patches clean up the UVC gadget driver after Bhupesh Sharma's
> > >
Hi,
Whenever, software asserts, HC resets during xHCI initialization, host
controller is setting PRC and CSC (one of the version of host controller sets
WRC bit also). However, there is no handling of these bits in xHCI software.
1. At Initialization - device is NOT connected and due to HC RESET,
On Tue, 23 Oct 2012, Florian Fainelli wrote:
> Commit cfa49b4b (USB: ohci: merge ohci_finish_controller_resume with
> ohci_resume) merged ohci_finish_controller_resume with ohci_resume but forgot
> to update the ohci-sm501 driver accordingly, thus causing the folllowing build
> failure:
>
> drive
On Tue, 23 Oct 2012, Florian Fainelli wrote:
> Hi Kelvin,
>
> On Tuesday 23 October 2012 16:13:01 Kelvin Cheung wrote:
> > Thank Florian.
> > It looks great.
> > However, you forget to remove corresponding section in
> > drivers/usb/host/ehci-hcd.c
> > ...
> > #ifdef CONFIG_MACH_LOONGSON1
> > #in
On Tue, 23 Oct 2012, Ming Lei wrote:
> The hub status endpoint has a long 'bInterval', which is 255ms
> for FS/LS device and 256ms for HS device according to USB 2.0 spec,
> so the device connection change may be reported later more than 255ms
> via status pipe.
>
> The connection change in hub m
On Mon, 22 Oct 2012, Justin P. Mattock wrote:
> From: "Justin P. Mattock"
>
> Signed-off-by: Justin P. Mattock
>
> ---
>
> The below patch fixes a typo in staging: "ehci-w90x900"
What does ehci-w90x900 have to do with staging?
> drivers/usb/host/ehci-w90x900.c |2 +-
> 1 file changed,
On Mon, 22 Oct 2012, Stephen Warren wrote:
> > I see. But why would it be done this way instead having a separate
> > property?
>
> Well, I did say normally:-)
>
> I can certainly see an argument for representing these differences using
> custom properties, rather than deriving the information
Hi,
On Tue, Oct 23, 2012 at 09:50:10PM +0800, Bhupesh SHARMA wrote:
> Hi Laurent,
>
> > -Original Message-
> > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
> > Sent: Tuesday, October 23, 2012 6:31 PM
> > To: linux-usb@vger.kernel.org
> > Cc: Bhupesh SHARMA
> > Subject
On Mon, Oct 22, 2012 at 5:40 PM, Sarah Sharp
wrote:
> On Sun, Oct 21, 2012 at 06:03:24PM +0200, Ulrich Eckhardt wrote:
>> Hello,
>>
>> I have problems to get my USB3 cardreader to work reliably when
>> connected to the USB3 port. Due to lack of other USB3 devices I
>> don't know if it is the cardr
Hi Laurent,
> -Original Message-
> From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
> Sent: Tuesday, October 23, 2012 6:31 PM
> To: linux-usb@vger.kernel.org
> Cc: Bhupesh SHARMA
> Subject: Re: [PATCH 0/6] UVC gadget cleanup
>
> Hi Bhupesh,
>
> On Wednesday 01 August 201
Hi Kishon,
On 10/23/2012 01:02 PM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Wed, Aug 8, 2012 at 11:28 AM, Rajaram R
> wrote:
>> On Tue, Aug 7, 2012 at 6:39 PM, Roger Quadros wrote:
>>> Do not rely on any hints from gadget drivers and use DMA mode 1
>>> whenever we expect data of at least the
Hi Bhupesh,
On Wednesday 01 August 2012 14:57:09 Laurent Pinchart wrote:
> Hi,
>
> These 6 patches clean up the UVC gadget driver after Bhupesh Sharma's "UVC
> webcam gadget related changes" patch series. They're what I would have asked
> during patch review if the original patches hadn't been me
Hi,
On Tue, Oct 23, 2012 at 06:04:53PM +0530, Sekhar Nori wrote:
> On 10/8/2012 6:47 PM, Constantine Shulyupin wrote:
> > From: Constantine Shulyupin
> >
> > Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
> > CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HO
On 10/8/2012 6:47 PM, Constantine Shulyupin wrote:
> From: Constantine Shulyupin
>
> Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
> CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST
> and set MUSB_OTG configuration by default
> because this configuration
On Fri, Oct 19, 2012 at 04:53:18PM +0200, Johan Hovold wrote:
> Fix port-data memory leak by moving port data deallocation to
> port_remove for regular ports.
Greg, please ignore this one for now.
Only moving deallocation to port probe, fixes the memory leak at
release, but port data must also be
Hi,
On Tue, Oct 23, 2012 at 04:23:19PM +0530, Venu Byravarasu wrote:
> > -Original Message-
> > From: Venu Byravarasu
> > Sent: Monday, October 22, 2012 4:04 PM
> > To: 'ba...@ti.com'
> > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > u...@vger.kernel.org; linux-ker.
> -Original Message-
> From: Venu Byravarasu
> Sent: Monday, October 22, 2012 4:04 PM
> To: 'ba...@ti.com'
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: RE: [PATCH v3 resend] USB: PHY: Re-organize Tegra US
Commit 2be350fa (MIPS: Alchemy: use the ehci platform driver) and commit
e223a4cc (MIPS: Alchemy: use the OHCI platform driver) have change the Alchemy
platform code to register an EHCI and OHCI platform driver, the defconfig file
must thus be accordingly updated to build these drivers by default.
Commit cfa49b4b (USB: ohci: merge ohci_finish_controller_resume with
ohci_resume) merged ohci_finish_controller_resume with ohci_resume but forgot
to update the ohci-sm501 driver accordingly, thus causing the folllowing build
failure:
drivers/usb/host/ohci-sm501.c: In function 'ohci_sm501_resume':
On 10/23/2012 01:02 PM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Wed, Aug 8, 2012 at 11:28 AM, Rajaram R
> wrote:
>> On Tue, Aug 7, 2012 at 6:39 PM, Roger Quadros wrote:
>>> Do not rely on any hints from gadget drivers and use DMA mode 1
>>> whenever we expect data of at least the endpoint's p
Hi,
On Wed, Aug 8, 2012 at 11:28 AM, Rajaram R wrote:
> On Tue, Aug 7, 2012 at 6:39 PM, Roger Quadros wrote:
>> Do not rely on any hints from gadget drivers and use DMA mode 1
>> whenever we expect data of at least the endpoint's packet size and
>> have not yet received a short packet.
>
> Could
On Mon, Oct 15, 2012 at 2:30 PM, Oliver Neukum wrote:
>>
>> v1:
>> - drop previous patch 12, and let net/core handle
>> runtime PM in ioctl path
>
> Acked-by: Oliver Neukum
David, could you queue the patchset on net-next since my some usbnet
runtime PM patches depend on it?
Thanks,
Hello Felipe, Hello Sebastian,
On Tuesday, October 23, 2012 8:55 AM Felipe Balbi wrote:
> Hi,
>
> On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote:
> > after a mkdir config0 you should allocate a struct usb_configuration for
> this.
> >
> > |+->functio
On Mon, Oct 22, 2012 at 10:33 PM, Alan Stern wrote:
>
> Tail recursion should be implemented as a loop, not as an explicit
> recursion. That is, the function should be:
>
> void pm_runtime_set_memalloc_noio(struct device *dev, bool enable)
> {
> do {
> dev->power.memalloc_
On Tuesday 23 October 2012 10:46:50 Florian Fainelli wrote:
> Hi Kelvin,
>
> On Tuesday 23 October 2012 16:13:01 Kelvin Cheung wrote:
> > Thank Florian.
> > It looks great.
> > However, you forget to remove corresponding section in
> > drivers/usb/host/ehci-hcd.c
> > ...
> > #ifdef CONFIG_MACH_LOO
On 10/23/2012 08:54 AM, Felipe Balbi wrote:
Hi,
Hi,
On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote:
after a mkdir config0 you should allocate a struct usb_configuration for this.
|+->function0
|+ name (=> ether)
Here I am not
Hi Kelvin,
On Tuesday 23 October 2012 16:13:01 Kelvin Cheung wrote:
> Thank Florian.
> It looks great.
> However, you forget to remove corresponding section in
> drivers/usb/host/ehci-hcd.c
> ...
> #ifdef CONFIG_MACH_LOONGSON1
> #include "ehci-ls1x.c"
> #define PLATFORM_DRIVER ehci_ls1x_dr
On Mon, Oct 22, 2012 at 10:37 PM, Alan Stern wrote:
> On Mon, 22 Oct 2012, Ming Lei wrote:
>>
>> + /*
>> + * Don't allocate memory with GFP_KERNEL in current
>> + * context to avoid possible deadlock if usb mass
>> + * storage interface or usbnet interface(iSCSI case)
>> +
On Tue, Oct 23, 2012 at 3:18 AM, Alan Stern wrote:
> On Mon, 22 Oct 2012, Ming Lei wrote:
> Is this really needed? Even with iSCSI, doesn't register_disk() have
> to be called for the underlying block device? And given your 3/6
> patch, wouldn't that mark the network device?
The problem is tha
>
> This if is a no-op, as OTG_ are defined as:
>
> #define OTGSC_AVVIS BIT(17)
> #define OTGSC_AVVIE BIT(25)
>
> Resulting in queue_work() never called from here.
>
> > +
> > spin_unlock(&ci->lock);
> >
>
> I'm not that deep into the OTG stuff to fix it properly.
>
flush_work_sync and flush_work are now the same and flush_work_sync
has been deprecated. This fixes the following warning:
drivers/usb/core/hub.c: In function hub_quiesce:
drivers/usb/core/hub.c:1216:3: warning: flush_work_sync is deprecated (declared
at include/linux/workqueue.h:448) [-Wdeprecat
This patchset is to set DeviceRemovable according ACPI information
and create a new attribute "connect_type" under port device to expose
port connect type to user space. Patch3 create two link files under
port device and its child device to show their relationship under sysfs.
Following patchset i
Some platforms provide usb port connect types through ACPI. This
patch is to add this new attribute to expose these information
to user space.
Signed-off-by: Lan Tianyu
---
Documentation/ABI/testing/sysfs-bus-usb |9 +++
drivers/usb/core/hub.c | 43
Hi Greg,
here's my second set of fixes for v3.7-rc cycle. Let me know if you
want any changes.
cheers
The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556:
Linux 3.7-rc2 (2012-10-20 12:11:32 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm
On Tue, Oct 23, 2012 at 09:56:45AM +0300, Felipe Balbi wrote:
>
> that's fine, it doesn't matter how many files you touch as long as the
> patch is a single, logical, self-contained change. Look at how many
> things you're doing in a single patch:
>
> you add new function pointers to a structure,
This patch is to set xhci root hub's DeviceRemovable according to usb port's
connect type which currently comes from ACPI information. If ACPI information
was different with PORTSC, there would be a warning.
Signed-off-by: Lan Tianyu
---
drivers/usb/host/xhci-hub.c | 19 +--
1
To show the relationship between usb port and child device,
add link file "port" under usb device's sysfs directoy and
"child" under usb port device's sysfs directory. They are linked
to each other.
Signed-off-by: Lan Tianyu
---
drivers/usb/core/hub.c | 17 +
1 file changed, 17
ACPI provide "_PLD" and "_UPC" aml methods to describe usb port
visibility and connectability. This patch is to use those information
to set usb port's DeviceRemovable.
Signed-off-by: Lan Tianyu
---
drivers/usb/core/hub.c | 23 +++
drivers/usb/core/usb.h |4 --
On Mon, Oct 22, 2012 at 11:18:58AM +0800, Peter Chen wrote:
> On Fri, Oct 19, 2012 at 07:20:01PM +0300, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Oct 16, 2012 at 09:36:46AM +0800, Peter Chen wrote:
> > > The patch includes both API change and caller change.
> > > The main changes like below:
> >
Hi,
On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote:
> after a mkdir config0 you should allocate a struct usb_configuration for this.
>
> |+->function0
> |+ name (=> ether)
>
> Here I am not sure if we should name it function0 and hav
91 matches
Mail list logo
