[PATCH 2/5] usb: s3c-hsotg: Adding phy driver support

2012-11-01 Thread Praveen Paneri
Adding the phy driver support to hsotg driver. Keeping the platform data for continuing the smooth operation for boards which still uses it. Signed-off-by: Praveen Paneri --- drivers/usb/gadget/s3c-hsotg.c | 37 +++-- 1 files changed, 27 insertions(+), 10 deleti

Re: [PATCH v7 2/5] usb: s3c-hsotg: Adding phy driver support

2012-11-01 Thread Praveen Paneri
On Wed, Oct 31, 2012 at 8:14 PM, Lukasz Majewski wrote: > Hi Felipe, > >> Hi, >> >> On Tue, Oct 30, 2012 at 10:27:34AM +0530, Praveen Paneri wrote: >> > @@ -3501,20 +3511,27 @@ static int __devinit s3c_hsotg_probe(struct >> > platform_device *pdev) int ret; >> > int i; >> > >> > - plat = pde

Re: [PATCH V2 1/4] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-01 Thread Lan Tianyu
On 2012年11月01日 23:54, Sarah Sharp wrote: > On Mon, Oct 29, 2012 at 04:28:38PM +0800, Lan Tianyu wrote: >> ACPI provide "_PLD" and "_UPC" aml methods to describe usb port >> visibility and connectability. This patch is to use those information >> to set usb port's DeviceRemovable. > > You should pr

Re: [usb:usb-next 89/89] drivers/usb/host/ehci.h:662:3: error: implicit declaration of function 'readl_be'

2012-11-01 Thread Fengguang Wu
Hi Alan, > It's hard to know which headers are needed for foreign architectures. > Still, I think this ought to fix the problems you found. Can you test > this patch? Yes, it works. Thanks for the quick fix! Thanks, Fengguang > Index: usb-3.7/drivers/usb/host/ehci-platform.c > ==

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-11-01 Thread Matthias Schniedermeyer
On 01.11.2012 12:03, Alan Stern wrote: > On Thu, 1 Nov 2012, Sarah Sharp wrote: > > > On Wed, Oct 31, 2012 at 03:54:49PM -0400, Alan Stern wrote: > > > + ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), > > > + USB_REQ_SET_CONFIGURATION, 0, configuration, 0, > > > +

Re: problem with Roseweil eusb3 enclosure

2012-11-01 Thread Sarah Sharp
On Thu, Nov 01, 2012 at 04:47:48PM -0400, cov...@ccs.covici.com wrote: > Hi. Which kernel should I patch, the 3.6.2 or Linus's git tree which I > will update before I do it? You should test Linus' git tree. Sarah Sharp > > Sarah Sharp wrote: > > > On Sat, Oct 27, 2012 at 04:48:55AM -0400, co

Re: problem with Roseweil eusb3 enclosure

2012-11-01 Thread Sarah Sharp
On Thu, Nov 01, 2012 at 03:46:37PM -0400, Alan Stern wrote: > On Thu, 1 Nov 2012, Sarah Sharp wrote: > > > Alan, can you take a look at the patch and see what I can do in the case > > where five warm port resets fail? I think it's a pretty unlikely > > scenario, but if you have a good solution, I

Re: linux-next: Tree for Oct 31 (ehci, dbgp)

2012-11-01 Thread Jan Beulich
>>> Alan Stern 11/01/12 9:39 PM >>> >On Thu, 1 Nov 2012, Jan Beulich wrote: >> >>> Alan Stern 11/01/12 4:28 PM >>> >> >Evidently we need to change your new test in >> >drivers/usb/early/ehci-dbgp.c to: >> > >> >#if IS_ENABLED(CONFIG_USB_HCD_EHCI) || defined(CONFIG_USB_CHIPIDEA_HOST) >> > >> >Upco

Re: problem with Roseweil eusb3 enclosure

2012-11-01 Thread covici
And thanks again for all your work on this -- its been a real pain. Sarah Sharp wrote: > On Sat, Oct 27, 2012 at 04:48:55AM -0400, cov...@ccs.covici.com wrote: > > Hi. Well, here is an interesting piece of information -- I started from > > a poweroff state and the disk drive is seen even when i

Re: problem with Roseweil eusb3 enclosure

2012-11-01 Thread covici
Hi. Which kernel should I patch, the 3.6.2 or Linus's git tree which I will update before I do it? Sarah Sharp wrote: > On Sat, Oct 27, 2012 at 04:48:55AM -0400, cov...@ccs.covici.com wrote: > > Hi. Well, here is an interesting piece of information -- I started from > > a poweroff state and th

Re: linux-next: Tree for Oct 31 (ehci, dbgp)

2012-11-01 Thread Alan Stern
On Thu, 1 Nov 2012, Jan Beulich wrote: > >>> Alan Stern 11/01/12 4:28 PM >>> > >On Wed, 31 Oct 2012, Randy Dunlap wrote: > >> on x86_64: > >> > >> drivers/built-in.o: In function `ehci_reset': > >> host.c:(.text+0x542a7e): undefined reference to `dbgp_reset_prep' > >> host.c:(.text+0x542b75): un

Re: [PATCH] xhci: fix null-pointer dereference when destroying half-built segment rings

2012-11-01 Thread Julius Werner
>> Is it just >> for (prev = *first; prev; prev = prev->next) >>xhci_segment_free(xhci, prev); >> >> ? > > Yeah, that seems cleaner. > > Sarah Sharp I can submit it that way if you want, but I would advise against it. This way you access the prev pointer after it has been freed already… th

Re: [PATCH] xhci: fix null-pointer dereference when destroying half-built segment rings

2012-11-01 Thread Sarah Sharp
On Thu, Nov 01, 2012 at 10:13:00PM +0200, Andy Shevchenko wrote: > On Thu, Nov 1, 2012 at 9:47 PM, Julius Werner wrote: > > xhci_alloc_segments_for_ring() builds a list of xhci_segments and links > > the tail to head at the end (forming a ring). When it bails out for OOM > > reasons half-way throu

Re: [PATCH] xhci: fix null-pointer dereference when destroying half-built segment rings

2012-11-01 Thread Andy Shevchenko
On Thu, Nov 1, 2012 at 9:47 PM, Julius Werner wrote: > xhci_alloc_segments_for_ring() builds a list of xhci_segments and links > the tail to head at the end (forming a ring). When it bails out for OOM > reasons half-way through, it tries to destroy its half-built list with > xhci_free_segments_for

[PATCH] xhci: fix null-pointer dereference when destroying half-built segment rings

2012-11-01 Thread Julius Werner
xhci_alloc_segments_for_ring() builds a list of xhci_segments and links the tail to head at the end (forming a ring). When it bails out for OOM reasons half-way through, it tries to destroy its half-built list with xhci_free_segments_for_ring(), even though it is not a ring yet. This causes a null-

Re: linux-next: Tree for Oct 31 (ehci, dbgp)

2012-11-01 Thread Jan Beulich
>>> Alan Stern 11/01/12 4:28 PM >>> >On Wed, 31 Oct 2012, Randy Dunlap wrote: >> on x86_64: >> >> drivers/built-in.o: In function `ehci_reset': >> host.c:(.text+0x542a7e): undefined reference to `dbgp_reset_prep' >> host.c:(.text+0x542b75): undefined reference to `dbgp_external_startup' >> driver

Re: problem with Roseweil eusb3 enclosure

2012-11-01 Thread Alan Stern
On Thu, 1 Nov 2012, Sarah Sharp wrote: > Alan, can you take a look at the patch and see what I can do in the case > where five warm port resets fail? I think it's a pretty unlikely > scenario, but if you have a good solution, I'm all ears. Hmmm. Overall I'm not really sure about the logic in th

Re: [PATCH 0/3] USB: EHCI: Start splitting up the driver

2012-11-01 Thread Alan Stern
On Thu, 1 Nov 2012, Greg KH wrote: > On Thu, Nov 01, 2012 at 11:12:52AM -0400, Alan Stern wrote: > > Greg: > > > > This series of patches begins the process of splitting ehci-hcd up into > > a core library module and multiple independent platform-specific driver > > modules. The purpose of thi

Re: Force usb to use same port number for re/boot or re insert

2012-11-01 Thread Sarah Sharp
On Thu, Nov 01, 2012 at 10:10:07PM +0530, $rik@nth wrote: > Android is not giving any abstract layer for this kind of scenarios. > > I heard that using udev rule we can solve the problem. But that is also not > the right way to do it, so thought of asking for experts thoughts. What problem are y

Re: [PATCH V2 2/4] usb/xhci: set root hub's DeviceRemovable according to usb port connect type

2012-11-01 Thread Sarah Sharp
On Thu, Nov 01, 2012 at 01:00:43PM -0400, Alan Stern wrote: > On Thu, 1 Nov 2012, Greg KH wrote: > > > On Thu, Nov 01, 2012 at 08:59:11AM -0700, Sarah Sharp wrote: > > > On Mon, Oct 29, 2012 at 04:28:39PM +0800, Lan Tianyu wrote: > > > > This patch is to set xhci root hub's DeviceRemovable accordi

[RFC] Fix build error by making ChipIdea host a normal EHCI driver

2012-11-01 Thread Alan Stern
Alexander: The patch below (which is meant to apply to the linux-next tree) fixes a build error I introduced recently. However I don't know if it will work properly as the ChipIdea host driver. Can you verify that it is okay? Alan Stern This patch (as1627) splits the ehci-hcd core code, whic

Re: problem with Roseweil eusb3 enclosure

2012-11-01 Thread Sarah Sharp
On Sat, Oct 27, 2012 at 04:48:55AM -0400, cov...@ccs.covici.com wrote: > Hi. Well, here is an interesting piece of information -- I started from > a poweroff state and the disk drive is seen even when its plugged in! > However, I almost never do it that way and certainly it would not work > remo

Re: [PATCH 0/3] USB: EHCI: Start splitting up the driver

2012-11-01 Thread Greg KH
On Thu, Nov 01, 2012 at 11:12:52AM -0400, Alan Stern wrote: > Greg: > > This series of patches begins the process of splitting ehci-hcd up into > a core library module and multiple independent platform-specific driver > modules. The purpose of this change is to allow people and > distributions

Re: [PATCH] USB: ohci-exynos: initialize registers pointer earlier

2012-11-01 Thread Alan Stern
On Thu, 1 Nov 2012, Vincent Palatin wrote: > In the former code, we have a race condition between the first interrupt > and the regs field initilization in the usb_hcd structure. > If the OHCI irq fires before hcd->regs is set, we are getting a null > pointer dereference in ohci_irq. > > When cal

Re: [usb:usb-next 89/89] drivers/usb/host/ehci.h:662:3: error: implicit declaration of function 'readl_be'

2012-11-01 Thread Alan Stern
On Fri, 2 Nov 2012, Fengguang Wu wrote: > Hi Alan, > > FYI, kernel build failed on > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next > head: 99f91934a907df31ba878dfdd090002049dc476a > commit: 99f91934a907df31ba878dfdd090002049dc476a [89/89] USB: EHCI: make > eh

RE: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-11-01 Thread Paul Zimmerman
> From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Thursday, November 01, 2012 7:48 AM > > On Wed, 31 Oct 2012, Paul Zimmerman wrote: > > > > From: Michal Nazarewicz [mailto:m...@google.com] On Behalf Of Michal > > > Nazarewicz > > > Sent: Wednesday, October 31, 2012 1:10 PM > > > > >

[usb:usb-next 87/89] usbmisc_imx6q.c:(.text+0xa30): multiple definition of `ehci_init_driver'

2012-11-01 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 99f91934a907df31ba878dfdd090002049dc476a commit: 3e0232039967d7a1a06c013d097458b4d5892af1 [87/89] USB: EHCI: prepare to make ehci-hcd a library module config: make ARCH=arm imx_v6_v7_defconfig All error/warnings

[PATCH] USB: ohci-exynos: initialize registers pointer earlier

2012-11-01 Thread Vincent Palatin
In the former code, we have a race condition between the first interrupt and the regs field initilization in the usb_hcd structure. If the OHCI irq fires before hcd->regs is set, we are getting a null pointer dereference in ohci_irq. When calling usb_add_hcd(), it first executes the reset() callba

Re: [PATCH] xhci: fix null-pointer dereference when destroying half-built segment rings

2012-11-01 Thread Sarah Sharp
On Mon, Oct 29, 2012 at 09:35:15PM +0300, Sergei Shtylyov wrote: > Hello. > > On 10/29/2012 08:00 PM, Julius Werner wrote: > > next = xhci_segment_alloc(xhci, cycle_state, flags); > > if (!next) { > > - xhci_free_segments_for_ring(xhci, *first); > > +

Re: Endpoint is not halted

2012-11-01 Thread Sarah Sharp
On Wed, Oct 31, 2012 at 12:31:43PM +0800, Shimmer Huang wrote: > Sarah, > > This patch works for me. Would you please help submit and merge this patch ? Yep, I'll get it merged shortly. It will be marked for stable kernels, so it should make it into the Linux distribution kernels as well. Sarah

Re: [PATCH V2 2/4] usb/xhci: set root hub's DeviceRemovable according to usb port connect type

2012-11-01 Thread Alan Stern
On Thu, 1 Nov 2012, Greg KH wrote: > On Thu, Nov 01, 2012 at 08:59:11AM -0700, Sarah Sharp wrote: > > On Mon, Oct 29, 2012 at 04:28:39PM +0800, Lan Tianyu wrote: > > > This patch is to set xhci root hub's DeviceRemovable according to usb > > > port's > > > connect type which currently comes from

USB card reader errors, was Re: Etron USB 3.0 xHCI

2012-11-01 Thread Sarah Sharp
On Sat, Oct 27, 2012 at 07:37:50PM -0700, Matthew Hall wrote: > Sarah, > > I finally had occasion to experiment with this further, as more USB 3.0 > devices have become available at decent prices. > > I discovered that, while the card reader would fail with strange errors, a 32 > GB USB 3.0 fla

[usb:usb-next 89/89] drivers/usb/host/ehci.h:662:3: error: implicit declaration of function 'readl_be'

2012-11-01 Thread Fengguang Wu
Hi Alan, FYI, kernel build failed on tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 99f91934a907df31ba878dfdd090002049dc476a commit: 99f91934a907df31ba878dfdd090002049dc476a [89/89] USB: EHCI: make ehci-platform a separate driver config: make ARCH=powerpc a

Re: [PATCH 1/6] arch: Change defconfigs to point to g_mass_storage.

2012-11-01 Thread Michal Nazarewicz
> On Wed, 31 Oct 2012, Michal Nazarewicz wrote: >> --- a/arch/arm/configs/qil-a9260_defconfig >> +++ b/arch/arm/configs/qil-a9260_defconfig >> @@ -108,7 +108,6 @@ CONFIG_ROOT_NFS=y >> CONFIG_NLS_CODEPAGE_437=y >> CONFIG_NLS_CODEPAGE_850=y >> CONFIG_NLS_ISO8859_1=y >> -CONFIG_DEBUG_KERNEL=y >> C

Re: [PATCH V2 2/4] usb/xhci: set root hub's DeviceRemovable according to usb port connect type

2012-11-01 Thread Greg KH
On Thu, Nov 01, 2012 at 08:59:11AM -0700, Sarah Sharp wrote: > On Mon, Oct 29, 2012 at 04:28:39PM +0800, Lan Tianyu wrote: > > This patch is to set xhci root hub's DeviceRemovable according to usb port's > > connect type which currently comes from ACPI information. If ACPI > > information > > was

Re: [PATCH 2/6] usb: gadget: Remove File-backed Storage Gadget (g_file_storage).

2012-11-01 Thread Michal Nazarewicz
On Thu, Nov 01 2012, Alan Stern wrote: > BTW, you might want to check about updating a couple of the web pages > at www.linux-usb.org. The gadget/index.html and > gadget/file_storage.html pages still refer to g_file_storage. Will do. Probably not this or next week (LCE) though. -- Best regards

Re: Force usb to use same port number for re/boot or re insert

2012-11-01 Thread Sarah Sharp
On Wed, Oct 31, 2012 at 02:27:04PM +0530, $rik@nth wrote: > Hi Sarah, > > I need some help regarding the usb devices(Android based mobiles)., > > I am having some trouble in automating the task. I am testing some android > based mobiles in linux machine. The automation script uses the device id

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-11-01 Thread Alan Stern
On Thu, 1 Nov 2012, Sarah Sharp wrote: > On Wed, Oct 31, 2012 at 03:54:49PM -0400, Alan Stern wrote: > > + ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), > > + USB_REQ_SET_CONFIGURATION, 0, configuration, 0, > > + NULL, 0, USB_CTRL_SET_TIMEOUT

Re: [PATCH V2 2/4] usb/xhci: set root hub's DeviceRemovable according to usb port connect type

2012-11-01 Thread Sarah Sharp
On Mon, Oct 29, 2012 at 04:28:39PM +0800, Lan Tianyu wrote: > This patch is to set xhci root hub's DeviceRemovable according to usb port's > connect type which currently comes from ACPI information. If ACPI information > was different with PORTSC, there would be a warning. You should also add the

Re: [PATCH V2 1/4] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-01 Thread Sarah Sharp
On Mon, Oct 29, 2012 at 04:28:38PM +0800, Lan Tianyu wrote: > ACPI provide "_PLD" and "_UPC" aml methods to describe usb port > visibility and connectability. This patch is to use those information > to set usb port's DeviceRemovable. You should probably mention you're changing the EHCI roothub de

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread James Bottomley
On Thu, 2012-11-01 at 06:04 -0700, Greg KH wrote: > On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > > On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > > > > tree: git://git.ker

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-11-01 Thread Sarah Sharp
On Wed, Oct 31, 2012 at 03:54:49PM -0400, Alan Stern wrote: > + ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), > + USB_REQ_SET_CONFIGURATION, 0, configuration, 0, > + NULL, 0, USB_CTRL_SET_TIMEOUT); > + if (ret < 0 && cp) { > +

Re: [PATCH 2/2] Remove VLAIS usage from gadget code

2012-11-01 Thread Joseph Glanville
On 31 October 2012 05:25, Behan Webster wrote: > The use of variable length arrays in structs (VLAIS) in the Linux Kernel code > precludes the use of compilers which don't implement VLAIS (for instance the > Clang compiler). This patch instead calculates offsets into the kmalloc-ed > memory buffer

Re: linux-next: Tree for Oct 31 (ehci, dbgp)

2012-11-01 Thread Alan Stern
On Wed, 31 Oct 2012, Randy Dunlap wrote: > On 10/30/2012 11:26 PM, Stephen Rothwell wrote: > > > Hi all, > > > > Changes since 20121030: > > > > > on x86_64: > > drivers/built-in.o: In function `ehci_reset': > host.c:(.text+0x542a7e): undefined reference to `dbgp_reset_prep' > host.c:(.text+

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-01 Thread Dmytro Milinevskyy
Hi Felipe, resent with requested formatting changes. cheers, -- dmytro On Wed, Oct 31, 2012 at 2:35 PM, Felipe Balbi wrote: > Hi, > > On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote: >> Convert USB descriptor's fields to CPU byte order before using locally in >> USB NCM gadge

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-01 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy --- drivers/usb/gadget/f_ncm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gad

[PATCH 3/3] USB: EHCI: make ehci-platform a separate driver

2012-11-01 Thread Alan Stern
This patch (as1626) splits the ehci-platform code from ehci-hcd out into its own separate driver module. Signed-off-by: Alan Stern --- drivers/usb/host/Kconfig |2 - drivers/usb/host/Makefile|1 drivers/usb/host/ehci-hcd.c |6 --- drivers/usb/host/ehci-platfor

[PATCH 1/3] USB: EHCI: prepare to make ehci-hcd a library module

2012-11-01 Thread Alan Stern
This patch (as1624) prepares ehci-hcd for being split up into a core library and separate platform driver modules. A generic ehci_hc_driver structure is created, containing all the "standard" values, and a new mechanism is added whereby a driver module can specify a set of overrides to those value

[PATCH 2/3] USB: EHCI: make ehci-pci a separate driver

2012-11-01 Thread Alan Stern
This patch (as1625) splits the PCI portion of ehci-hcd out into its own separate driver module, called ehci-pci. Consistently with the current practice, the decision whether to build this module is not user-configurable. If EHCI and PCI are enabled then the module will be built, always. Signed-o

[PATCH 0/3] USB: EHCI: Start splitting up the driver

2012-11-01 Thread Alan Stern
Greg: This series of patches begins the process of splitting ehci-hcd up into a core library module and multiple independent platform-specific driver modules. The purpose of this change is to allow people and distributions to build systems that support more than one platform driver for EHCI (

RE: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-11-01 Thread Munegowda, Keshava
From: Balbi, Felipe Sent: Thursday, November 01, 2012 3:51 PM To: Munegowda, Keshava Cc: Tony Lindgren; linux-o...@vger.kernel.org; devicetree-disc...@lists.ozlabs.org; linux-...@vger.kernel.org; linux-usb@vger.kernel.org; Balbi, Felipe; sa...@linux.intel

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread David Miller
From: Max Filippov Date: Thu, 1 Nov 2012 16:47:14 +0300 > Strange, AFAICS architectures that use asm-generic/io.h (blackfin, openrisc, > score, unicore32 and xtensa) also provide those functions. They define HAVE_IOMEM, s390 does not, therefore you must protect the driver Kconfig with HAVE_IOMEM

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread David Miller
From: Bjørn Mork Date: Thu, 01 Nov 2012 14:38:29 +0100 > Felipe Balbi writes: > >> btw, only alpha and x86 seem to be providing all of those, but if you >> look into our documentation, it's said that drivers are supposed to use >> write/read{b,w,l,q} for all memory-mapped io. I'd expect all pla

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-11-01 Thread David Miller
From: Felipe Balbi Date: Thu, 1 Nov 2012 09:21:16 +0200 > then we can merge to net tree and handle the conflicts when merging to > Linus, that'd be fine by me as long as people know how to solve the > conflict properly ;-) Like Herbert with the crypto tree, I'm simply not merging this absolute c

Re: [PATCH] usb: host: tegra: fix potential NULL pointer dereference

2012-11-01 Thread Alan Stern
On Thu, 1 Nov 2012, Wei Yongjun wrote: > From: Wei Yongjun > > The dereference should be moved below the NULL test. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun > --- > drivers/usb/host/ehci-tegra.c | 8 ++-- >

RE: Linux USB gadget mass storage

2012-11-01 Thread Alan Stern
On Thu, 1 Nov 2012, victor wrote: > Alan, > > The partial patch is here. In fact I am using file_storage.c in u-boot, the > context and buf pointer are mismatch when the value is returned back from > irq routine. The file-storage.c is not in u-boot release, so I post my > question on linux usb. I

RE: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-11-01 Thread Alan Stern
On Wed, 31 Oct 2012, Paul Zimmerman wrote: > > From: Michal Nazarewicz [mailto:m...@google.com] On Behalf Of Michal > > Nazarewicz > > Sent: Wednesday, October 31, 2012 1:10 PM > > > > On Wed, Oct 31 2012, Paul Zimmerman wrote: > > > Regarding that, would you guys accept a patch that adds the "b

Re: [PATCH 2/6] usb: gadget: Remove File-backed Storage Gadget (g_file_storage).

2012-11-01 Thread Alan Stern
On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > The File-backed Storage Gadget (g_file_storage) gadget has been replaced > with Mass Storage Gadget (g_mass_storage) which uses the composite > framework. This commit removes g_file_storage (and most references to it).

Re: [PATCH 4/4] usb: chipidea: imx: add internal vbus regulator control

2012-11-01 Thread Marek Vasut
Dear Peter Chen, > - For host, the vbus should always be on. > - For otg, the vbus is off defaultly, the vbus needs to be > turned on/off when usb role switches. > > Signed-off-by: Peter Chen > --- > drivers/usb/chipidea/ci.h |2 + > drivers/usb/chipidea/ci13xxx_imx.c | 67 >

Re: [PATCH 2/4] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-11-01 Thread Marek Vasut
Dear Peter Chen, [...] > +static void ci_wait_vbus_stable(struct ci13xxx *ci, bool low) > +{ > + unsigned long timeout; > + u32 otgsc = hw_read(ci, OP_OTGSC, ~0); > + > + timeout = jiffies + CI_WAIT_VBUS_STABLE_TIMEOUT; > + > + if (low) { > + while (otgsc & OTGSC_BSV)

Re: [PATCH 1/6] arch: Change defconfigs to point to g_mass_storage.

2012-11-01 Thread Alan Stern
On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > The File-backed Storage Gadget (g_file_storage) is being removed, since > it has been replaced by Mass Storage Gadget (g_mass_storage). This commit > changes defconfigs point to the new gadget. ... > --- a/arch/arm/co

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Fengguang Wu
On Thu, Nov 01, 2012 at 04:47:14PM +0300, Max Filippov wrote: > On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: > >> On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > >> > On Thu, Nov 01, 2012 at 12:33:39PM

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Max Filippov
On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi wrote: > Hi, > > On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: >> On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: >> > On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: >> > > Hi, >> > > >> > > On Thu, Nov 01, 2012 a

Re: [PATCH 5/6] usb: gadget: storage_common: Make fsg_lun_is_open() a function.

2012-11-01 Thread Michal Nazarewicz
> On Wed, Oct 31, 2012 at 09:32:38PM +0100, Michal Nazarewicz wrote: >> From: Michal Nazarewicz >> >> Since function-line macros are to be avoided, this commit replaces >> the fsg_lun_is_open() macro with a static inline function. >> >> While at it, this commit also adds “inline” modifier to the

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Bjørn Mork
Felipe Balbi writes: > btw, only alpha and x86 seem to be providing all of those, but if you > look into our documentation, it's said that drivers are supposed to use > write/read{b,w,l,q} for all memory-mapped io. I'd expect all platforms > to provide those even if just to allow compilation of d

Re: [PATCH 5/6] usb: gadget: storage_common: Make fsg_lun_is_open() a function.

2012-11-01 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 09:32:38PM +0100, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > Since function-line macros are to be avoided, this commit replaces > the fsg_lun_is_open() macro with a static inline function. > > While at it, this commit also adds “inline” modifier to the >

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: > On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > > On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > > > > tree: g

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-11-01 Thread Sebastian Andrzej Siewior
On Wed, Oct 31, 2012 at 07:33:44PM +, Paul Zimmerman wrote: > Regarding that, would you guys accept a patch that adds the "buflen" > module parameter to the mass-storage gadget? Without increasing the > buffer length above 16K, it's impossible to approach the max throughput > allowed by SuperSp

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Greg KH
On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv > > > hea

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Felipe Balbi
On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv > > head: 1789e52acc90c87484a109d6349eefe63cabb257 > > commit: 1789e52acc90c874

Re: [PATCH 0/4] USB: sierra: memory-leak fixes for v3.7

2012-11-01 Thread Johan Hovold
On Wed, Oct 24, 2012 at 02:53:01PM -0400, Lennart Sorensen wrote: > On Wed, Oct 24, 2012 at 07:24:15PM +0200, Johan Hovold wrote: > > This is an updated series of fixes rebased on the interface-data memory leak > > discovered by Lennart. > > > > One of the reasons that I missed it was that the int

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv > head: 1789e52acc90c87484a109d6349eefe63cabb257 > commit: 1789e52acc90c87484a109d6349eefe63cabb257 [3/3] usb: phy: add R-Car > USB phy driver > con

Re: [PATCH resend2] Input: usbtouchscreen - initialize eGalax devices

2012-11-01 Thread Jiri Kosina
On Mon, 10 Sep 2012, Dmitry Torokhov wrote: > > The other piece to this puzzle is that usbhid should blacklist these devices > > to avoid binding if it happens to be loaded before usbtouchscreen. To do > > this, usbhid needs to be able to blacklist devices based on interface > > protocol (right n

Re: [PATCH v2] usb/musb: remove hand-crafted id handling

2012-11-01 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 04:12:43PM +0100, Sebastian Andrzej Siewior wrote: > This replaced the handcrafted id handling by the PLATFORM_DEVID_AUTO > value which should do the same thing. > This patch probably also fixes ux500 because I did not find the "musbid" > variable to remove. And we clos

[balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv head: 1789e52acc90c87484a109d6349eefe63cabb257 commit: 1789e52acc90c87484a109d6349eefe63cabb257 [3/3] usb: phy: add R-Car USB phy driver config: make ARCH=cris allyesconfig All error/warnings: drivers/usb/phy/rcar-phy.c:

Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-11-01 Thread Felipe Balbi
On Thu, Nov 01, 2012 at 09:19:48AM +0100, Munegowda, Keshava wrote: > > > From: Tony Lindgren [t...@atomide.com] > Sent: Wednesday, October 31, 2012 11:59 PM > To: Munegowda, Keshava > Cc: linux-o...@vger.kernel.org; devicetree-disc...@lists.ozlabs.org; >

Re: [PATCH v6] usb: phy: add R-Car USB phy driver

2012-11-01 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 07:03:11PM -0700, Kuninori Morimoto wrote: > + /* > + * CAUTION > + * > + * Because this phy address is also mapped under OHCI/EHCI address area, > + * this driver can't use devm_request_and_ioremap(dev, res) here > + */ peculiar... but fai

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-11-01 Thread Matthias Schniedermeyer
On 31.10.2012 15:54, Alan Stern wrote: > On Fri, 26 Oct 2012, Sarah Sharp wrote: > > > On Fri, Oct 26, 2012 at 03:01:32PM -0700, Sarah Sharp wrote: > > > The USB core isn't dropping the endpoints before it calls > > > xhci_check_bandwidth. I remember running into this bug a while back, > > > and

RE: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-11-01 Thread Munegowda, Keshava
From: Tony Lindgren [t...@atomide.com] Sent: Wednesday, October 31, 2012 11:59 PM To: Munegowda, Keshava Cc: linux-o...@vger.kernel.org; devicetree-disc...@lists.ozlabs.org; linux-...@vger.kernel.org; linux-usb@vger.kernel.org; Balbi, Felipe; sa...@linux.

RE: PPC Serial over Host USB

2012-11-01 Thread Avner Flesch
Hi, Brief update: It is working! The issue was in the .dts file. Is there any DTS documentation? Thanks Avner > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Avner Flesch > Sent: ב 29 אוקטובר 2012 16:41 > To: Peter St

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-11-01 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 11:33:20AM -0400, Behan Webster wrote: > On 12-10-31 09:28 AM, Felipe Balbi wrote: > >hi, > > > >On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: > >>The use of variable length arrays in structs (VLAIS) in the Linux Kernel > >>code > >>precludes the use o