Re: [RFC 3/3] ARM/AVR32: get rid of serial_at91.h

2012-11-16 Thread Russell King - ARM Linux
On Fri, Nov 16, 2012 at 11:08:47PM +0100, Joachim Eastwood wrote: > When the atmel_open_hook/atmel_open_close assignment is dropped, these > global variables will be useless so we should remove them as well. > There are also some other code that uses the variables that can be > dropped. Should shav

Re: [RFC 3/3] ARM/AVR32: get rid of serial_at91.h

2012-11-16 Thread Joachim Eastwood
Hi Russell, I made a similar patch a while ago. One note below. (http://marc.info/?l=linux-arm-kernel&m=133372829203680) On 21 September 2012 11:36, Russell King wrote: > The definitions provided by serial_at91.h are only used by the > atmel_serial driver, and the function that uses it is never

Re: [RFC 3/3] ARM/AVR32: get rid of serial_at91.h

2012-11-16 Thread Andrew Victor
hi, > Yes, during previous attempt to remove the files, Andrew said that it > was used internally in his former company. I had no serious reason to > remove it, so we kept it back then. > But now it seems the situation has evolved and we must consider the move > to a single kernel image and the wi

Re: problem with Roseweil eusb3 enclosure

2012-11-16 Thread covici
I doubt its a bad cable, if I shut the power off it will work every time. Also it always works on that other OS, but that may be irrelevant. It would not be very much use for it to come up using usb2, that would be quite slow. I wonder, is there an actual way I can tell whether its using usb3 or

Re: [PATCH 00/16] OMAP USB Host cleanup

2012-11-16 Thread Kevin Hilman
Roger Quadros writes: > Hi, > > This patchset addresses the following > > - Avoid addressing clocks one by one by name and use a for loop + bunch > of cleanups. > - Get number of channels/ports dynamically either from revision register > or from platform data. Avoids getting clocks that are n

Re: [PATCH] Patch for clearing PRC bit in PORTSC register at the time of XHCI driver insertion

2012-11-16 Thread Sarah Sharp
On Fri, Nov 16, 2012 at 10:19:01AM -0500, Alan Stern wrote: > On Thu, 15 Nov 2012, Greg KH wrote: > > > On Wed, Nov 07, 2012 at 06:36:46PM +0530, Bhavik Kothari wrote: > > > Hi Greg, > > > > > > Our host controller sets PRC and CSC bits at the time of initialization > > > even though no USB devic

Re: problem with Roseweil eusb3 enclosure

2012-11-16 Thread Sarah Sharp
On Fri, Nov 16, 2012 at 03:51:29AM -0500, cov...@ccs.covici.com wrote: > Sorry, did not do its job -- here is the log output. The patch did do what I expected. When the warm reset failed, it disabled and re-enabled the port. The good news is this stopped your endless enumeration issues. The bad

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Alexander Shishkin
Matthieu CASTET writes: > Alexander Shishkin a écrit : >> Michael Grzeschik writes: >> >>> On Fri, Nov 16, 2012 at 03:34:23PM +0200, Alexander Shishkin wrote: Michael Grzeschik writes: > On Fri, Nov 16, 2012 at 02:45:39PM +0200, Alexander Shishkin wrote: >> Michael Grzeschik

Re: [RFC 3/3] ARM/AVR32: get rid of serial_at91.h

2012-11-16 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:36 Fri 21 Sep , Russell King wrote: > The definitions provided by serial_at91.h are only used by the > atmel_serial driver, and the function that uses it is never called > from anywhere in the kernel. Therefore, these definitions are unused > and/or obsolete, and can be removed. > > Sig

Re: [PATCH] Patch for clearing PRC bit in PORTSC register at the time of XHCI driver insertion

2012-11-16 Thread Alan Stern
On Thu, 15 Nov 2012, Greg KH wrote: > On Wed, Nov 07, 2012 at 06:36:46PM +0530, Bhavik Kothari wrote: > > Hi Greg, > > > > Our host controller sets PRC and CSC bits at the time of initialization > > even though no USB device is attached. At the time of initialization, > > hub_probe() gets called

Re: [PATCH 7/9] usb: chipidea: udc: add force-full-speed option

2012-11-16 Thread Matthieu CASTET
Alexander Shishkin a écrit : > Michael Grzeschik writes: > >> This patch makes it possible to set the chipidea udc >> into full-speed only mode. It can be set by the oftree >> property "force-full-speed". >> >> Signed-off-by: Michael Grzeschik >> Signed-off-by: Marc Kleine-Budde >> --- >> driv

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Matthieu CASTET
Alexander Shishkin a écrit : > Michael Grzeschik writes: > >> On Fri, Nov 16, 2012 at 03:34:23PM +0200, Alexander Shishkin wrote: >>> Michael Grzeschik writes: >>> On Fri, Nov 16, 2012 at 02:45:39PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > >> This patch ma

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Marc Kleine-Budde
On 11/16/2012 02:41 PM, Felipe Balbi wrote: > Hi, > > On Fri, Nov 16, 2012 at 12:44:19PM +0100, Marc Kleine-Budde wrote: diff --git a/drivers/of/of_usbphy.c b/drivers/of/of_usbphy.c new file mode 100644 index 000..2e71f7b --- /dev/null +++ b/drivers/of/of_usbphy.c

[GIT PATCH] USB fixes for 3.7-rc5

2012-11-16 Thread Greg KH
The following changes since commit 8f0d8163b50e01f398b14bcd4dc039ac5ab18d64: Linux 3.7-rc3 (2012-10-28 12:24:48 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.7-rc5 for you to fetch changes up to e592c5d0b7db94b485b4a2

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > On Fri, Nov 16, 2012 at 03:34:23PM +0200, Alexander Shishkin wrote: >> Michael Grzeschik writes: >> >> > On Fri, Nov 16, 2012 at 02:45:39PM +0200, Alexander Shishkin wrote: >> >> Michael Grzeschik writes: >> >> >> >> > This patch makes it possible to configure the

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Michael Grzeschik
On Fri, Nov 16, 2012 at 03:34:23PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > On Fri, Nov 16, 2012 at 02:45:39PM +0200, Alexander Shishkin wrote: > >> Michael Grzeschik writes: > >> > >> > This patch makes it possible to configure the PTW and PTS bits inside > >> > the p

Re: [PATCH v2] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Felipe Balbi
On Fri, Nov 16, 2012 at 05:06:38PM +0400, Sergei Shtylyov wrote: > Hello. > > On 16-11-2012 16:45, Kishon Vijay Abraham I wrote: > > >commit 392142 (moved event buffer allocation out of dwc3_core_init()). But > >The actual summary is "usb: dwc3: core: move event buffer > allocation out of dw

Re: [PATCH] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Felipe Balbi
On Fri, Nov 16, 2012 at 04:47:11AM -0800, Greg KH wrote: > On Fri, Nov 16, 2012 at 10:17:19AM +0200, Felipe Balbi wrote: > > Hi, > > > > On Fri, Nov 16, 2012 at 12:07:54PM +0530, Kishon Vijay Abraham I wrote: > > > commit 392142 moved event buffer allocation out of dwc3_core_init() but > > > event

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Felipe Balbi
Hi, On Fri, Nov 16, 2012 at 12:44:19PM +0100, Marc Kleine-Budde wrote: > >> diff --git a/drivers/of/of_usbphy.c b/drivers/of/of_usbphy.c > >> new file mode 100644 > >> index 000..2e71f7b > >> --- /dev/null > >> +++ b/drivers/of/of_usbphy.c > >> @@ -0,0 +1,49 @@ > >> +/* > >> + * OF helpers for

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > On Fri, Nov 16, 2012 at 02:45:39PM +0200, Alexander Shishkin wrote: >> Michael Grzeschik writes: >> >> > This patch makes it possible to configure the PTW and PTS bits inside >> > the portsc register for host and device mode before the driver starts >> > and the phy

Re: [PATCH v2 6/7] usb: chipidea: usbmisc: add mx53 support

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > This adds mx53 as the next user of the usbmisc driver and makes it > possible to disable the overcurrent-detection of the internal phy. > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/usbmisc_imx.c | 28

Re: [PATCH v2 5/7] usb: chipidea: usbmisc: add support for ahb, ipg and per clock

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Marc Kleine-Budde > > This patch adds support for a second and third clock to the usbmisc driver. On > modern freescale ARM cores like the imx51, imx53 and imx6q three clocks > ("ahb", > "ipg" and "per") must be enabled in order to access the USB core. > > ahb

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Michael Grzeschik
On Fri, Nov 16, 2012 at 02:45:39PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > This patch makes it possible to configure the PTW and PTS bits inside > > the portsc register for host and device mode before the driver starts > > and the phy can be addressed as hardware implem

Re: [PATCH v2] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Sergei Shtylyov
Hello. On 16-11-2012 16:45, Kishon Vijay Abraham I wrote: commit 392142 (moved event buffer allocation out of dwc3_core_init()). But The actual summary is "usb: dwc3: core: move event buffer allocation out of dwc3_core_init()". event buffer allocation uses the cached copy of hwparams t

Re: [PATCH 8/9] usb: chipidea: udc: remove unlocked ep_queue which can lead to an race

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > Its not nessecary to call ep_queue unlocked while in the > own driver. So we move the function to an unlocked version > and call it conditionaly. What do you mean by "conditionally" here? Also, when you say race, you might as well mention what code is racing what to m

Re: [PATCH 7/9] usb: chipidea: udc: add force-full-speed option

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > This patch makes it possible to set the chipidea udc > into full-speed only mode. It can be set by the oftree > property "force-full-speed". > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/bits.h |1 + > driv

Hard freeze after 'rfkill block bluetooth'

2012-11-16 Thread Jiri Kosina
Hi, I got a hard freeze with HEAD at 1b42fc4 (i.e. past -rc4) after running rfkill block bluetooth. Screen capture can be found at http://www.jikos.cz/jikos/junk/IMAG0264.jpg (sorry for the bad picture quality, but I believe it's readable). I am not able to reproduce it again. -- Ji

Re: [PATCH] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Greg KH
On Fri, Nov 16, 2012 at 10:17:19AM +0200, Felipe Balbi wrote: > Hi, > > On Fri, Nov 16, 2012 at 12:07:54PM +0530, Kishon Vijay Abraham I wrote: > > commit 392142 moved event buffer allocation out of dwc3_core_init() but > > event buffer allocation uses the cached copy of hwparams to determine > >

[PATCH v2] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Kishon Vijay Abraham I
commit 392142 (moved event buffer allocation out of dwc3_core_init()). But event buffer allocation uses the cached copy of hwparams to determine the number of event buffers and the caching is done in dwc3_core_init. So moved dwc3_cache_hwparams function before dwc3_alloc_event_buffers so that dwc3_

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > This patch makes it possible to configure the PTW and PTS bits inside > the portsc register for host and device mode before the driver starts > and the phy can be addressed as hardware implementation is designed. > > Signed-off-by: Michael Grzeschik > Signed-off-by: M

Re: [PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > This patch makes it possible to configure the PTW and PTS bits inside > the portsc register for host and device mode before the driver starts > and the phy can be addressed as hardware implementation is designed. > > Signed-off-by: Michael Grzeschik > Signed-off-by: M

Re: [PATCH] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Sergei Shtylyov
Hello. On 16-11-2012 10:37, Kishon Vijay Abraham I wrote: commit 392142 Please specify thta commit summary in parens. moved event buffer allocation out of dwc3_core_init() but event buffer allocation uses the cached copy of hwparams to determine the number of event buffers and the cachin

Re: [PATCH 3/9] usb: chipidea: ci13xxx-imx: create dynamic platformdata

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > This patch removes the limitation of having only one instance of the > ci13xxx-imx platformdata and makes different configurations possible. > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/ci13xxx_imx.c | 27 +++

Re: [PATCH 1/4] ARM: OMAP: usb-host: Device tree support for USB Host

2012-11-16 Thread Roger Quadros
On 11/16/2012 01:06 PM, Benoit Cousson wrote: > On 11/16/2012 11:55 AM, Roger Quadros wrote: >> Hi Benoit, >> >> On 11/16/2012 12:30 PM, Benoit Cousson wrote: >>> Hi Roger, >>> >>> On 11/15/2012 03:56 PM, Roger Quadros wrote: Provides a means for the OMAP USB host subsystem to be initialized >

Re: [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata

2012-11-16 Thread Greg KH
On Fri, Nov 16, 2012 at 12:06:57PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > From: Marc Kleine-Budde > > > > Signed-off-by: Marc Kleine-Budde > > Signed-off-by: Michael Grzeschik > > static yes, __devinitdata -- probably not. These structs are used > everywhere throug

Re: [PATCH 4/9] usb: chipidea: ci13xxx-imx: add "dr_mode" property to device tree bindings

2012-11-16 Thread Marc Kleine-Budde
On 11/16/2012 12:53 PM, Alexander Shishkin wrote: > Michael Grzeschik writes: > >> From: Marc Kleine-Budde >> >> Its necessary to limit a hostonly soc to its single role, since >> debugging has shown that reading on the "CAP_DCCPARAMS" register inside >> a host-only port, what ci_hdrc_gadget_ini

Re: [PATCH 4/9] usb: chipidea: ci13xxx-imx: add "dr_mode" property to device tree bindings

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Marc Kleine-Budde > > Its necessary to limit a hostonly soc to its single role, since > debugging has shown that reading on the "CAP_DCCPARAMS" register inside > a host-only port, what ci_hdrc_gadget_init does, can lead to an > instable behaviour of the IC. Pro

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Marc Kleine-Budde
On 11/16/2012 12:31 PM, Felipe Balbi wrote: > Hi, > > On Wed, Nov 14, 2012 at 05:19:06PM +0100, Michael Grzeschik wrote: >> This patch makes it possible to set the connection of the usbphy to the >> soc. It is derived from the oftree bindings for the ethernetphy and adds >> similar helperfunctions

Re: [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata

2012-11-16 Thread Alexander Shishkin
Marc Kleine-Budde writes: > On 11/16/2012 11:06 AM, Alexander Shishkin wrote: >> Michael Grzeschik writes: >> >>> From: Marc Kleine-Budde >>> >>> Signed-off-by: Marc Kleine-Budde >>> Signed-off-by: Michael Grzeschik >> >> static yes, __devinitdata -- probably not. These structs are used >>

Re: [RFC 3/3] ARM/AVR32: get rid of serial_at91.h

2012-11-16 Thread Russell King - ARM Linux
On Fri, Nov 16, 2012 at 11:12:46AM +0100, Nicolas Ferre wrote: > On 11/16/2012 10:53 AM, Jean-Christophe PLAGNIOL-VILLARD : > > On 10:36 Fri 21 Sep , Russell King wrote: > >> The definitions provided by serial_at91.h are only used by the > >> atmel_serial driver, and the function that uses it i

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 05:19:06PM +0100, Michael Grzeschik wrote: > This patch makes it possible to set the connection of the usbphy to the > soc. It is derived from the oftree bindings for the ethernetphy and adds > similar helperfunctions. > > Signed-off-by: Michael Grzeschik > Signed-off

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 05:19:06PM +0100, Michael Grzeschik wrote: > This patch makes it possible to set the connection of the usbphy to the > soc. It is derived from the oftree bindings for the ethernetphy and adds > similar helperfunctions. > > Signed-off-by: Michael Grzeschik > Signed-off

Re: [PATCH 1/4] ARM: OMAP: usb-host: Device tree support for USB Host

2012-11-16 Thread Benoit Cousson
On 11/16/2012 11:55 AM, Roger Quadros wrote: > Hi Benoit, > > On 11/16/2012 12:30 PM, Benoit Cousson wrote: >> Hi Roger, >> >> On 11/15/2012 03:56 PM, Roger Quadros wrote: >>> Provides a means for the OMAP USB host subsystem to be initialized >>> from Device tree. This is a first step for device t

Re: [PATCH 1/4] ARM: OMAP: usb-host: Device tree support for USB Host

2012-11-16 Thread Roger Quadros
Hi Benoit, On 11/16/2012 12:30 PM, Benoit Cousson wrote: > Hi Roger, > > On 11/15/2012 03:56 PM, Roger Quadros wrote: >> Provides a means for the OMAP USB host subsystem to be initialized >> from Device tree. This is a first step for device tree migration where >> we specify only the board specif

Re: [PATCH 1/4] ARM: OMAP: usb-host: Device tree support for USB Host

2012-11-16 Thread Benoit Cousson
Hi Roger, On 11/15/2012 03:56 PM, Roger Quadros wrote: > Provides a means for the OMAP USB host subsystem to be initialized > from Device tree. This is a first step for device tree migration where > we specify only the board specific stuff. Things like I/O address space > and interrupts are not ye

Re: [PATCH 4/4] regulator: fixed: Properly use input_supply parameter from device tree

2012-11-16 Thread Roger Quadros
On 11/15/2012 09:11 PM, Laxman Dewangan wrote: > On 11/15/2012 09:56 AM, Roger Quadros wrote: >> The device tree node will provide the input supply name as >> a string. Use that to populate the supply_name parameter of >> the regulator descriptor. >> >> Also correct the documentation to reflect the

Re: [PATCH 3/9] usb: chipidea: ci13xxx-imx: create dynamic platformdata

2012-11-16 Thread Marc Kleine-Budde
On 11/16/2012 11:14 AM, Alexander Shishkin wrote: > Michael Grzeschik writes: > >> This patch removes the limitation of having only one instance of the >> ci13xxx-imx platformdata and makes different configurations possible. > > In more honest wording it should probably say: "makes using differe

Re: [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata

2012-11-16 Thread Marc Kleine-Budde
On 11/16/2012 11:06 AM, Alexander Shishkin wrote: > Michael Grzeschik writes: > >> From: Marc Kleine-Budde >> >> Signed-off-by: Marc Kleine-Budde >> Signed-off-by: Michael Grzeschik > > static yes, __devinitdata -- probably not. These structs are used > everywhere throughout the driver curren

Re: [PATCH 3/9] usb: chipidea: ci13xxx-imx: create dynamic platformdata

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > This patch removes the limitation of having only one instance of the > ci13xxx-imx platformdata and makes different configurations possible. In more honest wording it should probably say: "makes using different phys possible", but this is fine too. :) > > Signed-off-

Re: [RFC 3/3] ARM/AVR32: get rid of serial_at91.h

2012-11-16 Thread Nicolas Ferre
On 11/16/2012 10:53 AM, Jean-Christophe PLAGNIOL-VILLARD : > On 10:36 Fri 21 Sep , Russell King wrote: >> The definitions provided by serial_at91.h are only used by the >> atmel_serial driver, and the function that uses it is never called >> from anywhere in the kernel. Therefore, these defini

Re: [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Marc Kleine-Budde > > Signed-off-by: Marc Kleine-Budde > Signed-off-by: Michael Grzeschik static yes, __devinitdata -- probably not. These structs are used everywhere throughout the driver currently, not only at initialization time. > --- > drivers/usb/chip

Re: [PATCH 11/14] HID: hiddev: Remove redundant check on unsigned variable

2012-11-16 Thread Jiri Kosina
On Fri, 16 Nov 2012, Tushar Behera wrote: > No need to check whether unsigned variable is less than 0. > > CC: Jiri Kosina > CC: linux-usb@vger.kernel.org > CC: linux-in...@vger.kernel.org > Signed-off-by: Tushar Behera > --- > drivers/hid/usbhid/hiddev.c |2 +- > 1 files changed, 1 insert

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Alexander Shishkin
Michael Grzeschik writes: > This patch makes it possible to set the connection of the usbphy to the > soc. It is derived from the oftree bindings for the ethernetphy and adds > similar helperfunctions. > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- > drivers/of/K

Re: [PATCH] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Felipe Balbi
Hi, On Fri, Nov 16, 2012 at 12:07:54PM +0530, Kishon Vijay Abraham I wrote: > commit 392142 moved event buffer allocation out of dwc3_core_init() but > event buffer allocation uses the cached copy of hwparams to determine > the number of event buffers and the caching is done in dwc3_core_init. > S