On 11/22/2012 10:30 PM, Greg KH wrote:
On Thu, Nov 22, 2012 at 04:01:49PM +0100, Olivier Sobrie wrote:
Hi linux-usb folks,
Is there someone who can help me to fix the following errors?
smatch warnings:
+ drivers/net/can/usb/kvaser_usb.c:431 kvaser_usb_send_simple_msg() error:
doing
+dma
Sascha Hauer s.ha...@pengutronix.de writes:
On Fri, Nov 23, 2012 at 01:36:36PM +0800, Peter Chen wrote:
On Wed, Nov 21, 2012 at 03:06:29PM +0100, Michael Grzeschik wrote:
From: Marc Kleine-Budde m...@pengutronix.de
This fixes a potential race condition where the ci13xxx_imx glue code
On Thursday, November 22, 2012 3:37 PM Sebastian Andrzej Siewior wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:54 [+0100]:
My intention is not to add new gadgets, but to promote the use of
usb function modules, e.g. f_mass_storage.ko.
finally.
I don't use the usbf_option stuff,
This patchset refine some spinlocks which I think not used properly. Maybe my
'refine' make the code broken, so any comments will be appreciated.
patch1: The function 'usbip_event_add()' may be called in interrupt context on
the stub side:
On 11/22/2012 09:09 PM, Michal Nazarewicz wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:54 [+0100]:
During its lifetime, the mass storage can require creating
lunX directories for its luns. And again, with usbf_option
On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote:
You have first
On 11/22/2012 09:25 PM, Michal Nazarewicz wrote:
echo 1 /cfg/usb-function-gadget/G1/ready
On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote:
One thing you miss: Lets say you have C1 and C2. How do you configure
the same F1 in C1 and C2 _and_ how do you configure a different F1 in
F1 and
On 11/22/2012 09:30 PM, Michal Nazarewicz wrote:
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote:
pre_eject and post_eject are not used by anyone. Removing them.
Signed-off-by: Andrzej Pietrasiewiczandrze...@samsung.com
Signed-off-by: Kyungmin Parkkyungmin.p...@samsung.com
Acked-by: Michal
On 11/23/2012 06:36 AM, Peter Chen wrote:
On Wed, Nov 21, 2012 at 03:06:29PM +0100, Michael Grzeschik wrote:
From: Marc Kleine-Budde m...@pengutronix.de
This fixes a potential race condition where the ci13xxx_imx glue code
could be fast enough to call one of the usbmisc_ops before he got a
On 11/23/2012 07:53 AM, Peter Chen wrote:
On Wed, Nov 21, 2012 at 03:06:32PM +0100, Michael Grzeschik wrote:
This adds mx53 as the next user of the usbmisc driver and makes it
possible to disable the overcurrent-detection of the internal phy.
Signed-off-by: Michael Grzeschik
On Thursday, November 22, 2012 3:55 PM Sebastian Andrzej Siewior wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]:
snip
diff --git a/include/linux/usb/composite.h
b/include/linux/usb/composite.h
index e84c754..5bac1f8 100644
--- a/include/linux/usb/composite.h
+++
On 11/22/2012 09:48 PM, Michal Nazarewicz wrote:
I think neither is correct. The reviewed-by tag implies that the person
did a careful review of the code as per “Reviewer's statement of
oversight” (see Documentation/SubmittingPatches).
What actually happens is Kyungmin giving a green light to
This driver uses usb_phy interface to interact with s3c-hsotg. Supports
phy_init and phy_shutdown functions to enable/disable usb phy. Support
will be extended to host controllers and more Samsung SoCs.
Signed-off-by: Praveen Paneri p.pan...@samsung.com
Acked-by: Heiko Stuebner he...@sntech.de
On 11/22/2012 06:12 PM, Felipe Balbi wrote:
Hi,
On Thu, Nov 22, 2012 at 05:00:45PM +0200, Roger Quadros wrote:
On 11/22/2012 03:56 PM, Felipe Balbi wrote:
Hi,
On Thu, Nov 22, 2012 at 09:49:05PM +0800, Andy Green wrote:
Again it sounds like something that should be done at the hub driver
Hi,
On Thu, Nov 22, 2012 at 09:35:06PM -0500, Alan Stern wrote:
On Thu, 22 Nov 2012, Felipe Balbi wrote:
The latter, more or less. For example, maybe we can tell usbcore
somehow that regulator X is in control of a device attached to host
controller Y (not sure how we would express X
On Fri, Nov 23, 2012 at 12:23:52PM +0200, Roger Quadros wrote:
On 11/22/2012 06:12 PM, Felipe Balbi wrote:
Hi,
On Thu, Nov 22, 2012 at 05:00:45PM +0200, Roger Quadros wrote:
On 11/22/2012 03:56 PM, Felipe Balbi wrote:
Hi,
On Thu, Nov 22, 2012 at 09:49:05PM +0800, Andy Green wrote:
Hi,
-Original Message-
From: Sebastian Andrzej Siewior [mailto:bige...@linutronix.de]
Sent: Friday, November 23, 2012 7:17 PM
To: Michal Nazarewicz
Cc: Andrzej Pietrasiewicz; linux-usb@vger.kernel.org; 'Kyungmin Park';
'Felipe Balbi'; 'Greg Kroah-Hartman'; 'Joel Becker'; Marek
One more,
I checked it again Documentation/SubmittingPatches
In the 12) Sign your work
You can find the following paragraphs.
Some people also put extra tags at the end. They'll just be ignored for
now, but you can do this to mark internal company procedures or just
point out some special
Hello Sebastian,
As far as many of your comments are concerned, I agree and do not reply
to them. For others I agree and reply, and for yet others I reply ;)
Please see inline.
On Thursday, November 22, 2012 5:57 PM Sebastian Andrzej Siewior wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:56
On Thursday, November 22, 2012 9:09 PM Michal Nazarewicz wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:54 [+0100]:
During its lifetime, the mass storage can require creating lunX
directories for its luns. And again, with usbf_option
On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote:
Hello Michał,
Thanks for comments, I generally agree.
On Thursday, November 22, 2012 10:00 PM Michal Nazarewicz wrote:
snip
Then specific functions to be run follow, e.g.:
echo MassStorage /cfg/usb-function-gadget/G1/C1/F1/name
Why not
mkdir
On Thursday, November 22, 2012 10:07 PM Michal Nazarewicz wrote:
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote:
@@ -45,10 +46,9 @@
#define VLDBG(lun, fmt, args...) do { } while (0) #endif /*
VERBOSE_DEBUG */
-#define LDBG(lun, fmt, args...) dev_dbg ((lun)-dev, fmt, ## args)
On Thursday, November 22, 2012 11:00 PM Michal Nazarewicz wrote:
snip
+
+#define UFG_MODULE (UFG_SUBSYSTEM-subsys.su_group.cg_item.ci_type-
ct_owner)
I cannot seem to find UFG_SUBSYSTEM anywhere.
Because it is not here... It is exported from the usb_functions.c.
That's also why it
pre_eject and post_eject are not used by anyone. Removing them.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
drivers/usb/gadget/f_mass_storage.c | 15 +--
On 11/23/2012 02:22 PM, Andrzej Pietrasiewicz wrote:
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -1259,26 +1259,13 @@ static int do_start_stop(struct fsg_common *common)
if (!loej)
I don't know what loej does but it is unused now, isn't it?
On Fri, Nov 23, 2012 at 02:25:44PM +0100, Sebastian Andrzej Siewior wrote:
On 11/23/2012 02:22 PM, Andrzej Pietrasiewicz wrote:
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -1259,26 +1259,13 @@ static int do_start_stop(struct fsg_common *common)
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
Here is the incremental patch.
Thank you Greg !
Olivier
drivers/net/can/usb/kvaser_usb.c |
On Fri, Nov 23, 2012 at 02:30:28PM +0100, Olivier Sobrie wrote:
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
Here is the incremental
Hello,
I have a strange problem with embedded system I'm developing on. It is a
board with TI's DM365 SoC. It has 2514b 4-port hub connected to its usb
interface. It is running Linux in version 2.6.37 with TI patches, but I
tried also vanilla and another older or recent versions and the
On 11/23/2012 02:40 PM, Olivier Sobrie wrote:
On Fri, Nov 23, 2012 at 02:30:28PM +0100, Olivier Sobrie wrote:
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie
On Friday 23 November 2012 14:40:37 Jan Pohanka wrote:
I have tried to reproduce this behavior directly on my PC, but there it
works like a charm - at first I thought that the problem lies in cdc_acm
driver, but today I tried to desolder the hub and connect the USB modem
directly to the
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
---
drivers/net/can/usb/kvaser_usb.c | 111 --
1 file changed,
On 11/23/2012 02:54 PM, Olivier Sobrie wrote:
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier Sobrie oliv...@sobrie.be
Thanks, I've squashed it into the original patch
On Fri, Nov 23, 2012 at 03:08:08PM +0100, Marc Kleine-Budde wrote:
On 11/23/2012 02:54 PM, Olivier Sobrie wrote:
The dma buffer given to usb_bulk_msg() must be allocated and not on
the stack.
See Documentation/DMA-API-HOWTO.txt section What memory is DMA'able?
Signed-off-by: Olivier
Hi Alan,
did you ever recieve any feedback concerning the patch you wrote
the patch in the message mentioned above for? I am getting reports
from customers that it fixes issues with NVIDIA chipsets.
Regards
Oliver
--
To unsubscribe from this list: send the line
Hi,
in usb_unbind_interface() we call usb_cancel_queued_reset() before
restoring altsetting 0. This seems wrong to me. If a driver found it
necessary to reset a device we cannot simply ignore that. I'd say
that we should wait for the work to finish, not cancel it.
What do you say?
scsi_host_alloc() will zero our private data, no need to memset it.
Signed-off-by: Yan Hong clouds@gmail.com
---
drivers/usb/storage/usb.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 12aa726..31b3e1a 100644
---
On Thu, 22 Nov 2012, Piergiorgio Sartor wrote:
OK, I got a log with working and then non working system,
so there should be a transition,
Problem is, the file is 1.2MB, bizp2 reduces it to 200K.
How do I pass it to you?
You could post it on a web site, or put it on pastebin.com. Or you
On Wed, 21 Nov 2012, Chao Xie wrote:
From: Chao Xie chao@marvell.com
Signed-off-by: Chao Xie xiechao.m...@gmail.com
I don't like patches with no patch description. You should write
something here, explaining why the change is needed. What's wrong with
the clk APIs?
The same hold for
On Fri, Nov 23, 2012 at 10:39 PM, Oliver Neukum oneu...@suse.de wrote:
Hi,
in usb_unbind_interface() we call usb_cancel_queued_reset() before
restoring altsetting 0. This seems wrong to me. If a driver found it
necessary to reset a device we cannot simply ignore that. I'd say
that we should
On Fri, Nov 23, 2012 at 02:51:16PM +0800, Peter Chen wrote:
On Wed, Nov 21, 2012 at 03:06:31PM +0100, Michael Grzeschik wrote:
From: Marc Kleine-Budde m...@pengutronix.de
This patch adds support for a second and third clock to the usbmisc driver.
On
modern freescale ARM cores like the
On Fri, 23 Nov 2012, Felipe Balbi wrote:
Thanks for the example. The only problem is, how do we associate a
regulator to a specific port in the system.
heh, that's the 1 million dollar question, isn't it ? :-)
that's what we need to figure out now. Luckily we have Alan Stern
helping us
On Fri, 23 Nov 2012, Felipe Balbi wrote:
And maybe the same sort of scheme could be used for clocks, although I
don't know how to do it in a generic way that will work on all
platforms.
perhaps making use of pm_clk_add() and letting PM layer do the rest for
us ? If that doesn't work
On Fri, Nov 23, 2012 at 08:05:29PM +0900, Kyungmin Park wrote:
Hi,
-Original Message-
From: Sebastian Andrzej Siewior [mailto:bige...@linutronix.de]
Sent: Friday, November 23, 2012 7:17 PM
To: Michal Nazarewicz
Cc: Andrzej Pietrasiewicz; linux-usb@vger.kernel.org; 'Kyungmin
On Fri, 23 Nov 2012, Oliver Neukum wrote:
Hi,
in usb_unbind_interface() we call usb_cancel_queued_reset() before
restoring altsetting 0. This seems wrong to me. If a driver found it
necessary to reset a device we cannot simply ignore that. I'd say
that we should wait for the work to
On Fri, 23 Nov 2012, Oliver Neukum wrote:
Hi Alan,
did you ever recieve any feedback concerning the patch you wrote
the patch in the message mentioned above for? I am getting reports
from customers that it fixes issues with NVIDIA chipsets.
You mean the patch I posted on Oct. 9? No, no
On Thu, 22 Nov 2012, Chris Holland wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=50821
Summary: Mouse and keyboard freeze Ivy-bridge
I have been having the problem of the mouse and keyboard freezing since
upgrading my system in May 2012
GIGABYTE GA-Z77X-UD5H LGA 1155 Intel Z77
On Wed, 21 Nov 2012, Sarah Sharp wrote:
A device may need to be reset several times during enumeration, and this
causes a disconnect between the USB core's device state and the xHC's
device state.
For example, usb_reset_and_verify_device calls into hub_port_init in a
loop. Say that on the
On Wed, 21 Nov 2012, Sarah Sharp wrote:
USB 3.0 hubs and roothubs will automatically transition a failed hot
reset to a warm (BH) reset. In that case, the warm reset change bit
will be set, and the link state change bit may also be set. Change
hub_port_finish_reset to unconditionally clear
On Wed, 21 Nov 2012, Sarah Sharp wrote:
The USB core disables the USB 2.0 ports in several different error
cases. It expects that all USB hubs will act like external hubs, and
always return an interrupt event if a port change bit is set. External
USB 2.0 and USB 3.0 hubs are
On Wed, 21 Nov 2012, Sarah Sharp wrote:
The port reset code bails out early if the current connect status is
cleared (device disconnected). If we're issuing a hot reset, it may
also look at the link state before the reset is finished.
Section 10.14.2.6 of the USB 3.0 spec says that when a
On Wed, 21 Nov 2012, Sarah Sharp wrote:
Hi Alan,
Can you take a look over this patchset to improve reset support under
xHCI roothubs?
There's a lot of changes here, but I tried to break it up into easily
verifiable chunks. I'd like to backport all the patches except the last
one to
From: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com
Date: Thu, 22 Nov 2012 08:35:17 +0100
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com
Applied to net-next.
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to
this is v4 of the gadget interface.
v1. first version
v2. converted all ACM users
v3. removed the generic configuration. This will be added once we have
configfs.
v4. changes based on feedback I received:
- renamed usb_d_function to usb_function_driver
- removed the typedef of function. I
Lets assume nokia_bind() starts with return -EINVAL. After loading the
gadget we end up with:
|udc dummy_udc.0: registering UDC driver [g_nokia]
|BUG: unable to handle kernel NULL pointer dereference at 0040
|IP: [c11f9555] __list_add+0x25/0xf0
|Call Trace:
| [c12d4e21]
f_loopback should only include the bare function but it also includes
the config descriptor. This patch moves the config descriptor into
zero.c, the only user of this function.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/f_loopback.c | 44
This patch provides an infrastructure to register unregister a USB
function. This allows to turn a function into a module and avoid the
'#include f_.*.c' magic and we get a clear API / cut between the bare
gadget and its functions.
The concept is simple:
Each function defines the
The significant part of this function was removed in 90f7976 (USB:
Remove unsupported usb gadget drivers). I would move this to function
bind time but I don't see the point in moving an empty function.
Therefore bye bye.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
This patch factors out the three possible functions into three possible
bind functions which are passed as an argument to usb_add_config(). This
will ease the step by step converting of the individual functions to the
new function registration method.
Signed-off-by: Sebastian Andrzej Siewior
This patch converts the f_sourcesink and f_loopback file to the USB-function
module. Both functions shares a few common utility functions which are
currently implemented in g_zero.c itself. This patch moves the common
code into the sourcesink file and creates one module out of the the two
Every user of u_serial has now to select the U_SERIAL symbol instead of
including the file.
There is one limition with this: ports and and gs_tty_driver are global
variables in u_serial. Since all users share them, there can be only one
user loaded at a time i.e. either g_serial or g_nokia.
f_sourcesink should only include the bare function but it also includes
the config descriptor. This patch moves the config descriptor into
zero.c, the only user of this function.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/f_sourcesink.c | 48
The setup request can be sent to an interface/endpoint or to the device
itself. If it is sent to an interface / endpoint then we forward it to
the function that is mapped to that interface / endpoint.
If the device is the target of the setup request then we forward it to the
-setup() callback of
This will be used to remove a single function from a given config. Right
now ignore that an error at -bind() time and cleanup later during
composite_unbind() / remove_config().
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/composite.c | 12
This patch converts f_acm into a module which uses the new function
interface. It also converts one of its users that is g_serial to make
use of it. The other users of it (g_nokia for instance) are still using
the old include file system and should not notice the change at all. So
they can be
This patch converts the acm_ms gadget to make use of the function
framework to request the ACM function.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/multi.c | 47 ++--
2 files
This patch converts the acm_ms gadget to make use of the function
framework to request the ACM function.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/acm_ms.c | 21 ++---
2 files changed, 15
This patch converts the acm_ms gadget to make use of the function
framework to request the ACM function.
With nokia beeing the last user of the include interface, it is gone
now.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/Kconfig|1 +
This patch converts the acm_ms gadget to make use of the function
framework to request the ACM function.
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/cdc2.c | 17 -
2 files changed, 13 insertions(+),
On 11/24/12 00:25, the mail apparently from Alan Stern included:
On Fri, 23 Nov 2012, Felipe Balbi wrote:
Thanks for the example. The only problem is, how do we associate a
regulator to a specific port in the system.
heh, that's the 1 million dollar question, isn't it ? :-)
that's what we
On Fri, Nov 23, 2012 at 11:03 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 22 Nov 2012, Chris Holland wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=50821
Summary: Mouse and keyboard freeze Ivy-bridge
I have been having the problem of the mouse and keyboard freezing since
This driver was removed by commit 68a5059 (block: remove the deprecated
ub driver).
Cc: Pete Zaitcev zait...@redhat.com
Cc: linux-usb@vger.kernel.org
Signed-off-by: Cesar Eduardo Barros ces...@cesarb.net
---
MAINTAINERS | 6 --
1 file changed, 6 deletions(-)
diff --git a/MAINTAINERS
71 matches
Mail list logo
