RE: Root hub autosusend delay

2013-01-23 Thread Chen Peter-B29397
Add rpm trace log for log 1, the coming behavior is expected, the usb subsystem will enters low power mode again. root@freescale ~$ cat /sys/kernel/debug/tracing/trace # tracer: nop # # entries-in-buffer/entries-written: 156/156 #P:4 # # _-=> irqs-off #

[PATCH 0/2] drivers/usb/host/uhci-*: fix memory flow bug and beautify source code

2013-01-23 Thread Chen Gang
PATCH 1/2: check buffer length to avoid memory overflow PATCH 2/2: beautify source code "PATCH 2/2" is made based on "PATCH 1/2" please apply "PATCH 1/2" firstly, and then apply "PATCH 2/2" total stat (2 patches together): --- drivers/usb/host/uhci-debug.c | 178

[PATCH 1/2] drivers/usb/host/uhci-* : check buffer length to avoid memory overflow

2013-01-23 Thread Chen Gang
for function uhci_sprint_schedule: the buffer len is MAX_OUTPUT: 64 * 1024, which may not be enough: may loop UHCI_NUMFRAMES times (UHCI_NUMFRAMES is 1024) each time of loop may get more than 64 bytes so need check the buffer length to avoid memory overflow this patch fix

[PATCH 2/2] drivers/usb/host/uhci-*: beautify source code

2013-01-23 Thread Chen Gang
get rid of the line breaks in string constants. let comments within 80 with limitation. delete ' \' at the end of a statement. Signed-off-by: Chen Gang --- drivers/usb/host/uhci-debug.c | 28 drivers/usb/host/uhci-hcd.c | 27 +--

[PATCH] usb:musb: musbhsdma: change the number of dma channels according to hardware configuration

2013-01-23 Thread yingchun li
According to "musbhdrd usb 2.0 high-speed dual-role controller Product Specification" the number of dma channels can be read from register RAMINFO. it is not always that number of dma channels is MUSB_HSDMA_CHANNELS, some SOC may have little dma channels(for my chip, it only has 4 channel). Signed

Re: Root hub autosusend delay

2013-01-23 Thread Ming Lei
Hi Peter, On Wed, Jan 23, 2013 at 2:15 PM, Peter Chen wrote: > Hi Ming, I also find this problem at my platform. > (At chipidea controller, the resume signal will be ended about 21ms > automatically) > > Neither delay 30ms at hub_events, nor revert your patch > (596d789a211d134dc5f94d1e5957248c2

Re: [PATCH v2] usb: phy: moving all PHY API definitions to usb/phy directory

2013-01-23 Thread Roger Quadros
On 01/23/2013 01:56 AM, Venu Byravarasu wrote: >> -Original Message- >> From: Roger Quadros [mailto:rog...@ti.com] >> Sent: Tuesday, January 22, 2013 7:51 PM >> To: Venu Byravarasu >> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; >> linux-ker...@vger.kernel.org >>

Re: Root hub autosusend delay

2013-01-23 Thread Peter Chen
On Wed, Jan 23, 2013 at 04:44:54PM +0800, Ming Lei wrote: > Hi Peter, > > On Wed, Jan 23, 2013 at 2:15 PM, Peter Chen wrote: > > Hi Ming, I also find this problem at my platform. > > (At chipidea controller, the resume signal will be ended about 21ms > > automatically) > > > > Neither delay 30ms

[PATCH] USB: option: add and update Alcatel modems

2013-01-23 Thread Bjørn Mork
Adding three currently unsupported modems based on information from .inf driver files: Diag VID_1BBB&PID_0052&MI_00 AGPS VID_1BBB&PID_0052&MI_01 VOICE VID_1BBB&PID_0052&MI_02 ATVID_1BBB&PID_0052&MI_03 Modem VID_1BBB&PID_0052&MI_05 wwan VID_1BBB&PID_0052&MI_06 Diag VID_1BBB&P

Re: [PATCH 1/2] usb: host: tegra: don't touch EMC clock

2013-01-23 Thread Lucas Stach
Am Mittwoch, den 23.01.2013, 12:25 +0530 schrieb Venu Byravarasu: > > -Original Message- > > From: linux-tegra-ow...@vger.kernel.org [mailto:linux-tegra- > > ow...@vger.kernel.org] On Behalf Of Stephen Warren > > Sent: Wednesday, January 23, 2013 5:58 AM > > To: Alan Stern; Greg Kroah-Hartm

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: > Felipe Balbi wrote: > > Hi, > > > Hi Felipe, > > [...] > > > > Right, DWC has version number, but that being the kind of USB controller > > > (USB 2.0 and USB 3.0) > > > > > > DWC2: USB High Speed controller (as also indicated in

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread Felipe Balbi
Hi, On Wed, Jan 23, 2013 at 03:10:50PM +0800, victor yeo wrote: > >> >> Ok, rephrase the question, is this the flow for bulk transfer? > >> >> > >> >> 1) data is received by Usb mass storage HW, the UDC driver ISR is > >> >> called to read the data to usb_request buffer > >> >> 2) bulk_out_complet

Re: Root hub autosusend delay

2013-01-23 Thread Ming Lei
On Wed, Jan 23, 2013 at 5:38 PM, Peter Chen wrote: > Hi Ming, > > As I can't apply your patch directly, I just try below code. > It works, no "hub 1-0:1.0: hub_suspend" is called. > >> init2: >> + if (type == HUB_RESUME) { >> + /* root hub is sending resume signal, so wait for it

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread victor yeo
Hi, >> >> >> Ok, rephrase the question, is this the flow for bulk transfer? >> >> >> >> >> >> 1) data is received by Usb mass storage HW, the UDC driver ISR is >> >> >> called to read the data to usb_request buffer >> >> >> 2) bulk_out_complete() in gadget driver, is called to set buffer state >>

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread Felipe Balbi
Hi, On Wed, Jan 23, 2013 at 06:04:55PM +0800, victor yeo wrote: > Hi, > > >> >> >> Ok, rephrase the question, is this the flow for bulk transfer? > >> >> >> > >> >> >> 1) data is received by Usb mass storage HW, the UDC driver ISR is > >> >> >> called to read the data to usb_request buffer > >> >

[PATCH v9 09/20] mfd: omap-usb-tll: serialize access to TLL device

2013-01-23 Thread Roger Quadros
Get rid of the unnecessary spin_lock_irqsave/restore() as there is no interrupt handler for this driver. Instead we serialize access to tll_dev using a global spinlock. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 53 ++---

[PATCH v9 19/20] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

2013-01-23 Thread Roger Quadros
clk_set_parent is expected to fail on OMAP3 platforms. We don't consider that as fatal so don't spam console. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/

[PATCH v9 20/20] mdf: omap-usb-host: get rid of build warning

2013-01-23 Thread Roger Quadros
Fixes the below build warning when driver is built-in. drivers/mfd/omap-usb-host.c:750:12: warning: ‘usbhs_omap_remove’ defined but not used [-Wunused-function] Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH v9 18/20] mfd: omap-usb-host: clean up omap_usbhs_init()

2013-01-23 Thread Roger Quadros
We split initializing revision 1 and revision 2 into different functions. Initialization is now done dynamically so that only the number of ports available on the system are initialized. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 129 ++

[PATCH v9 14/20] mfd: omap-usb-host: override number of ports from platform data

2013-01-23 Thread Roger Quadros
Both OMAP4 and 5 exhibit the same revision ID in the REVISION register but they have different number of ports i.e. 2 and 3 respectively. So we can't rely on REVISION register for number of ports on OMAP5 and depend on platform data (or device tree) instead. Signed-off-by: Roger Quadros Reviewed-

[PATCH v9 16/20] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-23 Thread Roger Quadros
Enable the optional HSIC clocks (60MHz and 480MHz) for the ports that are configured in HSIC mode. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 97 -- 1 files changed, 83 insertions(+), 14 deletions(-) diff -

[PATCH v9 17/20] mfd: omap-usb-host: Get rid of unnecessary spinlock

2013-01-23 Thread Roger Quadros
The driver does not have an interrupt handler and we don't really need a spinlock, so get rid of it. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 16 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/omap-u

[PATCH v9 15/20] mfd: omap-usb-host: cleanup clock management code

2013-01-23 Thread Roger Quadros
All ports have similarly named port clocks so we can bunch them into a port data structure and use for loop to enable/disable the clocks. Dynamically allocate and get clocks based on number of ports available on the platform Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mf

[PATCH v9 12/20] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap()

2013-01-23 Thread Roger Quadros
Use devm_ variants of kzalloc and ioremap. Also clean up error path. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 38 +++--- 1 files changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c

[PATCH v9 02/20] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-23 Thread Roger Quadros
Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board data, one for USB Host (UHH) module and one for USB-TLL module. This makes the code much simpler and avoids creating multiple copies of platform data. CC:

[PATCH v9 07/20] mfd: omap-usb-tll: Check for missing platform data in probe

2013-01-23 Thread Roger Quadros
No need to check for missing platform data in runtime_suspend/resume as it makes more sense to do it in the probe function. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git

[PATCH v9 08/20] mfd: omap-usb-tll: Fix error message

2013-01-23 Thread Roger Quadros
omap_enable/disable_tll() can fail if TLL device is not initialized. It could be due to multiple reasons and not only due to missing platform data. Also make local variables static and use 'struct device *' instead of 'struct platform_device *' for global reference. Signed-off-by: Roger Quadros

[PATCH v9 10/20] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support

2013-01-23 Thread Roger Quadros
The TLL module on OMAP5 has 3 channels. HSIC mode requires the TLL channel to be in Transparent UTMI mode. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/oma

[PATCH v9 13/20] mfd: omap-usb-host: know about number of ports from revision register

2013-01-23 Thread Roger Quadros
The revision register should tell us how many ports are present. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 33 - 1 files changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers

[PATCH v9 11/20] mfd: omap_usb_host: Avoid missing platform data checks in suspend/resume

2013-01-23 Thread Roger Quadros
Get rid of the unnecessary missing platform data checks in runtime_suspend/resume. We are already checking for missing platform data in probe. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions

[PATCH v9 06/20] mfd: omap-usb-tll: introduce and use mode_needs_tll()

2013-01-23 Thread Roger Quadros
This is a handy macro to check if the port requires the USB TLL module or not. Use it to Enable the TLL module and manage the clocks. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 20 1 files changed, 12 insertions(+), 8 deletions

[PATCH v9 05/20] mfd: omap-usb-tll: Clean up clock handling

2013-01-23 Thread Roger Quadros
Every channel has a functional clock that is similarly named. It makes sense to use a for loop to manage these clocks as OMAPs can come with up to 3 channels. Dynamically allocate and get channel clocks depending on the number of clocks avaiable on the platform. Signed-off-by: Roger Quadros Revi

[PATCH v9 04/20] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path

2013-01-23 Thread Roger Quadros
Use devm_ variants of kzalloc() and ioremap(). Simplify the error path. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 38 -- 1 files changed, 12 insertions(+), 26 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.

[PATCH v9 01/20] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-23 Thread Roger Quadros
This driver does not request any gpios so don't free them. Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd with ehci-omap in use. Without this patch, EHCI will break on repeated insmod/rmmod of ehci_hcd for all OMAP2+ platforms that use EHCI and set 'phy_reset = true' in usbhs_omap_board

[PATCH v9 00/20] OMAP USB Host cleanup

2013-01-23 Thread Roger Quadros
Hi Samuel, I think this series is in a pretty good shape to pull now :). I've added Reviewed-by and Acked-by tags. You can please pull from below. NOTE: the first patch is a stable fix so Greg KH might want to pick it up for 3.8-rc. The following changes since commit 7d1f9aeff1ee4a20b1aeb377dd0

[PATCH v9 03/20] mfd: omap-usb-tll: Fix channel count detection

2013-01-23 Thread Roger Quadros
Fix channel count detecion for REV2. Also, don't give up if we don't recognize the IP Revision. We assume the default number of channels (i.e. 3) for unrecognized IPs. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 20 +++- 1 files chan

[PATCH net] net: cdc_mbim: send ZLP only for the specific buggy device

2013-01-23 Thread Bjørn Mork
Reverting 328d7b8 and instead adding an exception for the Sierra Wireless MC7710. commit 328d7b8 (net: cdc_mbim: send ZLP after max sized NTBs) added a workaround for an issue observed on one specific device. Concerns were raised that this workaround adds a performance penalty to all devices based

RE: [PATCH] usb: musb: fix context save over suspend.

2013-01-23 Thread Bilovol, Ruslan
Hi, I faced the same issue on OMAP4 and made similar fix a week ago: http://review.omapzoom.org/31700 but in this patch I also check is the MUSB is already suspended (so the context is already saved) in .suspend callback so reading/writing to MUSB register is more safe. It is almost same soluti

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread victor yeo
Hi, >> >> In fsg_dev structure, there are 3 usb_ep: bulk_in, bulk_out, and >> >> intr_in. Why is the intr_out endpoint not defined? >> > >> > because it's not needed. Read the USB Mass Storage Class specification >> > from usb.org >> >> Ok. In the gadget driver, it keeps on receiving the same bulk

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread Felipe Balbi
Hi, On Wed, Jan 23, 2013 at 07:17:44PM +0800, victor yeo wrote: > >> >> In fsg_dev structure, there are 3 usb_ep: bulk_in, bulk_out, and > >> >> intr_in. Why is the intr_out endpoint not defined? > >> > > >> > because it's not needed. Read the USB Mass Storage Class specification > >> > from usb.o

Re: [PATCH v2 2/4] ARM: OMAP: devices: create device for usb part of control module

2013-01-23 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 07:38:26PM +0530, Kishon Vijay Abraham I wrote: > A seperate driver has been added to handle the usb part of control > module. A device for the above driver is created here, using the register > address information to be used by the driver for powering on the PHY and >

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread victor yeo
Hi, >> >> Ok. In the gadget driver, it keeps on receiving the same bulk_out >> >> data, maybe because the data is not processed. The get_next_command is >> >> not called. >> >> >> >> g_file_storage gadget: bulk-out, length 31: >> >> : 55 53 42 43 38 b5 ea 86 24 00 00 00 80 00 06 12 >> >> 0

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread Felipe Balbi
Hi, On Wed, Jan 23, 2013 at 07:35:41PM +0800, victor yeo wrote: > Hi, > > >> >> Ok. In the gadget driver, it keeps on receiving the same bulk_out > >> >> data, maybe because the data is not processed. The get_next_command is > >> >> not called. > >> >> > >> >> g_file_storage gadget: bulk-out, len

[PATCH 0/9] Towards configfs in mass storage

2013-01-23 Thread Andrzej Pietrasiewicz
The prerequisite for providing the configfs interface for mass storage and all its users is converting them to the new function interface from Sebastian. This patch series serves the purpose stated above. The plan for the conversion is as follows: - identify all users of mass storage (acm_ms, ma

[PATCH 1/9] usb/gadget: create utility for mass_storage

2013-01-23 Thread Andrzej Pietrasiewicz
This aims at making f_mass_storage.c a module. But first we need to get rid of "#include "storage_common.c". This patch makes mass_storage.c a separately compiled file, which is built as a utility module named u_ms.ko. After all mass storage users are converted to the new function interface this mo

[PATCH 2/9] usb/gadget: allow not clearing the memory for struct fsg_common

2013-01-23 Thread Andrzej Pietrasiewicz
This patch is needed to prepare for using the new function interface. The memory for struct fsg_common can either be provided by the mass storage user, or it can be allocated by mass storage. With the new function interface it will be provided by the mass storage user. The new function interface u

[PATCH 5/9] usb/gadget: convert acm_ms to new function interface

2013-01-23 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/acm_ms.c | 78 --- 2 files changed, 45 insertions(+), 34 deletions(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/ga

[PATCH 8/9] usb/gadget: remove compatibility layer for f_mass_storage

2013-01-23 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_mass_storage.c | 66 --- 1 files changed, 0 insertions(+), 66 deletions(-) diff --gi

[PATCH 3/9] usb/gadget: create header file for f_mass_storage

2013-01-23 Thread Andrzej Pietrasiewicz
In order to prepare for the new function interface the f_mass_storage.c needs to be compiled as a module, and so a header file will be required. This patch factors out some code to a new f_mass_storage.h. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f

[PATCH 9/9] usb/gadget: merge mass storage utility object with f_mass_storage object

2013-01-23 Thread Andrzej Pietrasiewicz
The u_ms.ko utility module is now used only by the f_mass_storage.ko module, so there is no point in splitting the code into two modules. This patch merges the two into one while keeping their corresponing source code files compiled separately. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by:

[PATCH 7/9] usb/gadget: convert multi to new function interface

2013-01-23 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/multi.c | 69 +++- 2 files changed, 50 insertions(+), 20 deletions(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gad

[PATCH 4/9] usb/gadget: convert f_mass_storage to new function interface with backward compatibility

2013-01-23 Thread Andrzej Pietrasiewicz
Converting mass storage to the new function interface requires converting the USB mass storage's function code and its users. This patch converts the f_mass_storage.c to the new function interface. The file is now compiled into a separate f_ms.ko module. The old function interface is provided by me

[PATCH 6/9] usb/gadget: convert mass_storage to new function interface

2013-01-23 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig|1 + drivers/usb/gadget/mass_storage.c | 118 +++- 2 files changed, 76 insertions(+), 43 deletions(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/u

Re: [V4 PATCH 18/26] usb: phy: mv_usb2_phy: add externel chip support

2013-01-23 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 10:51:32AM +0800, Chao Xie wrote: > On Mon, Jan 21, 2013 at 11:51 PM, Russell King - ARM Linux > wrote: > > On Mon, Jan 21, 2013 at 05:07:36AM -0500, Chao Xie wrote: > >> + mv_phy->extern_chip.head = devm_kzalloc(&pdev->dev, > >> +

Re: [V4 PATCH 00/26] mv-usb fix and enhancement patches

2013-01-23 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 05:07:18AM -0500, Chao Xie wrote: > The patches are divied into 4 parts > 1. bug fixes > usb: gadget: mv_udc: use udc_start and udc_stop functions > usb: gadget: mv_udc: use devm_xxx for probe > usb: gadget: mv_udc: fix the warning of mv_udc_remove > usb: otg: m

USB3 host dying on SIGKILL

2013-01-23 Thread Frank Lömker
Hello, We have a somewhat UVC compliant USB2 camera connected to a USB3 port. It works mostly great. But when we SIGKILL the program which opened the device, the corresponding host controller dies and the system must be rebooted to access the USB port again. If the program closes the device normal

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi all, On Wed, Jan 23, 2013 at 3:20 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: >> Felipe Balbi wrote: >> > Hi, >> > >> Hi Felipe, >> >> [...] >> >> > > Right, DWC has version number, but that being the kind of USB controller >> > > (USB 2.0 and

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread victor yeo
Hi, >> >> In my udc driver, i set the req->length to the number of bytes i >> >> received from HW, which is 31 bytes. Is it necessary to do that? How >> > >> > you shouldn't touch req->lenght, you should only update req->actual. >> > req->length is readonly for the UDC. >> > >> >> to know the gadg

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Sylwester Nawrocki
Hi, On 01/23/2013 01:20 PM, Vivek Gautam wrote: > - { .compatible = "samsung,exynos-dwc3" }, > + { .compatible = "samsung,synopsis-dwc3" } You're both missing a point here. The synopsys IP driver is called dwc3.ko and that's compatible with synopsys,dwc3. Your glue l

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread Felipe Balbi
Hi, On Wed, Jan 23, 2013 at 08:24:36PM +0800, victor yeo wrote: > >> >> In my udc driver, i set the req->length to the number of bytes i > >> >> received from HW, which is 31 bytes. Is it necessary to do that? How > >> > > >> > you shouldn't touch req->lenght, you should only update req->actual. >

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-23 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam wrote: > Hi Tomasz, > > > On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa wrote: >> Hi Vivek, >> >> Don't you need also some clkdev lookup entry to make the clock available >> in the driver? >> > > This clock source we added with a motive of

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi Sylwester, On Wed, Jan 23, 2013 at 6:10 PM, Sylwester Nawrocki wrote: > Hi, > > On 01/23/2013 01:20 PM, Vivek Gautam wrote: >> - { .compatible = "samsung,exynos-dwc3" }, >> + { .compatible = "samsung,synopsis-dwc3" } > > You're both missing a point here. The synopsys I

RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-23 Thread Mohammed, Afzal
Hi Koen, On Tue, Jan 22, 2013 at 22:32:56, Koen Kooi wrote: > Actually it uses nop-phy as a phy, which is missing from > arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the > nop-phy to the DT is easy enough to patch in locally. USB first instance of am335x works in m

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-23 Thread kishon
Hi Afzal, On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: Hi Koen, On Tue, Jan 22, 2013 at 22:32:56, Koen Kooi wrote: Actually it uses nop-phy as a phy, which is missing from arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the nop-phy to the DT is easy

[Resend PATCH 1/2] usb: Using correct way to clear usb3.0 device's remote wakeup feature.

2013-01-23 Thread Lan Tianyu
Usb3.0 device defines function remote wakeup which is only for interface recipient rather than device recipient. This is different with usb2.0 device's remote wakeup feature which is defined for device recipient. According usb3.0 spec 9.4.5, the function remote wakeup can be modified by the SetFeat

[Resend PATCH 2/2] usb: add usb_enable/disable_remote_wakeup()

2013-01-23 Thread Lan Tianyu
usb2.0 and usb3.0 devices have different ways to enalbe/disable remote wakeup. This patch is to put both their operations into the seperate functions. Otherwise, usb_control_msg() has some long arguments and are usually nested some indentations. So encapsulating it into seperate functions would be

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread victor yeo
Hi, >> Here are the last two setup data and CBW data received. the >> get_next_command() is not called when CBW data is received. the >> bulk_out_complete() wakes up the thread, however, get_next_command() >> still sleeps. i do not see where req->length is checked in gadget >> driver. >> >> g_file

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-23 Thread Alan Stern
On Tue, 22 Jan 2013, Sascha Hauer wrote: > On Tue, Jan 22, 2013 at 03:38:55PM +, Arnd Bergmann wrote: > > On Tuesday 22 January 2013, Alan Stern wrote: > > > In order to prevent this, you have to make sure that each glue driver > > > depends on USB_ARCH_HAS_EHCI. A simple way to do this is to

Re: [PATCH 1/2] usb: host: tegra: don't touch EMC clock

2013-01-23 Thread Alan Stern
On Tue, 22 Jan 2013, Stephen Warren wrote: > From: Stephen Warren > > Clock "emc" is for the External Memory Controller. The USB driver has no > business touching this clock directly. Remove the code that does so. > > Signed-off-by: Stephen Warren > --- > Greg, Alan, I'd like to take this patc

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, victor yeo wrote: > In my udc driver, i set the req->length to the number of bytes i > received from HW, which is 31 bytes. Is it necessary to do that? How > to know the gadget driver queued 0-bytes? By > bh->bulk_out_intended_length ? Victor, it sounds like you haven't read

[PATCH v2 1/3] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-01-23 Thread Ezequiel Garcia
The Armada 370 and Armada XP SoC has an Orion EHCI USB controller. This patch adds support for this controller in Armada 370 and Armada XP SoC common device tree files. Cc: Lior Amsalem Cc: Thomas Petazzoni Tested-by: Nobuhiro Iwamatsu Tested-by: Florian Fainelli Signed-off-by: Gregory CLEMENT

Re: [PATCH v9 00/20] OMAP USB Host cleanup

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, Roger Quadros wrote: > Hi Samuel, > > I think this series is in a pretty good shape to pull now :). I've added > Reviewed-by and Acked-by tags. You can please pull from below. > > NOTE: the first patch is a stable fix so Greg KH might want to pick it up for > 3.8-rc. > > T

[PATCH v2 3/3] arm: mvebu: Update defconfig to select USB support

2013-01-23 Thread Ezequiel Garcia
Cc: Lior Amsalem Cc: Thomas Petazzoni Cc: Gregory CLEMENT Tested-by: Nobuhiro Iwamatsu Tested-by: Florian Fainelli Signed-off-by: Ezequiel Garcia --- arch/arm/configs/mvebu_defconfig |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/configs/mvebu_defconfig

[PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

2013-01-23 Thread Ezequiel Garcia
This patch activates every USB port provided by each SoC. Except for Armada XP Openblocks AX3-4 board, where we enable only the first two USB ports until we have more information on the third one usage. Cc: Lior Amsalem Cc: Thomas Petazzoni Cc: Gregory CLEMENT Tested-by: Nobuhiro Iwamatsu Test

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, victor yeo wrote: > Here are the last two setup data and CBW data received. the > get_next_command() is not called when CBW data is received. the It's not supposed to be _called_; it's supposed to be _woken up_. > bulk_out_complete() wakes up the thread, however, get_next_co

Re: Root hub autosusend delay

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, Peter Chen wrote: > On Tue, Jan 22, 2013 at 03:08:27PM -0500, Alan Stern wrote: > > Lei: > > > > It turns out that your patch setting the autosuspend delay for hubs to > > 0 causes problems for root hubs. They need a delay of at least 30 ms. > > > > When a child device send

Re: Root hub autosusend delay

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, Ming Lei wrote: > On Wed, Jan 23, 2013 at 4:08 AM, Alan Stern wrote: > > Lei: > > > > It turns out that your patch setting the autosuspend delay for hubs to > > 0 causes problems for root hubs. They need a delay of at least 30 ms. > > > > When a child device sends a remote w

Re: USB subsystem stops working

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, Norbert Preining wrote: > Hi Alan, > > On Di, 22 Jan 2013, Alan Stern wrote: > > It looks like things may improve if you do > > > > echo 50 >/sys/bus/usb/devices/usb1/power/autosuspend_delay_ms > > > I did some testing over here. It looks like in addition to increasing

Re: [PATCH 1/2] usb: host: tegra: don't touch EMC clock

2013-01-23 Thread Stephen Warren
On 01/23/2013 02:45 AM, Lucas Stach wrote: > Am Mittwoch, den 23.01.2013, 12:25 +0530 schrieb Venu Byravarasu: >>> -Original Message- >>> From: linux-tegra-ow...@vger.kernel.org [mailto:linux-tegra- >>> ow...@vger.kernel.org] On Behalf Of Stephen Warren >>> Sent: Wednesday, January 23, 2013

Re: [Resend PATCH 2/2] usb: add usb_enable/disable_remote_wakeup()

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, Lan Tianyu wrote: > usb2.0 and usb3.0 devices have different ways to enalbe/disable > remote wakeup. This patch is to put both their operations into > the seperate functions. Otherwise, usb_control_msg() has some > long arguments and are usually nested some indentations. So >

Re: [PATCH 1/2] drivers/usb/host/uhci-* : check buffer length to avoid memory overflow

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, Chen Gang wrote: > for function uhci_sprint_schedule: > the buffer len is MAX_OUTPUT: 64 * 1024, which may not be enough: > may loop UHCI_NUMFRAMES times (UHCI_NUMFRAMES is 1024) > each time of loop may get more than 64 bytes > so need check the buffer le

Re: [PATCH 2/2] ARM: tegra: add clocks properties to USB PHY nodes

2013-01-23 Thread Stephen Warren
On 01/22/2013 11:43 PM, Venu Byravarasu wrote: > Stephen Warren wrote at Wednesday, January 23, 2013 6:03 AM: >> On 01/22/2013 05:28 PM, Stephen Warren wrote: >>> The patch to add USB PHY nodes to device tree was written before Tegra >>> supported the clocks property in device tree. Now that it doe

Re: USB subsystem stops working

2013-01-23 Thread Ming Lei
On Thu, Jan 24, 2013 at 12:08 AM, Alan Stern wrote: > > Not increasing the delay explains why you got all those "suspend failed > because a port is resuming" messages. Alan, looks the "suspend failed because a port is resuming" messages" is nothing to do with the autosuspend delay, and increase t

Re: [PATCH 2/2] drivers/usb/host/uhci-*: beautify source code

2013-01-23 Thread Alan Stern
On Wed, 23 Jan 2013, Chen Gang wrote: > > get rid of the line breaks in string constants. > let comments within 80 with limitation. > delete ' \' at the end of a statement. > > Signed-off-by: Chen Gang This is good except for... > --- a/drivers/usb/host/uhci-hub.c > +++ b/drivers/usb/ho

Re: Linux USB file storage gadget with new UDC

2013-01-23 Thread Felipe Balbi
Hi, On Wed, Jan 23, 2013 at 11:20:56PM +0800, victor yeo wrote: > Hi, > > >> Here are the last two setup data and CBW data received. the > >> get_next_command() is not called when CBW data is received. the > >> bulk_out_complete() wakes up the thread, however, get_next_command() > >> still sleeps

Re: Root hub autosusend delay

2013-01-23 Thread Ming Lei
On Thu, Jan 24, 2013 at 12:02 AM, Alan Stern wrote: > > Other strange things seem to be happening. Take a look at the log just > posted by Norbert Preining: > > http://www.preining.info/usb-syslog-prob.txt > > Starting at timestamp 400.570029, the external hub and root hub go into > a str

Re: [PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

2013-01-23 Thread Ezequiel Garcia
Hi Nobuhiro, On Wed, Jan 23, 2013 at 12:26 PM, Ezequiel Garcia wrote: > This patch activates every USB port provided by each SoC. > Except for Armada XP Openblocks AX3-4 board, > where we enable only the first two USB ports > until we have more information on the third one usage. > > Cc: Lior Ams

Re: [PATCH v2 1/3] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-01-23 Thread Ezequiel Garcia
Jason, On Wed, Jan 23, 2013 at 12:26 PM, Ezequiel Garcia wrote: > The Armada 370 and Armada XP SoC has an Orion EHCI USB controller. > This patch adds support for this controller in Armada 370 > and Armada XP SoC common device tree files. > > Cc: Lior Amsalem > Cc: Thomas Petazzoni > Tested-by:

Re: [PATCH v2 1/3] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-01-23 Thread Jason Cooper
On Wed, Jan 23, 2013 at 02:06:12PM -0300, Ezequiel Garcia wrote: > Jason, > > On Wed, Jan 23, 2013 at 12:26 PM, Ezequiel Garcia > wrote: > > The Armada 370 and Armada XP SoC has an Orion EHCI USB controller. > > This patch adds support for this controller in Armada 370 > > and Armada XP SoC comm

[PATCH] USB: misc: usb3503: add dt support

2013-01-23 Thread Dongjin Kim
Added device tree support for usb3503 driver and add new document with device tree binding information. Signed-off-by: Dongjin Kim --- Documentation/devicetree/bindings/usb/usb3503.txt | 20 + drivers/usb/misc/usb3503.c| 31 + 2 files

Re: [PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

2013-01-23 Thread Thomas Petazzoni
Dear Ezequiel Garcia, On Wed, 23 Jan 2013 14:04:42 -0300, Ezequiel Garcia wrote: > from the OpenBlocks AX3-4 board dts file, since you mentioned this > board uses that USB > port for a PCIe connector -- if I understood correctly. No. The OpenBlocks has a different USB controller that sits on the

Re: [PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

2013-01-23 Thread Ezequiel Garcia
Hi Thomas, On Wed, Jan 23, 2013 at 3:03 PM, Thomas Petazzoni wrote: > On Wed, 23 Jan 2013 14:04:42 -0300, Ezequiel Garcia wrote: > >> from the OpenBlocks AX3-4 board dts file, since you mentioned this >> board uses that USB >> port for a PCIe connector -- if I understood correctly. > > No. The Op

Re: USB subsystem stops working

2013-01-23 Thread Alan Stern
On Thu, 24 Jan 2013, Ming Lei wrote: > On Thu, Jan 24, 2013 at 12:08 AM, Alan Stern > wrote: > > > > Not increasing the delay explains why you got all those "suspend failed > > because a port is resuming" messages. > > Alan, looks the "suspend failed because a port is resuming" messages" > is n

Re: USB3 Not Being Detected on Intel DX79TO Desktop Board

2013-01-23 Thread Robert Dvoracek
02:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host Controller (rev 04) Subsystem: Intel Corporation Device 4953 On Wed, Jan 23, 2013 at 12:28 AM, Greg KH wrote: > On Wed, Jan 23, 2013 at 12:19:41AM -0500, Robert Dvoracek wrote: >> It shows up in lspci as NEC Corporation uPD720200 USB

Re: USB3 Not Being Detected on Intel DX79TO Desktop Board

2013-01-23 Thread Greg KH
On Wed, Jan 23, 2013 at 01:14:09PM -0500, Robert Dvoracek wrote: > 02:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host > Controller (rev 04) > Subsystem: Intel Corporation Device 4953 > > On Wed, Jan 23, 2013 at 12:28 AM, Greg KH wrote: > > On Wed, Jan 23, 2013 at 12:19:41AM -0500, Rob

[PATCH 4/4 v.2] USB: EHCI: fix build error in ehci-mxc

2013-01-23 Thread Alan Stern
This patch (as1643b) fixes a build error in ehci-hcd when compiling for ARM with allmodconfig: drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" redefined [enabled by default] drivers/usb/host/ehci-hcd.c:1255:0: note: this is the location of the previous definition drivers/usb/host/

Re: [PATCH net] net: cdc_mbim: send ZLP only for the specific buggy device

2013-01-23 Thread David Miller
From: Bjørn Mork Date: Wed, 23 Jan 2013 11:57:02 +0100 > Reverting 328d7b8 and instead adding an exception for the > Sierra Wireless MC7710. > > commit 328d7b8 (net: cdc_mbim: send ZLP after max sized NTBs) > added a workaround for an issue observed on one specific device. > Concerns were raised

[PATCH] USB: UHCI: remove unused definition

2013-01-23 Thread Alan Stern
From: Woody Suwalski Remove an unused (and erroneous) definition from the UHCI driver. Signed-off: Woody Suwalski Acked-by: Alan Stern --- --- a/drivers/usb/host/uhci-hcd.h 2013-01-23 11:43:17.330420515 -0500 +++ b/drivers/usb/host/uhci-hcd.h 2013-01-23 13:16:48.708380367 -0500 @

Re: USB3 Not Being Detected on Intel DX79TO Desktop Board

2013-01-23 Thread Robert Dvoracek
It's Knoppix 7.0.5, kernel 3.6.11 Thank you, Robert On Wed, Jan 23, 2013 at 1:16 PM, Greg KH wrote: > On Wed, Jan 23, 2013 at 01:14:09PM -0500, Robert Dvoracek wrote: >> 02:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host >> Controller (rev 04) >> Subsystem: Intel Corporation Device 4

Re: [Resend PATCH 2/2] usb: add usb_enable/disable_remote_wakeup()

2013-01-23 Thread Alan Stern
On Thu, 24 Jan 2013, Lan Tianyu wrote: > > > + status = usb_disable_function_remotewakeup(udev); > > > > Don't call that function here. Just put the code here and run it > > directly. Then you can get rid of the old function. > > > usb_disable_function_remotewakeup is ju

  1   2   >