On Tue, Feb 26, 2013 at 10:51:45PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 26-02-2013 13:34, Felipe Balbi wrote:
>
> >we can cache the last read value of the event
> >buffer count register on this field, for later
> >handling.
>
> >Signed-off-by: Felipe Balbi
> >---
> > drivers/usb/dwc3/
Hi,
On Wed, Feb 27, 2013 at 02:33:17PM +0800, Peter Chen wrote:
> - For host, the vbus should always be on.
> - For otg, the vbus is off defaultly, the vbus needs to be
> turned on/off when usb role switches.
>
> Signed-off-by: Peter Chen
one quick question, if chipidea already has an imx glue
Hi, Felipe
Does the following patch still break your editor? I have fix the patch
and resend it again, but I didn't find the patch in your 'big patch
bomb' for v3.10,
should I fix something?
On Tue, Jan 29, 2013 at 4:22 PM, yingchun li wrote:
> According to "musbhdrd usb 2.0 high-speed dual-
In DWC3 versions < 2.50a configured without
Hibernation mode enabled, there will be an
extra link status change interrupt if device
detects host-initiated U3 exit.
In that case, core will generate an unnecessary
U3 -> RESUME transition which should be ignored
by the driver.
Signed-off-by: Felipe
Some new revisions of the DWC3 core have
been released, let's add our defines to help
implementing known erratas.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index b417506..8bed18
If the core's probe fails, the platform layer may not get core's
private data, if the platform tries to use struct ci13xxx, it will
use uninitialized pointer. Besides, if the core's probe fails,
the platform layer should know it, and let its probe fail too.
Signed-off-by: Peter Chen
---
drivers/
When we rmmod gadget, the ci->driver needs to be cleared.
Otherwise, we plug in usb cable again, the driver will
consider gadget is there, in fact, it is removed.
Besides, consolidate the calling of ci->driver->disconnect, when
we do rmmod gadget, the gadget's disconnect should be called from
udc
- For host, the vbus should always be on.
- For otg, the vbus is off defaultly, the vbus needs to be
turned on/off when usb role switches.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci.h |2 +
drivers/usb/chipidea/ci13xxx_imx.c | 76
2
(change CI13XXX to CI13 to avoid junk email check)
Now, we have handled vbus session in core driver when the
vbus interrupt occurs, so our pullup operations are all
according to vbus.
Of cource, the software can still call .pullup when device connects
to host if it wants to connect/disconnect with
- During the connect/disconnect host, we need to pullup
and pulldown dp
- Make sure the dp is not pullup until the vbus is on when
flag CI13XXX_PULLUP_ON_VBUS is set
- Using hw_device_state when set run/stop bit
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/udc.c | 10 --
1 files
The main design flow is the same with msm otg driver, that is the id and
vbus interrupt are handled at core driver, others are handled by
individual drivers.
- At former design, when switch usb role from device->host, it will call
udc_stop, it will remove the gadget driver, so when switch role
fro
Implement struct usb_otg, In that way, calling otg_set_peripheral
will not be failed at udc.c.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/Makefile |2 +-
drivers/usb/chipidea/ci.h |2 +
drivers/usb/chipidea/otg.c| 60 +
drivers/us
vbus register is at otgsc, and vbus detect does not belong
to device function. Revert this patch, and will move
vbus detect function to drivers/usb/chipidea/udc.c
This reverts commit 8c4fc031954b4eb72daf13d3c907a985a3eee208.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci.h |1 -
dri
Changes for v10:
- Delete [8/9] at v9, ci core's drvdata must be set for further operation.
[8/8]
Changes for v9:
- Some small comments from Alex like: variable comment for otg event
additional newline. [3/9]
- Import function tell show if the controller has otg capable, if
the controller supports
On Tue, Feb 26, 2013 at 02:47:34PM +0100, Marc Kleine-Budde wrote:
> On 02/26/2013 02:25 PM, Alexander Shishkin wrote:
> > Marc Kleine-Budde writes:
> >
> >> On 02/26/2013 11:56 AM, Alexander Shishkin wrote:
> >>> Peter Chen writes:
> >>>
> Hi Alex,
> >>>
> >>> Hi,
> >>>
> Do we have a
Add the DWC2 Kconfig and Makefile, and modify the USB Kconfig and
Makefile to include them
Signed-off-by: Paul Zimmerman
---
drivers/usb/dwc2/Kconfig | 35 +++
drivers/usb/dwc2/Makefile | 18 ++
2 files changed, 53 insertions(+)
create mode 10064
This file contains the PCI bus interface "glue" for the DWC2 driver
Signed-off-by: Paul Zimmerman
---
drivers/usb/dwc2/pci.c | 199 +
1 file changed, 199 insertions(+)
create mode 100644 drivers/usb/dwc2/pci.c
diff --git a/drivers/usb/dwc2/pci.c
This file contains the code to support the HCD descriptor DMA mode
of the controller
Signed-off-by: Paul Zimmerman
---
drivers/usb/dwc2/hcd_ddma.c | 1179 +++
1 file changed, 1179 insertions(+)
create mode 100644 drivers/usb/dwc2/hcd_ddma.c
diff --git a/
Add a usb_otg_state_string() routine to print the OTG state for
debugging
Signed-off-by: Paul Zimmerman
---
drivers/usb/usb-common.c | 26 ++
include/linux/usb/phy.h | 8
2 files changed, 34 insertions(+)
diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb
Hi Felipe,
Here is v5 of the DWC2 patch set. I think I made all of the changes we
agreed on after your last review.
You'll be happy to hear that I removed all of the module parameters. I
realized it is easy enough for me to maintain a local patch here to add
them back when we need to do driver/RT
On Tue, Feb 26, 2013 at 08:21:41PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Sun, Feb 17, 2013 at 11:09:53AM +0800, Peter Chen wrote:
> > @@ -1373,6 +1375,8 @@ static int ci13xxx_vbus_session(struct usb_gadget
> > *_gadget, int is_active)
> > hw_device_state(ci, ci->ep0out->qh.d
On Tue, Feb 26, 2013 at 11:42:34AM +0200, Felipe Balbi wrote:
> On Sun, Feb 17, 2013 at 05:24:42PM +0800, Peter Chen wrote:
> > If the probe fails, the ci13xxx_add_device will not return error,
> > (bus_probe_device doesn't has return value)
> > therefore, the platform layer can't know whether core
Ok, I've added this patch to my for-usb-next-queue branch. I'll be
sending it off to Greg for 3.10 after 3.9-rc1 is out and he's accepting
pull requests again.
Sarah Sharp
On Mon, Feb 11, 2013 at 12:58:00PM +0200, Felipe Balbi wrote:
> From: Vikas Sajjan
>
> Adds power management support to xH
Hi Dmitry,
Thanks for catching this. I've applied it to my for-usb-linus-queue,
and I'll be sending it to Greg as a bug fix after 3.9-rc1 is out.
Sarah Sharp
On Mon, Feb 25, 2013 at 10:56:01AM -0800, Dmitry Torokhov wrote:
> According to XHCI specification (5.5.2.1) the IP is bit 0 and IE is bi
From: David Miller
Date: Tue, 26 Feb 2013 17:28:56 -0500 (EST)
> Applied, thanks Glen.
Actually, I had to revert, this doesn't even compile against
current sources:
CC [M] drivers/net/usb/asix_devices.o
drivers/net/usb/asix_devices.c:941:14: error: ‘asix_rx_fixup’ undeclared here
(not in a
From: Glen Turner
Date: Tue, 26 Feb 2013 14:47:12 +1030
> This USB ethernet adapter was purchased in anodyne packaging
> marked "USB2.0 to LAN" from the computer store adjacent to
> linux.conf.au 2013 in Canberra (Australia). A web search
> shows other recent purchasers in Lancaster (UK) and Seat
On Tue, 26 Feb 2013 00:10:22 -0500 (EST)
David Miller wrote:
> It didn't make it to any of the lists, that's why you are the
> only person who saw the original patch.
I've got it (the original send) here, so it seems to have gone through
to linux-usb@vger.kernel.org (or at least some of it) witho
On Tue, Feb 26, 2013 at 10:59:12PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 26-02-2013 13:34, Felipe Balbi wrote:
>
> >gadget's device pointer now is guaranteed to
> >have valid dma_mask, dma_parms and coherent_dma_mask
> >fields since we're always copying from our
> >parent device.
>
> >Si
Clean up modem status retrieval.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index 5779dd8..e0093dd 100644
--- a/drivers/usb/serial
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb_wwan.c | 25 -
1 file changed, 12 insertions(+), 13
Fetch modem status on carrier_raised and tiocmget.
This driver appeared to support modem-status but only read the modem
status registers once at open and then used that cached value for all
further enquires.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 27 ++---
Remove redundant port number from debug output (already printed as part
of device name).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 4
Make sure to wake up any process sleeping on the modem-status-change
queue at port remove.
Currently a process waiting on modem status changes will not be woken on
device disconnect.
Note that we need to use the disconnected flag to detect disconnect as
the port private data may have been freed w
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/sierra.c | 39 +--
1 file changed, 17 inser
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ark3116.c | 49 +---
1 file changed, 14 insertions(+), 35 deletions(-)
diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c
index 4188f
The generic close operation will be used if the close field is left
uninitialised.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 8bb8579..adbca36 100644
--- a/dr
Use interface rather than usb-serial device for debugging interface
related operations. This gives more descriptive messages, such as
[ 905.669436] pl2303 1-4.1:1.0: 0x40:0x1:0x8:0x0 0
rather than
[ 341.943535] usb 1-4.1: 0x40:0x1:0x8:0x0 0
Signed-off-by: Johan Hovold
---
drivers/usb/seri
Add generic get_icount implementation that subdrivers relying on the
port interrupt counters can use.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c | 27 +++
include/linux/usb/serial.h | 2 ++
2 files changed, 29 insertions(+)
diff --git a/drivers/usb/s
Remove broken TIOCMIWAIT support.
This drivers appears to implement TIOCMIWAIT but has no means of
receiving modem-status interrupts.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 67
1 file changed, 67 deletions(-)
diff --git a/dri
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 48 ++--
1 file changed, 2 insertions(+), 46 deletions(-)
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index bdf57d
Switch to the generic get_icount implementation.
Note that the interrupt counters will no longer be reset at open which
is in accordance with which how the other drivers work.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 56 +++-
1 file
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mct_u232.c | 61 ++-
1 file changed, 2 insertions(+), 59 deletions(-)
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index 0889
Remove SMP memory barriers from icount handling and rely on the barriers
implied by wait_event, sleep and locks, while using the port lock to
guarantee atomicity.
This is a step in moving over to the generic icount implementations.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c |
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 39 ++-
1 file changed, 2 insertions(+), 37 deletions(-)
Break out TIOCMIWAIT handling from custom ioctl operation and use
tiocmiwait operation field instead.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
Remove kill of interrupt-in urb on close as it has never been submitted.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index ff77027..a3bfcb3 100644
--- a/dri
Failed allocations already get an OOM message and a stack dump.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 37 +
1 file changed, 9 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-seri
Remove the port data refcounting and release the private data
explicitly at port remove.
The port data refcounting was used to make sure the port data was not
freed until the last tty reference was closed. Since moving over to tty
ports, the underlying assumptions are no longer valid as close is n
The disconnect callback is set to the generic implementation by
usb-serial core if NULL.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 8891203..8bb8579 100644
--- a/dr
Make sure to wake up any process sleeping on the modem-status-change
queue at port remove.
Currently a process waiting on modem status changes will not
necessarily be woken on device disconnect.
Note that we need to use the disconnected flag to detect disconnect as
the port private data may have
Rename port_release so that all usb_serial_port functions have a common
prefix.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 2c32f84.
Replace custom ioctl operation with tiocmiwait.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 7acb155..d556c94 100644
--- a/dr
Remove disconnected test from close which did not protect any device IO
at all.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index 23b77eb..f6a7d88 10064
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/digi_acceleport.c | 92 ++--
1 file changed, 45
Remove redundant port number from debug output (already printed as part
of device name).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 478f2b4..4f9bfe5 100644
Make sure to wake up any process sleeping on the modem-status-change
queue at port remove.
Currently a process waiting on modem status changes will not be
woken on device disconnect.
Note that we need to use the disconnected flag to detect disconnect
as the port private data may have been freed w
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 50 +++
1 file changed, 12 insertions(+), 38 deletions(-)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 897
Break out TIOCMIWAIT handling from custom ioctl operation and use
tiocmiwait operation field instead.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/f81232.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Most USB serial drivers are, and should be, using as much of the generic
implementation as possible.
Rename the fixup_generic function to a more descriptive name.
Reword the related debug message in a more neutral tone (and remember to
add the missing newline).
Finally, move the operations initial
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Remove unnecessary disconnect test in tiocmset. No ioctls will be made
after disconnect returns.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/opticon.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/op
Make sure we return 0 or a negative error number appropriate for
userspace on errors.
Currently 1 rather than 0 is returned on successful operation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/opticon.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/driv
We should not call kill_traffic (and usb_kill_urb) once disconnect
returns. Any pending urbs are killed at disconnect and new submissions
are prevented by usb_unbind_interface (and usb_disable_interface).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 7 ---
1 file changed
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ti_usb_3410_5052.c | 44 ++-
1 file changed, 7 insertions(+), 37 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_
Remove broken get_icount and TIOCMIWAIT support.
The driver has an icount structure but it is never been updated which
makes get_icount rather pointless and causes TIOCMIWAIT to always return
-EIO.
Note that the TIOCMIWAIT implementation has always been broken and would
not work even if icount su
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_edgeport.c | 37 +
drivers/usb/serial/io_tables.h | 4
2 files changed, 5 insertions(+), 36 deletions(-)
diff --git a/drivers/usb/serial/io_edgeport
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Switch to the generic get_icount implementation.
Note that the interrupt counters will no longer be reset at open which
is in accordance with which how the other drivers work.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_edgeport.c | 45 +++-
drivers
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan_pda.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
d
Remove redundant comments and fix some minor coding style issues.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index a5e8
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Make sure to unregister the tty device before calling subdriver
port_remove.
This way remove will reverse probe, and specifically any port data
released in port_remove will be available throughout tty unregister.
Reported-by: Peter Hurley
Signed-off-by: Johan Hovold
---
drivers/usb/serial/bus.
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mct_u232.c | 40
1 file changed, 4 insertions(+), 36 deletions(-)
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index 6a2957d
There is no need for the generic disconnect callback to stop the read
and write urbs a second time as this has already been taken care of by
close (which is called from hangup as part of disconnect).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c | 12 +---
1 file changed,
Remove kill of interrupt-in urb on close as it has never been submitted.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/kl5kusb105.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
index 769d910..57fd001 100644
--- a/dri
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ti_usb_3410_5052.c | 30 +++---
1 file changed, 3 insertions(+), 27 deletions(-)
Remove bogus (and unnecessary) test for serial->dev being NULL in
dtr_rts.
The device is never cleared, and disconnect is handled for dtr_rts in
usb-serial core anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan_pda.c | 10 --
1 file changed, 4 insertions(+), 6 deletions
Switch to the generic get_icount implementation.
Note that the interrupt counters will no longer be reset at open which
is in accordance with which how the other drivers work.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_ti.c | 39 ---
1 file changed
Make sure the interrupt urb submitted in port_probe is killed in
port_remove.
The interrupt-urb completion handler references the port and may get
called after port_remove has returned and the port has been
unregistered (although this is currently prevented by usb-serial core as
we are using a non
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cyberjack.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff
Update copyright information.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 2 +-
drivers/usb/serial/generic.c| 2 +-
drivers/usb/serial/usb-serial.c | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/f
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ark3116.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions
The calls to usb_poison_urb and usb_unpoison_urb are expected to be
balanced. However, if an urb that has not yet been submitted is
poisoned, its reject counter will not be increased as its ep-field is
NULL. A consecutive call to unpoison will thus in fact poison the urb
as its reject counter will
Pass usb-serial port to the control functions for uart status and work
mode.
Use port device for debugging and use dev_err to report errors.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 54 +++-
1 file changed, 28 insertions(+), 26 delet
Add tiocmiwait operation to struct usb_serial_driver.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 15 +++
include/linux/usb/serial.h | 1 +
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial
Use usb_poison_urb to reliably kill all urbs on disconnect and suspend.
This way there will be no question that the urbs cannot be resubmitted
by buggy subdrivers.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 55 +++--
1 file changed, 37
Remove empty generic release implementation and make the release
callback non-mandatory (like attach, probe and disconnect).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c| 5 -
drivers/usb/serial/usb-serial.c | 3 +--
include/linux/usb/serial.h | 1 -
3 files changed,
Replace custom ioctl operation with tiocmiwait.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.c | 81 +
1 file changed, 34 insertions(+), 47 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 55 +
1 file changed, 15 insertions(+), 40 deletions(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index adbca36
Clean up this driver somewhat.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 72 +++-
1 file changed, 37 insertions(+), 35 deletions(-)
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index f34930c..a5c3a36 100644
Remove bogus disconnect test for serial device being NULL in close. This
can never happen as close is guaranteed to be called before the last tty
reference is dropped (and port->serial is cleared).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/garmin_gps.c | 4
1 file changed, 4 deleti
Reimplement device type detection using the device id table and quirks.
Device type was used to detect one device type which did not support to
control functions. Add quirks to the device table and store them in the
private port data at probe instead.
Signed-off-by: Johan Hovold
---
drivers/usb
Add generic TIOCMIWAIT implementation which correctly handles USB-device
disconnects, does not rely on the deprecated sleep_on functions and
hence does not suffer from the races currently affecting several
usb-serial drivers.
This makes it much easier to add TIOCMIWAIT support to subdrivers as the
Make sure we return 0 or a negative error number appropriate for
userspace on errors.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 4b709585..8
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 48 ++-
1 file changed, 2 insertions(+), 46 deletions(-)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 8ce8
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_ti.c | 38 --
1 file changed, 4 insertions(+), 34 deletions(-)
di
1 - 100 of 396 matches
Mail list logo
