Remove bogus (and unnecessary) test for serial-dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/iuu_phoenix.c | 13 +
1 file changed, 5
We should not call kill_traffic (and usb_kill_urb) once disconnect
returns. Any pending urbs are killed at disconnect and new submissions
are prevented by usb_unbind_interface (and usb_disable_interface).
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/usb-serial.c | 7
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/ti_usb_3410_5052.c | 44 ++-
1 file changed, 7 insertions(+), 37 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
Make sure we return 0 or a negative error number appropriate for
userspace on errors.
Currently 1 rather than 0 is returned on successful operation.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/opticon.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
Remove unnecessary disconnect test in tiocmset. No ioctls will be made
after disconnect returns.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/opticon.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/serial/opticon.c
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
Break out TIOCMIWAIT handling from custom ioctl operation and use
tiocmiwait operation field instead.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/f81232.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/f81232.c
Make sure to wake up any process sleeping on the modem-status-change
queue at port remove.
Currently a process waiting on modem status changes will not be
woken on device disconnect.
Note that we need to use the disconnected flag to detect disconnect
as the port private data may have been freed
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/ftdi_sio.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index
Remove bogus (and unnecessary) test for serial-dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/digi_acceleport.c | 92 ++--
1
Remove disconnected test from close which did not protect any device IO
at all.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/cypress_m8.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index
Replace custom ioctl operation with tiocmiwait.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/ch341.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index
Rename port_release so that all usb_serial_port functions have a common
prefix.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/usb-serial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c
Make sure to wake up any process sleeping on the modem-status-change
queue at port remove.
Currently a process waiting on modem status changes will not
necessarily be woken on device disconnect.
Note that we need to use the disconnected flag to detect disconnect as
the port private data may have
The disconnect callback is set to the generic implementation by
usb-serial core if NULL.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/ssu100.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index
Remove the port data refcounting and release the private data
explicitly at port remove.
The port data refcounting was used to make sure the port data was not
freed until the last tty reference was closed. Since moving over to tty
ports, the underlying assumptions are no longer valid as close is
Failed allocations already get an OOM message and a stack dump.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/usb-serial.c | 37 +
1 file changed, 9 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c
Remove kill of interrupt-in urb on close as it has never been submitted.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/iuu_phoenix.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index
Break out TIOCMIWAIT handling from custom ioctl operation and use
tiocmiwait operation field instead.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/pl2303.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/ftdi_sio.c | 39 ++-
1 file changed, 2
Remove SMP memory barriers from icount handling and rely on the barriers
implied by wait_event, sleep and locks, while using the port lock to
guarantee atomicity.
This is a step in moving over to the generic icount implementations.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/mct_u232.c | 61 ++-
1 file changed, 2 insertions(+), 59 deletions(-)
diff --git a/drivers/usb/serial/mct_u232.c
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
Switch to the generic get_icount implementation.
Note that the interrupt counters will no longer be reset at open which
is in accordance with which how the other drivers work.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/mos7840.c | 56
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/mos7840.c | 48 ++--
1 file changed, 2 insertions(+), 46 deletions(-)
diff --git a/drivers/usb/serial/mos7840.c
Remove broken TIOCMIWAIT support.
This drivers appears to implement TIOCMIWAIT but has no means of
receiving modem-status interrupts.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/spcp8x5.c | 67
1 file changed, 67 deletions(-)
Add generic get_icount implementation that subdrivers relying on the
port interrupt counters can use.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/generic.c | 27 +++
include/linux/usb/serial.h | 2 ++
2 files changed, 29 insertions(+)
diff
Use interface rather than usb-serial device for debugging interface
related operations. This gives more descriptive messages, such as
[ 905.669436] pl2303 1-4.1:1.0: 0x40:0x1:0x8:0x0 0
rather than
[ 341.943535] usb 1-4.1: 0x40:0x1:0x8:0x0 0
Signed-off-by: Johan Hovold jhov...@gmail.com
---
The generic close operation will be used if the close field is left
uninitialised.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/ssu100.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/ark3116.c | 49 +---
1 file changed, 14 insertions(+), 35 deletions(-)
diff --git a/drivers/usb/serial/ark3116.c
Remove bogus (and unnecessary) test for serial-dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/sierra.c | 39 +--
1 file
Make sure to wake up any process sleeping on the modem-status-change
queue at port remove.
Currently a process waiting on modem status changes will not be woken on
device disconnect.
Note that we need to use the disconnected flag to detect disconnect as
the port private data may have been freed
Remove redundant port number from debug output (already printed as part
of device name).
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/generic.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/generic.c
Fetch modem status on carrier_raised and tiocmget.
This driver appeared to support modem-status but only read the modem
status registers once at open and then used that cached value for all
further enquires.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/spcp8x5.c | 27
Remove bogus (and unnecessary) test for serial-dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/usb_wwan.c | 25 -
1 file changed, 12
Clean up modem status retrieval.
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/spcp8x5.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index 5779dd8..e0093dd 100644
---
On Tue, Feb 26, 2013 at 10:59:12PM +0400, Sergei Shtylyov wrote:
Hello.
On 26-02-2013 13:34, Felipe Balbi wrote:
gadget's device pointer now is guaranteed to
have valid dma_mask, dma_parms and coherent_dma_mask
fields since we're always copying from our
parent device.
Signed-off-by:
On Tue, 26 Feb 2013 00:10:22 -0500 (EST)
David Miller da...@davemloft.net wrote:
It didn't make it to any of the lists, that's why you are the
only person who saw the original patch.
I've got it (the original send) here, so it seems to have gone through
to linux-usb@vger.kernel.org (or at least
From: Glen Turner g...@gdt.id.au
Date: Tue, 26 Feb 2013 14:47:12 +1030
This USB ethernet adapter was purchased in anodyne packaging
marked USB2.0 to LAN from the computer store adjacent to
linux.conf.au 2013 in Canberra (Australia). A web search
shows other recent purchasers in Lancaster (UK)
From: David Miller da...@davemloft.net
Date: Tue, 26 Feb 2013 17:28:56 -0500 (EST)
Applied, thanks Glen.
Actually, I had to revert, this doesn't even compile against
current sources:
CC [M] drivers/net/usb/asix_devices.o
drivers/net/usb/asix_devices.c:941:14: error: ‘asix_rx_fixup’
Hi Dmitry,
Thanks for catching this. I've applied it to my for-usb-linus-queue,
and I'll be sending it to Greg as a bug fix after 3.9-rc1 is out.
Sarah Sharp
On Mon, Feb 25, 2013 at 10:56:01AM -0800, Dmitry Torokhov wrote:
According to XHCI specification (5.5.2.1) the IP is bit 0 and IE is
Ok, I've added this patch to my for-usb-next-queue branch. I'll be
sending it off to Greg for 3.10 after 3.9-rc1 is out and he's accepting
pull requests again.
Sarah Sharp
On Mon, Feb 11, 2013 at 12:58:00PM +0200, Felipe Balbi wrote:
From: Vikas Sajjan vikas.saj...@linaro.org
Adds power
On Tue, Feb 26, 2013 at 11:42:34AM +0200, Felipe Balbi wrote:
On Sun, Feb 17, 2013 at 05:24:42PM +0800, Peter Chen wrote:
If the probe fails, the ci13xxx_add_device will not return error,
(bus_probe_device doesn't has return value)
therefore, the platform layer can't know whether core's
On Tue, Feb 26, 2013 at 08:21:41PM +0200, Felipe Balbi wrote:
Hi,
On Sun, Feb 17, 2013 at 11:09:53AM +0800, Peter Chen wrote:
@@ -1373,6 +1375,8 @@ static int ci13xxx_vbus_session(struct usb_gadget
*_gadget, int is_active)
hw_device_state(ci, ci-ep0out-qh.dma);
Hi Felipe,
Here is v5 of the DWC2 patch set. I think I made all of the changes we
agreed on after your last review.
You'll be happy to hear that I removed all of the module parameters. I
realized it is easy enough for me to maintain a local patch here to add
them back when we need to do
Add a usb_otg_state_string() routine to print the OTG state for
debugging
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/usb/usb-common.c | 26 ++
include/linux/usb/phy.h | 8
2 files changed, 34 insertions(+)
diff --git
This file contains the code to support the HCD descriptor DMA mode
of the controller
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/usb/dwc2/hcd_ddma.c | 1179 +++
1 file changed, 1179 insertions(+)
create mode 100644
This file contains the PCI bus interface glue for the DWC2 driver
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/usb/dwc2/pci.c | 199 +
1 file changed, 199 insertions(+)
create mode 100644 drivers/usb/dwc2/pci.c
diff --git
Add the DWC2 Kconfig and Makefile, and modify the USB Kconfig and
Makefile to include them
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/usb/dwc2/Kconfig | 35 +++
drivers/usb/dwc2/Makefile | 18 ++
2 files changed, 53 insertions(+)
On Tue, Feb 26, 2013 at 02:47:34PM +0100, Marc Kleine-Budde wrote:
On 02/26/2013 02:25 PM, Alexander Shishkin wrote:
Marc Kleine-Budde m...@pengutronix.de writes:
On 02/26/2013 11:56 AM, Alexander Shishkin wrote:
Peter Chen peter.c...@freescale.com writes:
Hi Alex,
Hi,
Do we
vbus register is at otgsc, and vbus detect does not belong
to device function. Revert this patch, and will move
vbus detect function to drivers/usb/chipidea/udc.c
This reverts commit 8c4fc031954b4eb72daf13d3c907a985a3eee208.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
Implement struct usb_otg, In that way, calling otg_set_peripheral
will not be failed at udc.c.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/Makefile |2 +-
drivers/usb/chipidea/ci.h |2 +
drivers/usb/chipidea/otg.c| 60
The main design flow is the same with msm otg driver, that is the id and
vbus interrupt are handled at core driver, others are handled by
individual drivers.
- At former design, when switch usb role from device-host, it will call
udc_stop, it will remove the gadget driver, so when switch role
- During the connect/disconnect host, we need to pullup
and pulldown dp
- Make sure the dp is not pullup until the vbus is on when
flag CI13XXX_PULLUP_ON_VBUS is set
- Using hw_device_state when set run/stop bit
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/udc.c |
(change CI13XXX to CI13 to avoid junk email check)
Now, we have handled vbus session in core driver when the
vbus interrupt occurs, so our pullup operations are all
according to vbus.
Of cource, the software can still call .pullup when device connects
to host if it wants to connect/disconnect with
- For host, the vbus should always be on.
- For otg, the vbus is off defaultly, the vbus needs to be
turned on/off when usb role switches.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/ci.h |2 +
drivers/usb/chipidea/ci13xxx_imx.c | 76
When we rmmod gadget, the ci-driver needs to be cleared.
Otherwise, we plug in usb cable again, the driver will
consider gadget is there, in fact, it is removed.
Besides, consolidate the calling of ci-driver-disconnect, when
we do rmmod gadget, the gadget's disconnect should be called from
udc
If the core's probe fails, the platform layer may not get core's
private data, if the platform tries to use struct ci13xxx, it will
use uninitialized pointer. Besides, if the core's probe fails,
the platform layer should know it, and let its probe fail too.
Signed-off-by: Peter Chen
Some new revisions of the DWC3 core have
been released, let's add our defines to help
implementing known erratas.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/dwc3/core.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index
In DWC3 versions 2.50a configured without
Hibernation mode enabled, there will be an
extra link status change interrupt if device
detects host-initiated U3 exit.
In that case, core will generate an unnecessary
U3 - RESUME transition which should be ignored
by the driver.
Signed-off-by: Felipe
Hi, Felipe
Does the following patch still break your editor? I have fix the patch
and resend it again, but I didn't find the patch in your 'big patch
bomb' for v3.10,
should I fix something?
On Tue, Jan 29, 2013 at 4:22 PM, yingchun li sword.l.dra...@gmail.com wrote:
According to musbhdrd
Hi,
On Wed, Feb 27, 2013 at 02:33:17PM +0800, Peter Chen wrote:
- For host, the vbus should always be on.
- For otg, the vbus is off defaultly, the vbus needs to be
turned on/off when usb role switches.
Signed-off-by: Peter Chen peter.c...@freescale.com
one quick question, if chipidea
On Tue, Feb 26, 2013 at 10:51:45PM +0400, Sergei Shtylyov wrote:
Hello.
On 26-02-2013 13:34, Felipe Balbi wrote:
we can cache the last read value of the event
buffer count register on this field, for later
handling.
Signed-off-by: Felipe Balbi ba...@ti.com
---
301 - 363 of 363 matches
Mail list logo
