Re: [PATCH v11 4/9] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state

2013-03-08 Thread Peter Chen
On Fri, Mar 08, 2013 at 09:18:32AM +0200, Felipe Balbi wrote: This isn't legal. If you want to make sure vbus is alive before connecting pullups, then do it generically. Modify udc-core.c to make those checks for you. Bypassing the framework is dangerous because whenever I wanna

Re: [PATCH v11 6/9] usb: chipidea: add vbus regulator control

2013-03-08 Thread Peter Chen
On Fri, Mar 08, 2013 at 09:26:24AM +0200, Felipe Balbi wrote: Differ with dwc3, chipidea created its platform data at glue layer, and chipidea core owing this data when platform device is created. yeah yeah, but that's just because chipidea core doesn't understand DT. It should take

Re: [PATCH v11 6/9] usb: chipidea: add vbus regulator control

2013-03-08 Thread Felipe Balbi
Hi, On Fri, Mar 08, 2013 at 04:32:46PM +0800, Peter Chen wrote: If we also want get things from DT node, we need to get node from glue layer as this node is NOT belonged to chipidea core's pdev. which DT node are you talking about ? you want chipidea core to have access to glue's DT

Re: [PATCH v11 6/9] usb: chipidea: add vbus regulator control

2013-03-08 Thread Peter Chen
On Fri, Mar 08, 2013 at 10:42:35AM +0200, Felipe Balbi wrote: Second, why you think it is a broken patch, it just follows current framework. Besides, if you have concerns about DT stuff for chipidea core, why not mention it when sasche added dr_mode and phy_mode at that time? Well,

Re: [PATCH v11 6/9] usb: chipidea: add vbus regulator control

2013-03-08 Thread Felipe Balbi
On Fri, Mar 08, 2013 at 04:52:02PM +0800, Peter Chen wrote: On Fri, Mar 08, 2013 at 10:42:35AM +0200, Felipe Balbi wrote: Second, why you think it is a broken patch, it just follows current framework. Besides, if you have concerns about DT stuff for chipidea core, why not mention it

Re: fsl_udc_core: set address request aren't handled like expected. usb30cv test suite fails.

2013-03-08 Thread Peter Chen
On Thu, Mar 07, 2013 at 09:58:52AM +0100, Peter Bestler wrote: Hi, We try to get our device (based on p2020rdb) usb 2.0 compliant. We ran the usb30cv test suite (version 1.0.1.2, chapter 9 tests for usb 2.0 devices) on win7 with g_zero and g_serial. We access the device via an usb 3.0 hcd

About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-08 Thread Peter Chen
Hi David I notice at your code for hw_usb_set_address, there is a comment for it /** * This function explicitly sets the address, without the USBADRA (advance) * feature, which is not supported by older versions of the controller. */ If we use USB3.0 host for CV test, we must use this bit, or

[PATCH] usb: gadget: get rid of two outdated selects

2013-03-08 Thread Paul Bolle
The Kconfig symbols USB_GADGET_DUALSPEED and USB_GADGET_SUPERSPEED were removed in commit 85b8614d722389202af298e1bf8a599c431fef19 (usb: gadget: get rid of USB_GADGET_{DUAL,SUPER}SPEED). These two select statements somehow escaped cleaning up. Get rid of these too. Signed-off-by: Paul Bolle

Re: fsl_udc_core: set address request aren't handled like expected. usb30cv test suite fails.

2013-03-08 Thread Felipe Balbi
On Fri, Mar 08, 2013 at 05:38:53PM +0800, Peter Chen wrote: On Thu, Mar 07, 2013 at 09:58:52AM +0100, Peter Bestler wrote: Hi, We try to get our device (based on p2020rdb) usb 2.0 compliant. We ran the usb30cv test suite (version 1.0.1.2, chapter 9 tests for usb 2.0 devices) on win7

Re: Testing for hardware bug in EHCI controllers

2013-03-08 Thread Roger Quadros
On 03/04/2013 05:36 AM, Ming Lei wrote: On Tue, Feb 26, 2013 at 4:54 AM, Alan Stern st...@rowland.harvard.edu wrote: I'd be interested to hear the results of testing on a variety of controllers. (This computer also has an NEC EHCI controller, and that one does not have the bug.) Do the

Re: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-08 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Hi David Hi, I notice at your code for hw_usb_set_address, there is a comment for it /** * This function explicitly sets the address, without the USBADRA (advance) * feature, which is not supported by older versions of the controller. */

Re: [PATCH 01/13] usb: phy: nop: Add device tree support and binding information

2013-03-08 Thread Marc Kleine-Budde
On 02/04/2013 04:58 PM, Roger Quadros wrote: The PHY clock, clock rate, VCC regulator and RESET regulator can now be provided via device tree. Signed-off-by: Roger Quadros rog...@ti.com --- .../devicetree/bindings/usb/usb-nop-xceiv.txt | 34

[PATCH 0/3] usb: phy: isp1301 refactor

2013-03-08 Thread Felipe Balbi
Hi, the following patches turn isp1301 into a real transceiver driver, instead of the hackery added just so it was easy to use ohci-nxp and lpc32xx udc. Later patches can come removing that code and switching over to using proper PHY API though devm_usb_phy_get(), usb_phy_init() and

[PATCH 3/3] usb: phy: isp1301: implement PHY API

2013-03-08 Thread Felipe Balbi
this patch implements -init() and -set_vbus() methods for isp1301 transceiver driver. Later patches can now come in order to remove the hackery from ohci-nxp and lpc32xx udc drivers. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/phy/phy-isp1301.c | 59

Re: fsl_udc_core: set address request aren't handled like expected. usb30cv test suite fails.

2013-03-08 Thread Peter Chen
On Fri, Mar 08, 2013 at 11:54:41AM +0200, Felipe Balbi wrote: On Fri, Mar 08, 2013 at 05:38:53PM +0800, Peter Chen wrote: On Thu, Mar 07, 2013 at 09:58:52AM +0100, Peter Bestler wrote: Hi, We try to get our device (based on p2020rdb) usb 2.0 compliant. We ran the usb30cv test

Re: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-08 Thread Peter Chen
On Fri, Mar 08, 2013 at 12:39:04PM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Hi David Hi, I notice at your code for hw_usb_set_address, there is a comment for it /** * This function explicitly sets the address, without the USBADRA (advance)

Re: [PATCH 2/3] usb: phy: introduce -set_vbus() method

2013-03-08 Thread Peter Chen
On Fri, Mar 08, 2013 at 01:30:52PM +0200, Felipe Balbi wrote: this method will be used to enable or disable the charge pump. Whenever we have DRD devices, we need to be able to turn VBUS on or off whenever we want. Note that in the ideal case, this would be controlled by the ID-pin

Re: [PATCH v11 3/9] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2013-03-08 Thread Peter Chen
On Thu, Mar 07, 2013 at 01:50:24PM +0800, Peter Chen wrote: On Wed, Mar 06, 2013 at 07:09:34PM +0200, Alexander Shishkin wrote: - start/stop API are used at otg id switch and probe routine - Defer some gadget operations at ci's delayed work queue When I asked you to reorder patches,

Re: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-08 Thread Matthieu CASTET
Alexander Shishkin a écrit : Peter Chen peter.c...@freescale.com writes: Hi David Hi, I notice at your code for hw_usb_set_address, there is a comment for it /** * This function explicitly sets the address, without the USBADRA (advance) * feature, which is not supported by older

[RFC PATCH 0/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-08 Thread oskar.andero
Hi, When going through our patches to be mainlined I stumbled on this one which we have fixed in many different ways internally. The problem is a NULL pointer dereference that can be triggered by disconnecting the USB cable at a specific time. Before submitting the final patch I would like to

[RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-08 Thread oskar.andero
From: Truls Bengtsson truls.bengts...@sonymobile.com The udc_irq service runs the isr_tr_complete_handler which in turn nukes the endpoints, including a call to rndis_response_complete, if appropriate. If the rndis_msg_parser fails here, an error will be printed using a dev_err call (through the

Re: About USBADRA bit at DEVICEADDR for chipidea driver

2013-03-08 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Fri, Mar 08, 2013 at 12:39:04PM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Hi David Hi, I notice at your code for hw_usb_set_address, there is a comment for it /** * This function explicitly sets

Re: [PATCH 01/13] usb: phy: nop: Add device tree support and binding information

2013-03-08 Thread Roger Quadros
On 03/08/2013 12:46 PM, Marc Kleine-Budde wrote: On 02/04/2013 04:58 PM, Roger Quadros wrote: The PHY clock, clock rate, VCC regulator and RESET regulator can now be provided via device tree. Signed-off-by: Roger Quadros rog...@ti.com --- .../devicetree/bindings/usb/usb-nop-xceiv.txt

Re: fsl_udc_core: set address request aren't handled like expected. usb30cv test suite fails.

2013-03-08 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Thu, Mar 07, 2013 at 09:58:52AM +0100, Peter Bestler wrote: Hi, We try to get our device (based on p2020rdb) usb 2.0 compliant. We ran the usb30cv test suite (version 1.0.1.2, chapter 9 tests for usb 2.0 devices) on win7 with g_zero and

Re: [PATCH 01/13] usb: phy: nop: Add device tree support and binding information

2013-03-08 Thread Marc Kleine-Budde
On 03/08/2013 11:46 AM, Marc Kleine-Budde wrote: On 02/04/2013 04:58 PM, Roger Quadros wrote: The PHY clock, clock rate, VCC regulator and RESET regulator can now be provided via device tree. Signed-off-by: Roger Quadros rog...@ti.com --- .../devicetree/bindings/usb/usb-nop-xceiv.txt

Re: [PATCH 3/5] usb: chipidea: udc: add the define TD_COUNT and fix all users

2013-03-08 Thread Alexander Shishkin
Michael Grzeschik m.grzesc...@pengutronix.de writes: A static count of transfer descriptors was used everywhere in the driver with the fixed number 4. This patch adds a define, named TD_COUNT, and replaces all users of this value. This way its possible to have only one parameter to change and

Re: [PATCH 3/4] USB mxs-phy: use readl(), writel() instead of the _relaxed() versions

2013-03-08 Thread Marc Kleine-Budde
On 02/28/2013 12:25 PM, Alexander Shishkin wrote: Marc Kleine-Budde m...@pengutronix.de writes: This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed() to the plain readl(), writel() functions, which are available on all platforms. This is done to enable compile time

Re: [RFC 03/10] xhci: Handle command stalls.

2013-03-08 Thread Alan Stern
On Thu, 7 Mar 2013, Sarah Sharp wrote: One Ring to rule them all, One Ring to find them, One Ring to bring them all and in the darkness bind them - J. R. R. Tolkien There is only one command ring for each xHCI host, and all commands flow through that ring. However, when a tricksy little

Re: Testing for hardware bug in EHCI controllers

2013-03-08 Thread Alan Stern
On Fri, 8 Mar 2013, Roger Quadros wrote: On 03/04/2013 05:36 AM, Ming Lei wrote: On Tue, Feb 26, 2013 at 4:54 AM, Alan Stern st...@rowland.harvard.edu wrote: I'd be interested to hear the results of testing on a variety of controllers. (This computer also has an NEC EHCI

Re: [PATCH 3/4] USB mxs-phy: use readl(), writel() instead of the _relaxed() versions

2013-03-08 Thread Felipe Balbi
Hi, On Fri, Mar 08, 2013 at 05:05:58PM +0100, Marc Kleine-Budde wrote: On 02/28/2013 12:25 PM, Alexander Shishkin wrote: Marc Kleine-Budde m...@pengutronix.de writes: This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed() to the plain readl(), writel()

Re: [PATCH 1/5] USB chipidea: ci13xxx-imx: create dynamic platformdata

2013-03-08 Thread Felipe Balbi
HI, Hi, On Thu, Feb 28, 2013 at 11:57:00AM +0100, Marc Kleine-Budde wrote: @@ -107,6 +100,18 @@ static int ci13xxx_imx_probe(struct platform_device *pdev) !usbmisc_ops) return -EPROBE_DEFER; + pdata = devm_kzalloc(pdev-dev, sizeof(*pdata), GFP_KERNEL);

Re: [PATCH 3/4] USB mxs-phy: use readl(), writel() instead of the _relaxed() versions

2013-03-08 Thread Marc Kleine-Budde
On 03/08/2013 05:28 PM, Felipe Balbi wrote: Hi, On Fri, Mar 08, 2013 at 05:05:58PM +0100, Marc Kleine-Budde wrote: On 02/28/2013 12:25 PM, Alexander Shishkin wrote: Marc Kleine-Budde m...@pengutronix.de writes: This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed()

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-08 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote: @@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_device *pdev) return -ENODEV; } + /* For now we treat dual-role as otg */ + dr_mode = ci-platdata-dr_mode; + if (dr_mode

Re: [PATCH 5/5] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-03-08 Thread Felipe Balbi
On Thu, Feb 28, 2013 at 11:57:04AM +0100, Marc Kleine-Budde wrote: @@ -147,19 +146,20 @@ static int ci13xxx_imx_probe(struct platform_device *pdev) return ret; } - phy_np = of_parse_phandle(pdev-dev.of_node, fsl,usbphy, 0); - if (phy_np) { -

Re: [PATCH 5/5] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-03-08 Thread Marc Kleine-Budde
On 03/08/2013 05:33 PM, Felipe Balbi wrote: On Thu, Feb 28, 2013 at 11:57:04AM +0100, Marc Kleine-Budde wrote: @@ -147,19 +146,20 @@ static int ci13xxx_imx_probe(struct platform_device *pdev) return ret; } -phy_np = of_parse_phandle(pdev-dev.of_node, fsl,usbphy, 0);

Re: [PATCH 0/5] usb: musb: am335x support

2013-03-08 Thread Daniel Mack
On 07.03.2013 13:51, Daniel Mack wrote: On 04.03.2013 00:53, Daniel Mack wrote: Hi Peter, On 03.03.2013 23:24, Peter Korsgaard wrote: Daniel == Daniel Mack zon...@gmail.com writes: Hi, Daniel On my board, the USB is purely used as host interface, with a Daniel type B plug soldered. In

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-08 Thread Alexander Shishkin
On 8 March 2013 18:33, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote: @@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_device *pdev) return -ENODEV; } + /* For now we treat dual-role as otg */ +

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-08 Thread Marc Kleine-Budde
On 03/08/2013 05:46 PM, Alexander Shishkin wrote: On 8 March 2013 18:33, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote: @@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_device *pdev) return -ENODEV; }

[PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-08 Thread Alexey Khoroshilov
As it was described by Oliver Neukum in commit acbe2fe USB: Don't use GFP_KERNEL while we cannot reset a storage device: Memory allocations with GFP_KERNEL can cause IO to a storage device which can fail resulting in a need to reset the device. Therefore GFP_KERNEL cannot be safely used

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Stephen Warren
On 03/08/2013 12:14 AM, Felipe Balbi wrote: Hi, On Thu, Mar 07, 2013 at 02:20:36PM -0700, Stephen Warren wrote: On 03/07/2013 02:35 AM, Felipe Balbi wrote: Hi folks, inspired by Paul's DWC2 patchset which added usb_otg_state_string() (a copy of otg_state_string()) I have now renamed

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-08 Thread Stephen Warren
On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that we have sensible names for all phy drivers. Current situation was already quite bad with too generic names being

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-08 Thread Alan Stern
On Sat, 9 Mar 2013, Alexey Khoroshilov wrote: As it was described by Oliver Neukum in commit acbe2fe USB: Don't use GFP_KERNEL while we cannot reset a storage device: Memory allocations with GFP_KERNEL can cause IO to a storage device which can fail resulting in a need to reset the

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Felipe Balbi
On Fri, Mar 08, 2013 at 10:14:11AM -0700, Stephen Warren wrote: On 03/08/2013 12:14 AM, Felipe Balbi wrote: Hi, On Thu, Mar 07, 2013 at 02:20:36PM -0700, Stephen Warren wrote: On 03/07/2013 02:35 AM, Felipe Balbi wrote: Hi folks, inspired by Paul's DWC2 patchset which added

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-08 Thread Stephen Warren
On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that we have sensible names for all phy drivers. Current situation was already quite bad with too generic names being

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Stephen Warren
On 03/08/2013 11:26 AM, Felipe Balbi wrote: On Fri, Mar 08, 2013 at 10:14:11AM -0700, Stephen Warren wrote: On 03/08/2013 12:14 AM, Felipe Balbi wrote: Hi, On Thu, Mar 07, 2013 at 02:20:36PM -0700, Stephen Warren wrote: On 03/07/2013 02:35 AM, Felipe Balbi wrote: Hi folks, inspired by

Re: [RFC 03/10] xhci: Handle command stalls.

2013-03-08 Thread Sarah Sharp
On Fri, Mar 08, 2013 at 11:14:38AM -0500, Alan Stern wrote: On Thu, 7 Mar 2013, Sarah Sharp wrote: One Ring to rule them all, One Ring to find them, One Ring to bring them all and in the darkness bind them - J. R. R. Tolkien There is only one command ring for each xHCI host, and

Re: [PATCH 1/3] usb: phy: isp1301: give it a context structure

2013-03-08 Thread Sergei Shtylyov
Hello. On 08-03-2013 15:30, Felipe Balbi wrote: this patch is a small preparation to fix isp1301 driver so that other platforms can use it. We're defining our private data structure to represent this device and adding the PHY to the PHY list. Later patches will come implementing proper

Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-08 Thread Sergei Shtylyov
Hello. On 08-03-2013 16:53, oskar.and...@sonymobile.com wrote: From: Truls Bengtsson truls.bengts...@sonymobile.com The udc_irq service runs the isr_tr_complete_handler which in turn nukes the endpoints, including a call to rndis_response_complete, if appropriate. If the rndis_msg_parser

Re: [PATCH 3/3] usb: phy: isp1301: implement PHY API

2013-03-08 Thread Sergei Shtylyov
Hello. On 08-03-2013 15:30, Felipe Balbi wrote: this patch implements -init() and -set_vbus() methods for isp1301 transceiver driver. Later patches can now come in order to remove the hackery from ohci-nxp and lpc32xx udc drivers. Signed-off-by: Felipe Balbi ba...@ti.com ---

Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-08 Thread Greg Kroah-Hartman
On Fri, Mar 08, 2013 at 11:56:26PM +0400, Sergei Shtylyov wrote: Hello. On 08-03-2013 16:53, oskar.and...@sonymobile.com wrote: From: Truls Bengtsson truls.bengts...@sonymobile.com The udc_irq service runs the isr_tr_complete_handler which in turn nukes the endpoints, including a call

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-08 Thread Oliver Neukum
On Friday 08 March 2013 12:55:08 Alan Stern wrote: On Sat, 9 Mar 2013, Alexey Khoroshilov wrote: As it was described by Oliver Neukum in commit acbe2fe USB: Don't use GFP_KERNEL while we cannot reset a storage device: Memory allocations with GFP_KERNEL can cause IO to a storage

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-08 Thread Alexander Shishkin
On 8 March 2013 18:52, Marc Kleine-Budde m...@pengutronix.de wrote: On 03/08/2013 05:46 PM, Alexander Shishkin wrote: On 8 March 2013 18:33, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote: @@ -487,14 +488,23 @@ static int

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-08 Thread Greg Kroah-Hartman
On Sat, Mar 09, 2013 at 12:50:47AM +0800, Alexey Khoroshilov wrote: As it was described by Oliver Neukum in commit acbe2fe USB: Don't use GFP_KERNEL while we cannot reset a storage device: Memory allocations with GFP_KERNEL can cause IO to a storage device which can fail resulting in a

RFC: [PATCH 0/3] usb: cdc_ncm: patches for MirrorLink

2013-03-08 Thread Loic Domaigne
The following serie of patches has been devised at jambit within the MirrorLink(TM) context. It contains: - a patch for getting acceptable performance of the NCM driver under WMware environment (tested so far up to Workstation 9.0) - a patch to have a single driver source for many kernel

RFC: [PATCH 1/3] usb: cdc_ncm: patch for VMware

2013-03-08 Thread Loic Domaigne
This patch limits the Rx URB size to 16kB if the driver is compiled for a VMware environment. As of workstation 9, there are some major performance problems if the Rx URB size exceeds that limit. This patch applies to longterm kernel version 3.4.35. Signed-Off-By: Loic Domaigne

RFC: [PATCH 2/3] usb: cdc_ncm: patch for multi kernel versions

2013-03-08 Thread Loic Domaigne
This patch allows to have a single source for many kernel versions. As the NCM driver at jambit runs on a wide range of embedded linux (from 2.6.35 to 3.4.x) we devised this convenient patch. This patch applies to longterm kernel version 3.4.35. Signed-Off-By: Loic Domaigne

RFC: [PATCH 3/3] usb: cdc_ncm: MirrorLink booster for N60x,70x

2013-03-08 Thread Loic Domaigne
This patch allows to boost the performance if used for MirrorLink(TM). It is derived from a patch provided by Nokia-LC/Berlin. It optimizes the transfer speed for the Nokia N60x,70x. which requires special settings (jumbo frame, no batching) This patch applies to longterm kernel version 3.4.35.

DWC2 driver to staging tree?

2013-03-08 Thread Paul Zimmerman
Hi Greg, It looks like the DWC2 driver is not going to be ready for mainline any time soon, so would it be acceptable to add it to the staging tree as-is? I really need to show some progress being made here, or my management will ask me to stop work on it altogether. If it's in staging, I can at

Re: DWC2 driver to staging tree?

2013-03-08 Thread gre...@linuxfoundation.org
On Fri, Mar 08, 2013 at 09:18:51PM +, Paul Zimmerman wrote: Hi Greg, It looks like the DWC2 driver is not going to be ready for mainline any time soon, so would it be acceptable to add it to the staging tree as-is? I really need to show some progress being made here, or my management

Re: [PATCH v3 1/2] usb: add find_raw_port_number callback to struct hc_driver()

2013-03-08 Thread Sarah Sharp
Hi Tianyu, Sorry for the long long delay in reviewing this. :( On Fri, Jan 25, 2013 at 10:29:26AM +0800, Lan Tianyu wrote: xhci driver divides the root hub into two logical hubs which work respectively for usb 2.0 and usb 3.0 devices. They are independent devices in the usb core. But in the

Re: RFC: [PATCH 1/3] usb: cdc_ncm: patch for VMware

2013-03-08 Thread Dan Williams
On Fri, 2013-03-08 at 22:03 +0100, Loic Domaigne wrote: This patch limits the Rx URB size to 16kB if the driver is compiled for a VMware environment. As of workstation 9, there are some major performance problems if the Rx URB size exceeds that limit. This patch applies to longterm kernel

Re: 3.9.0-rc1+: irq 16: nobody cared

2013-03-08 Thread Peter Hurley
[ +linux-usb, linux-pci] This is the 2nd report today for unhandled interrupts with usb hcd. On Fri, 2013-03-08 at 08:37 +0100, Thomas Meyer wrote: [1.883369] input: C-Media Electronics Inc. USB Multimedia Audio Device as

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Arnd Bergmann
On Friday 08 March 2013, Stephen Warren wrote: Yes, I think it should instead work like: ARCH_TEGRA* selects nothing in particular related to USB. The Tegra EHCI controller Kconfig depends on ARCH_TEGRA so it doesn't show up for other builds. Yes, that's fine. I hope it's OK for the

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Stephen Warren
On 03/08/2013 04:08 PM, Arnd Bergmann wrote: On Friday 08 March 2013, Stephen Warren wrote: Yes, I think it should instead work like: ARCH_TEGRA* selects nothing in particular related to USB. The Tegra EHCI controller Kconfig depends on ARCH_TEGRA so it doesn't show up for other builds.

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Arnd Bergmann
On Friday 08 March 2013, Stephen Warren wrote: config USB_ULPI_VIEWPORT def_bool y depends on USB_EHCI_TEGRA If USB_ULPI_VIEWPORT has any other dependencies, the best solution in the above scenario is to make USB_EHCI_TEGRA depend on those. USB_ULPI_VIEWPORT is, AFAIK,

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Stephen Warren
On 03/08/2013 04:56 PM, Arnd Bergmann wrote: On Friday 08 March 2013, Stephen Warren wrote: config USB_ULPI_VIEWPORT def_bool y depends on USB_EHCI_TEGRA If USB_ULPI_VIEWPORT has any other dependencies, the best solution in the above scenario is to make USB_EHCI_TEGRA depend on

Re: [RFC 03/10] xhci: Handle command stalls.

2013-03-08 Thread Alan Stern
On Fri, 8 Mar 2013, Sarah Sharp wrote: On Fri, Mar 08, 2013 at 11:14:38AM -0500, Alan Stern wrote: On Thu, 7 Mar 2013, Sarah Sharp wrote: One Ring to rule them all, One Ring to find them, One Ring to bring them all and in the darkness bind them - J. R. R. Tolkien There is

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-08 Thread Alan Stern
On Fri, 8 Mar 2013, Peter Hurley wrote: [ +linux-usb ] On Fri, 2013-03-08 at 14:12 -0500, Shawn Starr wrote: Hello folks, I am noticing since rc0 and now rc1, very poor interrupt handling. Keyboard response, mouse movements, display refreshing etc. General input/display

Re: PROBLEM: USB device registered on OHCI instead of EHCI at boot

2013-03-08 Thread Alan Stern
On Fri, 8 Mar 2013, Bruce Guenter wrote: I have an internal card reader in my computer. Recently (not sure which kernel version), it has been registered with the OCHI bus on boot instead of EHCI, resulting in slow I/O speeds. Unplugging it (from the motherboard) and plugging it back in fixes

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-08 Thread Alan Stern
On Fri, 8 Mar 2013, Jenya Y wrote: On 03/07/2013 09:16 PM, Alan Stern wrote: It isn't. What _would_ be helpful is if you do what I suggested earlier: Build a kernel with CONFIG_USB_DEBUG enabled and post the output from the dmesg command showing what happens during boot. Alan Stern

Re: [PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

2013-03-08 Thread Alan Stern
On Fri, 8 Mar 2013, Oliver Neukum wrote: On Friday 08 March 2013 12:55:08 Alan Stern wrote: On Sat, 9 Mar 2013, Alexey Khoroshilov wrote: As it was described by Oliver Neukum in commit acbe2fe USB: Don't use GFP_KERNEL while we cannot reset a storage device: Memory

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-08 Thread Jenya Y
On 03/09/2013 03:50 AM, Alan Stern wrote: Stern wrote: I recompiled the kernel CONFIG_USB_DEBUG flag and here is the output of the dmesg. Okay, this is good. It looks like your .config has CONFIG_USB_EHCI_HCD=y and CONFIG_USB_UHCI_HCD=y, right? And it also has CONFIG_USB_EHCI_PCI=m. That's

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-08 Thread Jenya Y
On 03/09/2013 04:03 AM, Jenya Y wrote: On 03/09/2013 03:50 AM, Alan Stern wrote: Stern wrote: I recompiled the kernel CONFIG_USB_DEBUG flag and here is the output of the dmesg. Okay, this is good. It looks like your .config has CONFIG_USB_EHCI_HCD=y and CONFIG_USB_UHCI_HCD=y, right? And it

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-08 Thread Jenya Y
On 03/09/2013 05:10 AM, Jenya Y wrote: On 03/09/2013 04:03 AM, Jenya Y wrote: Okay, this is good. It looks like your .config has CONFIG_USB_EHCI_HCD=y and CONFIG_USB_UHCI_HCD=y, right? And it also has CONFIG_USB_EHCI_PCI=m. That's why you're getting all those error messages. Change it to