Re: [PATCH] USB: EHCI: fix for leaking isochronous data

2013-03-15 Thread Soeren Moch
On 14.03.2013 22:33, Alan Stern wrote: Maybe a better way to go about this is, instead of printing out every allocation and deallocation, to keep a running counter. You could have the driver print out the value of this counter every minute or so. Any time the device isn't in use, the counter sh

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Greg Kroah-Hartman
On Fri, Mar 15, 2013 at 09:13:52PM +, Arnd Bergmann wrote: > On Friday 15 March 2013, Greg Kroah-Hartman wrote: > > > Unless something is changed, this patch won't get into 3.9-final. > > > Do you want Greg to move it to his usb-linus branch? > > > > It's a bit too "big" for 3.9-final, sorry

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Sergei Shtylyov
Hello. On 03/16/2013 12:11 AM, Arnd Bergmann wrote: On Friday 15 March 2013, Sergei Shtylyov wrote: a) Apply Roger's patch for 3.9, and add my "USB: EHCI: DT support for generic bus glue" patch on top after it has been tested Arnd, sorry, where can I find this patch? Archive search

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Greg Kroah-Hartman wrote: > > Unless something is changed, this patch won't get into 3.9-final. > > Do you want Greg to move it to his usb-linus branch? > > It's a bit too "big" for 3.9-final, sorry. Would you consider the hot fix at the start of this thread for 3.9 the

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Sergei Shtylyov wrote: > > > > a) Apply Roger's patch for 3.9, and add my "USB: EHCI: DT support > > for generic bus glue" patch on top after it has been tested > > Arnd, sorry, where can I find this patch? Archive search doesn't > turn up anything... It's in thi

Re: [PATCH 8/9] usb: host: ehci-tegra: fix PHY error handling

2013-03-15 Thread Stephen Warren
On 03/15/2013 03:12 AM, Felipe Balbi wrote: > PHY layer no longer returns NULL, we must > switch from IS_ERR_OR_NULL() to IS_ERR(). This change will definitely conflict with some Tegra EHCI/USB-PHY changes that Venu plans to submit very soon, for 3.10. This is relevant since we'd previously discus

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Sergei Shtylyov
Hello. On 03/15/2013 11:15 PM, Arnd Bergmann wrote: On Friday 15 March 2013, Alan Stern wrote: I just got an automated message from Greg: -- This is a note to let you know that I've just added the patch titled USB:

RE: Two remain problems at chipidea driver

2013-03-15 Thread Svetoslav Neykov
Hi Peter, >> There is a core on mips which doesn't support otg. From my point of >> view, support for dual_role should be a separate patch, ideally by >> Svetoslav (Cc'ed) who has this hardware, after we've cleaned up all >> dr-mode related stuff. > >What means support OTG? The spec said it or the

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-15 Thread Stephen Warren
On 03/14/2013 05:01 AM, Felipe Balbi wrote: > On Fri, Mar 08, 2013 at 11:37:17AM -0700, Stephen Warren wrote: >> On 03/08/2013 11:26 AM, Felipe Balbi wrote: >>> On Fri, Mar 08, 2013 at 10:14:11AM -0700, Stephen Warren >>> wrote: On 03/08/2013 12:14 AM, Felipe Balbi wrote: > Hi, >

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Alan Stern wrote: > I just got an automated message from Greg: > > -- > This is a note to let you know that I've just added the patch titled > > USB: EHCI: split ehci-omap out to a separate driver

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Alan Stern wrote: > On Fri, 15 Mar 2013, Arnd Bergmann wrote: > > @@ -89,12 +90,17 @@ static int ehci_platform_probe(struct platform_device > > *dev) > > return -ENXIO; > > } > > > > - if (pdata->power_on) { > > + if (pdata && pdata->power_on) { > >

Re: [PATCH 2/5] USB: ftdi_sio: fix use after free in TIOCMIWAIT

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 08:29:12PM +0100, Johan Hovold wrote: > On Fri, Mar 15, 2013 at 12:04:34PM -0700, Greg KH wrote: > > For now, consider all patches you have sent to me previously, that I > > have not applied, as dropped from my todo queues. > > Great, but only the USB-ones, right? Yes, I s

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 12:05:58PM -0700, Greg KH wrote: > On Thu, Mar 07, 2013 at 03:55:47PM +0100, Johan Hovold wrote: > > These patches against 3.9-rc1 fix a few issues with tty-port hangup and > > close. > > Are these for 3.9-final? I'd say it can wait for 3.10 as it fixes long-standing issue

Re: [PATCH 2/5] USB: ftdi_sio: fix use after free in TIOCMIWAIT

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 12:04:34PM -0700, Greg KH wrote: > On Fri, Mar 15, 2013 at 06:16:07PM +0100, Johan Hovold wrote: > > On Wed, Feb 27, 2013 at 01:52:27PM +0100, Johan Hovold wrote: > > > Make sure to check the serial disconnected flag before accessing port > > > private data after waking up.

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Greg Kroah-Hartman
On Fri, Mar 15, 2013 at 03:19:08PM -0400, Alan Stern wrote: > On Fri, 15 Mar 2013, Arnd Bergmann wrote: > > > On Friday 15 March 2013, Alan Stern wrote: > > > Roger just submitted my patch to split out ehci-omap. > > > > Ok, if we can merge that for 3.9, the main issue will be resolved, because >

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Gene Heskett
On Friday 15 March 2013 15:19:17 Greg KH did opine: > On Fri, Mar 15, 2013 at 02:39:57PM -0400, Gene Heskett wrote: > > On Friday 15 March 2013 14:39:35 Greg KH did opine: > > > On Fri, Mar 15, 2013 at 02:07:52PM -0400, Gene Heskett wrote: > > > > On Friday 15 March 2013 13:51:47 Greg KH did opine

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Arnd Bergmann wrote: > On Friday 15 March 2013, Alan Stern wrote: > > Roger just submitted my patch to split out ehci-omap. > > Ok, if we can merge that for 3.9, the main issue will be resolved, because > an OMAP+Orion config is much more interesting in practice than adding >

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Yinghai Lu
On Fri, Mar 15, 2013 at 8:14 AM, Jiri Kosina wrote: > Just a datapoint -- I have put a trivial debugging patch in place, and it > reveals that "nobody cared" for irq 16 happens long after last > > I915_WRITE(GMBUS4 + reg_offset, 0); > > has been performed in gmbus_wait_hw_status(). On the

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Gene Heskett
On Friday 15 March 2013 15:02:42 Alan Stern did opine: > On Fri, 15 Mar 2013, Gene Heskett wrote: > > On Friday 15 March 2013 14:08:40 Alan Stern did opine: > > > On Fri, 15 Mar 2013, Gene Heskett wrote: > > > > Greetings; > > > > > > > > What modules do I need to make builtin in order to have a

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-15 Thread Greg Kroah-Hartman
On Thu, Mar 07, 2013 at 03:55:47PM +0100, Johan Hovold wrote: > These patches against 3.9-rc1 fix a few issues with tty-port hangup and > close. Are these for 3.9-final? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...

Re: [PATCH 2/5] USB: ftdi_sio: fix use after free in TIOCMIWAIT

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 06:16:07PM +0100, Johan Hovold wrote: > On Wed, Feb 27, 2013 at 01:52:27PM +0100, Johan Hovold wrote: > > Make sure to check the serial disconnected flag before accessing port > > private data after waking up. > > > > This fixes a use after free in the ftdi_sio introduced b

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 02:39:57PM -0400, Gene Heskett wrote: > On Friday 15 March 2013 14:39:35 Greg KH did opine: > > > On Fri, Mar 15, 2013 at 02:07:52PM -0400, Gene Heskett wrote: > > > On Friday 15 March 2013 13:51:47 Greg KH did opine: > > > > On Fri, Mar 15, 2013 at 01:20:41PM -0400, Gene H

[PATCH] USB: EHCI: fix regression during bus resume

2013-03-15 Thread Alan Stern
This patch (as1663) fixes a regression caused by commit 6e0c3339a6f19d748f16091d0a05adeb1e1f822b (USB: EHCI: unlink one async QH at a time). In order to avoid keeping multiple QHs in an unusable intermediate state, that commit changed unlink_empty_async() so that it unlinks only one empty QH at a

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Gene Heskett
On Friday 15 March 2013 14:39:35 Greg KH did opine: > On Fri, Mar 15, 2013 at 02:07:52PM -0400, Gene Heskett wrote: > > On Friday 15 March 2013 13:51:47 Greg KH did opine: > > > On Fri, Mar 15, 2013 at 01:20:41PM -0400, Gene Heskett wrote: > > > > Greetings; > > > > > > > > What modules do I need

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Gene Heskett wrote: > On Friday 15 March 2013 14:08:40 Alan Stern did opine: > > > On Fri, 15 Mar 2013, Gene Heskett wrote: > > > Greetings; > > > > > > What modules do I need to make builtin in order to have a working > > > keyboard > > > > > when the boot fails when the k

Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-15 Thread Greg KH
On Tue, Mar 05, 2013 at 11:45:28AM +0100, Thomas Renninger wrote: > On Monday, March 04, 2013 05:14:43 PM Thomas Renninger wrote: > > From: Hannes Reinecke > > > > xhci has its own interrupt enabling routine, which will try to > > use MSI-X/MSI if present. So the usb core shouldn't try to enable

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Gene Heskett
On Friday 15 March 2013 14:08:40 Alan Stern did opine: > On Fri, 15 Mar 2013, Gene Heskett wrote: > > Greetings; > > > > What modules do I need to make builtin in order to have a working > > keyboard > > > when the boot fails when the keyboard/mouse is this: > The question doesn't make sense. I

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 02:07:52PM -0400, Gene Heskett wrote: > On Friday 15 March 2013 13:51:47 Greg KH did opine: > > > On Fri, Mar 15, 2013 at 01:20:41PM -0400, Gene Heskett wrote: > > > Greetings; > > > > > > What modules do I need to make builtin in order to have a working > > > keyboard > >

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Gene Heskett
On Friday 15 March 2013 13:51:47 Greg KH did opine: > On Fri, Mar 15, 2013 at 01:20:41PM -0400, Gene Heskett wrote: > > Greetings; > > > > What modules do I need to make builtin in order to have a working > > keyboard > > > when the boot fails when the keyboard/mouse is this: > What is different

[PATCH] USB: net2280: remove leftover driver->unbind call in error pathway

2013-03-15 Thread Alan Stern
This patch (as1667) removes an incorrect driver->unbind() call from the net2280 driver. If startup fails, the UDC core takes care of unbinding the gadget driver automatically; the controller driver shouldn't do it too. Signed-off-by: Alan Stern --- drivers/usb/gadget/net2280.c |1 - 1 fil

[PATCH] USB: UDC core: fix a regression during gadget driver unbinding

2013-03-15 Thread Alan Stern
This patch (as1666) fixes a regression in the UDC core. The core takes care of unbinding gadget drivers, and it does the unbinding before telling the UDC driver to turn off the controller hardware. When the call to the udc_stop callback is made, the gadget no longer has a driver. The callback rou

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Gene Heskett wrote: > Greetings; > > What modules do I need to make builtin in order to have a working keyboard > when the boot fails when the keyboard/mouse is this: The question doesn't make sense. If boot fails, _none_ of the devices in the system will work. Alan Stern

Re: ccg USB gadget driver is now dead

2013-03-15 Thread Felipe Balbi
HI, On Fri, Mar 15, 2013 at 08:11:16AM -0700, Greg KH wrote: > On Fri, Mar 15, 2013 at 09:37:02AM +0200, Felipe Balbi wrote: > > On Thu, Mar 14, 2013 at 03:25:05PM -0700, Greg KH wrote: > > > FYI, I just applied this patch to my staging and USB trees, hopefully > > > this makes some people here ha

Re: Linux USB file storage gadget with new UDC

2013-03-15 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 11:00:45AM -0400, Alan Stern wrote: > On Fri, 15 Mar 2013, Felipe Balbi wrote: > > > On Fri, Mar 15, 2013 at 04:26:10PM +0800, victor yeo wrote: > > > Hi, > > > > > > > On Fri, Mar 15, 2013 at 01:59:30PM +0800, victor yeo wrote: > > > >> For bulk transfer, the new UDC driv

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Arnd Bergmann wrote: > On Friday 15 March 2013, Alan Stern wrote: > > Roger just submitted my patch to split out ehci-omap. > > Ok, if we can merge that for 3.9, the main issue will be resolved, because > an OMAP+Orion config is much more interesting in practice than adding >

Re: Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 01:20:41PM -0400, Gene Heskett wrote: > Greetings; > > What modules do I need to make builtin in order to have a working keyboard > when the boot fails when the keyboard/mouse is this: What is different from a working system? Did 3.8.1 work? Does 3.8.3 work? We need so

Keyboard/mouse dead in 3.8.2 from kernel.org

2013-03-15 Thread Gene Heskett
Greetings; What modules do I need to make builtin in order to have a working keyboard when the boot fails when the keyboard/mouse is this: Bus 002 Device 002: ID 045e:0745 Microsoft Corp. Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bD

Re: [PATCH 1/1] usb: xhci: fix build warning

2013-03-15 Thread Sarah Sharp
On Fri, Mar 15, 2013 at 10:47:50AM -0400, Alan Stern wrote: > On Fri, 15 Mar 2013, Peter Chen wrote: > > > On Thu, Mar 14, 2013 at 10:59:45AM -0400, Alan Stern wrote: > > > On Thu, 14 Mar 2013, Peter Chen wrote: > > > > > > > /home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c

Re: [PATCH 2/5] USB: ftdi_sio: fix use after free in TIOCMIWAIT

2013-03-15 Thread Johan Hovold
On Wed, Feb 27, 2013 at 01:52:27PM +0100, Johan Hovold wrote: > Make sure to check the serial disconnected flag before accessing port > private data after waking up. > > This fixes a use after free in the ftdi_sio introduced by commit > 876ae50d94b ("USB: ftdi_sio: fix race condition in TIOCMIWAIT

[PATCH] usb: misc: sisusbvga: Avoid NULL pointer dereference from sisusb

2013-03-15 Thread Colin King
From: Colin Ian King A failed kzalloc() is reported with a dev_err that dereferences the null sisusb, this will cause a NULL pointer deference error. Instead, pass dev->dev to the dev_err() rather than &sisusb->sisusb_dev->dev Smatch analysis: drivers/usb/misc/sisusbvga/sisusb.c:3087 sisusb_pr

Re: Testing for hardware bug in EHCI controllers

2013-03-15 Thread Sarah Sharp
On Fri, Mar 15, 2013 at 11:08:12AM -0400, Alan Stern wrote: > On Fri, 15 Mar 2013, Noone Nowhere wrote: > > > Hello Alan again, we will clear things up. Sorry for the late reply, > > dark forces delayed us. > > > > > > > Intel probably doesn't care, because they don't make the affected > > > chi

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Alan Stern wrote: > Roger just submitted my patch to split out ehci-omap. Ok, if we can merge that for 3.9, the main issue will be resolved, because an OMAP+Orion config is much more interesting in practice than adding VT8500 to the mix. An alternative for VT8500 would be

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Arnd Bergmann wrote: > A number of ARM platforms were changed in linux-3.9 so they can be enabled > at a single kernel configuration. Unfortunately, the necessary changes for > the EHCI driver were not ready in time and the first attempt to split out > the EHCI bus glues into

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
On Fri, 15 Mar 2013, Greg KH wrote: > > > > > I have the same problem on my Lenovo T500. I think the graphics card > > > > > is > > > > > involved. > > > > > > > > > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > > > > > Mobility Radeon HD 3650. When I boot with the In

Re: [PATCH v2 06/23] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes

2013-03-15 Thread Tony Lindgren
Hi, I think you can get rid of quite a bit more of the repeated data for most boards, see below. * Roger Quadros [130315 08:21]: > Add 2 platform devices for 'nop-usb-xceiv'. These will be used > as PHYs for HS USB ports 1 and 2 so provide binding information > for them. > > Use usbhs_init_phys

Re: [PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread kishon
On Friday 15 March 2013 08:09 PM, Felipe Balbi wrote: From: Kishon Vijay Abraham I musb does not use DMA buffer for ep0 but it uses the same giveback function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls *musb_g_giveback*). So for ep0 case request.dma will be '0' and will re

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Arnd Bergmann wrote: > @@ -1409,10 +1409,20 @@ static int __init ehci_hcd_init(void) > if (retval < 0) > goto clean4; > #endif > + > +#ifdef OMAP_PLATFORM_DRIVER > + retval = platform_driver_register(&OMAP_PLATFORM_DRIVER); > + if (retva

Re: [PATCH 1/4] usb: Fix linker errors during build

2013-03-15 Thread kishon
On Friday 15 March 2013 07:55 PM, Felipe Balbi wrote: On Fri, Mar 15, 2013 at 06:58:49PM +0530, Kishon Vijay Abraham I wrote: commit 63378a (usb: phy: remove CONFIG_USB_OTG_UTILS) removed CONFIG_USB_OTG_UTILS from Kconfig but failed to removed from Makefile. Fixed it here. Signed-off-by: Kishon

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 04:37:56PM +0100, Jiri Kosina wrote: > On Fri, 15 Mar 2013, Greg KH wrote: > > > > > I have the same problem on my Lenovo T500. I think the graphics card is > > > > involved. > > > > > > > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > > > > Mobi

[RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
A number of ARM platforms were changed in linux-3.9 so they can be enabled at a single kernel configuration. Unfortunately, the necessary changes for the EHCI driver were not ready in time and the first attempt to split out the EHCI bus glues into separate modules had to get reverted before the mer

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
On Fri, 15 Mar 2013, Greg KH wrote: > > > I have the same problem on my Lenovo T500. I think the graphics card is > > > involved. > > > > > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > > > Mobility Radeon HD 3650. When I boot with the Intel card, I get "irq 16: > > >

Re: Testing for hardware bug in EHCI controllers

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Noone Nowhere wrote: > Hello ,here are the logs from the failing EHCI hosts(chipset-SL > Spec/revision@mainboard-system): > > > ICH4-SL66K@FIC VC37 > 00:1d.7 USB Controller [0c03]: Intel Corporation 82801DB/DBM > (ICH4/ICH4-M) USB2 EHCI Controller [8086:24cd] (rev 01) (prog-

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 02:33:13PM +0100, Jiri Kosina wrote: > On Fri, 15 Mar 2013, Harald Arnesen wrote: > > > I have the same problem on my Lenovo T500. I think the graphics card is > > involved. > > > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > > Mobility Radeon H

[PATCH v2 01/23] usb: phy: nop: Add some parameters to platform data

2013-03-15 Thread Roger Quadros
Add clk_rate parameter to platform data. If supplied, the NOP phy driver will program the clock to that rate during probe. Also add 2 flags, needs_vcc and needs_reset. If the flag is set and the regulator couldn't be found then the driver will bail out with -EPROBE_DEFER. Signed-off-by: Roger Qua

[PATCH v2 03/23] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data

2013-03-15 Thread Roger Quadros
Add platform device and data for 'nop-usb-xceiv'. This will be used as PHY for HS USB port 1, so provide binding information for it. Get rid of managing the PHY clock as it will be done by the PHY driver. For that to work we create a clock alias that links the PHY clock name to the PHY device name

[PATCH v2 04/23] ARM: OMAP2+: omap4panda: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Use usbhs_init_phys() to register the PHY's VCC and RESET regulators. The VCC and RESET will then be managed by the PHY driver. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap4panda.c | 37 +-- 1 files changed, 11 insertions(+), 26 deletions(-) dif

[PATCH v2 02/23] ARM: OMAP2+: omap-usb-host: Add usbhs_init_phys()

2013-03-15 Thread Roger Quadros
This helper allows board support code to add the PHY's VCC and RESET regulators which are GPIO controlled. It also links the "vcc" and "reset" supplies to the PHY's device ID that is supplied in the struct usbhs_phy_data argument. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/usb-host.c

[PATCH v2 00/23] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-15 Thread Roger Quadros
Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done in [1], [2] & [3]. Device tree support is added for Beagleboard and Panda. NOTE: The first patch needs to be shared between the OMAP tree and Felipe's USB tree. v2: - Added helper

[PATCH v2 05/23] ARM: OMAP3: Beagle: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's VCC and RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3beagle.c | 44 +++

[PATCH v2 07/23] ARM: OMAP3: 3630SDP: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-3630sdp.c | 48

[PATCH v2 09/23] ARM: OMAP: AM3517evm: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as a PHY for HS USB Port 1 and 2, so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-am3517evm.c | 41 +

[PATCH v2 11/23] ARM: OMAP3: cm-t3517: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-cm-t3517.c | 45 +++

Re: Testing for hardware bug in EHCI controllers

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Noone Nowhere wrote: > USB stick on 12 different EHCI USB hosts. On VT8235M it took ages to > go to 1000. A human readable timestamp could be used. Evidently the VT8235M is very slow for some of the operations used by the test program. > To sum up printing a start up messag

Re: [PATCH v2 33/85] USB: serial: clean up usb-serial bus device removal

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 08:02:45AM -0400, Peter Hurley wrote: > On Thu, 2013-03-14 at 19:30 +0100, Johan Hovold wrote: > > On Thu, Mar 14, 2013 at 01:39:39PM -0400, Peter Hurley wrote: > > > On Thu, 2013-03-14 at 16:23 +0100, Johan Hovold wrote: > > > > Make sure to unregister the tty-device before

[PATCH v2 12/23] ARM: OMAP: devkit8000: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 1, so provide binding information for it. Signed-off-by: Roger Quadros Acked-by: Felipe Balbi --- arch/arm/mach-omap2/board-devkit8000.c | 20 1 files changed, 12 insertions(+), 8 deletion

[PATCH v2 14/23] ARM: OMAP3: omap3evm: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. VAUX2 supplies the PHY's VCC. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3evm.c | 41 +

[PATCH v2 13/23] ARM: OMAP3: igep0020: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-igep0020.c | 66 +++

[PATCH v2 10/23] ARM: OMAP3: cm-t35: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-cm-t35.c | 45 +

[PATCH v2 08/23] ARM: OMAP: AM3517crane: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 1, so provide binding information for it. Use usbhs_init_phys() to register the PHY's VCC and RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-am3517crane.c | 38 +++

[PATCH v2 06/23] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-3430sdp.c | 47

[PATCH v2 18/23] ARM: OMAP3: overo: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-overo.c | 32 ++--

[PATCH v2 19/23] ARM: OMAP: zoom: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-zoom.c | 32 ++-- 1

[PATCH v2 20/23] ARM: dts: OMAP4: Add HS USB Host IP nodes

2013-03-15 Thread Roger Quadros
Adds device nodes for HS USB Host module, TLL module, OHCI and EHCI controllers. CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4.dtsi | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b

[PATCH v2 21/23] ARM: dts: omap4-panda: Add USB Host support

2013-03-15 Thread Roger Quadros
Provide the RESET and Power regulators for the USB PHY, the USB Host port mode and the PHY device. Also provide pin multiplexer information for the USB host pins. CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4-panda.dts | 56 +

[PATCH v2 17/23] ARM: OMAP3: omap3touchbook: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as a PHY for HS USB Ports 1 and 2, so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulator. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3touchbook.c | 38

[PATCH v2 16/23] ARM: OMAP3: omap3stalker: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3stalker.c | 29 ++-

[PATCH v2 15/23] ARM: OMAP3: omap3pandora: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. VAUX2 supplies the PHY's VCC. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3pandora.c |

[PATCH v2 23/23] ARM: dts: omap3-beagle: Add USB Host support

2013-03-15 Thread Roger Quadros
Provide RESET and Power regulators for the USB PHY, the USB Host port mode and the PHY device. Also provide pin multiplexer information for USB host pins. CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap3-beagle.dts | 71 1 files

[PATCH v2 22/23] ARM: dts: OMAP3: Add HS USB Host IP nodes

2013-03-15 Thread Roger Quadros
Adds device nodes for HS USB Host module, TLL module, OHCI and EHCI controllers. CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap3.dtsi | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi

Re: Two remain problems at chipidea driver

2013-03-15 Thread Alexander Shishkin
Peter Chen writes: > On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: >> >> >> >> I'd say, in the core driver: >> >> 1) get dr_mode from platform data >> >> 2) only if that's DR_MODE_UNKNOWN (iirc), read DCCPARAMS, since it's >> >> not guaranteed to work across all chipi

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
On Fri, 15 Mar 2013, Jiri Kosina wrote: > > I have the same problem on my Lenovo T500. I think the graphics card is > > involved. > > > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > > Mobility Radeon HD 3650. When I boot with the Intel card, I get "irq 16: > > nobody c

Re: ccg USB gadget driver is now dead

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 09:37:02AM +0200, Felipe Balbi wrote: > On Thu, Mar 14, 2013 at 03:25:05PM -0700, Greg KH wrote: > > FYI, I just applied this patch to my staging and USB trees, hopefully > > this makes some people here happy. > > > > > > > > From: Greg Kroah-H

Re: Testing for hardware bug in EHCI controllers

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Noone Nowhere wrote: > Hello Alan again, we will clear things up. Sorry for the late reply, > dark forces delayed us. > > > > Intel probably doesn't care, because they don't make the affected > > chipsets any more. I don't know what AMD is currently making. Do you? > > Ye

Re: [PATCH 0/9] usb: fix PHY error handling

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Felipe Balbi wrote: > Hi Folks, > > this patch set depends on [1] which makes PHY layer > *always* return an error as suggested by Alan Stern. > > I have compiled what I could, please go over the > patches and give your Acked-by or NAK it if you think > there's something wro

Re: Linux USB file storage gadget with new UDC

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Felipe Balbi wrote: > On Fri, Mar 15, 2013 at 04:26:10PM +0800, victor yeo wrote: > > Hi, > > > > > On Fri, Mar 15, 2013 at 01:59:30PM +0800, victor yeo wrote: > > >> For bulk transfer, the new UDC driver has one problem. When SCSI > > >> Inquiry command is received, the UDC

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Felipe Balbi wrote: > > Adding this back in revealed a bug in udc-core. It is fixed as > > follows: > > > > Index: usb-3.9/drivers/usb/gadget/udc-core.c > > === > > --- usb-3.9.orig/drivers/usb/gadget/udc-core.

Re: [PATCH 1/1] usb: xhci: fix build warning

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Peter Chen wrote: > On Thu, Mar 14, 2013 at 10:59:45AM -0400, Alan Stern wrote: > > On Thu, 14 Mar 2013, Peter Chen wrote: > > > > > /home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c: > > > In function ‘handle_port_status’: > > > /home/b29397/work/code/

[PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread Felipe Balbi
From: Kishon Vijay Abraham I musb does not use DMA buffer for ep0 but it uses the same giveback function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls *musb_g_giveback*). So for ep0 case request.dma will be '0' and will result in kernel OOPS if tried to *unmap_dma_buffer* for r

Re: [PATCH] USB: EHCI: fix for leaking isochronous data

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Soeren Moch wrote: > > The log shows a 1-1 match between allocations and deallocations, except > > for three excess allocations about 45 lines before the end. I have no > > idea what's up with those. They may be an artifact arising from where > > you stopped copying the log

Re: [PATCH 2/4] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 06:58:50PM +0530, Kishon Vijay Abraham I wrote: > musb does not use DMA buffer for ep0 but it uses the same giveback > function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls > *musb_g_giveback*). So for ep0 case request.dma will be '0' > and will result in

Re: [PATCH 1/4] usb: Fix linker errors during build

2013-03-15 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 06:58:49PM +0530, Kishon Vijay Abraham I wrote: > commit 63378a (usb: phy: remove CONFIG_USB_OTG_UTILS) removed > CONFIG_USB_OTG_UTILS from Kconfig but failed to removed from Makefile. > Fixed it here. > > Signed-off-by: Kishon Vijay Abraham I I can fold it in original co

Re: [PATCH] usb: gadget: f_mass_storage: add missing memory barrier for thread_wakeup_needed

2013-03-15 Thread Michal Nazarewicz
On Fri, Mar 15 2013, UCHINO Satoshi wrote: > Without this memory barrier, the file-storage thread may fail to > escape from the following while loop, because it may observe new > common->thread_wakeup_needed and old bh->state which are updated by > the callback functions. > > /* Wait for the

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-15 Thread kishon
On Friday 15 March 2013 06:11 PM, Benoit Cousson wrote: + Jon Hi Kishon, On 03/07/2013 02:35 PM, Kishon Vijay Abraham I wrote: Hi Benoit, Here are the dt data patches to get usb device functional in OMAP platforms. All the patches deal with modifying arch/arm/boot except one which modifies D

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
On Fri, 15 Mar 2013, Harald Arnesen wrote: > I have the same problem on my Lenovo T500. I think the graphics card is > involved. > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > Mobility Radeon HD 3650. When I boot with the Intel card, I get "irq 16: > nobody cared" dur

[PATCH 1/4] usb: Fix linker errors during build

2013-03-15 Thread Kishon Vijay Abraham I
commit 63378a (usb: phy: remove CONFIG_USB_OTG_UTILS) removed CONFIG_USB_OTG_UTILS from Kconfig but failed to removed from Makefile. Fixed it here. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/Ma

[PATCH 2/4] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread Kishon Vijay Abraham I
musb does not use DMA buffer for ep0 but it uses the same giveback function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls *musb_g_giveback*). So for ep0 case request.dma will be '0' and will result in kernel OOPS if tried to *unmap_dma_buffer* for requests in ep0. Fixed it by doi

[PATCH 3/4] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-15 Thread Kishon Vijay Abraham I
Used devres APIs devm_request_threaded_irq and devm_regulator_get for requesting irq and for getting regulator respectively. Signed-off-by: Kishon Vijay Abraham I Tested-by: Grazvydas Ignotas --- drivers/usb/phy/phy-twl4030-usb.c | 28 1 file changed, 8 insertions

[PATCH 4/4] usb: otg: twl4030: fix cold plug on OMAP3

2013-03-15 Thread Kishon Vijay Abraham I
Having twl4030_usb_phy_init() (detects if a cable is connected before twl4030 is probed) in twl4030 probe makes cable connect events to be missed by musb glue, since it gets loaded after twl4030. Having twl4030_usb_phy_init as a usb_phy ops lets twl4030_usb_phy_init to be called when glue is ready.

Re: Two remain problems at chipidea driver

2013-03-15 Thread Matthieu CASTET
Peter Chen a écrit : > On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: Do you see any problems with this? >>> How to know vbus status if dr_mode == gadget, we need to indicate connection >>> and disconnection? >> We don't. Do we need to indicate vbus session valid for gadge

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-15 Thread Benoit Cousson
+ Jon Hi Kishon, On 03/07/2013 02:35 PM, Kishon Vijay Abraham I wrote: > Hi Benoit, > > Here are the dt data patches to get usb device functional in OMAP platforms. > > All the patches deal with modifying arch/arm/boot except one which modifies > Documentation/../usb/omap-usb.txt > > Changes f

  1   2   >