On 08.04.2013 12:38, B, Ravi wrote:
> Felipe
>
>> Hi,
>>
>> On Mon, Apr 08, 2013 at 12:25:38PM +0200, B, Ravi wrote:
>>> Daniel
>>>
On 08.04.2013 09:57, B, Ravi wrote:
>> Hi all,
>>
>> here are some patches to separate the HCD and gadget part
>> of the
>> musb
>> driver
On Tuesday 09 April 2013 18:05:51 Dan Williams wrote:
> The driver and firmware sync up through SYNC messages, and the
> firmware's affirmative reply to these SYNC messages appears to be the
> "Reset" indication received via the status interrupt endpoint. Thus the
> driver needs the status interru
On Tuesday 09 April 2013 18:02:27 Dan Williams wrote:
> Some drivers (sierra_net) need the status interrupt URB
> active even when the device is closed, because they receive
> custom indications from firmware. Add functions to refcount
> the status interrupt URB submit/kill operation so that
> sub
> "Daniel" == Daniel Mack writes:
Daniel> The functionality meant to be represented by this symbol will be
Daniel> re-added later, but for now, USB_GADGET_MUSB_HDRC is in fact unused and
Daniel> can be dropped.
Daniel> Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
Daniel> ---
> "Daniel" == Daniel Mack writes:
Daniel> Let the function declarations live in the header files they belong to,
Daniel> which makes it easier to stub them out later.
Daniel> Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
Daniel> ---
Daniel> drivers/usb/musb/musb_core.h | 1
> "Daniel" == Daniel Mack writes:
Daniel> In particular, this introduces musb_host_resume_root_hub()and
Daniel> musb_host_poke_root_hub() which will be stubbed out later.
Daniel> Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this
> "Daniel" == Daniel Mack writes:
Daniel> This will be done from a more appropriate location and as it doesn't
Daniel> work anyway, it can safely be removed before the other changes.
Daniel> Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
Daniel> ---
Daniel> drivers/usb/musb/m
Hi,
>> Earlier, i used file=/dev/mmcblk0p1. Now i use
>> file=/mnt/sd/backing_file. This backing_file is a dummy file system
>> that i created. I attached two jpeg files. One show the MBR and Boot
>> Sector of the backing_file. Another shows the usbmon of the Linux Host
>
> Why did you send jpeg f
> "Daniel" == Daniel Mack writes:
Daniel> The musb struct is currently allocated along with the hcd,
Daniel> which makes it difficult to build a driver that only acts as
Daniel> gadget device.
Daniel> Fix this by allocating musb directly, and keep the hcd around as
Daniel> a pointer in
> "Daniel" == Daniel Mack writes:
Daniel> This makes building the actual object files optional to the selected
Daniel> mode, which saves users who know which kind of USB mode support they
Daniel> need some binary size.
Daniel> Unimplemented functions are stubbed out with static inline fu
> "Daniel" == Daniel Mack writes:
Daniel> This patch re-introduces the bits that are necessary to use the musb
Daniel> controller in host mode.
Acked-by: Peter Korsgaard
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a mess
> "Daniel" == Daniel Mack writes:
Daniel> Define MUSB_PORT_MODE_{HOST,GADGET,DUAL_ROLE} and store the
Daniel> platform-specified value in struct musb.
Daniel> Note that MUSB_PORT_MODE_HOST has to be set to 1 in order to
Daniel> match existing device tree bindings which are already
Danie
> "Daniel" == Daniel Mack writes:
Daniel> Initialize the host and gagdet subsystems of the musb driver only when
Daniel> the appropriate mode is selected from platform data, or device-tree
Daniel> information, respectively.
Daniel> Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
This adds a config option USB_DWC2_DEBUG_PERIODIC that allows debugging
output be suppressed for periodic transfers. This helps when debugging
non-periodic transfers while there are also periodic transfers going on
(both to make the debug output less polluted and to prevent all CPU time
going to de
> "Daniel" == Daniel Mack writes:
Daniel> With the hcd is now a direct member of struct musb, we can now simply
Daniel> eliminate the musb_to_hcd() macro. There aren't that many users left
Daniel> anyway, as some where already fixed up when parts were factored out to
Daniel> musb_host.c
> "Daniel" == Daniel Mack writes:
Daniel> This function has its only user in musb_virthub.c, so let's move it
Daniel> there and make it static.
Daniel> Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
Daniel> ---
Daniel> drivers/usb/musb/musb_core.c| 45
---
Quoting Nishanth Menon (2013-04-09 13:49:00)
> On 10:43-20130409, Tony Lindgren wrote:
> > * Tony Lindgren [130409 09:54]:
> > > * Roger Quadros [130409 03:00]:
> > > > On 04/05/2013 06:58 PM, Tony Lindgren wrote:
> > > > >
> > > > > Can't you just use the clock name there to get it?
> > > >
>
On Wed, Apr 10, 2013 at 09:10:19AM +0200, Daniel Mack wrote:
> On 08.04.2013 12:38, B, Ravi wrote:
> > Felipe
> >
> >> Hi,
> >>
> >> On Mon, Apr 08, 2013 at 12:25:38PM +0200, B, Ravi wrote:
> >>> Daniel
> >>>
> On 08.04.2013 09:57, B, Ravi wrote:
> >> Hi all,
> >>
> >> here are
Hi,
On Tue, Apr 09, 2013 at 07:35:33PM +0200, Matthijs Kooijman wrote:
> > > This adds a config option USB_DWC2_DEBUG_PERIODIC that allows debugging
> > > output be suppressed for periodic transfers. This helps when debugging
> > > non-periodic transfers while there are also periodic transfers goi
Hi,
On Wed, Apr 10, 2013 at 02:32:30AM +0400, Sergei Shtylyov wrote:
> Now that the EHCI internal buffer setup is done by the platform code, we can
> remove such code from this driver as it never really belonged here. We
> also
> no longer need the 2nd memory region now (2nd EHCI controller
Hi Felipe,
> > In some cases, this could help, but a lot of the prints modified by this
> > patch are used for both periodic and non-periodic transfers. AFAIU, with
> > dynamic printks you could only enable/disable them altogether, not based
> > on some arbitrary condition (e.g., the urb being han
On 10.04.2013 10:09, Felipe Balbi wrote:
> On Wed, Apr 10, 2013 at 09:10:19AM +0200, Daniel Mack wrote:
>> On 08.04.2013 12:38, B, Ravi wrote:
>>> Felipe
>>>
Hi,
On Mon, Apr 08, 2013 at 12:25:38PM +0200, B, Ravi wrote:
> Daniel
>
>> On 08.04.2013 09:57, B, Ravi wrote:
>>>
Hi,
On Tue, Apr 09, 2013 at 02:00:46PM -0500, Daniel Santos wrote:
> >>My bother & I are working on a project where we're planning on using
> >>these inexpensive Microchip MCP2210 USB to SPI bridge w/ GPIO
> >>devices. Mathew King at Trilithic started a driver and kindly
> >>released it on github
Hi,
On Wed, Apr 10, 2013 at 01:49:23PM +0900, Simon Horman wrote:
> On Wed, Apr 10, 2013 at 02:26:08AM +0400, Sergei Shtylyov wrote:
> > Hello.
> >
> >Here's the set of 9 patches against the Simon Horman's 'renesas.git'
> > repo,
> > &#
On Wed, Apr 10, 2013 at 02:32:30AM +0400, Sergei Shtylyov wrote:
> Now that the EHCI internal buffer setup is done by the platform code, we can
> remove such code from this driver as it never really belonged here. We
> also
> no longer need the 2nd memory region now (2nd EHCI controller is s
Hi,
On Wed, Apr 10, 2013 at 02:36:50AM +0400, Sergei Shtylyov wrote:
> The memory region that is used by the driver overlaps EHCI and OHCI register
> regions for absolutely no reason now -- fix it by adding offset of 0x800 to
> the base address, changing the register #define's accordingly. This
Hi,
On Wed, Apr 10, 2013 at 02:37:49AM +0400, Sergei Shtylyov wrote:
> Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since
> this
> register contains board-specific USB ports configuration and so its value
> should
> be somehow passed via the platform data. Add file wit
On Wed, Apr 10, 2013 at 02:39:47AM +0400, Sergei Shtylyov wrote:
> Set the USBPCTRL0 register from the passed platform data in
> rcar_usb_phy_init();
> don't reset it to 0 in rcar_usb_phy_shutdown() anymore as that does not make
> sense. Also, don't allow the driver's probe to succeed when the
Hi,
On Wed, Apr 10, 2013 at 02:50:18AM +0400, Sergei Shtylyov wrote:
> The driver currently only supports R8A7779 SoC. Compared to it, R8A7778
> USB-PHY
> has extra register range containing two high-speed signal quality
> characteristic
> control registers which should be set up during USB-PHY
the set of 9 patches against the Simon Horman's 'renesas.git'
> > > repo,
> > > 'renesas-next-20130410' tag. It was created to fix the shortcomings in
> > > the
> > > R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so
>
Vivek Gautam wrote:
>
> Based on 'for-next' of linux-samsung tree with following patches
> from Doug on top:
> usb: Document clocks in samsung, exynos4210-ehci/ohci bindings
> ARM: dts: add usb 2.0 clock references to exynos5250 device tree
>
> Also depending upon following patch-series for Samsu
Vivek Gautam wrote:
>
> This patch-set is in continuation with patch-series:
> [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250
> out of which follwowing patches have been picked up:
> ARM: Exynos5250: Enabling ehci-s5p driver
> ARM: Exynos5250: Enabling ohci-exynos driver
>
> Base
Hi Laurent,
> This patchset tries to enhance the UVC gadget test application and is based
> on Laurent's git tree available here (project: uvc-gadget.git):
> git://git.ideasonboard.org/uvc-gadget.git
>
> The patch 2/2 in this patchset also adds a README file describing the UVC
> gadget test appli
On 04/10/2013 11:06 AM, Mike Turquette wrote:
> Quoting Nishanth Menon (2013-04-09 13:49:00)
>> On 10:43-20130409, Tony Lindgren wrote:
>>> * Tony Lindgren [130409 09:54]:
* Roger Quadros [130409 03:00]:
> On 04/05/2013 06:58 PM, Tony Lindgren wrote:
>>
>> Can't you just use the
On 04/10/2013 12:54 AM, Nishanth Menon wrote:
> On 15:49-20130409, Nishanth Menon wrote:
>> On 10:43-20130409, Tony Lindgren wrote:
>>> * Tony Lindgren [130409 09:54]:
* Roger Quadros [130409 03:00]:
> On 04/05/2013 06:58 PM, Tony Lindgren wrote:
>>
>> Can't you just use the cloc
Hello.
On 10-04-2013 2:47, Sergei Shtylyov wrote:
Here's the set of 4 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130410' tag.
Sorry, forgot to mention that it is atop the previous R8A7779/Marzen USB
patchset.
WBR, Sergei
--
On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote:
> On Tuesday 09 April 2013 18:02:27 Dan Williams wrote:
> > Some drivers (sierra_net) need the status interrupt URB
> > active even when the device is closed, because they receive
> > custom indications from firmware. Add functions to refcoun
On Wednesday 10 April 2013 07:49:11 Dan Williams wrote:
> On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote:
> > On Tuesday 09 April 2013 18:02:27 Dan Williams wrote:
> > > +/* Submit the interrupt URB if it hasn't been submitted yet */
> > > +static int __usbnet_status_start(struct usbnet *d
On Wed, 2013-04-10 at 15:06 +0200, Oliver Neukum wrote:
> On Wednesday 10 April 2013 07:49:11 Dan Williams wrote:
> > On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote:
> > > On Tuesday 09 April 2013 18:02:27 Dan Williams wrote:
>
> > > > +/* Submit the interrupt URB if it hasn't been submitt
Dan Williams writes:
> +int usbnet_status_start(struct usbnet *dev, gfp_t mem_flags)
> +{
> + /* Only drivers that implement a status hook should call this */
> + BUG_ON(dev->interrupt == NULL);
>
I still don't think there is any reason to BUG out. See for example
http://article.gmane.or
On Wednesday 10 April 2013 08:18:57 Dan Williams wrote:
> On Wed, 2013-04-10 at 15:06 +0200, Oliver Neukum wrote:
> > On Wednesday 10 April 2013 07:49:11 Dan Williams wrote:
> > > On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote:
> > > > On Tuesday 09 April 2013 18:02:27 Dan Williams wrote:
>
On Wednesday 10 April 2013 15:25:49 Bjørn Mork wrote:
> Dan Williams writes:
>
> > +int usbnet_status_start(struct usbnet *dev, gfp_t mem_flags)
> > +{
> > + /* Only drivers that implement a status hook should call this */
> > + BUG_ON(dev->interrupt == NULL);
> >
> I still don't think there
On Wed, 2013-04-10 at 15:29 +0200, Oliver Neukum wrote:
> On Wednesday 10 April 2013 08:18:57 Dan Williams wrote:
> > On Wed, 2013-04-10 at 15:06 +0200, Oliver Neukum wrote:
> > > On Wednesday 10 April 2013 07:49:11 Dan Williams wrote:
> > > > On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote:
On Wednesday 10 April 2013 08:54:43 Dan Williams wrote:
> > The refcounting is very good. Just don't mess around with "force"
>
> That's easy to do if the helpers aren't used for suspend/resume, which
> is what I had previously in my v2 patches until Ming suggested that I
> use the helpers there.
On 10-04-2013 13:00, Felipe Balbi wrote:
Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this
register contains board-specific USB ports configuration and so its value should
be somehow passed via the platform data. Add file with
the USBPCTRL0 bit #define's and 'str
Hello.
On 10-04-2013 12:27, Felipe Balbi wrote:
On Wed, Apr 10, 2013 at 02:32:30AM +0400, Sergei Shtylyov wrote:
Now that the EHCI internal buffer setup is done by the platform code, we can
remove such code from this driver as it never really belonged here. We also
no longer need the 2nd
On Wed, 2013-04-10 at 09:15 +0200, Oliver Neukum wrote:
> On Tuesday 09 April 2013 18:05:51 Dan Williams wrote:
> > The driver and firmware sync up through SYNC messages, and the
> > firmware's affirmative reply to these SYNC messages appears to be the
> > "Reset" indication received via the status
On Wed, 2013-04-10 at 15:58 +0200, Oliver Neukum wrote:
> On Wednesday 10 April 2013 08:54:43 Dan Williams wrote:
> > > The refcounting is very good. Just don't mess around with "force"
> >
> > That's easy to do if the helpers aren't used for suspend/resume, which
> > is what I had previously in m
On Wednesday 10 April 2013 09:57:50 Dan Williams wrote:
> On Wed, 2013-04-10 at 09:15 +0200, Oliver Neukum wrote:
> > On Tuesday 09 April 2013 18:05:51 Dan Williams wrote:
> > > The driver and firmware sync up through SYNC messages, and the
> > > firmware's affirmative reply to these SYNC messages
On Wed, 10 Apr 2013, Sergei Shtylyov wrote:
> Sometimes there is a need to initialize some non-standard registers mapped to
> the EHCI region before accessing the standard EHCI registers. Add pre_setup()
> method with 'struct usb_hcd *' parameter to be called just before ehci_setup()
> to the 'e
On Wed, 10 Apr 2013, victor yeo wrote:
> I use kernel 3.4.4, the code in handle_stat1_irqs() is as below. There
> is no reset or disconnect member function in "struct
> usb_gadget_driver" in kernel 3.4.4.
>
> if (stat & (1 << SUSPEND_REQUEST_INTERRUPT)) {
>
On Wed, Apr 10, 2013 at 06:27:14AM +, Blaz Malnersic wrote:
> If it is as you said concerning the undefined state of the USB power
> across a reboot, that information is very helpful for me. It means we have
> to design things differently (apart from the obvious one which is to
> replace the
Dan Williams writes:
> On Wed, 2013-04-10 at 15:25 +0200, Bjørn Mork wrote:
>> Dan Williams writes:
>>
>> > +int usbnet_status_start(struct usbnet *dev, gfp_t mem_flags)
>> > +{
>> > + /* Only drivers that implement a status hook should call this */
>> > + BUG_ON(dev->interrupt == NULL);
>> >
As discussed earlier on this list, we are building a few devices which
provide two serial interfaces via a USB port. Since we last spoke, we
now have a valid VID+PID pair (thank you OpenMoko!) and the interface
seems to work out.
Dan, you said you needed to add this device to a "no probe" list so
On Wed, Apr 10, 2013 at 07:01:40PM +0200, Wesley W. Terpstra wrote:
> Greg, I've attached a small Linux driver which recognizes and the
> USB-Wishbone functionality of the device. It just adds two vendor
> messages to signal to the FPGA that the device has been opened. Please
> let me know what nee
Hi,
On Wed, Apr 10, 2013 at 06:03:49PM +0400, Sergei Shtylyov wrote:
> On 10-04-2013 13:00, Felipe Balbi wrote:
>
> >>Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since
> >>this
> >>register contains board-specific USB ports configuration and so its value
> >>should
> >
On Wed, 2013-04-10 at 19:01 +0200, Wesley W. Terpstra wrote:
> I've attached the output of lsusb -v
... and of course attached the output of an older version of the device.
The capabilities should read:
CDC ACM:
bmCapabilities 0x02
line coding and serial state
... oth
On Wed, 2013-04-10 at 10:08 -0700, Greg KH wrote:
> On Wed, Apr 10, 2013 at 07:01:40PM +0200, Wesley W. Terpstra wrote:
> > Greg, I've attached a small Linux driver which recognizes and the
> > USB-Wishbone functionality of the device. It just adds two vendor
> > messages to signal to the FPGA that
On 13:55-20130410, Roger Quadros wrote:
> On 04/10/2013 11:06 AM, Mike Turquette wrote:
> > Quoting Nishanth Menon (2013-04-09 13:49:00)
> >> On 10:43-20130409, Tony Lindgren wrote:
> >>> * Tony Lindgren [130409 09:54]:
> >>>> * Roger Quadros [130409
Hello.
On 04/10/2013 09:16 PM, Felipe Balbi wrote:
Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this
register contains board-specific USB ports configuration and so its value should
be somehow passed via the platform data. Add file with
the USBPCTRL0 bit #define
On Wednesday 10 April 2013 10:01:20 Dan Williams wrote:
> On Wed, 2013-04-10 at 15:58 +0200, Oliver Neukum wrote:
> > On Wednesday 10 April 2013 08:54:43 Dan Williams wrote:
> > > > The refcounting is very good. Just don't mess around with "force"
> > >
> > > That's easy to do if the helpers aren'
Hi all,
here are some patches to separate the HCD and gadget part of the musb
driver so they can be deselected in Kconfig. They also make the driver
keep track of the configured port mode that is set from DT, so the
actual runtime configuration can be selected dynamically.
One thing that is still
The functionality meant to be represented by this symbol will be
re-added later, but for now, USB_GADGET_MUSB_HDRC is in fact unused and
can be dropped.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/gadget/Kconfig | 8
1 file changed, 8 deletions(-)
diff --git a
Let the function declarations live in the header files they belong to,
which makes it easier to stub them out later.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.h | 17 -
drivers/usb/musb/musb_gadget.h | 17 +++--
drivers/usb
This function has its only user in musb_virthub.c, so let's move it
there and make it static.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.c| 45 -
drivers/usb/musb/musb_core.h| 1 -
drivers/usb/musb/musb_vi
This will be done from a more appropriate location and as it doesn't
work anyway, it can safely be removed before the other changes.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_gadget.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb
This makes building the actual object files optional to the selected
mode, which saves users who know which kind of USB mode support they
need some binary size.
Unimplemented functions are stubbed out with static inline functions.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
driver
This patch re-introduces the bits that are necessary to use the musb
controller in host mode.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.c | 5 +
drivers/usb/musb/musb_host.c | 21 +
drivers/usb/musb/musb_host.h | 8
3
Define MUSB_PORT_MODE_{HOST,GADGET,DUAL_ROLE} and store the
platform-specified value in struct musb.
Note that MUSB_PORT_MODE_HOST has to be set to 1 in order to match
existing device tree bindings which are already documented but in fact
unusued. For information on the bindings, please refer to
Initialize the host and gagdet subsystems of the musb driver only when
the appropriate mode is selected from platform data, or device-tree
information, respectively.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.c| 22 +-
drivers/usb
The musb struct is currently allocated along with the hcd, which makes
it difficult to build a driver that only acts as gadget device.
Fix this by allocating musb directly, and keep the hcd around as
a pointer in the musb struct.
struct hc_driver musb_hc_driver can now also be static to musb_host
With the hcd is now a direct member of struct musb, we can now simply
eliminate the musb_to_hcd() macro. There aren't that many users left
anyway, as some where already fixed up when parts were factored out to
musb_host.c
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb
In particular, this introduces musb_host_resume_root_hub()and
musb_host_poke_root_hub() which will be stubbed out later.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.c | 18 +++---
drivers/usb/musb/musb_host.c | 15 ++-
drivers/usb/
Hi,
On Wed, Apr 10, 2013 at 09:44:33PM +0400, Sergei Shtylyov wrote:
> Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong
> since this
> register contains board-specific USB ports configuration and so its value
> should
> be somehow passed via the platform
* Nishanth Menon [130410 10:44]:
> Details in the patch below (Tony, I have added you as collaborator for
> helping in getting this working-clk_add_alias was'nt needed in the
> internal patch discussion we had - I have taken a bit of freedom in
> adding your contributions to the patch below)
OK t
> "Daniel" == Daniel Mack writes:
Daniel> Initialize the host and gagdet subsystems of the musb driver
Daniel> only when
Sorry, I missed this before - s/gagdet/gadget/
Daniel> the appropriate mode is selected from platform data, or device-tree
Daniel> information, respectively.
Danie
On 04/10/2013 10:40 PM, Felipe Balbi wrote:
Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this
register contains board-specific USB ports configuration and so its value should
be somehow passed via the platform data. Add file with
the USBPCTRL0 bit #define's and
> "Daniel" == Daniel Mack writes:
Daniel> The musb struct is currently allocated along with the hcd, which makes
Daniel> it difficult to build a driver that only acts as gadget device.
Daniel> Fix this by allocating musb directly, and keep the hcd around as
Daniel> a pointer in the musb
On 10.04.2013 20:54, Peter Korsgaard wrote:
>> "Daniel" == Daniel Mack writes:
>
> Daniel> The musb struct is currently allocated along with the hcd, which
> makes
> Daniel> it difficult to build a driver that only acts as gadget device.
>
> Daniel> Fix this by allocating musb directly,
> "Daniel" == Daniel Mack writes:
Hi,
Daniel> +struct musb_hcd_link {
Daniel> + struct musb *musb;
Daniel> +};
Daniel> +
Daniel> +struct musb *hcd_to_musb(struct usb_hcd *hcd)
Daniel> +{
Daniel> + struct musb_hcd_link *link = (struct musb_hcd_link *)
hcd->hcd_priv;
Daniel>
Hi Tony,
On Wed, Apr 10, 2013 at 1:49 PM, Tony Lindgren wrote:
> * Nishanth Menon [130410 10:44]:
>> Details in the patch below (Tony, I have added you as collaborator for
>> helping in getting this working-clk_add_alias was'nt needed in the
>> internal patch discussion we had - I have taken a bi
Hi all,
here are some patches to separate the HCD and gadget part of the musb
driver so they can be deselected in Kconfig. They also make the driver
keep track of the configured port mode that is set from DT, so the
actual runtime configuration can be selected dynamically.
One thing that is still
The functionality meant to be represented by this symbol will be
re-added later, but for now, USB_GADGET_MUSB_HDRC is in fact unused and
can be dropped.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/gadget/Kconfig | 8
1 file changed, 8 deletions(-)
diff --git a
This function has its only user in musb_virthub.c, so let's move it
there and make it static.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.c| 45 -
drivers/usb/musb/musb_core.h| 1 -
drivers/usb/musb/musb_vi
This will be done from a more appropriate location and as it doesn't
work anyway, it can safely be removed before the other changes.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_gadget.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb
The musb struct is currently allocated along with the hcd, which makes
it difficult to build a driver that only acts as gadget device.
Fix this by allocating musb directly, and keep the hcd around as
a pointer in the musb struct.
struct hc_driver musb_hc_driver can now also be static to musb_host
Define MUSB_PORT_MODE_{HOST,GADGET,DUAL_ROLE} and store the
platform-specified value in struct musb.
Note that MUSB_PORT_MODE_HOST has to be set to 1 in order to match
existing device tree bindings which are already documented but in fact
unusued. For information on the bindings, please refer to
With the hcd is now a direct member of struct musb, we can now simply
eliminate the musb_to_hcd() macro. There aren't that many users left
anyway, as some where already fixed up when parts were factored out to
musb_host.c
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb
This patch re-introduces the bits that are necessary to use the musb
controller in host mode.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.c | 5 +
drivers/usb/musb/musb_host.c | 21 +
drivers/usb/musb/musb_host.h | 8
3
Initialize the host and gadget subsystems of the musb driver only when
the appropriate mode is selected from platform data, or device-tree
information, respectively.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.c| 22 +-
drivers/usb
In particular, this introduces musb_host_resume_root_hub()and
musb_host_poke_root_hub() which will be stubbed out later.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.c | 18 +++---
drivers/usb/musb/musb_host.c | 15 ++-
drivers/usb/
This makes building the actual object files optional to the selected
mode, which saves users who know which kind of USB mode support they
need some binary size.
Unimplemented functions are stubbed out with static inline functions.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
driver
Let the function declarations live in the header files they belong to,
which makes it easier to stub them out later.
Signed-off-by: Daniel Mack
Acked-by: Peter Korsgaard
---
drivers/usb/musb/musb_core.h | 17 -
drivers/usb/musb/musb_gadget.h | 17 +++--
drivers/usb
On 10.04.2013 21:15, Peter Korsgaard wrote:
>> "Daniel" == Daniel Mack writes:
>
> Hi,
>
> Daniel> +struct musb_hcd_link {
> Daniel> +struct musb *musb;
> Daniel> +};
> Daniel> +
> Daniel> +struct musb *hcd_to_musb(struct usb_hcd *hcd)
> Daniel> +{
> Daniel> +struct musb_hcd_l
> "Daniel" == Daniel Mack writes:
Hi,
>> Just that it's an unneeded extra level of indirection.
Daniel> Ok, alright. Sent v4 right now.
Thanks!
Daniel> Thanks for your feedback! Much appreciated. Btw - did you try
Daniel> that on your board yet? Does it work for you as well?
Sorry, n
* Nishanth Menon [130410 12:23]:
> On Wed, Apr 10, 2013 at 1:49 PM, Tony Lindgren wrote:
> >
> > We can avoid the concern of storing the struct clk * and do the
> > look up lazily on consumer driver probe by setting a dummy struct
> > clk * here. Then replace of_clk_src_simple_get() with a custom
Some drivers (sierra_net) need the status interrupt URB
active even when the device is closed, because they receive
custom indications from firmware. Add functions to refcount
the status interrupt URB submit/kill operation so that
sub-drivers and the generic driver don't fight over whether
the sta
The driver and firmware sync up through SYNC messages, and the
firmware's affirmative reply to these SYNC messages appears to be the
"Reset" indication received via the status interrupt endpoint. Thus the
driver needs the status interrupt endpoint always active so that the
Reset indication can be
> From: Matthijs Kooijman [mailto:matth...@stdin.nl]
> Sent: Wednesday, April 10, 2013 12:56 AM
>
> This adds a config option USB_DWC2_DEBUG_PERIODIC that allows debugging
> output be suppressed for periodic transfers. This helps when debugging
> non-periodic transfers while there are also periodi
Convert use of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Silviu-Mihai
1 - 100 of 109 matches
Mail list logo
