RE: [PATCH net-next] net/usb: new driver for RTL8152

2013-05-02 Thread hayeswang
Oliver Neukum [mailto:oneu...@suse.de] Sent: Friday, April 26, 2013 7:57 PM To: Hayeswang Cc: gre...@linuxfoundation.org; net...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; nic_swsd Subject: Re: [PATCH net-next] net/usb: new driver for RTL8152 [...]

Re: [PATCH net-next] net/usb: new driver for RTL8152

2013-05-02 Thread Oliver Neukum
On Thursday 02 May 2013 15:46:50 hayeswang wrote: Oliver Neukum [mailto:oneu...@suse.de] Sent: Friday, April 26, 2013 7:57 PM To: Hayeswang Cc: gre...@linuxfoundation.org; net...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; nic_swsd Subject: Re: [PATCH

[PATCH] staging: dwc2: use devm_ioremap_resource()

2013-05-02 Thread Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet laurent.na...@gmail.com --- drivers/staging/dwc2/pci.c |6 +++--- 1 file

Re: [PATCH] staging: dwc2: use devm_ioremap_resource()

2013-05-02 Thread Matthijs Kooijman
Hi Laurent, On Thu, May 02, 2013 at 01:23:17PM +0200, Laurent Navet wrote: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet

[PATCH v2 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread Hayes Wang
Add new driver for supporting Realtek RTL8152 Based USB 2.0 Ethernet Adapters Signed-off-by: Hayes Wang hayesw...@realtek.com Cc: Realtek linux nic maintainers nic_s...@realtek.com --- drivers/net/usb/Kconfig | 11 + drivers/net/usb/Makefile|1 + drivers/net/usb/cdc_ether.c | 10

Re: [PATCH V3 3/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-05-02 Thread Laurent Pinchart
Hi Michael, On Thursday 02 May 2013 00:27:59 Michael Grzeschik wrote: On Mon, Apr 29, 2013 at 10:26:49PM +0200, Laurent Pinchart wrote: On Monday 29 April 2013 17:56:50 Michael Grzeschik wrote: On Mon, Feb 11, 2013 at 08:42:37PM +0100, Laurent Pinchart wrote: On Monday 04 February 2013

USB 3 to SATA ASM1042 dies under I/O load

2013-05-02 Thread Stephan Diestelhorst
Hi, I am using a salvaged (from an external Toshiba spinning disk) SATA - USB 3 adaptor with a VLI701-04 chip behind a ASMedia Technology Inc. ASM1042 SuperSpeed USB Host Controller (ExpressCard slot). I have attached a Samsung sereis 840 SSD and whenever I dd some data onto the disk, the drive

Re: [PATCH] USB: remove remaining instances of USB_SUSPEND

2013-05-02 Thread Alan Stern
On Wed, 1 May 2013, Linus Torvalds wrote: On Wed, May 1, 2013 at 9:13 AM, Alan Stern st...@rowland.harvard.edu wrote: This patch (as1677) removes the remaining instances of that symbol. Btw, what are these as ID's, and what does the noise buy us? Doing a git log | egrep -w

Re: [PATCH v2 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread Greg KH
On Fri, May 03, 2013 at 03:48:07AM +0800, Hayes Wang wrote: +#define PATENTS This product is covered by one or more of the \ + following patents:\n \ + \t\tUS6,570,884, US6,115,776, and US6,327,625.\n Interesting, you are aware of the

Re: xhci_hcd 0000:11:00.0: HW died, polling stopped.

2013-05-02 Thread Alan Stern
On Wed, 1 May 2013, Martin Mokrejs wrote: That's not how drivers work in Linux. They don't unbind all by themselves; they wait until the bus-level code tells them to unbind. xhci-hcd is not alone in this respect; all the drivers behave this way. I don't believe that. From my tests only

[PATCH][USB GADGET] Add a couple kernel-doc lines to prevent warnings.

2013-05-02 Thread Robert P. J. Day
No functional change. Signed-off-by: Robert P. J. Day rpj...@crashcourse.ca --- feel free to tweak explanation if you want something more expansive diff --git a/drivers/usb/gadget/f_ecm.c b/drivers/usb/gadget/f_ecm.c index d893d69..abf8a31 100644 --- a/drivers/usb/gadget/f_ecm.c +++

[PATCH][USB GADGET] Correct typo supperspeed to superspeed.

2013-05-02 Thread Robert P. J. Day
Tidy up kernel-doc content for USB GADGET. No functional change. Signed-off-by: Robert P. J. Day rpj...@crashcourse.ca --- diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index c454a88..f1b0dca 100644 --- a/include/linux/usb/gadget.h +++ b/include/linux/usb/gadget.h @@

[PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c index aa27d7f..8d17a0d 100644 ---

Re: [PATCH 1/2] staging: dwc2: when dma is disabled, clear dev-dma_mask

2013-05-02 Thread Matthijs Kooijman
Hi Paul ( Greg), On Thu, May 02, 2013 at 01:23:42AM +, Paul Zimmerman wrote: From: Paul Zimmerman Sent: Monday, April 29, 2013 6:27 PM From: Matthijs Kooijman [mailto:matth...@stdin.nl] Sent: Monday, April 29, 2013 7:33 AM } else { - dma_set_mask(hsotg-dev, 0);

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Nishanth Menon
On 20:03-20130502, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c index

Re: USB 3 to SATA ASM1042 dies under I/O load

2013-05-02 Thread Martin Mokrejs
Hi Stefan, I can only tell you that I had success with ASM1051 on the drive side (SilverStone Treasure TS04) against both NEC uPD720200 (rev. 3) controller and TI controller on the computer side. But ASM1051 does not propagate S.M.A.R.T. values back from the drive. Once I had a bad firmware in

Re[2]: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Alexander Shiyan
On 20:03-20130502, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Felipe Balbi
Hi, On Thu, May 02, 2013 at 08:28:44PM +0400, Alexander Shiyan wrote: On 20:03-20130502, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21 + 1 file changed, 17 insertions(+), 4 deletions

Re: [PATCH v2 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread David Miller
From: Greg KH gre...@linuxfoundation.org Date: Thu, 2 May 2013 07:12:39 -0700 On Fri, May 03, 2013 at 03:48:07AM +0800, Hayes Wang wrote: +#define PATENTS This product is covered by one or more of the \ +following patents:\n \ +

Sans Digital TR4U+B USB3 controller not working in kernel 3.8, 3.9

2013-05-02 Thread Aaron RIekenberg
I have an AMD E-350 PC with this USB3 controller on the motherboard 03:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host Controller (rev 04) I also have a Sans Digital TR4U+B 4-disk enclosure that I'm attempting to connect to the USB3 ports. Running Ubuntu 12.04.2 with kernel

RE: [PATCH] staging: dwc2: use devm_ioremap_resource()

2013-05-02 Thread Paul Zimmerman
From: Matthijs Kooijman [mailto:matth...@stdin.nl] Sent: Thursday, May 02, 2013 4:22 AM On Thu, May 02, 2013 at 01:23:17PM +0200, Laurent Navet wrote: Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch:

Re: [PATCH 1/1] usb: gadget/uvc: Add support to allocate UVC payload and header as SG elements

2013-05-02 Thread Bhupesh SHARMA
Hi Laurent, On 5/1/2013 3:53 AM, Laurent Pinchart wrote: Hi Bhupesh, On Wednesday 01 May 2013 01:08:23 Bhupesh SHARMA wrote: On 4/29/2013 8:08 PM, Laurent Pinchart wrote: On Wednesday 17 April 2013 09:44:25 Bhupesh Sharma wrote: This patch adds the support in UVC webcam gadget to allocate

Starting frames for isochronous URBs in xhci-hcd

2013-05-02 Thread Alan Stern
Sarah: xhci_queue_isoc_tx_prepare() has a comment saying Always assume URB_ISO_ASAP set. I'd like to see about fixing this, but I don't know where to look. It doesn't seem as though any significant computations are done for the starting frame; the value always gets set to the current

Re: USB 3 to SATA ASM1042 dies under I/O load

2013-05-02 Thread Stephan Diestelhorst
Martin, On 2 May 2013 18:26, Martin Mokrejs mmokr...@fold.natur.cuni.cz wrote: I can only tell you that I had success with ASM1051 on the drive side (SilverStone Treasure TS04) against both NEC uPD720200 (rev. 3) controller and TI controller on the computer side. But ASM1051 does not

[PATCH 0/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-02 Thread Vladimir Zapolskiy
This change removes calls of uvc_function_connect()/uvc_function_disconnect() functions from open()/close() syscalls. This is a bugfix in g_webcam module, in some test scenarios (e.g. UDC in suspend mode or OTG in host mode) straightforward control of D+ pull-up might lead to system's

[PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-02 Thread Vladimir Zapolskiy
This change removes redundant calls to uvc_function_connect() and uvc_function_disconnect() on V4L2 device node open and release. These two functions attemp to control pull-up on D+ line directly, however such an action should be performed by an UDC iteself, and within the gadget there is no

[PATCH 2/2] usb: gadget/uvc: remove connection/disconnection routines

2013-05-02 Thread Vladimir Zapolskiy
The uvc_function_connect() and uvc_function_disconnect() functions are to be removed, because there is no users of them. Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 24

Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-02 Thread Laurent Pinchart
Hi Vladimir, Thank you for the patch. On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote: This change removes redundant calls to uvc_function_connect() and uvc_function_disconnect() on V4L2 device node open and release. These two functions attemp to control pull-up on D+ line directly,

Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-02 Thread Michael Grzeschik
On Fri, May 03, 2013 at 12:18:21AM +0200, Laurent Pinchart wrote: Hi Vladimir, Thank you for the patch. On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote: This change removes redundant calls to uvc_function_connect() and uvc_function_disconnect() on V4L2 device node open and

Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-02 Thread Vladimir Zapolskiy
Hi Laurent, On 05/03/13 01:18, Laurent Pinchart wrote: Hi Vladimir, Thank you for the patch. On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote: This change removes redundant calls to uvc_function_connect() and uvc_function_disconnect() on V4L2 device node open and release. These two

Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-02 Thread Laurent Pinchart
Hi Vladimir, On Friday 03 May 2013 02:00:29 Vladimir Zapolskiy wrote: On 05/03/13 01:18, Laurent Pinchart wrote: On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote: This change removes redundant calls to uvc_function_connect() and uvc_function_disconnect() on V4L2 device node open and

Re: [PATCH] ARM: OMAP-USB: Fix possible memory leak

2013-05-02 Thread Russell King - ARM Linux
On Thu, May 02, 2013 at 07:40:58PM +0300, Felipe Balbi wrote: Hi, On Thu, May 02, 2013 at 08:28:44PM +0400, Alexander Shiyan wrote: On 20:03-20130502, Alexander Shiyan wrote: Signed-off-by: Alexander Shiyan shc_w...@mail.ru --- arch/arm/mach-omap2/usb-host.c | 21

Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-02 Thread Laurent Pinchart
Hi Michael, On Friday 03 May 2013 00:34:40 Michael Grzeschik wrote: On Fri, May 03, 2013 at 12:18:21AM +0200, Laurent Pinchart wrote: On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote: This change removes redundant calls to uvc_function_connect() and uvc_function_disconnect() on

Re: Starting frames for isochronous URBs in xhci-hcd

2013-05-02 Thread Sarah Sharp
On Thu, May 02, 2013 at 04:01:32PM -0400, Alan Stern wrote: Sarah: xhci_queue_isoc_tx_prepare() has a comment saying Always assume URB_ISO_ASAP set. I'd like to see about fixing this, but I don't know where to look. It doesn't seem as though any significant computations are done for

[PATCH v3 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread Hayes Wang
Add new driver for supporting Realtek RTL8152 Based USB 2.0 Ethernet Adapters Signed-off-by: Hayes Wang hayesw...@realtek.com Cc: Realtek linux nic maintainers nic_s...@realtek.com --- drivers/net/usb/Kconfig | 11 + drivers/net/usb/Makefile|1 + drivers/net/usb/cdc_ether.c | 10

Re: [PATCH v3 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread Greg KH
On Fri, May 03, 2013 at 10:01:25AM +0800, Hayes Wang wrote: Add new driver for supporting Realtek RTL8152 Based USB 2.0 Ethernet Adapters Signed-off-by: Hayes Wang hayesw...@realtek.com Cc: Realtek linux nic maintainers nic_s...@realtek.com You removed the wording I had questions about last

RE: [PATCH v3 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread hayeswang
Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, May 03, 2013 10:33 AM To: Hayeswang Cc: oli...@neukum.org; net...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; nic_swsd Subject: Re: [PATCH v3 net-next] net/usb: new driver for RTL8152 On Fri, May 03,

Re: [PATCH v3 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread 'Greg KH'
On Fri, May 03, 2013 at 11:11:47AM +0800, hayeswang wrote: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, May 03, 2013 10:33 AM To: Hayeswang Cc: oli...@neukum.org; net...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; nic_swsd Subject: Re: [PATCH

Re: [PATCH v3 net-next] net/usb: new driver for RTL8152

2013-05-02 Thread David Miller
From: 'Greg KH' gre...@linuxfoundation.org Date: Thu, 2 May 2013 20:23:15 -0700 On Fri, May 03, 2013 at 11:11:47AM +0800, hayeswang wrote: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, May 03, 2013 10:33 AM To: Hayeswang Cc: oli...@neukum.org; net...@vger.kernel.org;