Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-07 Thread Laurent Pinchart
Hi Michael, On Friday 03 May 2013 10:37:40 Michael Grzeschik wrote: Hi Laurent, On Fri, May 03, 2013 at 01:20:15AM +0200, Laurent Pinchart wrote: [snip] I'm open to suggestions :-) What features of the userspace application do you think could (and should) be moved to kernelspace ? Many

Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-07 Thread Laurent Pinchart
Hi Peter, On Monday 06 May 2013 10:35:25 Peter Chen wrote: On Sun, May 5, 2013 at 2:22 AM, Bhupesh SHARMA wrote: [snip] The whole point of having a user-space application governing the behavior of UVC webcam gadget as per commands from a UVC host is to plug the same with a real video

Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-07 Thread Laurent Pinchart
Hi Vladimir, On Monday 06 May 2013 13:42:45 Vladimir Zapolskiy wrote: On 05/04/13 21:22, Bhupesh SHARMA wrote: On 5/3/2013 6:00 PM, Vladimir Zapolskiy wrote: On 05/03/13 02:05, Laurent Pinchart wrote: On Friday 03 May 2013 02:00:29 Vladimir Zapolskiy wrote: On 05/03/13 01:18, Laurent

RE: Testing phonet

2013-05-07 Thread Andrzej Pietrasiewicz
On Wednesday, May 01, 2013 1:53 PM Daniele Forsi wrote: 2013/4/30 Andrzej Pietrasiewicz: As I already wrote I am now stuck with sending correct data, so that when I sendto() from host I can recvfrom() on device (or vice versa). payload data doesn't matter so you don't need my dumps,

[RFC PATCH 0/2] USB: OHCI: Start splitting up the driver

2013-05-07 Thread Manjunath Goudar
This series of patches begins the process of splitting ohci-hcd up into a core library module and independent pci driver modules. Patch 1/2 prepares the way by exporting a few functions from ohci-hcd and adding a new mechanism for platform-specific drivers to initialize their hc_driver

[RFC PATCH 1/2] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-07 Thread Manjunath Goudar
This patch prepares ohci-hcd for being split up into a core library and separate platform driver modules. A generic ohci_hc_driver structure is created, containing all the standard values, and a new mechanism is added whereby a driver module can specify a set of overrides to those values. In

Re: Linux USB file storage gadget with new UDC

2013-05-07 Thread victor yeo
Hi, How the UDC driver know when the request is really complete? An OUT request is really complete when either: The total number of bytes copied into req.buffer (i.e., req.actual) is equal to req.length, or The number of bytes received in the last packet is smaller

[RFC PATCH 2/2] USB: OHCI: make ohci-pci a separate driver

2013-05-07 Thread Manjunath Goudar
This patch splits the PCI portion of ohci-hcd out into its own separate driver module, called ohci-pci. Consistently with the current practice, the decision whether to build this module is not user-configurable. If OHCI_PCI are enabled then the module will be built, always. V2: - few specific

[RFC PATCH 0/2] USB: OHCI: Start splitting up the driver

2013-05-07 Thread Manjunath Goudar
This series of patches begins the process of splitting ohci-hcd up into a core library module and independent pci driver modules. Patch 1/2 prepares the way by exporting a few functions from ohci-hcd and adding a new mechanism for platform-specific drivers to initialize their hc_driver

[RFC PATCH 1/2] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-07 Thread Manjunath Goudar
This patch prepares ohci-hcd for being split up into a core library and separate platform driver modules. A generic ohci_hc_driver structure is created, containing all the standard values, and a new mechanism is added whereby a driver module can specify a set of overrides to those values. In

[RFC PATCH 2/2] USB: OHCI: make ohci-pci a separate driver

2013-05-07 Thread Manjunath Goudar
This patch splits the PCI portion of ohci-hcd out into its own separate driver module, called ohci-pci. Consistently with the current practice, the decision whether to build this module is not user-configurable. If OHCI_PCI are enabled then the module will be built, always. V2: - few specific

[PATCH] usb: musb: dsps: fix error return code in dsps_create_musb_pdev()

2013-05-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the devm_kzalloc() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/usb/musb/musb_dsps.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe()

2013-05-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code in the gpio_to_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/usb/gadget/s3c2410_udc.c | 1 + 1 file changed, 1

[PATCH] usb: gadget: r8a66597-udc: fix error return code in r8a66597_probe()

2013-05-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the request alloc error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/usb/gadget/r8a66597-udc.c | 4 +++- 1 file changed, 3

[PATCH] usb: gadget: m66592-udc: fix error return code in m66592_probe()

2013-05-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the request alloc error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/usb/gadget/m66592-udc.c | 4 +++- 1 file changed, 3

[PATCH] usb: gadget: fusb300_udc: fix error return code in fusb300_probe()

2013-05-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/usb/gadget/fusb300_udc.c | 4 +++- 1 file changed, 3

[PATCH] usb: gadget: dummy_hcd: fix error return code in init()

2013-05-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the kzalloc() error handling case instead of 0(following platform_device_add_data() will overwrite it to 0), as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

[PATCH] usb: gadget: fix error return code in configfs_composite_bind()

2013-05-07 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code in the go through all configs error handling case instead of 0(usb_add_function() will overwrite ret to 0). Also use error code from usb_gstrings_attach() in all strings init error case instead of -EINVAL.

NULL pointer dereference in xhci_free_dev

2013-05-07 Thread Frantisek Hrbata
Hi, there is a NULL pointer dereference in xhci_free_dev if xhci_alloc_dev timeouts while waiting for a slot. Fedora has several bugs reporting this problem. https://bugzilla.redhat.com/show_bug.cgi?id=957500 https://bugzilla.redhat.com/show_bug.cgi?id=959016

Re: [PATCH] usb: gadget: dummy_hcd: fix error return code in init()

2013-05-07 Thread Alan Stern
On Tue, 7 May 2013, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the kzalloc() error handling case instead of 0(following platform_device_add_data() will overwrite it to 0), as done elsewhere in this function. Signed-off-by: Wei Yongjun

Re: Linux USB file storage gadget with new UDC

2013-05-07 Thread Alan Stern
On Tue, 7 May 2013, victor yeo wrote: Hi, How the UDC driver know when the request is really complete? An OUT request is really complete when either: The total number of bytes copied into req.buffer (i.e., req.actual) is equal to req.length, or The

Re: Linux USB file storage gadget with new UDC

2013-05-07 Thread victor yeo
Hi, I made some changes regarding req.actual. Now the UDC driver still cannot process SCSI_WRITE_10 command. Please see the attached UDC driver log when i try to write to a text file. There should be three SCSI commands in the log: SCSI_REQUEST_SENSE, SCSI_TEST_UNIT_READY and SCSI_WRITE_10.

Re: [PATCH 1/2] usb: gadget/uvc: remove connect/disconnect calls on open/release

2013-05-07 Thread Bhupesh SHARMA
Hi, On 5/7/2013 12:35 PM, Laurent Pinchart wrote: Hi Vladimir, On Monday 06 May 2013 13:42:45 Vladimir Zapolskiy wrote: On 05/04/13 21:22, Bhupesh SHARMA wrote: On 5/3/2013 6:00 PM, Vladimir Zapolskiy wrote: On 05/03/13 02:05, Laurent Pinchart wrote: On Friday 03 May 2013 02:00:29 Vladimir

Re: [RFC PATCH 1/2] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-07 Thread Alan Stern
On Tue, 7 May 2013, Manjunath Goudar wrote: This patch prepares ohci-hcd for being split up into a core library and separate platform driver modules. A generic ohci_hc_driver structure is created, containing all the standard values, and a new mechanism is added whereby a driver module can

Re: Linux USB file storage gadget with new UDC

2013-05-07 Thread Alan Stern
On Tue, 7 May 2013, victor yeo wrote: It is likely that this bug occurs because you don't use a spinlock in kagen2_ep_queue. Does the interrupt handler routine use a spinlock? Spinlock is Not used in interrupt handler routine. Then that's the reason for this bug. [start_transfer]

Re: [PATCH 1/2 v6 RESEND] usbnet: allow status interrupt URB to always be active

2013-05-07 Thread Oliver Neukum
On Monday 06 May 2013 16:29:23 Dan Williams wrote: Some drivers (sierra_net) need the status interrupt URB active even when the device is closed, because they receive custom indications from firmware. Add functions to refcount the status interrupt URB submit/kill operation so that

Re: linux-next: Tree for May 7 (usb/chipidea)

2013-05-07 Thread Randy Dunlap
On 05/06/13 20:49, Stephen Rothwell wrote: Hi all, Please do not add any v3.11 destined work to your linux-next included branches until after v3.10-rc1 is released. I am receiving a (un)reasonable number of conflicts from there being multiple copies of some commits in various trees.

Re: [PATCH v6 3/3] ARM: shmobile: BOCK-W: add USB support

2013-05-07 Thread Sergei Shtylyov
Hello. On 05/01/2013 03:14 AM, Sergei Shtylyov wrote: Register the USB PHY device from bockw_init(), passing the platform data to it. Set machine's init_late() method to r8a7778_init_late() in order for [EO]HCI to get registered too... The patch has been tested on the BOCK-W board.

dwc3 on omap5432 no SuperSpeed host mode

2013-05-07 Thread Ben Dooks
We are using an OMAP5432 ES2.0 on an UEVM board and running into issues with the dwc3 usb. The first issue is that the xhci reset code stops the entire core from working after it is executed. We have commented the xhci reset code from issuing the CMD_RESET and this has allowed us to get the XHCI

[PATCH] USB: set device dma_mask without reference to global data

2013-05-07 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com Many USB host drivers contain code such as: if (!pdev-dev.dma_mask) pdev-dev.dma_mask = tegra_ehci_dma_mask; ... where tegra_ehci_dma_mask is a global. I suspect this code originated in commit 4a53f4e USB: ehci-tegra: add probing through device

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-07 Thread Greg Kroah-Hartman
On Tue, May 07, 2013 at 04:53:52PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Many USB host drivers contain code such as: if (!pdev-dev.dma_mask) pdev-dev.dma_mask = tegra_ehci_dma_mask; ... where tegra_ehci_dma_mask is a global. I suspect this code

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-07 Thread Arnd Bergmann
On Wednesday 08 May 2013, Greg Kroah-Hartman wrote: On Tue, May 07, 2013 at 04:53:52PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Suggested-by: Arnd Bergmann a...@arndb.de Signed-off-by: Stephen Warren swar...@nvidia.com So this needs to go in for 3.10, right?

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-07 Thread Peter Chen
On Wed, May 8, 2013 at 6:53 AM, Stephen Warren swar...@wwwdotorg.org wrote: From: Stephen Warren swar...@nvidia.com Many USB host drivers contain code such as: if (!pdev-dev.dma_mask) pdev-dev.dma_mask = tegra_ehci_dma_mask; ... where tegra_ehci_dma_mask is a global. I suspect this

Re: [PATCH] usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe()

2013-05-07 Thread Jingoo Han
On Tuesday, May 07, 2013 8:48 PM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code in the gpio_to_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-07 Thread Stephen Warren
On 05/07/2013 07:13 PM, Peter Chen wrote: On Wed, May 8, 2013 at 6:53 AM, Stephen Warren swar...@wwwdotorg.org wrote: From: Stephen Warren swar...@nvidia.com Many USB host drivers contain code such as: if (!pdev-dev.dma_mask) pdev-dev.dma_mask = tegra_ehci_dma_mask; ... where

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-07 Thread Peter Chen
This probably could be initialized from some DT property. However, there's no such property defined right now, and considering that DT is supposed to be an ABI, we'd always need the code in this patch as a fallback for DTs that were created before any such property was defined. Equally,

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-07 Thread Tony Prisk
On 08/05/13 10:53, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Many USB host drivers contain code such as: if (!pdev-dev.dma_mask) pdev-dev.dma_mask = tegra_ehci_dma_mask; ... where tegra_ehci_dma_mask is a global. I suspect this code originated in commit 4a53f4e