Hi folks,
I also bumped into the question of how to set the dma_mask when enabling
the dwc2 driver on the ramips target and found there didn't seem to be
any clear way to get a dma_mask.
It seems to me that in the pre-DT era, a platform_device would get a
dma_mask when it was defined in the board
On Wednesday 08 May 2013, Peter Chen wrote:
> >
> > This probably could be initialized from some DT property. However,
> > there's no such property defined right now, and considering that DT is
> > supposed to be an ABI, we'd always need the code in this patch as a
> > fallback for DTs that were cr
Hi,
> For the ramips target, the MIPS folks suggested another approach: The
> soc code finds the platform_device generated by DT and adds the
> dma_mask:
>
> http://www.linux-mips.org/archives/linux-mips/2013-04/msg00162.html
For completeness: It seems this approach is not going to be used after
Hi Greg,
> Greg, is it ok for a HCD to modify hcd->self.uses_dma like this?
perhaps you missed this question in my previous mail? :-)
Gr.
Matthijs
> diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
> index d9a2055..18a91de 100644
> --- a/drivers/staging/dwc2/hcd.c
> +++ b/dr
Hi Peter,
On 05/07/13 04:39, Peter Chen wrote:
On Fri, May 3, 2013 at 6:13 AM, Vladimir Zapolskiy
wrote:
This change removes calls of uvc_function_connect()/uvc_function_disconnect()
functions from open()/close() syscalls.
This is a bugfix in g_webcam module, in some test scenarios (e.g. UDC
On Wed, May 8, 2013 at 4:01 PM, Vladimir Zapolskiy
wrote:
> Hi Peter,
>
>
> On 05/07/13 04:39, Peter Chen wrote:
>>
>> On Fri, May 3, 2013 at 6:13 AM, Vladimir Zapolskiy
>> wrote:
>>>
>>> This change removes calls of
>>> uvc_function_connect()/uvc_function_disconnect()
>>> functions from open()/
On Mon, May 6, 2013 at 7:52 PM, Alan Stern wrote:
> On Mon, 6 May 2013, [ISO-8859-1] Aurélien Leblond wrote:
>
>> Hello all,
>>
>> I have two usb soundcards at home and my laptop has both EHCI and XHCI
>> usb ports.
>>
>> The M-Audio Fast-Track Ultra (USB 2) is not recognized by ALSA when
>> plugg
Jiri Slaby writes:
> From: Jeff Mahoney
>
> The chipidea driver currently has needless ifneq rules in the makefile
> for things that should be config options.
Please elaborate on the "should be" part.
> This can be problematic,
> especially in the IMX case, since the OF_DEVICE dependency will
Hi,
>> > It is likely that this bug occurs because you don't use a spinlock in
>> > kagen2_ep_queue. Does the interrupt handler routine use a spinlock?
>>
>> Spinlock is Not used in interrupt handler routine.
>
> Then that's the reason for this bug.
>
>> >[start_transfer] 53425355 10d
>> >ept1 ou
Randy Dunlap reported below problem
at i386:
> drivers/built-in.o: In function `ci_hdrc_host_init':
> (.text+0x2ce75c): undefined reference to `ehci_init_driver'
> When USB_EHCI_HCD=m and USB_CHIPIDEA=y.
In fact, this problem is existed at all platforms which are using
chipidea driver. The root
On 05/08/2013 02:11 AM, Matthijs Kooijman wrote:
> Hi folks,
>
> I also bumped into the question of how to set the dma_mask when enabling
> the dwc2 driver on the ramips target and found there didn't seem to be
> any clear way to get a dma_mask.
>
> It seems to me that in the pre-DT era, a platfo
On Wednesday 08 May 2013, Rob Herring wrote:
> On 05/08/2013 02:11 AM, Matthijs Kooijman wrote:
> > https://lkml.org/lkml/2012/12/4/54
> >
> > And here's the previous attempt, to which Rob Herring refers in a reply.
> >
> > https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-March/013180.
On Wed, 8 May 2013, Arnd Bergmann wrote:
> On Wednesday 08 May 2013, Greg Kroah-Hartman wrote:
> > On Tue, May 07, 2013 at 04:53:52PM -0600, Stephen Warren wrote:
> > > From: Stephen Warren
>
> > > Suggested-by: Arnd Bergmann
> > > Signed-off-by: Stephen Warren
> >
> > So this needs to go in
05.05.2013 22:32, Johan Hovold пишет:
Add generic wait_until_sent implementation which polls for empty
hardware buffers using the new port-operation tx_empty.
The generic implementation will be used for all sub-drivers that
implement tx_empty but does not define wait_until_sent.
Hi Johan.
The
On Wed, 8 May 2013, Matthijs Kooijman wrote:
> Hi Greg,
>
> > Greg, is it ok for a HCD to modify hcd->self.uses_dma like this?
> perhaps you missed this question in my previous mail? :-)
>
> Gr.
>
> Matthijs
>
> > diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
> > index d
On Wed, 8 May 2013, victor yeo wrote:
> >> Is the kagen2_ep_queue function gotten interrupted here? So the
> >> kagen2_ep_queue and interrupt routine need spinlock for
> >> synchronisation?
> >
> > That's right. Interrupts can occur at almost any time (on
> > multiprocessor systems they can occur
On Wed, 8 May 2013, Yuan-Hsin Chen wrote:
> Hi,
>
> Are there any advice?
> Thanks.
>
> On Fri, Apr 26, 2013 at 5:37 PM, Yuan-Hsin Chen wrote:
> > FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200.
> > FUSBH200 is an ehci-like controller with some differences.
> > First, register layout of FUS
> > > + if (hsotg->core_params->dma_enable <= 0)
> > > + hcd->self.uses_dma = 0;
> > > +
> > > hcd->has_tt = 1;
> > >
> > > spin_lock_init(&hsotg->lock);
>
> This is okay providing you do it before calling usb_add_hcd().
Great, thanks!
Matthijs
--
To unsubsc
On Wednesday 08 May 2013, Alan Stern wrote:
> > The first occurence was apparently in 3.3, but only in ehci-tegra.c,
> > while the other drivers subsequently copied the bug.
>
> An alternative solution -- perhaps not better but also not relying on
> coherent_dma_mask -- is to clear pdev->dev.dma_m
Hi,
On Wed, May 8, 2013 at 10:40 PM, Alan Stern wrote:
> On Wed, 8 May 2013, Yuan-Hsin Chen wrote:
>
>> Hi,
>>
>> Are there any advice?
>> Thanks.
>>
>> On Fri, Apr 26, 2013 at 5:37 PM, Yuan-Hsin Chen wrote:
>> > FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200.
>> > FUSBH200 is an ehci-like c
This patch shortens the logic in xhci_endpoint_init() by moving common
calculations involving max_packet and max_burst outside the switch
statement, rather than repeating the same code in multiple
case-specific statements. It also replaces two usages of max_packet
which were clearly intended to be
On Wed, May 08, 2013 at 10:40:08AM -0400, Alan Stern wrote:
> On Wed, 8 May 2013, Yuan-Hsin Chen wrote:
>
> > Hi,
> >
> > Are there any advice?
> > Thanks.
> >
> > On Fri, Apr 26, 2013 at 5:37 PM, Yuan-Hsin Chen wrote:
> > > FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200.
> > > FUSBH200 is
* Ben Dooks | 2013-05-07 22:06:33 [+0200]:
>We are using an OMAP5432 ES2.0 on an UEVM board
>and running into issues with the dwc3 usb.
Sorry, I can't help at all. I don't have the board and I never had one.
I had ES1.0 but I never got dwc3 to work.
Sebastian
--
To unsubscribe from this list: se
On Wed, May 08, 2013 at 06:25:13PM +0400, Stas Sergeev wrote:
> 05.05.2013 22:32, Johan Hovold пишет:
> > Add generic wait_until_sent implementation which polls for empty
> > hardware buffers using the new port-operation tx_empty.
> >
> > The generic implementation will be used for all sub-drivers
Hi guys,
I tried the 3.9 kernel and on bootup sequence I have a panic.
I don't have a serial console available without USB, so no direct logs can be
provided.
What I have is the line where the breakage happens :
drivers/usb/otg.c:133
if (IS_ERR(phy) || !try_module_get(phy->dev->driver->ow
Add generic wait_until_sent implementation which polls for empty
hardware buffers using the new port-operation tx_empty.
The generic implementation will be used for all sub-drivers that
implement tx_empty but does not define wait_until_sent.
Signed-off-by: Johan Hovold
---
v2: make sure to hand
On 08/05/13 17:45, Sebastian Andrzej Siewior wrote:
* Ben Dooks | 2013-05-07 22:06:33 [+0200]:
We are using an OMAP5432 ES2.0 on an UEVM board
and running into issues with the dwc3 usb.
Sorry, I can't help at all. I don't have the board and I never had one.
I had ES1.0 but I never got dwc3 to
Hi,
On Wed, May 08, 2013 at 05:52:50PM +0200, Ben Dooks wrote:
> On 08/05/13 17:45, Sebastian Andrzej Siewior wrote:
> >* Ben Dooks | 2013-05-07 22:06:33 [+0200]:
> >
> >>We are using an OMAP5432 ES2.0 on an UEVM board
> >>and running into issues with the dwc3 usb.
> >
> >Sorry, I can't help at al
On 08/05/13 18:02, Felipe Balbi wrote:
Hi,
On Wed, May 08, 2013 at 05:52:50PM +0200, Ben Dooks wrote:
On 08/05/13 17:45, Sebastian Andrzej Siewior wrote:
* Ben Dooks | 2013-05-07 22:06:33 [+0200]:
We are using an OMAP5432 ES2.0 on an UEVM board
and running into issues with the dwc3 usb.
So
Hi Felipe,
Commit 388e5c51135f817f01177c42261f1116a6d7f2ad usb: dwc3: remove dwc3
dependency on host AND gadget
by me breaks compilation when USB_DWC3=y, USB=y but USB_GADGET=m,
additionally when either of USB_DWC3_GADGET=y or USB_DWC3_DUAL_ROLE=y :-(
I had some confusion with this actually
The context entries field of the slot context must be set to one more
than the highest endpoint index currently active. The previous logic
only included the set of endpoints currently being added, meaning that
if an endpoint where dropped then the field would be reset to 1,
deactivating all configu
On 05/08/13 03:02, Peter Chen wrote:
> Randy Dunlap reported below problem
> at i386:
>> drivers/built-in.o: In function `ci_hdrc_host_init':
>> (.text+0x2ce75c): undefined reference to `ehci_init_driver'
>
>> When USB_EHCI_HCD=m and USB_CHIPIDEA=y.
>
> In fact, this problem is existed at all pl
Platform devices added through OF usually do not have any dma_mask
pointer set. In this case, point it at the coherent_dma_mask and set
their value to a 32 bit mask. This still allows any platform code to set
any more specific mask if needed, but makes the driver work for most
dma-enabled hardware
There was some code that cleared the dma_mask when dma was disabled in
the driver. Given that clearing the mask doesn't actually tell the usb
core we're not using dma, and a previous commit explicitely sets the
hcd->self.uses_dma value, it seems these values are unneeded and can
only potentially ca
When dma is disabled inside dwc2 (because the hardware does not support
it, or the code was changed to disable it for testing), let the usb core
know about this by clearing hcd->self.uses_dma.
By default, the usb core assumes that dma is used when a dma_mask is
set, but this might not always match
Hi folks,
here's some more dma fixes for the dwc2 driver. The second patch of this
series is the same as in my previous series, the others are new.
> staging: dwc2: Set a default dma_mask for platform devices
It would be great if at least this first patch in this series could be
included in 3.10
If the platform driver failed to setup a dma_mask, but the hardware
advertises support for DMA, before DMA would be enabled in dwc2, but
disabled in the usb core, making all connectivity break.
With this commit, the dwc2 driver will emit a warning and fall back to
slave mode in this case.
Signed-
From: Dan Williams
Date: Mon, 06 May 2013 16:29:23 -0500
> Some drivers (sierra_net) need the status interrupt URB
> active even when the device is closed, because they receive
> custom indications from firmware. Add functions to refcount
> the status interrupt URB submit/kill operation so that
From: Dan Williams
Date: Mon, 06 May 2013 16:34:56 -0500
> The driver and firmware sync up through SYNC messages, and the
> firmware's affirmative reply to these SYNC messages appears to be the
> "Reset" indication received via the status interrupt endpoint. Thus the
> driver needs the status in
> From: Matthijs Kooijman [mailto:matth...@stdin.nl]
> Sent: Wednesday, May 08, 2013 12:45 PM
>
> Platform devices added through OF usually do not have any dma_mask
> pointer set. In this case, point it at the coherent_dma_mask and set
> their value to a 32 bit mask. This still allows any platfor
Hi Paul,
> > + /*
> > +* Use reasonable defaults so platforms don't have to provide these.
> > +*/
> > + if (!dev->dev.dma_mask)
> > + dev->dev.dma_mask = &dev->dev.coherent_dma_mask;
> > + if (!dev->dev.coherent_dma_mask)
> > + dev->dev.coherent_dma_mask = DMA_BI
Hi Paul,
I'm running into an issue with the dwc2 driver. When I power on my board
with an usb device (mass storage in this case) connected, the hardware
is returning transaction errors (e.g., triggering channel halted +
xacterr interrupts) for every transfer scheduled, starting with the
first ones
I have a USB 2.0 device (wifi card) that is not detected when I plug it
into a 3.0 port. It does not show up in /dev/bus/usb. This is an FC16
kernel(linux-3.3), and we have tested that it works in FC18 (linux-3.5)
just fine. I cannot at this point switch out the whole kernel. I was
hoping that y
On Wed, May 08, 2013 at 02:14:35PM -0700, curtis.wy...@gdc4s.com wrote:
> I have a USB 2.0 device (wifi card) that is not detected when I plug it
> into a 3.0 port. It does not show up in /dev/bus/usb. This is an FC16
> kernel(linux-3.3), and we have tested that it works in FC18 (linux-3.5)
> jus
On 05/07/2013 08:54 PM, Peter Chen wrote:
>>
>> This probably could be initialized from some DT property. However,
>> there's no such property defined right now, and considering that DT is
>> supposed to be an ABI, we'd always need the code in this patch as a
>> fallback for DTs that were created b
Robert Jarzmik writes:
> Hi guys,
I almost forgot.
This simple patch fixes the issue, but I haven't thought it through if it is the
proper fix :
diff --git a/drivers/usb/otg/gpio_vbus.c b/drivers/usb/otg/gpio_vbus.c
index a7d4ac5..f65615c 100644
--- a/drivers/usb/otg/gpio_vbus.c
+++ b/drivers/u
Hello.
Here's the set of 3 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130426' tag, the R8A7779/Marzen and sh-pfc patchset I've posted.
It was created to add support of R8A7778/BOCK-W USB to the platform code and
the USB common PHY driver, and so spans both arch/arm/m
The driver currently only supports R8A7779 SoC. Compared to it, R8A7778 USB-PHY
has extra register range containing two high-speed signal quality characteristic
control registers which should be set up during USB-PHY startup depending on
whether a ferrite bead is in use or not. So, we now handle
Add USB clock and EHCI, OHCI, and USB PHY platform devices for R8A7778 SoC; add
a function to register PHY device with board-specific platform data and register
EHCI and OHCI platfrom devices from the init_late() board method.
Also, don't forget to enable CONFIG_ARCH_HAS_[EO]HCI options for R8A7
Register the USB PHY device from bockw_init(), passing the platform data to it.
Set machine's init_late() method to r8a7778_init_late() in order for [EO]HCI to
get registered too...
Don't forget to add USB PENC0/1 pins to bockw_pinctrl_map[].
The patch has been tested on the BOCK-W board.
Signe
On Tue, Apr 23, 2013 at 05:09:35PM +0200, Clemens Ladisch wrote:
> Alan Stern wrote:
> > On Tue, 23 Apr 2013, Clemens Ladisch wrote:
> >> Why is having a queue of two URB with one packet each suddenly not
> >> allowed?
> >
> > It _is_ allowed when URB_ISO_ASAP is clear. I have never fully
> > unde
We met similar problem at chipidea. I give a patch, but maybe there
can be improved.
http://marc.info/?l=linux-usb&m=136804273919518&w=2
On Thu, May 9, 2013 at 12:34 AM, Vivek Gautam wrote:
> Hi Felipe,
>
> Commit 388e5c51135f817f01177c42261f1116a6d7f2ad usb: dwc3: remove dwc3
> dependency on ho
fix four goto wrong tag, avoid memleak
Libo Chen (4):
usb: ehci-s5p: fix memleak when fallback to pdata
usb: isp1760-if: fix memleak when platform_get_resource fail
usb: ohci: fix goto wrong tag in err case
usb: tilegx: fix memleak when create hcd fail
drivers/usb/host/ehci-s5p.c|
From: Libo Chen
When platform_get_resource fail, we should release_mem_region
Signed-off-by: Libo Chen
---
drivers/usb/host/isp1760-if.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c
index bbb791b..a137
From: Libo Chen
When usb_create_hcd fail, we should call gxio_usb_host_destroy
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-tilegx.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers/usb/host/ohci-tilegx.c
index 1ae7b2
From: Libo Chen
When devm_usb_get_phy fail, we should free hcd
Signed-off-by: Libo Chen
---
drivers/usb/host/ehci-s5p.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
index 6357752..3fbab58 100644
--- a/drivers
From: Libo Chen
fix goto wrong tag in usb_hcd_nxp_probe
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-nxp.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index f4988fb..eb294a9 100644
--- a/dri
fix goto wrong tag in usb_hcd_nxp_probe
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-nxp.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index f4988fb..eb294a9 100644
--- a/drivers/usb/host/ohci
When devm_usb_get_phy fail, we should free hcd
Signed-off-by: Libo Chen
---
drivers/usb/host/ehci-s5p.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
index 6357752..3fbab58 100644
--- a/drivers/usb/host/ehci-s5p
When platform_get_resource fail, we should release_mem_region
Signed-off-by: Libo Chen
---
drivers/usb/host/isp1760-if.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c
index bbb791b..a13709e 100644
--- a/d
change address from "Libo Chen " to "Libo Chen
"
fix four goto wrong tag, avoid memleak
Libo Chen (4):
usb: ehci-s5p: fix memleak when devm_usb_get_phy fail
usb: isp1760-if: fix memleak when platform_get_resource fail
usb: ohci: fix goto wrong tag in err case
usb: tilegx: fix memleak w
When usb_create_hcd fail, we should call gxio_usb_host_destroy
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-tilegx.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers/usb/host/ohci-tilegx.c
index 1ae7b28..5888fc4 100644
Hi,
>> > That's right. Interrupts can occur at almost any time (on
>> > multiprocessor systems they can occur even when interrupts are disabled
>> > on some of the CPUs).
>>
>> I am confused. I add the spinlock functions to kagen2_ep_queue function.
>>
>> spin_lock_irqsave(&dev->lock, flags
63 matches
Mail list logo
