Re: NULL pointer dereference in xhci_free_dev

2013-05-09 Thread Frantisek Hrbata
On Thu, May 09, 2013 at 03:15:59PM -0700, Sarah Sharp wrote: > On Tue, May 07, 2013 at 04:03:33PM +0200, Frantisek Hrbata wrote: > > Hi, > > Hi Frantisek, > > > there is a NULL pointer dereference in xhci_free_dev if > > xhci_alloc_dev timeouts while waiting for a slot. Fedora has several bugs >

[PATCH v2] usb: ohci: fix goto wrong tag in err case

2013-05-09 Thread Libo Chen
fix goto wrong tag in usb_hcd_nxp_probe * Changelog from v1: * instead of all these statement labels suggested by Alan Stern Signed-off-by: Libo Chen --- drivers/usb/host/ohci-nxp.c | 46 +- 1 files changed, 23 insertions(+), 23 deletions(-) diff -

Re: Phy and gpio_vbus breakage in 3.9

2013-05-09 Thread Kishon Vijay Abraham I
On Thursday 09 May 2013 09:29 PM, Felipe Balbi wrote: Hi, On Thu, May 09, 2013 at 05:54:12PM +0200, Robert Jarzmik wrote: Felipe Balbi writes: it is, please send a proper patch. Done. I think others should have a look too, especially : - fsl_otg.c - isp1301_omap.c - msm_otg.c - mv_o

Re: musb throughput issues

2013-05-09 Thread Frederik Schmid
Hi Greg, The kernel is based on 3.4.11 from omapzoom.org (ti-ubuntu-3.4-1487) with Variscite BSP patches from: http://www.variwiki.com/index.php?title=VAR-SOM-OM44_-_Ubuntu_Precise I was expecting 200-250Mbps which is entirly possible on the same chip using its ehci-controller. musb seems to s

usbip port option missing

2013-05-09 Thread Michael Hoffman
usbip team, In the readme document for the userland code it explicitly states there is a usbip port option to list the virtual ports: client:# usbip port - Show virtual port status. However, looking at the src code and the binaries produced from a compilation, there is no port option. Ho

[PATCH] usb: xhci: Consolidate XHCI TD Size calculation

2013-05-09 Thread Julius Werner
The TD Size field in an XHCI TRB is calculated in two different ways, depending on the XHCI version. The current code does this version check in every caller, which makes it easy to forget (such as in the function for control transfers, which still erroneously uses the old calculation for its data

Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-09 Thread Libo Chen
On 2013/5/10 9:09, Libo Chen wrote: > On 2013/5/10 2:02, Chris Metcalf wrote: >> On 5/9/2013 2:08 AM, Libo Chen wrote: >>> When usb_create_hcd fail, we should call gxio_usb_host_destroy >>> >>> Signed-off-by: Libo Chen >>> --- >>> drivers/usb/host/ohci-tilegx.c |7 +-- >>> 1 files changed

Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-09 Thread Libo Chen
On 2013/5/10 2:02, Chris Metcalf wrote: > On 5/9/2013 2:08 AM, Libo Chen wrote: >> When usb_create_hcd fail, we should call gxio_usb_host_destroy >> >> Signed-off-by: Libo Chen >> --- >> drivers/usb/host/ohci-tilegx.c |7 +-- >> 1 files changed, 5 insertions(+), 2 deletions(-) > > Thanks

Re: [RFT 2/2] xhci: Disable D3cold for buggy TI redrivers.

2013-05-09 Thread Huang Ying
On Thu, 2013-05-09 at 16:31 -0700, Sarah Sharp wrote: > Some xHCI hosts contain a "redriver" from TI that silently drops port > status connect changes if the port slips into Compliance Mode. If the > port slips into compliance mode while the host is in D0, there will not > be a port status change

[RFT 2/2] xhci: Disable D3cold for buggy TI redrivers.

2013-05-09 Thread Sarah Sharp
Some xHCI hosts contain a "redriver" from TI that silently drops port status connect changes if the port slips into Compliance Mode. If the port slips into compliance mode while the host is in D0, there will not be a port status change event. If the port slips into compliance mode while the host

[RFT 1/2] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-05-09 Thread Sarah Sharp
From: Tony Camuso Commit 71c731a2 (usb: host: xhci: Fix Compliance Mode on SN65LVPE502CP Hardware) was a workaround for systems using the SN65LVPE502CP, controller, but it introduced a bug in resume from hibernate. The fix created a timer, comp_mode_recovery_timer, which is deleted from a timer

[RFT 0/2] TI compliance mode fixes

2013-05-09 Thread Sarah Sharp
Hi Tony, Don, and Oliver, Can one of you double check these two patches resolve the resume from S3 issue on effected HP systems with the TI compliance mode quirk? Oliver has confirmed that the first patch works, but no one has tested the patch to disable D3cold for the xHCI host on those systems.

Re: NULL pointer dereference in xhci_free_dev

2013-05-09 Thread Sarah Sharp
On Tue, May 07, 2013 at 04:03:33PM +0200, Frantisek Hrbata wrote: > Hi, Hi Frantisek, > there is a NULL pointer dereference in xhci_free_dev if > xhci_alloc_dev timeouts while waiting for a slot. Fedora has several bugs > reporting this problem. > > https://bugzilla.redhat.com/show_bug.cgi?id=95

Re: [PATCH] USB: xHCI: override bogus bulk wMaxPacketSize values

2013-05-09 Thread Sarah Sharp
On Thu, May 09, 2013 at 01:46:51PM -0700, Sarah Sharp wrote: > Thanks Alan, I will add this to my for-usb-linus queue. One note though: I've been bitten by this code before, by someone who refactored code and fixed a bug at the same time. The math was wrong, and I ended up breaking full-speed dev

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-09 Thread Russell King - ARM Linux
On Wed, May 08, 2013 at 09:24:44AM +0200, Arnd Bergmann wrote: > It probably should. The main thing is that the dma_mask setting in > of_platform (and elsewhere) is a mess and that nobody so far had the > guts to try to get it right for good. > > Setting a 32 bit DMA mask is /probably/ the right d

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-09 Thread Russell King - ARM Linux
On Wed, May 08, 2013 at 10:54:48AM +0800, Peter Chen wrote: > > > > This probably could be initialized from some DT property. However, > > there's no such property defined right now, and considering that DT is > > supposed to be an ABI, we'd always need the code in this patch as a > > fallback for

Re: [PATCH] USB: set device dma_mask without reference to global data

2013-05-09 Thread Russell King - ARM Linux
On Wed, May 08, 2013 at 01:42:11AM +0200, Arnd Bergmann wrote: > On Wednesday 08 May 2013, Greg Kroah-Hartman wrote: > > On Tue, May 07, 2013 at 04:53:52PM -0600, Stephen Warren wrote: > > > From: Stephen Warren > > > > Suggested-by: Arnd Bergmann > > > Signed-off-by: Stephen Warren > > > > So

RE: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-05-09 Thread Svetoslav Neykov
Hi Marc, Marc Kleine-Budde [mailto:m...@pengutronix.de] (On Thursday, March 28, 2013 4:16 PM) >On 03/28/2013 10:28 AM, Alexander Shishkin wrote: >> Svetoslav Neykov writes: >> >>> Convert between big-endian and little-endian format when accessing >>> the usb controller structures which are littl

Re: [PATCH] USB: xHCI: override bogus bulk wMaxPacketSize values

2013-05-09 Thread Sarah Sharp
Thanks Alan, I will add this to my for-usb-linus queue. Sarah On Wed, May 08, 2013 at 11:18:05AM -0400, Alan Stern wrote: > This patch shortens the logic in xhci_endpoint_init() by moving common > calculations involving max_packet and max_burst outside the switch > statement, rather than repeatin

Re: [RFC PATCH 1/2] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-09 Thread Alan Stern
On Thu, 9 May 2013, Arnd Bergmann wrote: > On Thursday 09 May 2013, Alan Stern wrote: > > > > The #else part of this isn't needed, and I doubt very much that it > > > > would work correctly if it was needed. > > > > > > As Arnd suggestion,so I written else part. > > > > The existing code doesn't

Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-09 Thread Alan Stern
On Thu, 9 May 2013, Libo Chen wrote: > When usb_create_hcd fail, we should call gxio_usb_host_destroy > > Signed-off-by: Libo Chen > --- > drivers/usb/host/ohci-tilegx.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers

Re: [PATCH RESEND 1/4] usb: ehci-s5p: fix memleak when devm_usb_get_phy fail

2013-05-09 Thread Alan Stern
On Thu, 9 May 2013, Libo Chen wrote: > When devm_usb_get_phy fail, we should free hcd > > Signed-off-by: Libo Chen > --- > drivers/usb/host/ehci-s5p.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c > index

Re: [PATCH RESEND 3/4] usb: ohci: fix goto wrong tag in err case

2013-05-09 Thread Alan Stern
On Thu, 9 May 2013, Libo Chen wrote: > fix goto wrong tag in usb_hcd_nxp_probe > > Signed-off-by: Libo Chen > --- > drivers/usb/host/ohci-nxp.c | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c > i

Re: [RFC PATCH 1/2] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-09 Thread Arnd Bergmann
On Thursday 09 May 2013, Alan Stern wrote: > > > The #else part of this isn't needed, and I doubt very much that it > > > would work correctly if it was needed. > > > > As Arnd suggestion,so I written else part. > > The existing code doesn't have a #else part, and I don't think you need > to add

Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-09 Thread Chris Metcalf
On 5/9/2013 2:08 AM, Libo Chen wrote: > When usb_create_hcd fail, we should call gxio_usb_host_destroy > > Signed-off-by: Libo Chen > --- > drivers/usb/host/ohci-tilegx.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) Thanks; taken into the tile tree. I also made the same ch

Re: Phy and gpio_vbus breakage in 3.9

2013-05-09 Thread Felipe Balbi
Hi, On Thu, May 09, 2013 at 05:54:12PM +0200, Robert Jarzmik wrote: > Felipe Balbi writes: > > > it is, please send a proper patch. > Done. > I think others should have a look too, especially : > - fsl_otg.c > - isp1301_omap.c > - msm_otg.c > - mv_otg.c > - twl4030-usb.c > > Maybe either M

Re: [RFC PATCH 1/2] USB: OHCI: prepare to make ohci-hcd a library module

2013-05-09 Thread Alan Stern
On Thu, 9 May 2013, Manjunath Goudar wrote: > > > @@ -767,7 +762,37 @@ retry: > > > > > > return 0; > > > } > > > > > +/**/ > > > + > > > +/* ohci generic function for all OHCI bus glue */ > > > + > > > +static int ohci

Re: Phy and gpio_vbus breakage in 3.9

2013-05-09 Thread Robert Jarzmik
Felipe Balbi writes: > it is, please send a proper patch. Done. I think others should have a look too, especially : - fsl_otg.c - isp1301_omap.c - msm_otg.c - mv_otg.c - twl4030-usb.c Maybe either Mark or Kishon could repair the remaining drivers, as if I'm not mistaken the breakage comes f

[PATCH] usb: otg: gpio_vbus driver initialisation fix

2013-05-09 Thread Robert Jarzmik
Upon initialisation (driver probe) a NULL pointer exception is triggered. This is due to lack of initialisation of device field in phy structure, which is used by phy framework in usb_get_phy(). Fix it by initialising the device field. Signed-off-by: Robert Jarzmik --- drivers/usb/otg/gpio_vbus

Re: Phy and gpio_vbus breakage in 3.9

2013-05-09 Thread Felipe Balbi
On Thu, May 09, 2013 at 01:22:00AM +0200, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Hi guys, > > I almost forgot. > This simple patch fixes the issue, but I haven't thought it through if it is > the > proper fix : > > diff --git a/drivers/usb/otg/gpio_vbus.c b/drivers/usb/otg/gpio_v

Re: musb throughput issues

2013-05-09 Thread Greg KH
On Thu, May 09, 2013 at 10:44:05AM +0200, Frederik Schmid wrote: > Hi, > > I'm developing a camera application on a TI OMAP4460. I have a cmos > usb-camera > from IDS (UI-1551-LE-C-HQ) connected to the OTG-port (musb as host) on the > OMAP. > > I get very poor frame rates with this setup relia

Re: undefined reference to `usb_gadget_unmap_request' regression

2013-05-09 Thread Felipe Balbi
Hi, On Wed, May 08, 2013 at 10:04:56PM +0530, Vivek Gautam wrote: > Commit 388e5c51135f817f01177c42261f1116a6d7f2ad usb: dwc3: remove > dwc3 dependency on host AND gadget > by me breaks compilation when USB_DWC3=y, USB=y but USB_GADGET=m, > additionally when either of USB_DWC3_GADGET=y or USB_DWC3

Re: Linux USB file storage gadget with new UDC

2013-05-09 Thread Alan Stern
On Thu, 9 May 2013, victor yeo wrote: > The "BUG: scheduling while atomic" is solved. Need to add extra > spinlock functions for req->complete() as below: > spin_unlock(&dev->lock); > req->complete(ep, req); > spin_lock(&dev->lock); Yes, I forgot to

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-05-09 Thread Alan Stern
On Wed, 8 May 2013, Joe Rayhawk wrote: > For what it's worth, the following -stable patch > > "ALSA: USB: adjust for changed 3.8 USB API" > c75c5ab575af7db707689cdbb5a5c458e9a034bb > > fixes the discontinuous playback on period sizes between 139 and 192, > but the discontinuous playback on perio

Re: usb 2 dev in usb 3 port "unable to enumerate USB device on port"

2013-05-09 Thread Alan Stern
On Wed, 8 May 2013 curtis.wy...@gdc4s.com wrote: > I have a USB 2.0 device (wifi card) that is not detected when I plug it > into a 3.0 port. It does not show up in /dev/bus/usb. This is an FC16 > kernel(linux-3.3), and we have tested that it works in FC18 (linux-3.5) > just fine. I cannot at th

RE: [Regression 2.6.37->2.6.38] f_phonet with SOCK_DGRAM

2013-05-09 Thread Andrzej Pietrasiewicz
On Thursday, May 09, 2013 1:15 PM Rémi Denis-Courmont wrote: >Unfortunately, I do not have hardware to test f_phonet and HIGHMEM together at >thé moment. >(Neither do I have a proper mail agent.) > >While the original fix may be wrong, I doubt reverting will work. It should >bomb if an skb >segm

[Regression 2.6.37->2.6.38] f_phonet with SOCK_DGRAM

2013-05-09 Thread Andrzej Pietrasiewicz
Dear All, I have discovered a regression in f_phonet. I am trying to send/receive data through a socket of SOCK_DGRAM type. I enclose a program which I use to send and receive the data. First, I configure the phonet using the tools found here: git://git.gitorious.org/meego-cellular/phonet-utils

[Regression 2.6.37->2.6.38] pnxmit.c, test program

2013-05-09 Thread Andrzej Pietrasiewicz
$ pnxmit -a 0x10 -s 0x6c # send from host 0x10 to device 0x6c $ pnxmit -a 0x6c -r # on the device, receive Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- /* * Test program for phonet * * Copyright (c) 2013 Samsung Electronics Co., Ltd. * http://www.samsung

[Regression 2.6.37->2.6.38] Revert "f_phonet: avoid pskb_pull(), fix OOPS with CONFIG_HIGHMEM"

2013-05-09 Thread Andrzej Pietrasiewicz
This reverts commit f5a45325284ec10a907b96052ebf2168e7166b5c. To be applied on current kernels, but only for the purpose of debugging the regression mentioned in the subject. There is a small conflict during the revert, but this patch fixes it. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by

musb throughput issues

2013-05-09 Thread Frederik Schmid
Hi, I'm developing a camera application on a TI OMAP4460. I have a cmos usb-camera from IDS (UI-1551-LE-C-HQ) connected to the OTG-port (musb as host) on the OMAP. I get very poor frame rates with this setup reliably. The throughput rate is ~50-70Mbps. (1600x1200,8bpp,3-5fps) I uploaded a scr